[jira] [Comment Edited] (AVRO-2299) Get Plain Schema

2019-02-04 Thread Rumeshkrishnan (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760229#comment-16760229
 ] 

Rumeshkrishnan edited comment on AVRO-2299 at 2/4/19 9:59 PM:
--

I was going through all the avro types and found that many changes required 
with respective AVRO types. I have done code changes in new file, if we can 
able to find the way reuse functionalities and combine the 
SchemaNormalization.java then it is helpful. I will try to come up with test 
cases for this SchemaCanonicalizer. The rules as followed.
 * Canonical normaliser should filter and order the reserved as well as user 
given properties.
 * User able to normalise schema with additional user defined logical types.
 * name, namespace is different keys in Canonical normaliser. it should not 
reduce as single property `name` for RECORD, FIXED, ENUM types.
 * reserved avro property ordering as below, followed by user given properties.

{code:java}
"name", "namespace", "type", "fields", "symbols", "items", "values", 
"logicalType", "size", "order", "doc", "aliases", "default"{code}
*Current  SchemaCanonicalizer.java implementation:*
{code:java}
import org.apache.avro.util.internal.JacksonUtils;

import java.io.IOException;
import java.util.*;

/**
 * Collection of static methods for generating the canonical form of
 * schemas with reserved properties (see {@link #toCanonicalForm}).
 */
public class SchemaCanonicalizer {

  private static final LinkedHashSet RESERVED_PROPERTIES = new 
LinkedHashSet<>();

  private static final LinkedHashSet ADDITIONAL_LOGICAL_TYPES = 
new LinkedHashSet<>();

  private SchemaCanonicalizer() {
  }

  private SchemaCanonicalizer(LogicalTypes... lts) {
ADDITIONAL_LOGICAL_TYPES.addAll(Arrays.asList(lts));
  }

  static {
Collections.addAll(RESERVED_PROPERTIES,
  "name", "namespace", "type", "fields", "symbols", "items", "values",
  "logicalType", "size", "order", "doc", "aliases", "default");
  }

  public static String toCanonicalForm(Schema s) {
try {
  return build(s, new StringBuilder()).toString();
} catch (IOException e) {
  // Shouldn't happen, b/c StringBuilder can't throw IOException
  throw new RuntimeException(e);
}
  }

  public static String toCanonicalForm(Schema s, LinkedHashSet 
properties) {
try {
  RESERVED_PROPERTIES.addAll(properties);
  return build(s, new StringBuilder()).toString();
} catch (IOException e) {
  // Shouldn't happen, b/c StringBuilder can't throw IOException
  throw new RuntimeException(e);
}
  }

  private static Appendable build(Schema s, Appendable o) throws IOException {
Schema.Type st = s.getType();
LogicalType lt = null;
if (ADDITIONAL_LOGICAL_TYPES.isEmpty()) {
  lt = s.getLogicalType();
} else {
  lt = getLogicalType(s);
}

if (lt == null) {
  switch (st) {
default: // boolean, bytes, double, float, int, long, null, string
  return o.append('"').append(st.getName()).append('"');
case UNION:
  writeUnionType(s, o);
case ARRAY:
  writeArrayType(s, o);
case MAP:
  writeMapType(s, o);
case ENUM:
  writeEnumType(s, o);
case FIXED:
  writeFixedType(s, o);
case RECORD:
  writeRecordType(s, o);
  }
} else {
  writeLogicalType(s, lt, o);
}

return o;
  }

  private static LogicalType getLogicalType(Schema s) {
for (LogicalTypes lts : ADDITIONAL_LOGICAL_TYPES) {
  LogicalType lt = LogicalTypes.fromSchema(s);
  if (lt != null) return lt;
}
return null;
  }

  private static Appendable writeLogicalType(Schema s, LogicalType lt, 
Appendable o) throws IOException {
  o.append("{\"type\":\"").append(s.getType().getName()).append("\"");

o.append("\"").append(LogicalType.LOGICAL_TYPE_PROP).append("\":\"").append(lt.getName()).append("\"");
  if (lt.getName() == "decimal") {
LogicalTypes.Decimal dlt = (LogicalTypes.Decimal) lt;
o.append(",\"precision\":").append(Integer.toString(dlt.getPrecision()));
if(dlt.getScale() != 0) 
o.append(",\"scale\":").append(Integer.toString(dlt.getScale()));
  }
  // adding the reserved property
  writeProps(o, s.getObjectProps());
  return o.append("}");
}

  private static Appendable writeUnionType(Schema s, Appendable o) throws 
IOException {
boolean firstTime = true;
o.append('[');
for (Schema b : s.getTypes()) {
  if (!firstTime) o.append(',');
  else firstTime = false;
  build(b, o);
}
return o.append(']');
  }

  private static Appendable writeArrayType(Schema s, Appendable o) throws 
IOException {
o.append("{\"type\":\"").append(s.getType().getName()).append("\"");
build(s.getElementType(), o.append(",\"items\":"));
// adding the reserved property
writeProps(o, s.getObjectProps());
return o.append("}");
  }

  

[jira] [Comment Edited] (AVRO-2299) Get Plain Schema

2019-02-04 Thread Rumeshkrishnan (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760256#comment-16760256
 ] 

Rumeshkrishnan edited comment on AVRO-2299 at 2/4/19 9:51 PM:
--

As you mentioned canonical form for primitive types :-

*Input :*
{code:java}
{"type":"", "x":"y"}
{code}
*Output:*
{code:java}
"" //boolean, bytes, double, float, int, long, null, string
{code}
*Canonical form for Union:*
{code:java}
[ , ... ]{code}
*Canonical form for Record:*
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "record",
  "fields": [
{
  "name": "---",
  "types": ...,
  "order": "---", // optional if input contain then present
  "doc": "---", // optional if input contain then present
  "aliases": ["---", ...], // optional if input contain then present
  "default": ... // optional if input contain then present
}
...
  ]
}{code}
*Canonical form for Enum:*
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "enum",
  "symbols": [ ... ],
  "doc": "---", // optional if input contain then present
  "aliases": ["---", ...] // optional if input contain then present
}
{code}
 *Canonical form for Fixed:* 
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "fixed",
  "size": ...,
  "aliases": ["---", ...] // optional if input contain then present
}
{code}
*Canonical form for Logical Types:*
{code:java}
{
  "type": "...", // 
  "logicalType": "" // reserved avro logical types or user registered 
logical types
  "precision": ..., // if logical type is decimal
  "scale": ... // if logical type is decimal then optional if input contain 
then present
}{code}
 This is the order and rules, I am thinking of canonical normaliser can do. 
Kindly review this as well [~cutting]


was (Author: rumeshkrish):
As you mentioned canonical form for primitive types :-

*Input :*
{code:java}
{"type":"", "x":"y"}
{code}
*Output:*
{code:java}
"" //boolean, bytes, double, float, int, long, null, string
{code}
*Canonical form for Record:*
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "record",
  "fields": [
{
  "name": "---",
  "types": ...,
  "order": "---", // optional if input contain then present
  "doc": "---", // optional if input contain then present
  "aliases": ["---", ...], // optional if input contain then present
  "default": ... // optional if input contain then present
}
...
  ]
}{code}
*Canonical form for Enum:*
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "enum",
  "symbols": [ ... ],
  "doc": "---", // optional if input contain then present
  "aliases": ["---", ...] // optional if input contain then present
}
{code}
 *Canonical form for Fixed:* 
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "fixed",
  "size": ...,
  "aliases": ["---", ...] // optional if input contain then present
}
{code}
*Canonical form for Logical Types:*
{code:java}
{
  "type": "...", // 
  "logicalType": "" // reserved avro logical types or user registered 
logical types
  "precision": ..., // if logical type is decimal
  "scale": ... // if logical type is decimal then optional if input contain 
then present
}{code}
 This is the order and rules, I am thinking of canonical normaliser can do. 
Kindly review this as well [~cutting]

> Get Plain Schema
> 
>
> Key: AVRO-2299
> URL: https://issues.apache.org/jira/browse/AVRO-2299
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.8.2
>Reporter: Rumeshkrishnan
>Priority: Minor
>  Labels: features
> Fix For: 1.9.0, 1.8.2, 1.8.3, 1.8.4
>
>
> {panel:title=Avro Schema Reserved Keys:}
> "doc", "fields", "items", "name", "namespace",
>  "size", "symbols", "values", "type", "aliases", "default"
> {panel}
> AVRO also supports user defined properties for both Schema and Field.
> Is there way to get the schema with reserved property (key, value)? 
> Input Schema: 
> {code:java}
> {
>   "name": "testSchema",
>   "namespace": "com.avro",
>   "type": "record",
>   "fields": [
> {
>   "name": "email",
>   "type": "string",
>   "doc": "email id",
>   "user_field_prop": "x"
> }
>   ],
>   "user_schema_prop": "xx"
> }{code}
> Expected Plain Schema:
> {code:java}
> {
>   "name": "testSchema",
>   "namespace": "com.avro",
>   "type": "record",
>   "fields": [
> {
>   "name": "email",
>   "type": "string",
>   "doc": "email id"
> }
>   ]
> }
> {code}



--
This message was sent by Atlassian JIRA

[jira] [Commented] (AVRO-2299) Get Plain Schema

2019-02-04 Thread Rumeshkrishnan (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760256#comment-16760256
 ] 

Rumeshkrishnan commented on AVRO-2299:
--

As you mentioned canonical form for primitive types :-

*Input :*
{code:java}
{"type":"", "x":"y"}
{code}
*Output:*
{code:java}
"" //boolean, bytes, double, float, int, long, null, string
{code}
*Canonical form for Record:*
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "record",
  "fields": [
{
  "name": "---",
  "types": ...,
  "order": "---", // optional if input contain then present
  "doc": "---", // optional if input contain then present
  "aliases": ["---", ...], // optional if input contain then present
  "default": ... // optional if input contain then present
}
...
  ]
}{code}
*Canonical form for Enum:*
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "enum",
  "symbols": [ ... ],
  "doc": "---", // optional if input contain then present
  "aliases": ["---", ...] // optional if input contain then present
}
{code}
 *Canonical form for Fixed:* 
{code:java}
{
  "name": "---",
  "namespace": "---", // optional if input contain then present
  "type": "fixed",
  "size": ...,
  "aliases": ["---", ...] // optional if input contain then present
}
{code}
*Canonical form for Logical Types:*
{code:java}
{
  "type": "...", // 
  "logicalType": "" // reserved avro logical types or user registered 
logical types
  "precision": ..., // if logical type is decimal
  "scale": ... // if logical type is decimal then optional if input contain 
then present
}{code}
 This is the order and rules, I am thinking of canonical normaliser can do. 
Kindly review this as well [~cutting]

> Get Plain Schema
> 
>
> Key: AVRO-2299
> URL: https://issues.apache.org/jira/browse/AVRO-2299
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.8.2
>Reporter: Rumeshkrishnan
>Priority: Minor
>  Labels: features
> Fix For: 1.9.0, 1.8.2, 1.8.3, 1.8.4
>
>
> {panel:title=Avro Schema Reserved Keys:}
> "doc", "fields", "items", "name", "namespace",
>  "size", "symbols", "values", "type", "aliases", "default"
> {panel}
> AVRO also supports user defined properties for both Schema and Field.
> Is there way to get the schema with reserved property (key, value)? 
> Input Schema: 
> {code:java}
> {
>   "name": "testSchema",
>   "namespace": "com.avro",
>   "type": "record",
>   "fields": [
> {
>   "name": "email",
>   "type": "string",
>   "doc": "email id",
>   "user_field_prop": "x"
> }
>   ],
>   "user_schema_prop": "xx"
> }{code}
> Expected Plain Schema:
> {code:java}
> {
>   "name": "testSchema",
>   "namespace": "com.avro",
>   "type": "record",
>   "fields": [
> {
>   "name": "email",
>   "type": "string",
>   "doc": "email id"
> }
>   ]
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Status of 1.9....

2019-02-04 Thread Thiruvalluvan MG
 Hi Fokko,
Thank you for your effort. I can work with you to the release done.
Let's plan the tasks and execute them between us.
Thank you,
Thiru
On Monday, 4 February, 2019, 2:20:38 PM IST, Driesprong, Fokko 
 wrote:  
 
 I'll go through the pending tickets today. Is there a PMC which is willing
to shepherd the release?

I'm happy to help with getting everything ready, and with a
colllegeau, I'll refactor our Divolte event collector
 with
the new version of Avro to do some proper testing and verification of the
1.9.

Cheers, Fokko

Op di 22 jan. 2019 om 00:53 schreef Brian Lachniet :

> That resolved my issue. I'm now able to assign issues to myself. Thank you!
>
> On Mon, Jan 21, 2019 at 3:15 PM Driesprong, Fokko 
> wrote:
>
> > Brian, I recently added you as a contributor to the Jira. Could you try
> > again to assign the ticket?
> >
> > I'm happy to help with the 1.9 release.
> >
> > Cheers, Fokko
> >
> > Op vr 18 jan. 2019 om 00:10 schreef Brian Lachniet  >:
> >
> > > It appears that I don't have permissions to edit or assign issues to
> > > myself. Is that something I should have permissions for, or should I
> ask
> > > someone to assign specific issues to me?
> > >
> > > On Thu, Jan 17, 2019, 8:19 AM Daniel Kulp  > >
> > > >
> > > >
> > > > > On Jan 16, 2019, at 9:29 PM, Thiruvalluvan MG
> > > 
> > > > wrote:
> > > > >
> > > > > To get a sense of what needs to be done, can you please review the
> > > > pending issues for 1.9.0? According to JIRA, there are 43 unresolved
> > > issues
> > > > with Fix Version 1.9.0. Issue Navigator - ASF JIRA
> > > > >
> > > >
> > > > https://issues.apache.org/jira/projects/AVRO/versions/1294
> > > >
> > > >
> > > >
> > > > > Please add the fix version to the issues outside the list that
> should
> > > be
> > > > resolved for the release and remove the fix version if some of the
> > issues
> > > > in the list need not be or cannot be resolved for 1.9.0. Also if you
> > > intend
> > > > to resolve it in the near future, please assign the issues to
> yourself.
> > > > Thank you.
> > > > > I've done the exercise for C++. There are three C++ issues
> unresolved
> > > > and I'll address them before the weekend.
> > > > > Thank you,
> > > >
> > > > Well, the main point is that not all of those 43 issues are going to
> > get
> > > > done for 1.9.  If someone is not actively working on it to be done in
> > the
> > > > next week or so, I’m going to remove them from 1.9.  I don’t see the
> > > point
> > > > in holding up a release that fixes 180 issues waiting for stuff that
> > may
> > > or
> > > > may not ever get complete.  Thus, everyone, please take a look at
> the
> > > list
> > > > and if you aren’t working on something that is assigned to you,
> remove
> > it
> > > > from 1.9.
> > > >
> > > > That said, I’ll try and take a look at the 17 that have “Patch
> > > > Available”.  If it’s just a matter of reviewing and applying a
> patch,
> > > that
> > > > shouldn’t be too hard.
> > > >
> > > > Dan
> > > >
> > > >
> > > >
> > > >
> > > > > Thiru    On Thursday, 17 January, 2019, 6:51:39 AM IST, Brian
> > Lachniet
> > > <
> > > > blachn...@gmail.com> wrote:
> > > > >
> > > > > I'd really like to get the changes to deploy C# NuGet packages in (
> > > > > https://github.com/apache/avro/pull/428). Other than that, I think
> > > > anything
> > > > > else in the C# realm can wait for later releases.
> > > > >
> > > > > On Wed, Jan 16, 2019, 1:12 PM Daniel Kulp  > > > >
> > > > >> Just a quick question:
> > > > >>
> > > > >> What’s the status of the things people are working for 1.9?    I
> > think
> > > > >> we’re getting really close to having something that would be a
> good
> > > 1.9
> > > > >> release.  We’ve accomplished a LOT with well over 100 PR’s merged
> > and
> > > > tons
> > > > >> of JIRA’s closed and such and I’d like to get a release out.  Can
> > > > anything
> > > > >> left be postponed to 1.10 or 1.9.1?
> > > > >>
> > > > >> Thanks!
> > > > >>
> > > > >> --
> > > > >> Daniel Kulp
> > > > >> dk...@apache.org  -
> > http://dankulp.com/blog
> > > <
> > > > >> http://dankulp.com/blog>
> > > > >> Talend Community Coder - http://talend.com <
> > http://coders.talend.com/
> > > >
> > > >
> > > > --
> > > > Daniel Kulp
> > > > dk...@apache.org  - http://dankulp.com/blog
> <
> > > > http://dankulp.com/blog>
> > > > Talend Community Coder - http://talend.com <
> http://coders.talend.com/>
> > > >
> > >
> >
>
>
> --
>
> [image: 51b630b05e01a6d5134ccfd520f547c4.png]
>
> Brian Lachniet
>
> Software Engineer
>
> E: blachn...@gmail.com | blachniet.com 
>
>  
>  

[jira] [Commented] (AVRO-1381) Publish C# artifacts to NuGet

2019-02-04 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759718#comment-16759718
 ] 

Hudson commented on AVRO-1381:
--

FAILURE: Integrated in Jenkins build AvroJava #595 (See 
[https://builds.apache.org/job/AvroJava/595/])
AVRO-1381: Generate NuGet package for main Avro library (#428) (fokko: 
[https://github.com/apache/avro/commit/e03f9d44f5fd0908f9402340164972415c0d])
* (edit) .editorconfig
* (delete) lang/csharp/src/apache/main/Properties/AssemblyInfo.cs
* (add) lang/csharp/common.props
* (edit) lang/csharp/src/apache/main/Avro.main.csproj
* (edit) lang/csharp/build.ps1
* (edit) lang/csharp/Avro.sln


> Publish C# artifacts to NuGet
> -
>
> Key: AVRO-1381
> URL: https://issues.apache.org/jira/browse/AVRO-1381
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: csharp
>Affects Versions: 1.7.5
>Reporter: Mark Lamley
>Assignee: Brian Lachniet
>Priority: Major
> Fix For: 1.9.0
>
>
> Currently referencing Avro requires manually downloading, compiling and 
> referencing the compiled library. It would be nice to simply reference the 
> compiled library from http://www.nuget.org/ instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Build failed in Jenkins: AvroJava #595

2019-02-04 Thread Apache Jenkins Server
See 

Changes:

[Fokko] AVRO-1381: Generate NuGet package for main Avro library (#428)

--
[...truncated 84.38 KB...]
[INFO] 
[INFO] --- maven-plugin-plugin:3.6.0:helpmojo (generated-helpmojo) @ 
avro-maven-plugin ---
[INFO] Using 'UTF-8' encoding to read mojo source files.
[INFO] java-javadoc mojo extractor found 5 mojo descriptors.
[INFO] java-annotations mojo extractor found 0 mojo descriptor.
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.2.1:process (default) @ 
avro-maven-plugin ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
avro-maven-plugin ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
avro-maven-plugin ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 6 source files to 

[INFO] 
:
 

 uses unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-plugin-plugin:3.6.0:descriptor (default-descriptor) @ 
avro-maven-plugin ---
[INFO] Using 'UTF-8' encoding to read mojo source files.
[INFO] java-javadoc mojo extractor found 5 mojo descriptors.
[INFO] java-annotations mojo extractor found 0 mojo descriptor.
[INFO] 
[INFO] --- maven-bundle-plugin:4.1.0:manifest (bundle-manifest) @ 
avro-maven-plugin ---
[WARNING] Ignoring project type maven-plugin - supportedProjectTypes = [bundle]
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
avro-maven-plugin ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 8 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
avro-maven-plugin ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @ 
avro-maven-plugin ---
[INFO] 
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.avro.mojo.TestIDLProtocolMojo
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.106 s 
- in org.apache.avro.mojo.TestIDLProtocolMojo
[INFO] Running org.apache.avro.mojo.TestProtocolMojo
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.161 s 
- in org.apache.avro.mojo.TestProtocolMojo
[INFO] Running org.apache.avro.mojo.TestInduceMojo
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.223 s 
- in org.apache.avro.mojo.TestInduceMojo
[INFO] Running org.apache.avro.mojo.TestSchemaMojo
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.243 s 
- in org.apache.avro.mojo.TestSchemaMojo
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:3.0.0:check (checkstyle-check) @ 
avro-maven-plugin ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] --- maven-surefire-plugin:3.0.0-M3:test (test-with-custom-coders) @ 
avro-maven-plugin ---
[INFO] 
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.avro.mojo.TestSchemaMojo
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.857 s 
- in org.apache.avro.mojo.TestSchemaMojo
[INFO] Running org.apache.avro.mojo.TestIDLProtocolMojo
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.373 s 
- in org.apache.avro.mojo.TestIDLProtocolMojo
[INFO] Running org.apache.avro.mojo.TestInduceMojo
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.179 s 
- in org.apache.avro.mojo.TestInduceMojo
[INFO] Running org.apache.avro.mojo.TestProtocolMojo
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.117 s 
- in org.apache.avro.mojo.TestProtocolMojo
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-jar-plugin:3.1.0:jar (default-jar) @ avro-maven-plugin ---
[INFO] Building jar: 

[jira] [Updated] (AVRO-1381) Publish C# artifacts to NuGet

2019-02-04 Thread Fokko Driesprong (JIRA)


 [ 
https://issues.apache.org/jira/browse/AVRO-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong updated AVRO-1381:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Publish C# artifacts to NuGet
> -
>
> Key: AVRO-1381
> URL: https://issues.apache.org/jira/browse/AVRO-1381
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: csharp
>Affects Versions: 1.7.5
>Reporter: Mark Lamley
>Assignee: Brian Lachniet
>Priority: Major
> Fix For: 1.9.0
>
>
> Currently referencing Avro requires manually downloading, compiling and 
> referencing the compiled library. It would be nice to simply reference the 
> compiled library from http://www.nuget.org/ instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AVRO-1381) Publish C# artifacts to NuGet

2019-02-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759701#comment-16759701
 ] 

ASF subversion and git services commented on AVRO-1381:
---

Commit e03f9d44f5fd0908f9402340164972415c0d in avro's branch 
refs/heads/master from Brian Lachniet
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=e03f9d4 ]

AVRO-1381: Generate NuGet package for main Avro library (#428)



> Publish C# artifacts to NuGet
> -
>
> Key: AVRO-1381
> URL: https://issues.apache.org/jira/browse/AVRO-1381
> Project: Apache Avro
>  Issue Type: New Feature
>  Components: csharp
>Affects Versions: 1.7.5
>Reporter: Mark Lamley
>Assignee: Brian Lachniet
>Priority: Major
> Fix For: 1.9.0
>
>
> Currently referencing Avro requires manually downloading, compiling and 
> referencing the compiled library. It would be nice to simply reference the 
> compiled library from http://www.nuget.org/ instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AVRO-1989) Ruby schema validation for fixed types should use bytesize in error message

2019-02-04 Thread Fokko Driesprong (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759699#comment-16759699
 ] 

Fokko Driesprong commented on AVRO-1989:


[~busbey] Any final thoughts on this?

> Ruby schema validation for fixed types should use bytesize in error message
> ---
>
> Key: AVRO-1989
> URL: https://issues.apache.org/jira/browse/AVRO-1989
> Project: Apache Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.9.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 1.9.0
>
> Attachments: AVRO-1989.0.patch
>
>
> From AVRO-1886:
> I'd like to get one thing improved, but it's fine as a follow-on.
> {code}
>  +   when :fixed
>  +  if datum.is_a? String
>  +message = "expected fixed with size #{expected_schema.size}, 
> got \"#{datum}\" with size #{datum.size}"
>  +result.add_error(path, message) unless datum.bytesize == 
> expected_schema.size
>  +  else
>  +result.add_error(path, "expected fixed with size 
> #{expected_schema.size}, got #{actual_value_message(datum)}")
>  +  end
> {code}
> the message here should use datum.bytesize instead of datum.size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (AVRO-2277) clean up Ruby warnings

2019-02-04 Thread Fokko Driesprong (JIRA)


 [ 
https://issues.apache.org/jira/browse/AVRO-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong updated AVRO-2277:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> clean up Ruby warnings
> --
>
> Key: AVRO-2277
> URL: https://issues.apache.org/jira/browse/AVRO-2277
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: ruby
>Reporter: Tim Perkins
>Assignee: Tim Perkins
>Priority: Minor
> Fix For: 1.9.0
>
>
> Running tests for the Ruby implementation generates a lot of warnings and 
> makes it unclear that the Ruby tests are passing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Status of 1.9....

2019-02-04 Thread Driesprong, Fokko
I'll go through the pending tickets today. Is there a PMC which is willing
to shepherd the release?

I'm happy to help with getting everything ready, and with a
colllegeau, I'll refactor our Divolte event collector
 with
the new version of Avro to do some proper testing and verification of the
1.9.

Cheers, Fokko

Op di 22 jan. 2019 om 00:53 schreef Brian Lachniet :

> That resolved my issue. I'm now able to assign issues to myself. Thank you!
>
> On Mon, Jan 21, 2019 at 3:15 PM Driesprong, Fokko 
> wrote:
>
> > Brian, I recently added you as a contributor to the Jira. Could you try
> > again to assign the ticket?
> >
> > I'm happy to help with the 1.9 release.
> >
> > Cheers, Fokko
> >
> > Op vr 18 jan. 2019 om 00:10 schreef Brian Lachniet  >:
> >
> > > It appears that I don't have permissions to edit or assign issues to
> > > myself. Is that something I should have permissions for, or should I
> ask
> > > someone to assign specific issues to me?
> > >
> > > On Thu, Jan 17, 2019, 8:19 AM Daniel Kulp  > >
> > > >
> > > >
> > > > > On Jan 16, 2019, at 9:29 PM, Thiruvalluvan MG
> > > 
> > > > wrote:
> > > > >
> > > > > To get a sense of what needs to be done, can you please review the
> > > > pending issues for 1.9.0? According to JIRA, there are 43 unresolved
> > > issues
> > > > with Fix Version 1.9.0. Issue Navigator - ASF JIRA
> > > > >
> > > >
> > > > https://issues.apache.org/jira/projects/AVRO/versions/1294
> > > >
> > > >
> > > >
> > > > > Please add the fix version to the issues outside the list that
> should
> > > be
> > > > resolved for the release and remove the fix version if some of the
> > issues
> > > > in the list need not be or cannot be resolved for 1.9.0. Also if you
> > > intend
> > > > to resolve it in the near future, please assign the issues to
> yourself.
> > > > Thank you.
> > > > > I've done the exercise for C++. There are three C++ issues
> unresolved
> > > > and I'll address them before the weekend.
> > > > > Thank you,
> > > >
> > > > Well, the main point is that not all of those 43 issues are going to
> > get
> > > > done for 1.9.  If someone is not actively working on it to be done in
> > the
> > > > next week or so, I’m going to remove them from 1.9.  I don’t see the
> > > point
> > > > in holding up a release that fixes 180 issues waiting for stuff that
> > may
> > > or
> > > > may not ever get complete.   Thus, everyone, please take a look at
> the
> > > list
> > > > and if you aren’t working on something that is assigned to you,
> remove
> > it
> > > > from 1.9.
> > > >
> > > > That said, I’ll try and take a look at the 17 that have “Patch
> > > > Available”.   If it’s just a matter of reviewing and applying a
> patch,
> > > that
> > > > shouldn’t be too hard.
> > > >
> > > > Dan
> > > >
> > > >
> > > >
> > > >
> > > > > ThiruOn Thursday, 17 January, 2019, 6:51:39 AM IST, Brian
> > Lachniet
> > > <
> > > > blachn...@gmail.com> wrote:
> > > > >
> > > > > I'd really like to get the changes to deploy C# NuGet packages in (
> > > > > https://github.com/apache/avro/pull/428). Other than that, I think
> > > > anything
> > > > > else in the C# realm can wait for later releases.
> > > > >
> > > > > On Wed, Jan 16, 2019, 1:12 PM Daniel Kulp  > > > >
> > > > >> Just a quick question:
> > > > >>
> > > > >> What’s the status of the things people are working for 1.9?I
> > think
> > > > >> we’re getting really close to having something that would be a
> good
> > > 1.9
> > > > >> release.  We’ve accomplished a LOT with well over 100 PR’s merged
> > and
> > > > tons
> > > > >> of JIRA’s closed and such and I’d like to get a release out.  Can
> > > > anything
> > > > >> left be postponed to 1.10 or 1.9.1?
> > > > >>
> > > > >> Thanks!
> > > > >>
> > > > >> --
> > > > >> Daniel Kulp
> > > > >> dk...@apache.org  -
> > http://dankulp.com/blog
> > > <
> > > > >> http://dankulp.com/blog>
> > > > >> Talend Community Coder - http://talend.com <
> > http://coders.talend.com/
> > > >
> > > >
> > > > --
> > > > Daniel Kulp
> > > > dk...@apache.org  - http://dankulp.com/blog
> <
> > > > http://dankulp.com/blog>
> > > > Talend Community Coder - http://talend.com <
> http://coders.talend.com/>
> > > >
> > >
> >
>
>
> --
>
> [image: 51b630b05e01a6d5134ccfd520f547c4.png]
>
> Brian Lachniet
>
> Software Engineer
>
> E: blachn...@gmail.com | blachniet.com 
>
>  
>