[jira] [Updated] (AVRO-2366) setValidateDefaults=false does not seem to work

2019-04-28 Thread Rumeshkrishnan (JIRA) 


 [ 
https://issues.apache.org/jira/browse/AVRO-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rumeshkrishnan updated AVRO-2366:
-
Attachment: (was: AVRO-2366_fix_setValidateDefaults.patch)

> setValidateDefaults=false does not seem to work
> ---
>
> Key: AVRO-2366
> URL: https://issues.apache.org/jira/browse/AVRO-2366
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Raman Gupta
>Priority: Major
>
> Followup to AVRO-2035.
> I am testing 1.9 SNAPSHOT. I set `Schema.Parser.setValidateDefaults` to 
> false, and still get a failure at compile-time if the default does not match 
> the schema. For example, a field definition of:
> {"name": "name", "type": "string", "default": null}
> Should this definition succeed if `setValidateDefaults(false)` is called? If 
> not, should the `setValidateDefaults` method just be removed?
> The exception is:
> Caused by: org.apache.avro.AvroTypeException: Invalid default for field name: 
> null not a {"type":"string","avro.java.string":"String"}
>   at org.apache.avro.Schema.validateDefault(Schema.java:1482)
>   at org.apache.avro.Schema.access$300(Schema.java:84)
>   at org.apache.avro.Schema$Field.(Schema.java:493)
>   at org.apache.avro.Schema$Field.(Schema.java:485)
>   at org.apache.avro.Schema$Field.(Schema.java:504)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:689)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:668)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compile(SpecificCompiler.java:598)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compileToDestination(SpecificCompiler.java:527)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (AVRO-2366) setValidateDefaults=false does not seem to work

2019-04-28 Thread Rumeshkrishnan (JIRA) 


 [ 
https://issues.apache.org/jira/browse/AVRO-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rumeshkrishnan updated AVRO-2366:
-
Comment: was deleted

(was: HI [~rocketraman] , I created patch for avro 
[https://github.com/apache/avro]. I hope this will help to fix the issue. Can 
you test with this patch. Let me know. I will create the pull request. )

> setValidateDefaults=false does not seem to work
> ---
>
> Key: AVRO-2366
> URL: https://issues.apache.org/jira/browse/AVRO-2366
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Raman Gupta
>Priority: Major
>
> Followup to AVRO-2035.
> I am testing 1.9 SNAPSHOT. I set `Schema.Parser.setValidateDefaults` to 
> false, and still get a failure at compile-time if the default does not match 
> the schema. For example, a field definition of:
> {"name": "name", "type": "string", "default": null}
> Should this definition succeed if `setValidateDefaults(false)` is called? If 
> not, should the `setValidateDefaults` method just be removed?
> The exception is:
> Caused by: org.apache.avro.AvroTypeException: Invalid default for field name: 
> null not a {"type":"string","avro.java.string":"String"}
>   at org.apache.avro.Schema.validateDefault(Schema.java:1482)
>   at org.apache.avro.Schema.access$300(Schema.java:84)
>   at org.apache.avro.Schema$Field.(Schema.java:493)
>   at org.apache.avro.Schema$Field.(Schema.java:485)
>   at org.apache.avro.Schema$Field.(Schema.java:504)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:689)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:668)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compile(SpecificCompiler.java:598)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compileToDestination(SpecificCompiler.java:527)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AVRO-2366) setValidateDefaults=false does not seem to work

2019-04-28 Thread Rumeshkrishnan (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828838#comment-16828838
 ] 

Rumeshkrishnan commented on AVRO-2366:
--

HI [~rocketraman] , I created patch for avro [https://github.com/apache/avro]. 
I hope this will help to fix the issue. Can you test with this patch. Let me 
know. I will create the pull request. 

> setValidateDefaults=false does not seem to work
> ---
>
> Key: AVRO-2366
> URL: https://issues.apache.org/jira/browse/AVRO-2366
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Raman Gupta
>Priority: Major
> Attachments: AVRO-2366_fix_setValidateDefaults.patch
>
>
> Followup to AVRO-2035.
> I am testing 1.9 SNAPSHOT. I set `Schema.Parser.setValidateDefaults` to 
> false, and still get a failure at compile-time if the default does not match 
> the schema. For example, a field definition of:
> {"name": "name", "type": "string", "default": null}
> Should this definition succeed if `setValidateDefaults(false)` is called? If 
> not, should the `setValidateDefaults` method just be removed?
> The exception is:
> Caused by: org.apache.avro.AvroTypeException: Invalid default for field name: 
> null not a {"type":"string","avro.java.string":"String"}
>   at org.apache.avro.Schema.validateDefault(Schema.java:1482)
>   at org.apache.avro.Schema.access$300(Schema.java:84)
>   at org.apache.avro.Schema$Field.(Schema.java:493)
>   at org.apache.avro.Schema$Field.(Schema.java:485)
>   at org.apache.avro.Schema$Field.(Schema.java:504)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:689)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:668)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compile(SpecificCompiler.java:598)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compileToDestination(SpecificCompiler.java:527)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (AVRO-2366) setValidateDefaults=false does not seem to work

2019-04-28 Thread Rumeshkrishnan (JIRA) 


 [ 
https://issues.apache.org/jira/browse/AVRO-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rumeshkrishnan updated AVRO-2366:
-
Attachment: AVRO-2366_fix_setValidateDefaults.patch

> setValidateDefaults=false does not seem to work
> ---
>
> Key: AVRO-2366
> URL: https://issues.apache.org/jira/browse/AVRO-2366
> Project: Apache Avro
>  Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Raman Gupta
>Priority: Major
> Attachments: AVRO-2366_fix_setValidateDefaults.patch
>
>
> Followup to AVRO-2035.
> I am testing 1.9 SNAPSHOT. I set `Schema.Parser.setValidateDefaults` to 
> false, and still get a failure at compile-time if the default does not match 
> the schema. For example, a field definition of:
> {"name": "name", "type": "string", "default": null}
> Should this definition succeed if `setValidateDefaults(false)` is called? If 
> not, should the `setValidateDefaults` method just be removed?
> The exception is:
> Caused by: org.apache.avro.AvroTypeException: Invalid default for field name: 
> null not a {"type":"string","avro.java.string":"String"}
>   at org.apache.avro.Schema.validateDefault(Schema.java:1482)
>   at org.apache.avro.Schema.access$300(Schema.java:84)
>   at org.apache.avro.Schema$Field.(Schema.java:493)
>   at org.apache.avro.Schema$Field.(Schema.java:485)
>   at org.apache.avro.Schema$Field.(Schema.java:504)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:689)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:668)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compile(SpecificCompiler.java:598)
>   at 
> org.apache.avro.compiler.specific.SpecificCompiler.compileToDestination(SpecificCompiler.java:527)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AVRO-2381) logical type for fixed incorrectly parsed as disallowed doc attribute

2019-04-28 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828819#comment-16828819
 ] 

Hudson commented on AVRO-2381:
--

SUCCESS: Integrated in Jenkins build AvroJava #656 (See 
[https://builds.apache.org/job/AvroJava/656/])
[AVRO-2381] Ruby: set logical type for fixed (#509) (fokko: 
[https://github.com/apache/avro/commit/3f44b7c22e355e5fde239fd16b5105cf5804b70b])
* (edit) lang/ruby/lib/avro/schema.rb
* (edit) lang/ruby/test/test_logical_types.rb


> logical type for fixed incorrectly parsed as disallowed doc attribute
> -
>
> Key: AVRO-2381
> URL: https://issues.apache.org/jira/browse/AVRO-2381
> Project: Apache Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.9.0
>Reporter: Tim Perkins
>Assignee: Tim Perkins
>Priority: Blocker
> Fix For: 1.9.0
>
> Attachments: avro-2381-patch.txt
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Avro 1.9.0 RC1

2019-04-28 Thread Driesprong, Fokko 
Ok, I'm canceling the vote for now. Thank you all for testing, and Brian
for uploading it to NuGet.

I'll incorporate the patches from Tim Perkins and Raman Gupta. I'll send
out RC2 soon.

Cheers, Fokko Driesprong

Op za 27 apr. 2019 om 14:08 schreef Brian Lachniet :

> +1
>
> I pushed the v1.9.0-rc1 package
>  to NuGet for the C#
> side of the house.
>
> On Fri, Apr 26, 2019 at 3:06 PM Daniel Kulp  wrote:
>
> >
> > Two minor issues:
> >
> > 1) It’s strange to extract the src tarball and have it be in a
> > “build/avro-src-1.9.0” directory.  I’d like to see the “build” level
> > removed.   Not a big deal, something we can fix in the future.
> >
> > 2) I’m getting some random test failures in java/mapred when run via
> > “build.sh docker-test", and not sure why.   If I just run maven outside
> of
> > docker it runs fine.   Also not something to block a release, but a bit
> > strange.
> >
> > Anyway, +1 as I don’t see either of them as a blocker.
> >
> > Dan
> >
> >
> >
> >
> > > On Apr 26, 2019, at 5:53 AM, Driesprong, Fokko 
> > wrote:
> > >
> > > Hi everyone,
> > >
> > > Since the last release of Apache Avro 1.8.2 on May 31, 2017. Two years
> > > later,
> > > I'm thrilled to propose the following RC to be released as official
> > Apache
> > > Avro 1.9.0 release.
> > >
> > > The commit id is 4607730012293fe1e58957760e8f7b5474abd408
> > > * This corresponds to the tag: release-1.9.0-rc1
> > > * https://github.com/apache/avro/releases/tag/release-1.9.0-rc1
> > >
> > > The release tarball, signature, and checksums are here:
> > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc1/
> > >
> > > You can find the KEYS file here:
> > > * https://dist.apache.org/repos/dist/dev/avro/KEYS
> > >
> > > Binary artifacts for Java are staged in Nexus here:
> > > *
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.0/
> > >
> > > This release includes 270 Jira issues:
> > > https://issues.apache.org/jira/projects/AVRO/versions/1294
> > > * Deprecate Joda-Time in favor of Java8 JSR310 and setting it as
> default
> > > * Remove support for Hadoop 1.x
> > > * Move from Jackson 1.x to 2.9
> > > * Add ZStandard Codec
> > > * Lots of updates on the dependencies to fix CVE's
> > > * and many, many more!
> > >
> > > Please download, verify, and test. This vote will remain open for at
> > least
> > > 72 hours. Given sufficient votes, I would like to close it on or about
> > > midnight
> > > on Monday, 29 April 2019.
> > >
> > > [ ] +1 Release this as Apache Avro 1.9.0
> > > [ ] +0
> > > [ ] -1 Do not release this because...
> > >
> > > Consider this a +1 (non-binding) from my side:
> > > * Compiled the new version of Parquet against the Divolte collector and
> > > Apache Parquet
> > >
> > > Cheers, Fokko Driesprong
> >
> > --
> > Daniel Kulp
> > dk...@apache.org  - http://dankulp.com/blog <
> > http://dankulp.com/blog>
> > Talend Community Coder - http://talend.com 
> >
>
>
> --
>
> [image: 51b630b05e01a6d5134ccfd520f547c4.png]
>
> Brian Lachniet
>
> Software Engineer
>
> E: blachn...@gmail.com | blachniet.com 
>
>  
>

[jira] [Updated] (AVRO-2383) Avro 1.9 applyAliases broken with self-referential records

2019-04-28 Thread Fokko Driesprong (JIRA) 


 [ 
https://issues.apache.org/jira/browse/AVRO-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong updated AVRO-2383:
---
Fix Version/s: 1.9.0

> Avro 1.9 applyAliases broken with self-referential records
> --
>
> Key: AVRO-2383
> URL: https://issues.apache.org/jira/browse/AVRO-2383
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Raman Gupta
>Priority: Blocker
> Fix For: 1.9.0
>
> Attachments: AVRO-2383.patch
>
>
> If a schema has a field with a self-referential record, the applyAliases 
> function produces a NullPointerException.
> The problem appears to be that the value for the record put into "seen" has 
> no fields, and then when the equality check is done, the `Schema.equals` 
> method assumes that fields is not null. Making the `equals` method more 
> defensive with null-checking "fields" solves the problem, as the `putAll` 
> method adds the fields back in, but I'm not sure if that is actually the best 
> fix.
> I will attach a patch with this fix.
> I'm marking this as a blocker for 1.9, as this behavior will cause a 
> NullPointerException in this situation any time data is decoded where the 
> writer and reader schema are different, and there are any aliases defined in 
> the reader (even if these aliases are unrelated to the self-referential 
> record).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (AVRO-2381) logical type for fixed incorrectly parsed as disallowed doc attribute

2019-04-28 Thread Fokko Driesprong (JIRA) 


 [ 
https://issues.apache.org/jira/browse/AVRO-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong updated AVRO-2381:
---
   Resolution: Fixed
Fix Version/s: 1.9.0
   Status: Resolved  (was: Patch Available)

> logical type for fixed incorrectly parsed as disallowed doc attribute
> -
>
> Key: AVRO-2381
> URL: https://issues.apache.org/jira/browse/AVRO-2381
> Project: Apache Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.9.0
>Reporter: Tim Perkins
>Assignee: Tim Perkins
>Priority: Blocker
> Fix For: 1.9.0
>
> Attachments: avro-2381-patch.txt
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AVRO-2381) logical type for fixed incorrectly parsed as disallowed doc attribute

2019-04-28 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828797#comment-16828797
 ] 

ASF subversion and git services commented on AVRO-2381:
---

Commit 3f44b7c22e355e5fde239fd16b5105cf5804b70b in avro's branch 
refs/heads/master from Tim Perkins
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=3f44b7c ]

[AVRO-2381] Ruby: set logical type for fixed (#509)



> logical type for fixed incorrectly parsed as disallowed doc attribute
> -
>
> Key: AVRO-2381
> URL: https://issues.apache.org/jira/browse/AVRO-2381
> Project: Apache Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.9.0
>Reporter: Tim Perkins
>Assignee: Tim Perkins
>Priority: Blocker
> Attachments: avro-2381-patch.txt
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)