Re: [VOTE] Release Apache Avro 1.9.0 RC4
If Spark is upgraded, then I'm afraid first Hive should be upgraded to 1.9.0. When I did a quick release verification, I remember I saw several failures due to Hive using deprecated and removed Avro methods (related to Jackson removal from public API). On Wed, May 15, 2019 at 11:04 PM Ismaël Mejía wrote: > Getting a new release of Avro feels amazing, thanks a lot Fokko for > all your wokr to get this out with the release. > > An interesting next step is downstreaming. I saw Fokko created a > ticket for Parquet, is anyone working on the Spark one? It will be > really nice to get this into Spark 3. Anything I can do to help there > or that we can sync work? > I filled https://issues.apache.org/jira/browse/SPARK-27733 for the moment. > > I am tackling the upgrade on Beam (the other project I work mostly on too. > https://issues.apache.org/jira/browse/BEAM-7328 > > Any other project worth the sync/work? > > > On Wed, May 15, 2019 at 8:54 PM Driesprong, Fokko > wrote: > > > > Hi Jacob, > > > > This looks off, I'll dive into it. I think it got released for some > reason. > > While releasing it today, I also noticed that the artifact wasn't staged > in > > Nexus anymore. However, RC4 is the same as the release. > > > > Cheers, Fokko > > > > Op wo 15 mei 2019 om 20:27 schreef Jacob Tolar > > : > > > > > Great news! We have been looking forward to the 1.9 release. > > > > > > I see 1.9.0 published on Maven Central. It appears to have been > published > > > 5/8 > > > (the same day as RC4 was announced but ~1week before vote passed). > > > > > > Is this the release build (presumably the same as RC4) or an earlier > RC? > > > > > > https://repo1.maven.org/maven2/org/apache/avro/avro/1.9.0/ > > > > > > Would it be helpful to have maven include the git sha somewhere in > > > MANIFEST.MF? > > > > > > jacob > > > > > > On Tue, May 14, 2019 at 1:04 PM Driesprong, Fokko > > > > wrote: > > > > > > > Thank you all, > > > > > > > > I'm happy to announce, the vote for Avro 1.9.0 has passed. > > > > > > > > Binding: > > > > +1 Daniel Kulp > > > > +1 Sean Busbey > > > > +1 Fokko Driesprong > > > > > > > > Non-binding: > > > > +1 Lunjie Jin > > > > +1 Michael A. Smith > > > > +1 Ismaël Mejía > > > > +1 Brian Lachniet > > > > > > > > I would like to thank the community from participating in the > release. > > > Both > > > > in providing patches for Apache Avro and giving the RC's a try. > > > > > > > > Yesterday I did some additional testing against Apache Spark > (similar to > > > > Nandor :-) and Apache Flink and did not find any blocking issues. > There > > > are > > > > some incompatibilities, but most of them are; revoking Jackson from > the > > > > public API and deprecating Joda. > > > > > > > > I'll publish the artifacts to the different repositories soon. On > this, I > > > > consider myself a polyglot programmer, but my knowledge is limited on > > > .Net, > > > > Perl, and Javascript, so I might ask some help from the community > here as > > > > well. > > > > > > > > Thanks all, and keep up the good work. > > > > > > > > Cheers, Fokko Driesprong > > > > > > > > Op di 14 mei 2019 om 14:48 schreef Nandor Kollar > > > > : > > > > > > > > > +1 (non-binding) > > > > > > > > > > * verified signatures and checksums > > > > > * ran unit tests, passed > > > > > * did a quick sanity test against Spark master: upgraded Spark Avro > > > > > dependency to this release candidate, ran spark-avro tests, all > passed > > > > (for > > > > > the record, two minor Maven changes are required due to removal of > > > > Hadoop 1 > > > > > support and making org.tukaani.xz provided dependency - looks like > > > Spark > > > > > tests against each codec). spark-hive tests failed, because > deprecated > > > > > methods were removed in Avro (related to Jackson removal from > public > > > API, > > > > > and Hive uses them), but I think it is expected, upgrading to a > major > > > > > release could have breaking changes. > > > > > > > > > > Nandor > > > > > > > > > > On Sun, May 12, 2019 at 7:11 AM Sean Busbey > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > -- Good: > > > > > > * signatures > > > > > > * checksums > > > > > > * tag/ref lines up with src artifact (except for one file > mentioned > > > > > below) > > > > > > * LICENSE/NOTICE spot check > > > > > > * apache rat says the license files for all the artifacts are > fine > > > > > (except > > > > > > it couldn't understand the gem; using the gem cli confirms it's > also > > > > > > correct) > > > > > > > > > > > > -- We Can Be Better Later: > > > > > > * filed AVRO-2395 because the "java" convenience binary part of > the > > > > dist > > > > > > section is redundant > > > > > > * in the future please post the specific staged maven repository > > > > instead > > > > > > of somewhere within the staged repository group. that'll help us > > > avoid > > > > > > possible conflicts should someone forget to cancel a staged RC or > > > > > > accidentally stage an additional
Re: [VOTE] Release Apache Avro 1.9.0 RC4
I just updated the docs: https://avro.apache.org/docs/current/ Still waiting on some permissions to fix some other languages. For the Apache Parquet one I ended up fixing more regression stuff than I expected. Especially that the NullNode wasn't working anymore: https://github.com/apache/parquet-mr/pull/638/files#diff-254da5a3fbfdb2d20acea16d54b9dc62L51 This now throws an exception. Don't know why I didn't saw this before. I've started on updating Flink as well, but that one still needs a bit more love. Replacing the Joda stuff with JSR310 requires some more attention. If someone else feels picking this up, this is fine from my side as well. I do would like to do the Incubating Druid one if no one objects. Cheers, Fokko Op wo 15 mei 2019 om 23:04 schreef Ismaël Mejía > Getting a new release of Avro feels amazing, thanks a lot Fokko for > all your wokr to get this out with the release. > > An interesting next step is downstreaming. I saw Fokko created a > ticket for Parquet, is anyone working on the Spark one? It will be > really nice to get this into Spark 3. Anything I can do to help there > or that we can sync work? > I filled https://issues.apache.org/jira/browse/SPARK-27733 for the moment. > > I am tackling the upgrade on Beam (the other project I work mostly on too. > https://issues.apache.org/jira/browse/BEAM-7328 > > Any other project worth the sync/work? > > > On Wed, May 15, 2019 at 8:54 PM Driesprong, Fokko > wrote: > > > > Hi Jacob, > > > > This looks off, I'll dive into it. I think it got released for some > reason. > > While releasing it today, I also noticed that the artifact wasn't staged > in > > Nexus anymore. However, RC4 is the same as the release. > > > > Cheers, Fokko > > > > Op wo 15 mei 2019 om 20:27 schreef Jacob Tolar > > : > > > > > Great news! We have been looking forward to the 1.9 release. > > > > > > I see 1.9.0 published on Maven Central. It appears to have been > published > > > 5/8 > > > (the same day as RC4 was announced but ~1week before vote passed). > > > > > > Is this the release build (presumably the same as RC4) or an earlier > RC? > > > > > > https://repo1.maven.org/maven2/org/apache/avro/avro/1.9.0/ > > > > > > Would it be helpful to have maven include the git sha somewhere in > > > MANIFEST.MF? > > > > > > jacob > > > > > > On Tue, May 14, 2019 at 1:04 PM Driesprong, Fokko > > > > wrote: > > > > > > > Thank you all, > > > > > > > > I'm happy to announce, the vote for Avro 1.9.0 has passed. > > > > > > > > Binding: > > > > +1 Daniel Kulp > > > > +1 Sean Busbey > > > > +1 Fokko Driesprong > > > > > > > > Non-binding: > > > > +1 Lunjie Jin > > > > +1 Michael A. Smith > > > > +1 Ismaël Mejía > > > > +1 Brian Lachniet > > > > > > > > I would like to thank the community from participating in the > release. > > > Both > > > > in providing patches for Apache Avro and giving the RC's a try. > > > > > > > > Yesterday I did some additional testing against Apache Spark > (similar to > > > > Nandor :-) and Apache Flink and did not find any blocking issues. > There > > > are > > > > some incompatibilities, but most of them are; revoking Jackson from > the > > > > public API and deprecating Joda. > > > > > > > > I'll publish the artifacts to the different repositories soon. On > this, I > > > > consider myself a polyglot programmer, but my knowledge is limited on > > > .Net, > > > > Perl, and Javascript, so I might ask some help from the community > here as > > > > well. > > > > > > > > Thanks all, and keep up the good work. > > > > > > > > Cheers, Fokko Driesprong > > > > > > > > Op di 14 mei 2019 om 14:48 schreef Nandor Kollar > > > > : > > > > > > > > > +1 (non-binding) > > > > > > > > > > * verified signatures and checksums > > > > > * ran unit tests, passed > > > > > * did a quick sanity test against Spark master: upgraded Spark Avro > > > > > dependency to this release candidate, ran spark-avro tests, all > passed > > > > (for > > > > > the record, two minor Maven changes are required due to removal of > > > > Hadoop 1 > > > > > support and making org.tukaani.xz provided dependency - looks like > > > Spark > > > > > tests against each codec). spark-hive tests failed, because > deprecated > > > > > methods were removed in Avro (related to Jackson removal from > public > > > API, > > > > > and Hive uses them), but I think it is expected, upgrading to a > major > > > > > release could have breaking changes. > > > > > > > > > > Nandor > > > > > > > > > > On Sun, May 12, 2019 at 7:11 AM Sean Busbey > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > -- Good: > > > > > > * signatures > > > > > > * checksums > > > > > > * tag/ref lines up with src artifact (except for one file > mentioned > > > > > below) > > > > > > * LICENSE/NOTICE spot check > > > > > > * apache rat says the license files for all the artifacts are > fine > > > > > (except > > > > > > it couldn't understand the gem; using the gem cli confirms it's > also > > > > > > correct) > > > >
Re: [VOTE] Release Apache Avro 1.9.0 RC4
Getting a new release of Avro feels amazing, thanks a lot Fokko for all your wokr to get this out with the release. An interesting next step is downstreaming. I saw Fokko created a ticket for Parquet, is anyone working on the Spark one? It will be really nice to get this into Spark 3. Anything I can do to help there or that we can sync work? I filled https://issues.apache.org/jira/browse/SPARK-27733 for the moment. I am tackling the upgrade on Beam (the other project I work mostly on too. https://issues.apache.org/jira/browse/BEAM-7328 Any other project worth the sync/work? On Wed, May 15, 2019 at 8:54 PM Driesprong, Fokko wrote: > > Hi Jacob, > > This looks off, I'll dive into it. I think it got released for some reason. > While releasing it today, I also noticed that the artifact wasn't staged in > Nexus anymore. However, RC4 is the same as the release. > > Cheers, Fokko > > Op wo 15 mei 2019 om 20:27 schreef Jacob Tolar > : > > > Great news! We have been looking forward to the 1.9 release. > > > > I see 1.9.0 published on Maven Central. It appears to have been published > > 5/8 > > (the same day as RC4 was announced but ~1week before vote passed). > > > > Is this the release build (presumably the same as RC4) or an earlier RC? > > > > https://repo1.maven.org/maven2/org/apache/avro/avro/1.9.0/ > > > > Would it be helpful to have maven include the git sha somewhere in > > MANIFEST.MF? > > > > jacob > > > > On Tue, May 14, 2019 at 1:04 PM Driesprong, Fokko > > wrote: > > > > > Thank you all, > > > > > > I'm happy to announce, the vote for Avro 1.9.0 has passed. > > > > > > Binding: > > > +1 Daniel Kulp > > > +1 Sean Busbey > > > +1 Fokko Driesprong > > > > > > Non-binding: > > > +1 Lunjie Jin > > > +1 Michael A. Smith > > > +1 Ismaël Mejía > > > +1 Brian Lachniet > > > > > > I would like to thank the community from participating in the release. > > Both > > > in providing patches for Apache Avro and giving the RC's a try. > > > > > > Yesterday I did some additional testing against Apache Spark (similar to > > > Nandor :-) and Apache Flink and did not find any blocking issues. There > > are > > > some incompatibilities, but most of them are; revoking Jackson from the > > > public API and deprecating Joda. > > > > > > I'll publish the artifacts to the different repositories soon. On this, I > > > consider myself a polyglot programmer, but my knowledge is limited on > > .Net, > > > Perl, and Javascript, so I might ask some help from the community here as > > > well. > > > > > > Thanks all, and keep up the good work. > > > > > > Cheers, Fokko Driesprong > > > > > > Op di 14 mei 2019 om 14:48 schreef Nandor Kollar > > > : > > > > > > > +1 (non-binding) > > > > > > > > * verified signatures and checksums > > > > * ran unit tests, passed > > > > * did a quick sanity test against Spark master: upgraded Spark Avro > > > > dependency to this release candidate, ran spark-avro tests, all passed > > > (for > > > > the record, two minor Maven changes are required due to removal of > > > Hadoop 1 > > > > support and making org.tukaani.xz provided dependency - looks like > > Spark > > > > tests against each codec). spark-hive tests failed, because deprecated > > > > methods were removed in Avro (related to Jackson removal from public > > API, > > > > and Hive uses them), but I think it is expected, upgrading to a major > > > > release could have breaking changes. > > > > > > > > Nandor > > > > > > > > On Sun, May 12, 2019 at 7:11 AM Sean Busbey wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > -- Good: > > > > > * signatures > > > > > * checksums > > > > > * tag/ref lines up with src artifact (except for one file mentioned > > > > below) > > > > > * LICENSE/NOTICE spot check > > > > > * apache rat says the license files for all the artifacts are fine > > > > (except > > > > > it couldn't understand the gem; using the gem cli confirms it's also > > > > > correct) > > > > > > > > > > -- We Can Be Better Later: > > > > > * filed AVRO-2395 because the "java" convenience binary part of the > > > dist > > > > > section is redundant > > > > > * in the future please post the specific staged maven repository > > > instead > > > > > of somewhere within the staged repository group. that'll help us > > avoid > > > > > possible conflicts should someone forget to cancel a staged RC or > > > > > accidentally stage an additional repository after the vote is called. > > > > FWIW > > > > > as far as I can tell from the Nexus UI, this is the staged repo for > > > this > > > > > VOTE (and it's what I verified): > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheavro-1020/ > > > > > > > > > > * When unpacking the source tarball I got this warning on OSX. > > > > > > > > > > > Busbey-MBA:1.9.0-RC4 busbey$ tar -C src_untar -xzf > > > > > > > > dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc4/avro-src-1.9.0.tar.gz > > > > > > tar: copyfile unpack > > > > > > > > > > > > > >
[jira] [Commented] (AVRO-2395) Stop including bare jars as convenience binary for Java
[ https://issues.apache.org/jira/browse/AVRO-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840689#comment-16840689 ] Brian Lachniet commented on AVRO-2395: -- (y) Perfect, the download from Maven serves my needs. > Stop including bare jars as convenience binary for Java > --- > > Key: AVRO-2395 > URL: https://issues.apache.org/jira/browse/AVRO-2395 > Project: Apache Avro > Issue Type: Task > Components: community, java >Affects Versions: 1.7.7, 1.9.0, 1.8.2 >Reporter: Sean Busbey >Priority: Major > > currently as a project our "convenience binary" for java is the complete set > of jars, source jars, test jars, and javadoc jars. that means as a part of RC > vetting someone has to check all of those individual files in addition to > checking them in the staged nexus repo. > > the overwhelming majority of java users will consume our releases via maven > central. we should either > > * ship nothing for java out of dist.a.o > * ship a tarball that contains the things we currently ship > * ship a tarball that is a laid out like a repository and includes both our > artifacts and transitive dependencies > > my personal preference is for "ship nothing". The last option would have the > most potential use IMHO, since it would allow someone to easily set up a > local repository when they need to build against our artifacts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Apache Avro 1.9.0 RC4
Hi Jacob, This looks off, I'll dive into it. I think it got released for some reason. While releasing it today, I also noticed that the artifact wasn't staged in Nexus anymore. However, RC4 is the same as the release. Cheers, Fokko Op wo 15 mei 2019 om 20:27 schreef Jacob Tolar : > Great news! We have been looking forward to the 1.9 release. > > I see 1.9.0 published on Maven Central. It appears to have been published > 5/8 > (the same day as RC4 was announced but ~1week before vote passed). > > Is this the release build (presumably the same as RC4) or an earlier RC? > > https://repo1.maven.org/maven2/org/apache/avro/avro/1.9.0/ > > Would it be helpful to have maven include the git sha somewhere in > MANIFEST.MF? > > jacob > > On Tue, May 14, 2019 at 1:04 PM Driesprong, Fokko > wrote: > > > Thank you all, > > > > I'm happy to announce, the vote for Avro 1.9.0 has passed. > > > > Binding: > > +1 Daniel Kulp > > +1 Sean Busbey > > +1 Fokko Driesprong > > > > Non-binding: > > +1 Lunjie Jin > > +1 Michael A. Smith > > +1 Ismaël Mejía > > +1 Brian Lachniet > > > > I would like to thank the community from participating in the release. > Both > > in providing patches for Apache Avro and giving the RC's a try. > > > > Yesterday I did some additional testing against Apache Spark (similar to > > Nandor :-) and Apache Flink and did not find any blocking issues. There > are > > some incompatibilities, but most of them are; revoking Jackson from the > > public API and deprecating Joda. > > > > I'll publish the artifacts to the different repositories soon. On this, I > > consider myself a polyglot programmer, but my knowledge is limited on > .Net, > > Perl, and Javascript, so I might ask some help from the community here as > > well. > > > > Thanks all, and keep up the good work. > > > > Cheers, Fokko Driesprong > > > > Op di 14 mei 2019 om 14:48 schreef Nandor Kollar > > : > > > > > +1 (non-binding) > > > > > > * verified signatures and checksums > > > * ran unit tests, passed > > > * did a quick sanity test against Spark master: upgraded Spark Avro > > > dependency to this release candidate, ran spark-avro tests, all passed > > (for > > > the record, two minor Maven changes are required due to removal of > > Hadoop 1 > > > support and making org.tukaani.xz provided dependency - looks like > Spark > > > tests against each codec). spark-hive tests failed, because deprecated > > > methods were removed in Avro (related to Jackson removal from public > API, > > > and Hive uses them), but I think it is expected, upgrading to a major > > > release could have breaking changes. > > > > > > Nandor > > > > > > On Sun, May 12, 2019 at 7:11 AM Sean Busbey wrote: > > > > > > > +1 (binding) > > > > > > > > -- Good: > > > > * signatures > > > > * checksums > > > > * tag/ref lines up with src artifact (except for one file mentioned > > > below) > > > > * LICENSE/NOTICE spot check > > > > * apache rat says the license files for all the artifacts are fine > > > (except > > > > it couldn't understand the gem; using the gem cli confirms it's also > > > > correct) > > > > > > > > -- We Can Be Better Later: > > > > * filed AVRO-2395 because the "java" convenience binary part of the > > dist > > > > section is redundant > > > > * in the future please post the specific staged maven repository > > instead > > > > of somewhere within the staged repository group. that'll help us > avoid > > > > possible conflicts should someone forget to cancel a staged RC or > > > > accidentally stage an additional repository after the vote is called. > > > FWIW > > > > as far as I can tell from the Nexus UI, this is the staged repo for > > this > > > > VOTE (and it's what I verified): > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheavro-1020/ > > > > > > > > * When unpacking the source tarball I got this warning on OSX. > > > > > > > > > Busbey-MBA:1.9.0-RC4 busbey$ tar -C src_untar -xzf > > > > > > dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc4/avro-src-1.9.0.tar.gz > > > > > tar: copyfile unpack > > > > > > > > > > (avro-src-1.9.0/lang/java/mapred/src/test/resources/org/apache/avro/mapreduce/mapreduce-test-input.avro/SUCCESS.crc) > > > > failed: No such file or directory > > > > > > > > I don't think it should be a blocker because it's shown up in prior > RCs > > > > since 2012 and AFAICT things are fine despite it, save a unit test. > > > > > > > > * An upgrade guide will help a bunch of folks given the time since > last > > > > release and this being a major version. > > > > > > > > For example, someone asked about how incompatible things are. So I > ran > > > the > > > > Java API Compliance Checker on the java libraries, since it's > > > (relatively) > > > > easy. After filtering out the "avro.shaded" package and excluding the > > > > hadoop1 specific jars from 1.8.2: > > > > > > > > > Busbey-MBA:1.9.0-RC4 busbey$ japi-compliance-checker -l "apache > avro" > > > > -d1 avro-1.8.2-jacc.xml -d2 avro-1.9.0-jacc.xml
Re: [VOTE] Release Apache Avro 1.9.0 RC4
Great news! We have been looking forward to the 1.9 release. I see 1.9.0 published on Maven Central. It appears to have been published 5/8 (the same day as RC4 was announced but ~1week before vote passed). Is this the release build (presumably the same as RC4) or an earlier RC? https://repo1.maven.org/maven2/org/apache/avro/avro/1.9.0/ Would it be helpful to have maven include the git sha somewhere in MANIFEST.MF? jacob On Tue, May 14, 2019 at 1:04 PM Driesprong, Fokko wrote: > Thank you all, > > I'm happy to announce, the vote for Avro 1.9.0 has passed. > > Binding: > +1 Daniel Kulp > +1 Sean Busbey > +1 Fokko Driesprong > > Non-binding: > +1 Lunjie Jin > +1 Michael A. Smith > +1 Ismaël Mejía > +1 Brian Lachniet > > I would like to thank the community from participating in the release. Both > in providing patches for Apache Avro and giving the RC's a try. > > Yesterday I did some additional testing against Apache Spark (similar to > Nandor :-) and Apache Flink and did not find any blocking issues. There are > some incompatibilities, but most of them are; revoking Jackson from the > public API and deprecating Joda. > > I'll publish the artifacts to the different repositories soon. On this, I > consider myself a polyglot programmer, but my knowledge is limited on .Net, > Perl, and Javascript, so I might ask some help from the community here as > well. > > Thanks all, and keep up the good work. > > Cheers, Fokko Driesprong > > Op di 14 mei 2019 om 14:48 schreef Nandor Kollar > : > > > +1 (non-binding) > > > > * verified signatures and checksums > > * ran unit tests, passed > > * did a quick sanity test against Spark master: upgraded Spark Avro > > dependency to this release candidate, ran spark-avro tests, all passed > (for > > the record, two minor Maven changes are required due to removal of > Hadoop 1 > > support and making org.tukaani.xz provided dependency - looks like Spark > > tests against each codec). spark-hive tests failed, because deprecated > > methods were removed in Avro (related to Jackson removal from public API, > > and Hive uses them), but I think it is expected, upgrading to a major > > release could have breaking changes. > > > > Nandor > > > > On Sun, May 12, 2019 at 7:11 AM Sean Busbey wrote: > > > > > +1 (binding) > > > > > > -- Good: > > > * signatures > > > * checksums > > > * tag/ref lines up with src artifact (except for one file mentioned > > below) > > > * LICENSE/NOTICE spot check > > > * apache rat says the license files for all the artifacts are fine > > (except > > > it couldn't understand the gem; using the gem cli confirms it's also > > > correct) > > > > > > -- We Can Be Better Later: > > > * filed AVRO-2395 because the "java" convenience binary part of the > dist > > > section is redundant > > > * in the future please post the specific staged maven repository > instead > > > of somewhere within the staged repository group. that'll help us avoid > > > possible conflicts should someone forget to cancel a staged RC or > > > accidentally stage an additional repository after the vote is called. > > FWIW > > > as far as I can tell from the Nexus UI, this is the staged repo for > this > > > VOTE (and it's what I verified): > > > > > > https://repository.apache.org/content/repositories/orgapacheavro-1020/ > > > > > > * When unpacking the source tarball I got this warning on OSX. > > > > > > > Busbey-MBA:1.9.0-RC4 busbey$ tar -C src_untar -xzf > > > > dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc4/avro-src-1.9.0.tar.gz > > > > tar: copyfile unpack > > > > > > (avro-src-1.9.0/lang/java/mapred/src/test/resources/org/apache/avro/mapreduce/mapreduce-test-input.avro/SUCCESS.crc) > > > failed: No such file or directory > > > > > > I don't think it should be a blocker because it's shown up in prior RCs > > > since 2012 and AFAICT things are fine despite it, save a unit test. > > > > > > * An upgrade guide will help a bunch of folks given the time since last > > > release and this being a major version. > > > > > > For example, someone asked about how incompatible things are. So I ran > > the > > > Java API Compliance Checker on the java libraries, since it's > > (relatively) > > > easy. After filtering out the "avro.shaded" package and excluding the > > > hadoop1 specific jars from 1.8.2: > > > > > > > Busbey-MBA:1.9.0-RC4 busbey$ japi-compliance-checker -l "apache avro" > > > -d1 avro-1.8.2-jacc.xml -d2 avro-1.9.0-jacc.xml -skip-packages > > > skip-packages.txt > > > > Preparing, please wait ... > > > > Using Java 1.8.0_161 > > > > Reading classes 1.8.2 ... > > > > WARNING: skipping "internal" packages > > > > NOTE: use --keep-internal option to check them > > > > Reading classes 1.9.0-rc4 ... > > > > WARNING: skipping "internal" packages > > > > Comparing classes ... > > > > Creating compatibility report ... > > > > Binary compatibility: 94.6% > > > > Source compatibility: 93.6% > > > > Total binary compatibility problems: 155, warnings: 26 > > > > Total source
[jira] [Updated] (AVRO-2392) Logical type time-micros and timestamp-micros generate as long types.
[
https://issues.apache.org/jira/browse/AVRO-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated AVRO-2392:
---
Fix Version/s: (was: 1.9.0)
1.10.0
> Logical type time-micros and timestamp-micros generate as long types.
> -
>
> Key: AVRO-2392
> URL: https://issues.apache.org/jira/browse/AVRO-2392
> Project: Apache Avro
> Issue Type: Bug
> Components: java, logical types
>Affects Versions: 1.8.2
>Reporter: Shameera Rathnayaka
>Priority: Major
> Fix For: 1.8.3, 1.10.0
>
>
> With Java code gen *time-micros* and *timestamp-micros* logical types
> generate as long typed value with Joda.
> Following will generate AvroLogicalTypeExample class, which has both
> `*timeMicrosField*` and '*timestampMicrosField*` values as *long* typed
> instance variables.
> {code:java}
> {
> "type": "record",
> "namespace": "com.shameera.test",
> "name": "AvroLogicalTypeExample",
> "fields": [
> {"name": "timeMicrosField",
> "type": {
> "type": "long",
> "logicalType": "time-micros"
> }
> },
> {"name": "timestampMicrosField",
> "type": {
> "type": "long",
> "logicalType": "timestamp-micros"
> }
> }
> ]
> }
> {code}
> https://issues.apache.org/jira/browse/AVRO-2123 partially address this issue,
> that is why I created a separate issue to track only the issue with micros
> times.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
