[jira] [Updated] (AVRO-2517) Avro new java Perf module includes a collision with avro module

[Jira]

 [ 
https://issues.apache.org/jira/browse/AVRO-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismaël Mejía updated AVRO-2517:
---
Description: 
While working on AVRO-2516 I discover that we had an issue with the package 
names in the Perf module, it should have an exclusive package or otherwise 
won't be compatible with Java 11
A ref that discusses this 
https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-19.md

  was:While working on AVRO-2516 I discover that we had an issue with the 
package names in the Perf module, it should have an exclusive package or 
otherwise won't be compatible with Java 11


> Avro new java Perf module includes a collision with avro module
> ---
>
> Key: AVRO-2517
> URL: https://issues.apache.org/jira/browse/AVRO-2517
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Major
> Fix For: 1.9.1
>
>
> While working on AVRO-2516 I discover that we had an issue with the package 
> names in the Perf module, it should have an exclusive package or otherwise 
> won't be compatible with Java 11
> A ref that discusses this 
> https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-19.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (AVRO-2517) Avro new java Perf module includes a collision with avro module

[Jira]

 [ 
https://issues.apache.org/jira/browse/AVRO-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismaël Mejía updated AVRO-2517:
---
Summary: Avro new java Perf module includes a collision with avro module  
(was: Avro new java Perf module includes a collisions with avro module)

> Avro new java Perf module includes a collision with avro module
> ---
>
> Key: AVRO-2517
> URL: https://issues.apache.org/jira/browse/AVRO-2517
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Major
> Fix For: 1.9.1
>
>
> While working on AVRO-2516 I discover that we had an issue with the package 
> names in the Perf module, it should have an exclusive package or otherwise 
> won't be compatible with Java 11



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (AVRO-2516) Add Automatic-Module-Name headers for Avro modules

[Jira]

 [ 
https://issues.apache.org/jira/browse/AVRO-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismaël Mejía updated AVRO-2516:
---
Fix Version/s: 1.9.1

> Add Automatic-Module-Name headers for Avro modules
> --
>
> Key: AVRO-2516
> URL: https://issues.apache.org/jira/browse/AVRO-2516
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Reporter: Ismaël Mejía
>Priority: Minor
> Fix For: 1.9.1
>
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and 
> later, every JAR should have a module name, even if the library does not 
> itself use modules. [This 
> ref|https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md]
>  explains why this is important and how to address it.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Release Apache Avro 1.9.1 RC1

[Ismaël Mejía]

Hello,

I have a question, while checking some Java 11 improvements I
discovered that the Perf module that we introduced in 1.9.0 has a
split package issue that can cause conflicts with Java 11. I was
wondering if we could fix this (the fix is just to isolate the module
classes into its own package), however this is not backwards
compatible with Avro 1.9.0. So should we get this into this release?
or be strict and let it for 1.10.x?

I just opened the PR for the solution for master (1.10.0) [1] but was
thinking that it is probably worth to cherry pick it and include it in
1.9.1 even if breaking the previous version compatiblity, because it
is quite new and I expect it has low impact.

Any opinions?

[1] https://github.com/apache/avro/pull/615


https://issues.apache.org/jira/browse/AVRO-2517

On Wed, Aug 21, 2019 at 11:22 AM Driesprong, Fokko  wrote:
>
> Thank you Brian,
>
> I'm canceling the RC1 and I'm doing some checks on the 1.9 branch. Seeing
> some funky stuff with the RAT checker. I'll prepare for RC2 this evening.
>
> Cheers, Fokko
>
>
>
>
> Op wo 21 aug. 2019 om 04:17 schreef Brian Lachniet :
>
> > It sounds like an rc2 is imminent, but I went ahead and ran some basic
> > checks on the C# bindings. I didn't find anything unusual. I published
> > Apache.Avro
> > v1.9.1-rc1  and
> > Apache.Avro.Tools
> > v1.9.1-rc1  to
> > nuget.org.
> >
> > On Tue, Aug 20, 2019 at 3:44 PM Driesprong, Fokko 
> > wrote:
> >
> > > Thanks, Dan for giving it a try. My mistake, this file comes from the
> > > test-suite. I'll clean up the repo and publish a new package.
> > >
> > > Cheers, Fokko
> > >
> > > Op di 20 aug. 2019 om 21:41 schreef Daniel Kulp :
> > >
> > > > Java doesn’t build.There is an empty file:
> > > >
> > > >
> > > >
> > >
> > lang/java/mapred/src/test/resources/org/apache/avro/mapreduce/mapreduce-test-input.avro/SUCCESS.crc
> > > >
> > > > In the tar that doesn’t seem to be in the git repo.  It’s causing a
> > > > problem with RAT since there isn’t a license header or anything.   I’m
> > > not
> > > > sure where that file came from.
> > > >
> > > >
> > > > Dan
> > > >
> > > >
> > > >
> > > >
> > > > > On Aug 20, 2019, at 2:04 PM, Driesprong, Fokko  > >
> > > > wrote:
> > > > >
> > > > > Hi everyone,
> > > > >
> > > > > I'm delighted to propose the following RC to be released as official
> > > > Apache
> > > > > Avro 1.9.1 release.
> > > > >
> > > > > The commit id is aad028bf84d43cc3481ac8b527f30debbdf213d2
> > > > > * This corresponds to the tag: release-1.9.1-rc1
> > > > > * https://github.com/apache/avro/releases/tag/release-1.9.1-rc1
> > > > >
> > > > > The release tarball, signature, and checksums are here:
> > > > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.1-rc1/
> > > > >
> > > > > You can find the KEYS file here:
> > > > > * https://dist.apache.org/repos/dist/dev/avro/KEYS
> > > > >
> > > > > Binary artifacts for Java are staged in Nexus here:
> > > > > *
> > > > >
> > > >
> > >
> > https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.1/
> > > > >
> > > > > This release includes 31 Jira issues:
> > > > >
> > > >
> > >
> > https://jira.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20fixVersion%20%3D%201.9.1
> > > > > * Most important, fix regression issues:
> > > > >  * Java: decoding schema's:
> > > > https://jira.apache.org/jira/browse/AVRO-2400
> > > > >  * .Net: Performance issue:
> > > > https://jira.apache.org/jira/browse/AVRO-2396
> > > > > * Java: Make org.apache.avro.Schema serializable
> > > > > * Java: Ability to add custom object to Velocity templating
> > > > > * Improved interoperability testing
> > > > > * Removed NPE's
> > > > > * Upgrade dependencies to latest to the latest version
> > > > > * And many more :-)
> > > > >
> > > > > Please download, verify, and test. This vote will remain open for at
> > > > least
> > > > > 72 hours. Given sufficient votes, I would like to close it on or
> > about
> > > > > midnight
> > > > > on Saturday, 24 August 2019.
> > > > >
> > > > > [ ] +1 Release this as Apache Avro 1.9.1
> > > > > [ ] +0
> > > > > [ ] -1 Do not release this because...
> > > > >
> > > > > Consider this a +1 (binding) from my side:
> > > > > * Compiled against Divolte collector and Iceberg
> > > > >
> > > > > Cheers, Fokko Driesprong
> > > >
> > > > --
> > > > Daniel Kulp
> > > > dk...@apache.org  - http://dankulp.com/blog <
> > > > http://dankulp.com/blog>
> > > > Talend Community Coder - http://talend.com 
> > > >
> > >
> >
> >
> > --
> >
> > [image: 51b630b05e01a6d5134ccfd520f547c4.png]
> >
> > Brian Lachniet
> >
> > Software Engineer
> >
> > E: blachn...@gmail.com | blachniet.com 
> >
> >  
> >

[jira] [Updated] (AVRO-2517) Avro new java Perf module includes a collisions with avro module

[Jira]

 [ 
https://issues.apache.org/jira/browse/AVRO-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismaël Mejía updated AVRO-2517:
---
Fix Version/s: 1.9.1

> Avro new java Perf module includes a collisions with avro module
> 
>
> Key: AVRO-2517
> URL: https://issues.apache.org/jira/browse/AVRO-2517
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Major
> Fix For: 1.9.1
>
>
> While working on AVRO-2516 I discover that we had an issue with the package 
> names in the Perf module, it should have an exclusive package or otherwise 
> won't be compatible with Java 11



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (AVRO-2517) Avro new java Perf module includes a collisions with avro module

[Jira]

Ismaël Mejía created AVRO-2517:
--

 Summary: Avro new java Perf module includes a collisions with avro 
module
 Key: AVRO-2517
 URL: https://issues.apache.org/jira/browse/AVRO-2517
 Project: Apache Avro
  Issue Type: Bug
  Components: java
Affects Versions: 1.9.0
Reporter: Ismaël Mejía
Assignee: Ismaël Mejía


While working on AVRO-2516 I discover that we had an issue with the package 
names in the Perf module, it should have an exclusive package or otherwise 
won't be compatible with Java 11



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (AVRO-2516) Add Automatic-Module-Name headers for Avro modules

[Jira]

Ismaël Mejía created AVRO-2516:
--

 Summary: Add Automatic-Module-Name headers for Avro modules
 Key: AVRO-2516
 URL: https://issues.apache.org/jira/browse/AVRO-2516
 Project: Apache Avro
  Issue Type: Bug
  Components: java
Reporter: Ismaël Mejía


For compatibility with the Java Platform Module System (JPMS) in Java 9 and 
later, every JAR should have a module name, even if the library does not itself 
use modules. [This 
ref|https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md]
 explains why this is important and how to address it.




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [VOTE] Release Apache Avro 1.9.1 RC1

[Driesprong, Fokko]

Thank you Brian,

I'm canceling the RC1 and I'm doing some checks on the 1.9 branch. Seeing
some funky stuff with the RAT checker. I'll prepare for RC2 this evening.

Cheers, Fokko




Op wo 21 aug. 2019 om 04:17 schreef Brian Lachniet :

> It sounds like an rc2 is imminent, but I went ahead and ran some basic
> checks on the C# bindings. I didn't find anything unusual. I published
> Apache.Avro
> v1.9.1-rc1  and
> Apache.Avro.Tools
> v1.9.1-rc1  to
> nuget.org.
>
> On Tue, Aug 20, 2019 at 3:44 PM Driesprong, Fokko 
> wrote:
>
> > Thanks, Dan for giving it a try. My mistake, this file comes from the
> > test-suite. I'll clean up the repo and publish a new package.
> >
> > Cheers, Fokko
> >
> > Op di 20 aug. 2019 om 21:41 schreef Daniel Kulp :
> >
> > > Java doesn’t build.There is an empty file:
> > >
> > >
> > >
> >
> lang/java/mapred/src/test/resources/org/apache/avro/mapreduce/mapreduce-test-input.avro/SUCCESS.crc
> > >
> > > In the tar that doesn’t seem to be in the git repo.  It’s causing a
> > > problem with RAT since there isn’t a license header or anything.   I’m
> > not
> > > sure where that file came from.
> > >
> > >
> > > Dan
> > >
> > >
> > >
> > >
> > > > On Aug 20, 2019, at 2:04 PM, Driesprong, Fokko  >
> > > wrote:
> > > >
> > > > Hi everyone,
> > > >
> > > > I'm delighted to propose the following RC to be released as official
> > > Apache
> > > > Avro 1.9.1 release.
> > > >
> > > > The commit id is aad028bf84d43cc3481ac8b527f30debbdf213d2
> > > > * This corresponds to the tag: release-1.9.1-rc1
> > > > * https://github.com/apache/avro/releases/tag/release-1.9.1-rc1
> > > >
> > > > The release tarball, signature, and checksums are here:
> > > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.1-rc1/
> > > >
> > > > You can find the KEYS file here:
> > > > * https://dist.apache.org/repos/dist/dev/avro/KEYS
> > > >
> > > > Binary artifacts for Java are staged in Nexus here:
> > > > *
> > > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.1/
> > > >
> > > > This release includes 31 Jira issues:
> > > >
> > >
> >
> https://jira.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20fixVersion%20%3D%201.9.1
> > > > * Most important, fix regression issues:
> > > >  * Java: decoding schema's:
> > > https://jira.apache.org/jira/browse/AVRO-2400
> > > >  * .Net: Performance issue:
> > > https://jira.apache.org/jira/browse/AVRO-2396
> > > > * Java: Make org.apache.avro.Schema serializable
> > > > * Java: Ability to add custom object to Velocity templating
> > > > * Improved interoperability testing
> > > > * Removed NPE's
> > > > * Upgrade dependencies to latest to the latest version
> > > > * And many more :-)
> > > >
> > > > Please download, verify, and test. This vote will remain open for at
> > > least
> > > > 72 hours. Given sufficient votes, I would like to close it on or
> about
> > > > midnight
> > > > on Saturday, 24 August 2019.
> > > >
> > > > [ ] +1 Release this as Apache Avro 1.9.1
> > > > [ ] +0
> > > > [ ] -1 Do not release this because...
> > > >
> > > > Consider this a +1 (binding) from my side:
> > > > * Compiled against Divolte collector and Iceberg
> > > >
> > > > Cheers, Fokko Driesprong
> > >
> > > --
> > > Daniel Kulp
> > > dk...@apache.org  - http://dankulp.com/blog <
> > > http://dankulp.com/blog>
> > > Talend Community Coder - http://talend.com 
> > >
> >
>
>
> --
>
> [image: 51b630b05e01a6d5134ccfd520f547c4.png]
>
> Brian Lachniet
>
> Software Engineer
>
> E: blachn...@gmail.com | blachniet.com 
>
>  
>

[jira] [Created] (AVRO-2515) Enable direct access to utility methods in ProtobufData

[Teodor Kostov (Jira)]

Teodor Kostov created AVRO-2515:
---

 Summary: Enable direct access to utility methods in ProtobufData
 Key: AVRO-2515
 URL: https://issues.apache.org/jira/browse/AVRO-2515
 Project: Apache Avro
  Issue Type: Improvement
  Components: java
Affects Versions: 1.9.0
 Environment: N/A
Reporter: Teodor Kostov


Enable direct access to utility methods in {{ProtobufData}} that deal with the 
message description on a more granular level.

{{ProtobufData}} presents some great functionality that allows dealing with the 
Protobuf message descriptors. The intention of this PR is to provide access to 
the methods that deal with these descriptors on a more granular level. This 
would make it more flexible for the library clients to deal with their Protobuf 
message.

In terms of extending the functionality this would make it possible for clients 
to adjust some specific moments of the conversion from Protobuf descriptors to 
Avro schemas.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)