Re: Avro 1.9.2
So far none of my python2/3 changes have been targeting 1.9. They're currently just in master. It would be great if someone could cherry pick them. I'm away this weekend, but happy to help via phone or more directly next week if it turns complex. Best regards, Mike On Sat, Jan 11, 2020 at 07:39 Driesprong, Fokko wrote: > Thanks for the review Ryan, appreciate it. > > I'm happy to help you with the release, if you could pick that up, that > would be great. Before starting the release process, I'd like to check if > there are commits that are targeted for 1.10 but can be cherry-picked back > to 1.9.2. > > For doing the release, there are two important things: > - Having the gpg keys in place: > https://www.apache.org/dev/release-signing.html > - Run the build chain for building the artifacts for the different > platforms: https://cwiki.apache.org/confluence/display/AVRO/How+To+Release > > Luckily we have Docker for the latter :-) > > Cheers, Fokko > > Op vr 10 jan. 2020 om 17:41 schreef Ryan Skraba : > > > Hello! I read and reviewed the PR -- it looks OK to me, is there > > something more to do to the current fix? > > > > I'd be happy to do or help out with the release ... I suspect I might > > need a bit of hand-holding for this first time, but the doc looks > > pretty complete. Alternatively, if it's easier, I could shadow > > whoever is doing this one and be ready for the next. It's pretty > > exciting to see the cadence pick up for Avro! > > > > All my best, Ryan > > > > On Thu, Jan 9, 2020 at 9:48 AM Driesprong, Fokko > > wrote: > > > > > > Hi all, > > > > > > I'm working on bumping Apache Avro on the Apache Iceberg project: > > > https://github.com/apache/incubator-iceberg/pull/297, I've discovered > a > > > regression bug. I've managed to create a unit test that catches the > > issue: > > > https://github.com/apache/avro/pull/752. The current fix isn't the > > correct > > > one. I hope to fix it somewhere this weekend, and afterward, start the > > > release process for 1.9.2. > > > > > > If there is anything that you need to have cherry-picked onto the 1.9 > > > branch, please let me know. Also, if there is anyone who likes to > > shepherd > > > the release, or wants to help out, please feel free to let me know :-) > > > > > > Thanks all, > > > > > > Cheers, Fokko > > >
[jira] [Commented] (AVRO-2672) Bump spotless-maven-plugin from 1.25.1 to 1.27.0
[ https://issues.apache.org/jira/browse/AVRO-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013471#comment-17013471 ] Hudson commented on AVRO-2672: -- SUCCESS: Integrated in Jenkins build AvroJava #800 (See [https://builds.apache.org/job/AvroJava/800/]) AVRO-2672: Bump spotless-maven-plugin from 1.25.1 to 1.27.0 (#757) (github: [https://github.com/apache/avro/commit/760112a748a608f555c20fcaec0edaa404beaf91]) * (edit) pom.xml > Bump spotless-maven-plugin from 1.25.1 to 1.27.0 > > > Key: AVRO-2672 > URL: https://issues.apache.org/jira/browse/AVRO-2672 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2674) Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final
[ https://issues.apache.org/jira/browse/AVRO-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013469#comment-17013469 ] Hudson commented on AVRO-2674: -- SUCCESS: Integrated in Jenkins build AvroJava #800 (See [https://builds.apache.org/job/AvroJava/800/]) AVRO-2674: Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final (github: [https://github.com/apache/avro/commit/5df740679737fdfb591213dff5bf1217a299c4c3]) * (edit) lang/java/pom.xml > Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final > > > Key: AVRO-2674 > URL: https://issues.apache.org/jira/browse/AVRO-2674 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2677) Decimal logical type don't serialize precision and scale in Ruby
[
https://issues.apache.org/jira/browse/AVRO-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013468#comment-17013468
]
Hudson commented on AVRO-2677:
--
SUCCESS: Integrated in Jenkins build AvroJava #800 (See
[https://builds.apache.org/job/AvroJava/800/])
AVRO-2677: Ruby parse/serialize bytes decimal logical type (#761) (fokko:
[https://github.com/apache/avro/commit/912c15b36caacdea5cf3a6753316022156681470])
* (edit) lang/ruby/test/test_schema.rb
* (edit) lang/ruby/lib/avro/schema.rb
> Decimal logical type don't serialize precision and scale in Ruby
>
>
> Key: AVRO-2677
> URL: https://issues.apache.org/jira/browse/AVRO-2677
> Project: Apache Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Sergey Toy
>Assignee: Sergey Toy
>Priority: Major
> Fix For: 1.10.0
>
>
>
> {code:java}
> payload = '{ "type": "bytes", "logicalType": "decimal", "precision": 9,
> "scale": 2 }'
> result = Avro::Schema.real_parse(JSON.parse(payload))
> result.to_avro # => {"type"=>"bytes", "logicalType"=>"decimal"}{code}
>
> Should be
> {code:java}
> {"type"=>"bytes", "logicalType"=>"decimal", "precision"=>9, "scale"=>2}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2673) Bump protobuf-java from 3.10.0 to 3.11.1
[ https://issues.apache.org/jira/browse/AVRO-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013470#comment-17013470 ] Hudson commented on AVRO-2673: -- SUCCESS: Integrated in Jenkins build AvroJava #800 (See [https://builds.apache.org/job/AvroJava/800/]) AVRO-2673: Bump protobuf-java from 3.10.0 to 3.11.1 (#759) (github: [https://github.com/apache/avro/commit/b0f0131647b8f8277b3648cb95c10ef4810e5c26]) * (edit) lang/java/pom.xml > Bump protobuf-java from 3.10.0 to 3.11.1 > > > Key: AVRO-2673 > URL: https://issues.apache.org/jira/browse/AVRO-2673 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2669) TestProtocolSpecific use getClientProtocol getter
[ https://issues.apache.org/jira/browse/AVRO-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013465#comment-17013465 ] ASF subversion and git services commented on AVRO-2669: --- Commit aa49146b0d8a0d6d5787348ba8f28d485671635d in avro's branch refs/heads/branch-1.9 from Fokko Driesprong [ https://gitbox.apache.org/repos/asf?p=avro.git;h=aa49146 ] AVRO-2669: TestProtocolSpecific use getClientProtocol getter (#755) > TestProtocolSpecific use getClientProtocol getter > - > > Key: AVRO-2669 > URL: https://issues.apache.org/jira/browse/AVRO-2669 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2669) TestProtocolSpecific use getClientProtocol getter
[ https://issues.apache.org/jira/browse/AVRO-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2669. Resolution: Fixed > TestProtocolSpecific use getClientProtocol getter > - > > Key: AVRO-2669 > URL: https://issues.apache.org/jira/browse/AVRO-2669 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Avro 1.9.2
Thanks for the review Ryan, appreciate it. I'm happy to help you with the release, if you could pick that up, that would be great. Before starting the release process, I'd like to check if there are commits that are targeted for 1.10 but can be cherry-picked back to 1.9.2. For doing the release, there are two important things: - Having the gpg keys in place: https://www.apache.org/dev/release-signing.html - Run the build chain for building the artifacts for the different platforms: https://cwiki.apache.org/confluence/display/AVRO/How+To+Release Luckily we have Docker for the latter :-) Cheers, Fokko Op vr 10 jan. 2020 om 17:41 schreef Ryan Skraba : > Hello! I read and reviewed the PR -- it looks OK to me, is there > something more to do to the current fix? > > I'd be happy to do or help out with the release ... I suspect I might > need a bit of hand-holding for this first time, but the doc looks > pretty complete. Alternatively, if it's easier, I could shadow > whoever is doing this one and be ready for the next. It's pretty > exciting to see the cadence pick up for Avro! > > All my best, Ryan > > On Thu, Jan 9, 2020 at 9:48 AM Driesprong, Fokko > wrote: > > > > Hi all, > > > > I'm working on bumping Apache Avro on the Apache Iceberg project: > > https://github.com/apache/incubator-iceberg/pull/297, I've discovered a > > regression bug. I've managed to create a unit test that catches the > issue: > > https://github.com/apache/avro/pull/752. The current fix isn't the > correct > > one. I hope to fix it somewhere this weekend, and afterward, start the > > release process for 1.9.2. > > > > If there is anything that you need to have cherry-picked onto the 1.9 > > branch, please let me know. Also, if there is anyone who likes to > shepherd > > the release, or wants to help out, please feel free to let me know :-) > > > > Thanks all, > > > > Cheers, Fokko >
[jira] [Commented] (AVRO-2672) Bump spotless-maven-plugin from 1.25.1 to 1.27.0
[ https://issues.apache.org/jira/browse/AVRO-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013464#comment-17013464 ] ASF subversion and git services commented on AVRO-2672: --- Commit 760112a748a608f555c20fcaec0edaa404beaf91 in avro's branch refs/heads/master from Fokko Driesprong [ https://gitbox.apache.org/repos/asf?p=avro.git;h=760112a ] AVRO-2672: Bump spotless-maven-plugin from 1.25.1 to 1.27.0 (#757) > Bump spotless-maven-plugin from 1.25.1 to 1.27.0 > > > Key: AVRO-2672 > URL: https://issues.apache.org/jira/browse/AVRO-2672 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2672) Bump spotless-maven-plugin from 1.25.1 to 1.27.0
[ https://issues.apache.org/jira/browse/AVRO-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2672. Resolution: Fixed > Bump spotless-maven-plugin from 1.25.1 to 1.27.0 > > > Key: AVRO-2672 > URL: https://issues.apache.org/jira/browse/AVRO-2672 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2673) Bump protobuf-java from 3.10.0 to 3.11.1
[ https://issues.apache.org/jira/browse/AVRO-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2673. Resolution: Fixed > Bump protobuf-java from 3.10.0 to 3.11.1 > > > Key: AVRO-2673 > URL: https://issues.apache.org/jira/browse/AVRO-2673 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2673) Bump protobuf-java from 3.10.0 to 3.11.1
[ https://issues.apache.org/jira/browse/AVRO-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013463#comment-17013463 ] ASF subversion and git services commented on AVRO-2673: --- Commit b0f0131647b8f8277b3648cb95c10ef4810e5c26 in avro's branch refs/heads/master from Fokko Driesprong [ https://gitbox.apache.org/repos/asf?p=avro.git;h=b0f0131 ] AVRO-2673: Bump protobuf-java from 3.10.0 to 3.11.1 (#759) > Bump protobuf-java from 3.10.0 to 3.11.1 > > > Key: AVRO-2673 > URL: https://issues.apache.org/jira/browse/AVRO-2673 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2674) Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final
[ https://issues.apache.org/jira/browse/AVRO-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013462#comment-17013462 ] ASF subversion and git services commented on AVRO-2674: --- Commit 5df740679737fdfb591213dff5bf1217a299c4c3 in avro's branch refs/heads/master from Fokko Driesprong [ https://gitbox.apache.org/repos/asf?p=avro.git;h=5df7406 ] AVRO-2674: Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final (#760) > Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final > > > Key: AVRO-2674 > URL: https://issues.apache.org/jira/browse/AVRO-2674 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2674) Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final
[ https://issues.apache.org/jira/browse/AVRO-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2674. Resolution: Fixed > Bump netty-codec-http2 from 4.1.42.Final to 4.1.44.Final > > > Key: AVRO-2674 > URL: https://issues.apache.org/jira/browse/AVRO-2674 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.9.1 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2677) Decimal logical type don't serialize precision and scale in Ruby
[
https://issues.apache.org/jira/browse/AVRO-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved AVRO-2677.
Resolution: Fixed
> Decimal logical type don't serialize precision and scale in Ruby
>
>
> Key: AVRO-2677
> URL: https://issues.apache.org/jira/browse/AVRO-2677
> Project: Apache Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Sergey Toy
>Assignee: Sergey Toy
>Priority: Major
> Fix For: 1.10.0
>
>
>
> {code:java}
> payload = '{ "type": "bytes", "logicalType": "decimal", "precision": 9,
> "scale": 2 }'
> result = Avro::Schema.real_parse(JSON.parse(payload))
> result.to_avro # => {"type"=>"bytes", "logicalType"=>"decimal"}{code}
>
> Should be
> {code:java}
> {"type"=>"bytes", "logicalType"=>"decimal", "precision"=>9, "scale"=>2}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2677) Decimal logical type don't serialize precision and scale in Ruby
[
https://issues.apache.org/jira/browse/AVRO-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013461#comment-17013461
]
ASF subversion and git services commented on AVRO-2677:
---
Commit 912c15b36caacdea5cf3a6753316022156681470 in avro's branch
refs/heads/master from Sergey Toy
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=912c15b ]
AVRO-2677: Ruby parse/serialize bytes decimal logical type (#761)
* add BytesDecimalSchema class
* remove unnecessary comment
* add tests for decimal schema
* refactor bytes decimal `to_avro`
* refactor BytesDecimalSchema to BytesSchema to works with all bytes schema and
not only for decimal
> Decimal logical type don't serialize precision and scale in Ruby
>
>
> Key: AVRO-2677
> URL: https://issues.apache.org/jira/browse/AVRO-2677
> Project: Apache Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Sergey Toy
>Assignee: Sergey Toy
>Priority: Major
>
>
> {code:java}
> payload = '{ "type": "bytes", "logicalType": "decimal", "precision": 9,
> "scale": 2 }'
> result = Avro::Schema.real_parse(JSON.parse(payload))
> result.to_avro # => {"type"=>"bytes", "logicalType"=>"decimal"}{code}
>
> Should be
> {code:java}
> {"type"=>"bytes", "logicalType"=>"decimal", "precision"=>9, "scale"=>2}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2677) Decimal logical type don't serialize precision and scale in Ruby
[
https://issues.apache.org/jira/browse/AVRO-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated AVRO-2677:
---
Fix Version/s: 1.10.0
> Decimal logical type don't serialize precision and scale in Ruby
>
>
> Key: AVRO-2677
> URL: https://issues.apache.org/jira/browse/AVRO-2677
> Project: Apache Avro
> Issue Type: Bug
> Components: ruby
>Reporter: Sergey Toy
>Assignee: Sergey Toy
>Priority: Major
> Fix For: 1.10.0
>
>
>
> {code:java}
> payload = '{ "type": "bytes", "logicalType": "decimal", "precision": 9,
> "scale": 2 }'
> result = Avro::Schema.real_parse(JSON.parse(payload))
> result.to_avro # => {"type"=>"bytes", "logicalType"=>"decimal"}{code}
>
> Should be
> {code:java}
> {"type"=>"bytes", "logicalType"=>"decimal", "precision"=>9, "scale"=>2}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
