[jira] [Commented] (AVRO-2070) Tolerate any Number when writing primitive values in Java in GenericDatumWriter

2020-02-19 Thread jason mathews (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040540#comment-17040540
 ] 

jason mathews commented on AVRO-2070:
-

This issue is a bug not an improvement. See the previous comment.

Please reclassify the issue as a bug against the java implementation. Thanks.

> Tolerate any Number when writing primitive values in Java in 
> GenericDatumWriter
> ---
>
> Key: AVRO-2070
> URL: https://issues.apache.org/jira/browse/AVRO-2070
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Reporter: Daniil Gitelson
>Assignee: Rabi Kumar K C
>Priority: Major
>
> Tolerating any Number (instead of concrete Long, Double, Float) makes 
> possible to use mutable Number implmentation for performance reasons 
> (specially for primitive collection iterations)
> Currently, this only works for int only:
> {code:java}
>   // Here it works
>   case INT: out.writeInt(((Number)datum).intValue()); break;
>   // This should be replaced with ((Number)datum).longValue() etc
>   case LONG:out.writeLong((Long)datum);   break;
>   case FLOAT:   out.writeFloat((Float)datum); break;
>   case DOUBLE:  out.writeDouble((Double)datum);   break;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AVRO-2753) Add leaveOpen option to DataFileReader and Writer to keep Stream open

2020-02-19 Thread Zoltan Csizmadia (Jira)


 [ 
https://issues.apache.org/jira/browse/AVRO-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Csizmadia updated AVRO-2753:
---
Description: 
# If a stream is used to open DataFileReader or DataFileWriter, an optional  
leaveOpen (default=false) should exist as an additional argument to flag the 
object not to close and dispose the stream when the reader/writer object is 
disposed.
 # The stream objects are not disposed (only closed) as of now, leaving the 
reader and writer objects not disposed.

 

leaveOpen follows the Stream pattern which used in other Stream related areas. 
This can be useful if streams are chained together, e.g. 
Compressor/decompressor streams chained together with Avro reader/writer 
objects.

> Add leaveOpen option to DataFileReader and Writer to keep Stream open
> -
>
> Key: AVRO-2753
> URL: https://issues.apache.org/jira/browse/AVRO-2753
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: Zoltan Csizmadia
>Assignee: Zoltan Csizmadia
>Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> # If a stream is used to open DataFileReader or DataFileWriter, an optional  
> leaveOpen (default=false) should exist as an additional argument to flag the 
> object not to close and dispose the stream when the reader/writer object is 
> disposed.
>  # The stream objects are not disposed (only closed) as of now, leaving the 
> reader and writer objects not disposed.
>  
> leaveOpen follows the Stream pattern which used in other Stream related 
> areas. This can be useful if streams are chained together, e.g. 
> Compressor/decompressor streams chained together with Avro reader/writer 
> objects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2754) Add support for UUID logical types in C#

2020-02-19 Thread Matthew Kellogg (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040397#comment-17040397
 ] 

Matthew Kellogg commented on AVRO-2754:
---

[https://github.com/apache/avro/pull/822]

> Add support for UUID logical types in C#
> 
>
> Key: AVRO-2754
> URL: https://issues.apache.org/jira/browse/AVRO-2754
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: csharp
>Affects Versions: 1.9.2
>Reporter: Matthew Kellogg
>Priority: Minor
>
> Add support for UUID logical types to the C# library
>  * Codegen should generate Guid fields/properties
>  * Base schema type is a string with the guid encoded in RFC 4122 format 
> (Guid.ToString() does this by default)
>  * Ensure nullable is supported properly



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (AVRO-2754) Add support for UUID logical types in C#

2020-02-19 Thread Matthew Kellogg (Jira)
Matthew Kellogg created AVRO-2754:
-

 Summary: Add support for UUID logical types in C#
 Key: AVRO-2754
 URL: https://issues.apache.org/jira/browse/AVRO-2754
 Project: Apache Avro
  Issue Type: Improvement
  Components: csharp
Affects Versions: 1.9.2
Reporter: Matthew Kellogg


Add support for UUID logical types to the C# library
 * Codegen should generate Guid fields/properties
 * Base schema type is a string with the guid encoded in RFC 4122 format 
(Guid.ToString() does this by default)
 * Ensure nullable is supported properly



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (AVRO-2753) Add leaveOpen option to DataFileReader and Writer to keep Stream open

2020-02-19 Thread Zoltan Csizmadia (Jira)
Zoltan Csizmadia created AVRO-2753:
--

 Summary: Add leaveOpen option to DataFileReader and Writer to keep 
Stream open
 Key: AVRO-2753
 URL: https://issues.apache.org/jira/browse/AVRO-2753
 Project: Apache Avro
  Issue Type: Improvement
Reporter: Zoltan Csizmadia
Assignee: Zoltan Csizmadia






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2732) Docker image build is broken on master

2020-02-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040052#comment-17040052
 ] 

Hudson commented on AVRO-2732:
--

SUCCESS: Integrated in Jenkins build AvroJava #832 (See 
[https://builds.apache.org/job/AvroJava/832/])
AVRO-2732: Add missing packages to avoid warnings in the docker image (iemejia: 
[https://github.com/apache/avro/commit/1dbf61ee8cf2866e6e590388198e64c190af1e3f])
* (edit) share/docker/Dockerfile


> Docker image build is broken on master
> --
>
> Key: AVRO-2732
> URL: https://issues.apache.org/jira/browse/AVRO-2732
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: docker
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
> Fix For: 1.10.0, 1.9.3
>
>
> It seems we had the bad luck that our Dockerfile building/validation image got
> broken because of a change in its upstream parent image openjdk:11 that was 
> upgraded
> to the latest version of its parent version (debian:stable). Debian stable 
> does
> not include Java 8 anymore, so when you build the image (as I did to validate
> the release) it is broken.
> We should fix this by installing Java 'manually' in the docker image. To avoid
> this kind of breakages in the future we should only rely on a pinned OS image
> and install all dev dependencies from there probably install Java.
> There are also some additional warnings that it would be good to fix, e.g. 
> apt-utils and wheel in pip upgrade.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2732) Docker image build is broken on master

2020-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039979#comment-17039979
 ] 

ASF subversion and git services commented on AVRO-2732:
---

Commit 1dbf61ee8cf2866e6e590388198e64c190af1e3f in avro's branch 
refs/heads/master from Ismaël Mejía
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1dbf61e ]

AVRO-2732: Add missing packages to avoid warnings in the docker image


> Docker image build is broken on master
> --
>
> Key: AVRO-2732
> URL: https://issues.apache.org/jira/browse/AVRO-2732
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: docker
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
> Fix For: 1.10.0, 1.9.3
>
>
> It seems we had the bad luck that our Dockerfile building/validation image got
> broken because of a change in its upstream parent image openjdk:11 that was 
> upgraded
> to the latest version of its parent version (debian:stable). Debian stable 
> does
> not include Java 8 anymore, so when you build the image (as I did to validate
> the release) it is broken.
> We should fix this by installing Java 'manually' in the docker image. To avoid
> this kind of breakages in the future we should only rely on a pinned OS image
> and install all dev dependencies from there probably install Java.
> There are also some additional warnings that it would be good to fix, e.g. 
> apt-utils and wheel in pip upgrade.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2742) Schema.Parser.parse() does not validate namespace

2020-02-19 Thread Zoltan Farkas (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039936#comment-17039936
 ] 

Zoltan Farkas commented on AVRO-2742:
-

[~rskraba] before I went the path of disabling name validation, I was thinking 
of implementing something similar to percent encoding (use _ instead of %) to 
basically convert arbitrary strings into ids... 

disabling validation was the path of least resistance...




> Schema.Parser.parse() does not validate namespace
> -
>
> Key: AVRO-2742
> URL: https://issues.apache.org/jira/browse/AVRO-2742
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.2
>Reporter: radai rosenblatt
>Priority: Major
>
> [the spec|https://avro.apache.org/docs/current/spec.html#names] has the 
> following to say about names:
> {quote}The name portion of a fullname, record field names, and enum symbols 
> must: ... A namespace is a dot-separated sequence of such names.
> {quote}
> and yet the following schema parses just fine for me:
> {code:java}
> {
>   "type": "record",
>   "namespace": "this thing. has spaces.in it?!",
>   "name": "HasInvalidNamespace",
>   "fields": [
> {
>   "name": "stringField",
>   "type": "string"
> }
>   ]
> }
> {code}
> am I misunderstanding the spec? also, even if this is technically a legal 
> schema it will never survive code generation of specific record classes (at 
> least in java?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2747) setup_requires breaks install behind proxy

2020-02-19 Thread Bernat Gabor (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039864#comment-17039864
 ] 

Bernat Gabor commented on AVRO-2747:


Any plans for publishing a release?

> setup_requires breaks install behind proxy
> --
>
> Key: AVRO-2747
> URL: https://issues.apache.org/jira/browse/AVRO-2747
> Project: Apache Avro
>  Issue Type: Bug
>  Components: python
>Affects Versions: 1.9.2
>Reporter: Bernat Gabor
>Assignee: Michael A. Smith
>Priority: Major
> Fix For: 1.10.0
>
>
> 1.9.2 adds two setup_requires dependencies; these are served by using the 
> easy_install system that has a different index server configuration than pip; 
> this means that a previously working ``pip -i 
> [http://a.index.server/simple]`` now breaks. Add the pyproject.toml as per 
> PEP-517 and PEP-518 to give a chance to pip to provide these dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2692) Do Not Access Map Twice in LogicalTypes

2020-02-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039852#comment-17039852
 ] 

Hudson commented on AVRO-2692:
--

SUCCESS: Integrated in Jenkins build AvroJava #831 (See 
[https://builds.apache.org/job/AvroJava/831/])
AVRO-2692: Do Not Access Map Twice in LogicalTypes (#772) (github: 
[https://github.com/apache/avro/commit/37be95b0bd64b9ecc118d0ff8b30e734f94e4d3c])
* (edit) lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java


> Do Not Access Map Twice in LogicalTypes
> ---
>
> Key: AVRO-2692
> URL: https://issues.apache.org/jira/browse/AVRO-2692
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Fix For: 1.10.0
>
>
> https://github.com/apache/avro/blob/84b056c2adc069cf31f3b4d3c9337cb7cdaa58d6/lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java#L102-L107
> {code:java|title=LogicalTypes.java}
> final LogicalTypeFactory typeFactory = REGISTERED_TYPES.get(typeName);
> if (typeFactory != null) {
>   logicalType = REGISTERED_TYPES.get(typeName).fromSchema(schema);
> } else {
>   logicalType = null;
> }
> {code}
> The {{typeFactory}} is already obtained from the map on the first line, no 
> need to go back to the map again to {{get}} it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AVRO-2659) Some full names are not correctly validated.

2020-02-19 Thread Ryan Skraba (Jira)


 [ 
https://issues.apache.org/jira/browse/AVRO-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Skraba updated AVRO-2659:
--
Description: 
The Java implementation will parse a schema with an obviously bad name:
{code:json}
{ "type":"record",
  "name":"org.9apache.äv rö..$!#!@%$.Sïmplé۵",
  "fields": [
{"name":"id", "type": "int"}
  ]
}
{code}
For Java:
 * no rules are applied to the namespace part of a full name, and
 * the {{isLetterOrDigit}} methods in Character accept accented or multibyte 
letters and digits
 * _(ambiguous)_ when a full name is specified, the namespace attribute is 
entirely ignored. Should it be an error if it contains a bad namespace?

We should be applying the rules to all of the dot-delimited parts of a full 
name and namespace (unless ignored).  Rules should be applied to named types, 
field names, and aliases consistently.

  was:
The Java implementation will parse a schema with an obviously bad name:

{code:json}
{ "type":"record",
  "name":"org.9apache.äv rö..$!#!@%$.Sïmplé۵",
  "fields": [
{"name":"id", "type": "int"}
  ]
}
{code}

For Java: 
* no rules are applied to the namespace part of a full name, and
* the {{isLetterOrDigit}} methods in Character accept accented or multibyte 
letters and digits
* _(ambiguous)_ when a full name is specified, the namespace attribute is 
entirely ignored.  Should it be an error if it contains a bad namespace?

We should be applying the rules to all of the dot-delimited parts of a full 
name and namespace (unless ignored).


> Some full names are not correctly validated.
> 
>
> Key: AVRO-2659
> URL: https://issues.apache.org/jira/browse/AVRO-2659
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Reporter: Ryan Skraba
>Priority: Minor
>
> The Java implementation will parse a schema with an obviously bad name:
> {code:json}
> { "type":"record",
>   "name":"org.9apache.äv rö..$!#!@%$.Sïmplé۵",
>   "fields": [
> {"name":"id", "type": "int"}
>   ]
> }
> {code}
> For Java:
>  * no rules are applied to the namespace part of a full name, and
>  * the {{isLetterOrDigit}} methods in Character accept accented or multibyte 
> letters and digits
>  * _(ambiguous)_ when a full name is specified, the namespace attribute is 
> entirely ignored. Should it be an error if it contains a bad namespace?
> We should be applying the rules to all of the dot-delimited parts of a full 
> name and namespace (unless ignored).  Rules should be applied to named types, 
> field names, and aliases consistently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2742) Schema.Parser.parse() does not validate namespace

2020-02-19 Thread Ryan Skraba (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039832#comment-17039832
 ] 

Ryan Skraba commented on AVRO-2742:
---

Good point about aliases – I'll add that to the other JIRA!

I'm pretty sure that being able to disable name validation is the "escape 
valve" for cases like this.  If we fix Avro to match the spec, it's going to 
break _someone_ who relied on it being buggy!

BTW, the AvroCalciteRest link looks really cool.  We run into the problem of 
having to store "db column names" with arbitrary rules as Avro fields all the 
time... it might be worthwhile thinking about mangling/demangling arbitrary as 
a feature.

> Schema.Parser.parse() does not validate namespace
> -
>
> Key: AVRO-2742
> URL: https://issues.apache.org/jira/browse/AVRO-2742
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.2
>Reporter: radai rosenblatt
>Priority: Major
>
> [the spec|https://avro.apache.org/docs/current/spec.html#names] has the 
> following to say about names:
> {quote}The name portion of a fullname, record field names, and enum symbols 
> must: ... A namespace is a dot-separated sequence of such names.
> {quote}
> and yet the following schema parses just fine for me:
> {code:java}
> {
>   "type": "record",
>   "namespace": "this thing. has spaces.in it?!",
>   "name": "HasInvalidNamespace",
>   "fields": [
> {
>   "name": "stringField",
>   "type": "string"
> }
>   ]
> }
> {code}
> am I misunderstanding the spec? also, even if this is technically a legal 
> schema it will never survive code generation of specific record classes (at 
> least in java?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2747) setup_requires breaks install behind proxy

2020-02-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039812#comment-17039812
 ] 

Hudson commented on AVRO-2747:
--

SUCCESS: Integrated in Jenkins build AvroJava #830 (See 
[https://builds.apache.org/job/AvroJava/830/])
AVRO-2747: Remove setup_requires (#818) (github: 
[https://github.com/apache/avro/commit/3812985c2d4219815c0521dc193fdf811afba0dc])
* (edit) lang/py/build.sh
* (edit) lang/py/setup.py
* (edit) lang/py/setup.cfg
* (edit) lang/py/tox.ini


> setup_requires breaks install behind proxy
> --
>
> Key: AVRO-2747
> URL: https://issues.apache.org/jira/browse/AVRO-2747
> Project: Apache Avro
>  Issue Type: Bug
>  Components: python
>Affects Versions: 1.9.2
>Reporter: Bernat Gabor
>Assignee: Michael A. Smith
>Priority: Major
> Fix For: 1.10.0
>
>
> 1.9.2 adds two setup_requires dependencies; these are served by using the 
> easy_install system that has a different index server configuration than pip; 
> this means that a previously working ``pip -i 
> [http://a.index.server/simple]`` now breaks. Add the pyproject.toml as per 
> PEP-517 and PEP-518 to give a chance to pip to provide these dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2692) Do Not Access Map Twice in LogicalTypes

2020-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039806#comment-17039806
 ] 

ASF subversion and git services commented on AVRO-2692:
---

Commit 37be95b0bd64b9ecc118d0ff8b30e734f94e4d3c in avro's branch 
refs/heads/master from belugabehr
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=37be95b ]

AVRO-2692: Do Not Access Map Twice in LogicalTypes (#772)

* AVRO-2692: Do Not Access Map Twice in LogicalTypes

* Apply spotless


> Do Not Access Map Twice in LogicalTypes
> ---
>
> Key: AVRO-2692
> URL: https://issues.apache.org/jira/browse/AVRO-2692
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Fix For: 1.10.0
>
>
> https://github.com/apache/avro/blob/84b056c2adc069cf31f3b4d3c9337cb7cdaa58d6/lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java#L102-L107
> {code:java|title=LogicalTypes.java}
> final LogicalTypeFactory typeFactory = REGISTERED_TYPES.get(typeName);
> if (typeFactory != null) {
>   logicalType = REGISTERED_TYPES.get(typeName).fromSchema(schema);
> } else {
>   logicalType = null;
> }
> {code}
> The {{typeFactory}} is already obtained from the map on the first line, no 
> need to go back to the map again to {{get}} it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (AVRO-2692) Do Not Access Map Twice in LogicalTypes

2020-02-19 Thread Fokko Driesprong (Jira)


 [ 
https://issues.apache.org/jira/browse/AVRO-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong resolved AVRO-2692.

Fix Version/s: 1.10.0
   Resolution: Fixed

> Do Not Access Map Twice in LogicalTypes
> ---
>
> Key: AVRO-2692
> URL: https://issues.apache.org/jira/browse/AVRO-2692
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Fix For: 1.10.0
>
>
> https://github.com/apache/avro/blob/84b056c2adc069cf31f3b4d3c9337cb7cdaa58d6/lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java#L102-L107
> {code:java|title=LogicalTypes.java}
> final LogicalTypeFactory typeFactory = REGISTERED_TYPES.get(typeName);
> if (typeFactory != null) {
>   logicalType = REGISTERED_TYPES.get(typeName).fromSchema(schema);
> } else {
>   logicalType = null;
> }
> {code}
> The {{typeFactory}} is already obtained from the map on the first line, no 
> need to go back to the map again to {{get}} it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2692) Do Not Access Map Twice in LogicalTypes

2020-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039804#comment-17039804
 ] 

ASF subversion and git services commented on AVRO-2692:
---

Commit 37be95b0bd64b9ecc118d0ff8b30e734f94e4d3c in avro's branch 
refs/heads/master from belugabehr
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=37be95b ]

AVRO-2692: Do Not Access Map Twice in LogicalTypes (#772)

* AVRO-2692: Do Not Access Map Twice in LogicalTypes

* Apply spotless


> Do Not Access Map Twice in LogicalTypes
> ---
>
> Key: AVRO-2692
> URL: https://issues.apache.org/jira/browse/AVRO-2692
> Project: Apache Avro
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Fix For: 1.10.0
>
>
> https://github.com/apache/avro/blob/84b056c2adc069cf31f3b4d3c9337cb7cdaa58d6/lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java#L102-L107
> {code:java|title=LogicalTypes.java}
> final LogicalTypeFactory typeFactory = REGISTERED_TYPES.get(typeName);
> if (typeFactory != null) {
>   logicalType = REGISTERED_TYPES.get(typeName).fromSchema(schema);
> } else {
>   logicalType = null;
> }
> {code}
> The {{typeFactory}} is already obtained from the map on the first line, no 
> need to go back to the map again to {{get}} it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (AVRO-2747) setup_requires breaks install behind proxy

2020-02-19 Thread Fokko Driesprong (Jira)


 [ 
https://issues.apache.org/jira/browse/AVRO-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong resolved AVRO-2747.

Fix Version/s: 1.10.0
   Resolution: Fixed

> setup_requires breaks install behind proxy
> --
>
> Key: AVRO-2747
> URL: https://issues.apache.org/jira/browse/AVRO-2747
> Project: Apache Avro
>  Issue Type: Bug
>  Components: python
>Affects Versions: 1.9.2
>Reporter: Bernat Gabor
>Assignee: Michael A. Smith
>Priority: Major
> Fix For: 1.10.0
>
>
> 1.9.2 adds two setup_requires dependencies; these are served by using the 
> easy_install system that has a different index server configuration than pip; 
> this means that a previously working ``pip -i 
> [http://a.index.server/simple]`` now breaks. Add the pyproject.toml as per 
> PEP-517 and PEP-518 to give a chance to pip to provide these dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (AVRO-2747) setup_requires breaks install behind proxy

2020-02-19 Thread Fokko Driesprong (Jira)


 [ 
https://issues.apache.org/jira/browse/AVRO-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong reassigned AVRO-2747:
--

Assignee: Michael A. Smith

> setup_requires breaks install behind proxy
> --
>
> Key: AVRO-2747
> URL: https://issues.apache.org/jira/browse/AVRO-2747
> Project: Apache Avro
>  Issue Type: Bug
>  Components: python
>Affects Versions: 1.9.2
>Reporter: Bernat Gabor
>Assignee: Michael A. Smith
>Priority: Major
>
> 1.9.2 adds two setup_requires dependencies; these are served by using the 
> easy_install system that has a different index server configuration than pip; 
> this means that a previously working ``pip -i 
> [http://a.index.server/simple]`` now breaks. Add the pyproject.toml as per 
> PEP-517 and PEP-518 to give a chance to pip to provide these dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AVRO-2747) setup_requires breaks install behind proxy

2020-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039791#comment-17039791
 ] 

ASF subversion and git services commented on AVRO-2747:
---

Commit 3812985c2d4219815c0521dc193fdf811afba0dc in avro's branch 
refs/heads/master from Michael A. Smith
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=3812985 ]

AVRO-2747: Remove setup_requires (#818)



> setup_requires breaks install behind proxy
> --
>
> Key: AVRO-2747
> URL: https://issues.apache.org/jira/browse/AVRO-2747
> Project: Apache Avro
>  Issue Type: Bug
>  Components: python
>Affects Versions: 1.9.2
>Reporter: Bernat Gabor
>Priority: Major
>
> 1.9.2 adds two setup_requires dependencies; these are served by using the 
> easy_install system that has a different index server configuration than pip; 
> this means that a previously working ``pip -i 
> [http://a.index.server/simple]`` now breaks. Add the pyproject.toml as per 
> PEP-517 and PEP-518 to give a chance to pip to provide these dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)