Re: [VOTE] Release Apache Avro 1.10.0 RC1
Hi Team, Is someone aware of the build issue ? Looks like all the build failures for the last couple of days. + dotnet build --configuration Release Avro.sln > 90 Restore completed in 2.89 sec for > C:\Users\travis\build\apache\avro\lang\csharp\src\apache\codegen\Avro.codegen.csproj. > 91 Restore completed in 2.95 sec for > C:\Users\travis\build\apache\avro\lang\csharp\src\apache\main\Avro.main.csproj. > 92 Restore completed in 973.79 ms for > C:\Users\travis\build\apache\avro\lang\csharp\src\apache\msbuild\Avro.msbuild.csproj. > 93C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj > : error NU1603: Apache.Avro depends on Newtonsoft.Json (>= 10.0.3) but > Newtonsoft.Json 10.0.3 was not found. An approximate best match of > Newtonsoft.Json 11.0.2 was resolved. > [C:\Users\travis\build\apache\avro\lang\csharp\Avro.sln] > 94C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj > : error NU1101: Unable to find package nunit. No packages exist with this id > in source(s): Microsoft Visual Studio Offline Packages > [C:\Users\travis\build\apache\avro\lang\csharp\Avro.sln] > 95C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj > : error NU1101: Unable to find package nunit3testadapter. No packages exist > with this id in source(s): Microsoft Visual Studio Offline Packages > [C:\Users\travis\build\apache\avro\lang\csharp\Avro.sln] > 96C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj > : error NU1101: Unable to find package NUnit.ConsoleRunner. No packages > exist with this id in source(s): Microsoft Visual Studio Offline Packages > [C:\Users\travis\build\apache\avro\lang\csharp\Avro.sln] > 97C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj > : error NU1101: Unable to find package Microsoft.NET.Test.Sdk. No packages > exist with this id in source(s): Microsoft Visual Studio Offline Packages > [C:\Users\travis\build\apache\avro\lang\csharp\Avro.sln] > 98C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj > : error NU1101: Unable to find package System.CodeDom. No packages exist > with this id in source(s): Microsoft Visual Studio Offline Packages > [C:\Users\travis\build\apache\avro\lang\csharp\Avro.sln] > 99 Restore failed in 75.03 ms for > C:\Users\travis\build\apache\avro\lang\csharp\src\apache\test\Avro.test.csproj. > 100 Restore completed in 1.16 sec for > C:\Users\travis\build\apache\avro\lang\csharp\src\apache\perf\Avro.perf.csproj. > 101 > 102Build FAILED. > > Thanks and Regards *Rumeshkrishnan Mohan* On Sun, Jun 14, 2020 at 8:53 AM Driesprong, Fokko wrote: > Thanks Ismaël for running the release. I've just tested an all looks good. > > +1 (binding) > > Cheers, Fokko > > Op za 13 jun. 2020 om 13:23 schreef Ryan Skraba : > > > The only change necessary to compile Parquet with the 1.10.0 RC1 > > artifacts was to add `public` to > > the parquet-avro pom.xml so that field members are generated with > > public access (the default is now private). Or we could rewrite the > > test classes to use getters! > > > > (Just for info, if you want to reproduce my build, I also changed the > > repositories and pluginRepositories to temporarily include the > > https://repository.apache.org/content/groups/staging for these release > > candidates. Something in my settings makes protoc-jar-maven-plugin > > unhappy with this setup, and the workaround is to build to a brand new > > local m2: `-Dmaven.repo.local=/tmp/m2` ) > > > > I'm interested in your Parquet/Avro/Spark experience! I've gotten > > them to work together using Apache Beam on Spark and extensive shading > > :/ Ismael has done some excellent (and tricky!) work trying to get > > the communities to move forward together! > > > > All my best, Ryan > > > > On Fri, Jun 12, 2020 at 7:23 PM Michael Heuer wrote: > > > > > > Hello Ryan, > > > > > > If you don't mind me asking, what were the changes you found necessary > > for Parquet to work with Avro 1.10? > > > > > > The only reason I lurk on this mailing list is in the vain hope that > > Parquet and Avro and Spark will work together nicely at some point. > > > > > >michael > > > > > > > > > > On Jun 12, 2020, at 3:44 AM, Ryan Skraba wrote: > > > > > > > > Hello! > > > > > > > > I checked the signature and SHA512 sums of the artifacts. > > > > > > > > Internally we have a large library of internal code that uses Avro > > > > 1.9, and it all recompiled and tests succeeded without modification. > > > > > > > > We have some other code that definitely breaks with 1.10 because of > > > > AVRO-2278 (getting an unknown field throws an exception). In > > > > practice, it's not going to impact us in the short term, since it's > > > > all run on a cluster where the avro version is provided (and usually > > > > 1.8.x). Our code will need to be rewritten to handle these > exceptions > > > > gracefully for Avro 1.10+ > >
Re: [VOTE] Release Apache Avro 1.10.0 RC1
Thanks Ismaël for running the release. I've just tested an all looks good. +1 (binding) Cheers, Fokko Op za 13 jun. 2020 om 13:23 schreef Ryan Skraba : > The only change necessary to compile Parquet with the 1.10.0 RC1 > artifacts was to add `public` to > the parquet-avro pom.xml so that field members are generated with > public access (the default is now private). Or we could rewrite the > test classes to use getters! > > (Just for info, if you want to reproduce my build, I also changed the > repositories and pluginRepositories to temporarily include the > https://repository.apache.org/content/groups/staging for these release > candidates. Something in my settings makes protoc-jar-maven-plugin > unhappy with this setup, and the workaround is to build to a brand new > local m2: `-Dmaven.repo.local=/tmp/m2` ) > > I'm interested in your Parquet/Avro/Spark experience! I've gotten > them to work together using Apache Beam on Spark and extensive shading > :/ Ismael has done some excellent (and tricky!) work trying to get > the communities to move forward together! > > All my best, Ryan > > On Fri, Jun 12, 2020 at 7:23 PM Michael Heuer wrote: > > > > Hello Ryan, > > > > If you don't mind me asking, what were the changes you found necessary > for Parquet to work with Avro 1.10? > > > > The only reason I lurk on this mailing list is in the vain hope that > Parquet and Avro and Spark will work together nicely at some point. > > > >michael > > > > > > > On Jun 12, 2020, at 3:44 AM, Ryan Skraba wrote: > > > > > > Hello! > > > > > > I checked the signature and SHA512 sums of the artifacts. > > > > > > Internally we have a large library of internal code that uses Avro > > > 1.9, and it all recompiled and tests succeeded without modification. > > > > > > We have some other code that definitely breaks with 1.10 because of > > > AVRO-2278 (getting an unknown field throws an exception). In > > > practice, it's not going to impact us in the short term, since it's > > > all run on a cluster where the avro version is provided (and usually > > > 1.8.x). Our code will need to be rewritten to handle these exceptions > > > gracefully for Avro 1.10+ > > > > > > Parquet needed some minor massaging because of the change to the > > > avro-maven-plugin (now generates private field members). This should > > > definitely be in the release notes: > > > > > > AVRO-2581: Maven plugin generates specific records with private fields. > > > > > > The arrow Avro adapter builds and tests with the 1.10.0 RC artifacts. > > > > > > I did some minor tests with a toy python project (both py and py3). > > > > > > +1 for me (mostly Java, some python). > > > > > > If there is a blocker or another release candidate, AVRO-2849 (spec > > > clarification) would be nice to include. > > > > > > All my best and thanks for the work, Ismael! > > > > > > Ryan > > > > > > > > > On Thu, Jun 11, 2020 at 2:25 PM Daniel Kulp wrote: > > >> > > >> +1 > > >> > > >> Been playing around with it a bit and it looks OK. > > >> > > >> Dan > > >> > > >> > > >>> On Jun 11, 2020, at 4:53 AM, Ismaël Mejía wrote: > > >>> > > >>> Kind reminder two days have passed, please check and vote! > > >>> > > >>> On Thu, Jun 11, 2020 at 2:29 AM Andy Le wrote: > > > > Hey Ryan, > > > > Thank you for your clear explanation. > > > > +1 for me :D > > > > Thank you. > > > > > > On 2020/06/10 14:39:10, Ryan Skraba wrote: > > > Hey Anh, a release requires 3 PMC votes, but "unofficial" opinions > are > > > welcome and taken into account. My opinion is unofficial too! > > > > > > Just reply with a +1 if you think the artifacts are good to go or > -1 > > > if you've found a bug, regression, security issue, or something > that > > > should block these artifacts from being the 1.10.0 release. > > > > > > For example, at my company, we have a lot of internal code and > > > libraries that work with Avro 1.9.2, especially the generic Java > APIs, > > > so I'm going to compile with 1.10.0 and see if all the unit tests > > > pass. > > > > > > If you're familiar with building any open source projects that use > > > Avro, try bumping there and reporting back. You can go through the > > > open JIRA and open PR and make recommendations if we missed > something > > > important. > > > > > > For example, I've gone through a lot of the JIRA and it looks like > > > AVRO-2799 (a protobuf bug) is blocking a user. I'm looking to see > if > > > this is a regression or if it's an easy fix before I vote. > > > > > > I've verified the signatures and SHA512 of the artifacts, so > that's good! > > > > > > All my best, Ryan > > > > > > > > > > > > > > > > > > > > > On Wed, Jun 10, 2020 at 8:53 AM Anh Le wrote: > > >> > > >> Hi, > > >> > > >> How can I make a vote on this? > > >> > > >> Best Regards. >
