[jira] [Resolved] (AVRO-2919) Make avro.test.test_datafile parallelizable and less leaky
[ https://issues.apache.org/jira/browse/AVRO-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael A. Smith resolved AVRO-2919. Resolution: Fixed > Make avro.test.test_datafile parallelizable and less leaky > -- > > Key: AVRO-2919 > URL: https://issues.apache.org/jira/browse/AVRO-2919 > Project: Apache Avro > Issue Type: Task > Components: python >Reporter: Michael A. Smith >Assignee: Michael A. Smith >Priority: Major > > avro.test.test_datafile in the python implementation uses a hardcoded > filename for a temporary file used repeatedly in every datafile test case. So > running these tests in parallel yields random failures and inconsistent > results. > Also, the file handle is not closed in every test case, leading to resource > leaks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2399) Release wheels
[ https://issues.apache.org/jira/browse/AVRO-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael A. Smith resolved AVRO-2399. Release Note: lang/py is now set up to build whl files and put those in dist. It will also continue to build tar.gz, but those should be considered secondary, and only used for special cases. (Note that wheel files can be unpacked with unzip, with no special tooling needed.) Resolution: Done > Release wheels > -- > > Key: AVRO-2399 > URL: https://issues.apache.org/jira/browse/AVRO-2399 > Project: Apache Avro > Issue Type: Improvement > Components: python >Reporter: Bernat Gabor >Assignee: Michael A. Smith >Priority: Major > > We should also release wheels via the manywheel. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2917) Update python avro.test.av_bench
[ https://issues.apache.org/jira/browse/AVRO-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael A. Smith resolved AVRO-2917. Resolution: Fixed > Update python avro.test.av_bench > > > Key: AVRO-2917 > URL: https://issues.apache.org/jira/browse/AVRO-2917 > Project: Apache Avro > Issue Type: Task > Components: python >Reporter: Michael A. Smith >Priority: Major > > avro.test.av_bench is outdated and runs in python 2 only. It is also a manual > implementation of a timing-based benchmark and may benefit from being > reimplemented in Python's built-in timeit module, which has several features > to make benchmarks more consistent and reliable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [avro] vlk32 opened a new pull request #950: AVRO-2924: LocalDateTime for logical type local-timestamp-millis
vlk32 opened a new pull request #950: URL: https://github.com/apache/avro/pull/950 Implementation of AVRO-2924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (AVRO-2924) SpecificCompiler add 'LocalDateTime' logical type
Vladimir Kralik created AVRO-2924:
-
Summary: SpecificCompiler add 'LocalDateTime' logical type
Key: AVRO-2924
URL: https://issues.apache.org/jira/browse/AVRO-2924
Project: Apache Avro
Issue Type: Bug
Components: java, logical types
Affects Versions: 1.10.0
Environment: Avro 1.10.0
Reporter: Vladimir Kralik
Fix For: 1.10.1
*As* a programmer
*I want* to generate java type {{java.time.LocalDateTime}} for logical type
{{local-timestamp-millis}} (or {{local_timestamp_ms}} in IDL)
*because* this should be the correct java type ( instead of long which is used
in version 1.10.0 ).
_Remark: for logical type {{timestamp-millis}} ( or {{timestamp_ms}} in IDL )
this compiler generates Java type {{java.time.Instant}}_
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] blackeyepanda closed pull request #949: AVRO-2923: GenericDatum::logicalType() api should return correct type with union
blackeyepanda closed pull request #949: URL: https://github.com/apache/avro/pull/949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Type Hints for Python!
Cool stuff Michael, I'll pick up some files and start adding type-hints :) Cheers, Fokko Op ma 17 aug. 2020 om 14:40 schreef Michael A. Smith : > We've had mypy, the Python type checker, running in Travis-CI on > lang/py for a little while. However, mypy doesn't actually check code > unless it has type hints, so it has been doing very little. Now that > we are only supporting Python 3.5 and up, we can add real type hints! > > I'm excited about this, because I think it will really improve the > Python implementation. There are a fair amount of Liskov violations > and other places where type theory rules have been bent or broken in > the Python implementation, so there will be places where we need to > decide if we want to make an API breaking change, or ignore an > inconsistency. > > If you want to see what mypy is able to check right now, you can > install mypy and lxml and run mypy --html-report mypy-html and open > mypy-html/index.html in your browser. > > If you can find the time to open a PR against AVRO-2921 and introduce > type hints in a single module or test, please give it a shot. If the > type checker finds a bug as a result, please report the bug. > > Happy Hinting! >
Re: [VOTE] Drop Python 2 support
Thanks Michael, Also, Spark is dropping support of 3.5 and below :) Cheers, Fokko Op vr 14 aug. 2020 om 17:04 schreef Michael A. Smith : > Based on these votes and plenty of time passing I will feel > comfortable making changes that are only compatible with python 3.5 > and up. > > Thank you all for your responses! > > On Tue, Jul 28, 2020 at 11:49 PM Micah Kornfield > wrote: > > > > +1 (non-binding) > > > > On Tue, Jul 28, 2020 at 9:30 AM Cris Ewing > > wrote: > > > > > +1 > > > > > > (to be clear, I'm not certain my vote counts for anything other than > > > advisory) > > > > > > yours > > > > > > c > > > > > > On Tue, Jul 28, 2020 at 6:15 AM Michael A. Smith > > > > wrote: > > > > > > > Python 2 has been officially obsolete since January 1. I propose we > drop > > > > support for it. > > > > > > > > If we decide to continue supporting it, note that pip, the (main) > Python > > > > package management tool, will itself only support python3 in its next > > > > release. So installing avro with python 2 will have to be done more > > > > manually after that point. > > > > > > > > Here are the Apache Voting Rules: > > > > http://www.apache.org/foundation/voting.html > > > > > > > > This vote will remain open for at least 72 hours, more probably until > > > next > > > > week. > > > > > > > > [ ] +1 Drop support for Python 2 > > > > [ ] +0 > > > > [ ] -1 Continue supporting Python 2 because/until… > > > > > > > >
[jira] [Commented] (AVRO-2896) avro-python3 setup_requires breaks installing beind proxy
[ https://issues.apache.org/jira/browse/AVRO-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181056#comment-17181056 ] Fokko Driesprong commented on AVRO-2896: Can you share some logs? Of how to reproduce this? > avro-python3 setup_requires breaks installing beind proxy > - > > Key: AVRO-2896 > URL: https://issues.apache.org/jira/browse/AVRO-2896 > Project: Apache Avro > Issue Type: Bug >Reporter: Bernat Gabor >Priority: Major > > Exact same as we did for avro (python 2), see > https://issues.apache.org/jira/browse/AVRO-2747, but also for Python 3, > please. Regression introduced with > [https://github.com/apache/avro/commit/097ff2d69b52cddb249ea27c89bea7059f6a79df] -- This message was sent by Atlassian Jira (v8.3.4#803005)
