Re: [VOTE] Accept donation of Avro Rust implementation
+1 (non-binding) Does someone know how much effort it would be to add consistent build.sh features to the rust implementation to ensure that the fundamental dev process is the same across langs? Less important, but nice to have: interop tests. On Mon, May 24, 2021 at 12:34 Micah Kornfield wrote: > +1 (non-binding) on accepting the donation. > > On a technical/process level. I think Rust community in general has some > different expectations with respect to tooling/developer workflow that > differs from a lot of apache projects. [1] highlights some process changes > that we recently went through with the Rust Arrow. It would be good to > take these into account when doing the actual code import. > > Was this discussed on the dev@ mailing list (apologies if I missed it)? > Discussing process/release requirements up front might save some angst down > the road. > > -Micah > > [1] > > https://docs.google.com/document/d/1TyrUP8_UWXqk97a8Hvb1d0UYWigch0HAephIjW7soSI/edit > > On Mon, May 24, 2021 at 7:33 AM Driesprong, Fokko > wrote: > > > Cool stuff! Checked the repo, and it looks very good! > > > > +1 (binding) from my side! > > > > Cheers, Fokko > > > > Op ma 24 mei 2021 om 11:34 schreef Ismaël Mejía : > > > > > Dear all, > > > > > > The developers of > > > https://github.com/flavray/avro-rs/ > > > > > > have been in touch with some members of the Apache Avro Project > > Management > > > Committee (PMC). Based on these discussions, it is being proposed to > > donate > > > this > > > Avro Rust implementation into the Apache Avro project to continue > > > developing it > > > together with the Apache Avro community following the Apache Software > > > Foundation > > > (ASF) guidelines. > > > > > > This vote is to determine if the Avro PMC is in favor of accepting this > > > donation. If the vote passes, the PMC and the authors of the code will > > work > > > together to complete the ASF IP Clearance process > > > (http://incubator.apache.org/ip-clearance/) and import the Rust > > > implementation > > > into the Avro codebase. > > > > > > +1 : Accept contribution of Rust implementation > > > 0 : No opinion > > > -1 : Reject contribution because... > > > > > > Here is my vote: +1 > > > > > > The vote will be open for at least 72 hours. > > > > > > Thanks, > > > Ismaël > > > > > >
Re: [VOTE] Accept donation of Avro Rust implementation
+1 I think we should work with them to find a release model that works, too. I would highly recommend keeping the releases decoupled so languages can move at their own pace. On Mon, May 24, 2021 at 9:34 AM Micah Kornfield wrote: > +1 (non-binding) on accepting the donation. > > On a technical/process level. I think Rust community in general has some > different expectations with respect to tooling/developer workflow that > differs from a lot of apache projects. [1] highlights some process changes > that we recently went through with the Rust Arrow. It would be good to > take these into account when doing the actual code import. > > Was this discussed on the dev@ mailing list (apologies if I missed it)? > Discussing process/release requirements up front might save some angst down > the road. > > -Micah > > [1] > > https://docs.google.com/document/d/1TyrUP8_UWXqk97a8Hvb1d0UYWigch0HAephIjW7soSI/edit > > On Mon, May 24, 2021 at 7:33 AM Driesprong, Fokko > wrote: > > > Cool stuff! Checked the repo, and it looks very good! > > > > +1 (binding) from my side! > > > > Cheers, Fokko > > > > Op ma 24 mei 2021 om 11:34 schreef Ismaël Mejía : > > > > > Dear all, > > > > > > The developers of > > > https://github.com/flavray/avro-rs/ > > > > > > have been in touch with some members of the Apache Avro Project > > Management > > > Committee (PMC). Based on these discussions, it is being proposed to > > donate > > > this > > > Avro Rust implementation into the Apache Avro project to continue > > > developing it > > > together with the Apache Avro community following the Apache Software > > > Foundation > > > (ASF) guidelines. > > > > > > This vote is to determine if the Avro PMC is in favor of accepting this > > > donation. If the vote passes, the PMC and the authors of the code will > > work > > > together to complete the ASF IP Clearance process > > > (http://incubator.apache.org/ip-clearance/) and import the Rust > > > implementation > > > into the Avro codebase. > > > > > > +1 : Accept contribution of Rust implementation > > > 0 : No opinion > > > -1 : Reject contribution because... > > > > > > Here is my vote: +1 > > > > > > The vote will be open for at least 72 hours. > > > > > > Thanks, > > > Ismaël > > > > > > -- Ryan Blue
[jira] [Commented] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint
[
https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350568#comment-17350568
]
Ryan commented on AVRO-3150:
https://github.com/apache/avro/pull/1236
> Checkstyle requires LF line endings: add .gitattributes hint
>
>
> Key: AVRO-3150
> URL: https://issues.apache.org/jira/browse/AVRO-3150
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.10.2
>Reporter: Ryan
>Priority: Major
>
> Running the Java unit tests on a Windows machine with the commonly configured
> git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
> CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule. If the unit tests require LF line endings
> then it would be helpful to add a .gitattributes file to automatically ensure
> the correct line endings are used on git clone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] slominskir opened a new pull request #1236: AVRO-3150: .gitattributes indicate LF line endings
slominskir opened a new pull request #1236:
URL: https://github.com/apache/avro/pull/1236
Java Unit Tests require LF line endings, even on Windows else fail with
NewlineAtEndOfFile checkstyle error
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3150
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
To test just clone project on a Windows machine where git has global
autocrlf configured.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (AVRO-3150) Checkstyle requires LF line endings: add .gitattributes hint
Ryan created AVRO-3150:
--
Summary: Checkstyle requires LF line endings: add .gitattributes
hint
Key: AVRO-3150
URL: https://issues.apache.org/jira/browse/AVRO-3150
Project: Apache Avro
Issue Type: Improvement
Components: java
Affects Versions: 1.10.2
Reporter: Ryan
Running the Java unit tests on a Windows machine with the commonly configured
git line ending configuration:
{quote}{{git config --global core.autocrlf true}}
{quote}
Results in test failure of:
{quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
CRLF(\r\n) is detected.}}
{quote}
This is due to a checkstyle rule. If the unit tests require LF line endings
then it would be helpful to add a .gitattributes file to automatically ensure
the correct line endings are used on git clone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] slominskir opened a new pull request #1235: Conditional Java String type schema modification
slominskir opened a new pull request #1235:
URL: https://github.com/apache/avro/pull/1235
Add option to skip the schema mangling step in the Java AVRO compiler that
breaks compatibility between Java and Python (and other languages).
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following issues:
- https://issues.apache.org/jira/browse/AVRO-2838
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [avro] iemejia opened a new pull request #1234: [WIP] AVRO-3149: Add Rust based Implementation of Avro
iemejia opened a new pull request #1234:
URL: https://github.com/apache/avro/pull/1234
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (AVRO-3149) Add Rust based Implementation of Avro
[ https://issues.apache.org/jira/browse/AVRO-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía updated AVRO-3149: --- Summary: Add Rust based Implementation of Avro (was: Add Avro rust based Implementation) > Add Rust based Implementation of Avro > - > > Key: AVRO-3149 > URL: https://issues.apache.org/jira/browse/AVRO-3149 > Project: Apache Avro > Issue Type: New Feature > Components: rust >Reporter: Ismaël Mejía >Priority: Minor > Fix For: 1.11.0 > > > Integrate [avro-rs|https://github.com/flavray/avro-rs/] into Apache Avro as > its default Rust based implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AVRO-3149) Add Avro rust based Implementation
[ https://issues.apache.org/jira/browse/AVRO-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía updated AVRO-3149: --- Fix Version/s: 1.11.0 > Add Avro rust based Implementation > -- > > Key: AVRO-3149 > URL: https://issues.apache.org/jira/browse/AVRO-3149 > Project: Apache Avro > Issue Type: New Feature > Components: rust >Reporter: Ismaël Mejía >Priority: Minor > Fix For: 1.11.0 > > > Integrate [avro-rs|https://github.com/flavray/avro-rs/] into Apache Avro as > its default Rust based implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AVRO-3149) Add Avro rust based Implementation
[ https://issues.apache.org/jira/browse/AVRO-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía updated AVRO-3149: --- Component/s: rust > Add Avro rust based Implementation > -- > > Key: AVRO-3149 > URL: https://issues.apache.org/jira/browse/AVRO-3149 > Project: Apache Avro > Issue Type: New Feature > Components: rust >Reporter: Ismaël Mejía >Priority: Minor > > Integrate [avro-rs|https://github.com/flavray/avro-rs/] into Apache Avro as > its default Rust based implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AVRO-3149) Add Avro rust based Implementation
Ismaël Mejía created AVRO-3149: -- Summary: Add Avro rust based Implementation Key: AVRO-3149 URL: https://issues.apache.org/jira/browse/AVRO-3149 Project: Apache Avro Issue Type: New Feature Reporter: Ismaël Mejía Integrate [avro-rs|https://github.com/flavray/avro-rs/] into Apache Avro as its default Rust based implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Accept donation of Avro Rust implementation
+1 (non-binding) on accepting the donation. On a technical/process level. I think Rust community in general has some different expectations with respect to tooling/developer workflow that differs from a lot of apache projects. [1] highlights some process changes that we recently went through with the Rust Arrow. It would be good to take these into account when doing the actual code import. Was this discussed on the dev@ mailing list (apologies if I missed it)? Discussing process/release requirements up front might save some angst down the road. -Micah [1] https://docs.google.com/document/d/1TyrUP8_UWXqk97a8Hvb1d0UYWigch0HAephIjW7soSI/edit On Mon, May 24, 2021 at 7:33 AM Driesprong, Fokko wrote: > Cool stuff! Checked the repo, and it looks very good! > > +1 (binding) from my side! > > Cheers, Fokko > > Op ma 24 mei 2021 om 11:34 schreef Ismaël Mejía : > > > Dear all, > > > > The developers of > > https://github.com/flavray/avro-rs/ > > > > have been in touch with some members of the Apache Avro Project > Management > > Committee (PMC). Based on these discussions, it is being proposed to > donate > > this > > Avro Rust implementation into the Apache Avro project to continue > > developing it > > together with the Apache Avro community following the Apache Software > > Foundation > > (ASF) guidelines. > > > > This vote is to determine if the Avro PMC is in favor of accepting this > > donation. If the vote passes, the PMC and the authors of the code will > work > > together to complete the ASF IP Clearance process > > (http://incubator.apache.org/ip-clearance/) and import the Rust > > implementation > > into the Avro codebase. > > > > +1 : Accept contribution of Rust implementation > > 0 : No opinion > > -1 : Reject contribution because... > > > > Here is my vote: +1 > > > > The vote will be open for at least 72 hours. > > > > Thanks, > > Ismaël > > >
Re: [VOTE] Accept donation of Avro Rust implementation
Cool stuff! Checked the repo, and it looks very good! +1 (binding) from my side! Cheers, Fokko Op ma 24 mei 2021 om 11:34 schreef Ismaël Mejía : > Dear all, > > The developers of > https://github.com/flavray/avro-rs/ > > have been in touch with some members of the Apache Avro Project Management > Committee (PMC). Based on these discussions, it is being proposed to donate > this > Avro Rust implementation into the Apache Avro project to continue > developing it > together with the Apache Avro community following the Apache Software > Foundation > (ASF) guidelines. > > This vote is to determine if the Avro PMC is in favor of accepting this > donation. If the vote passes, the PMC and the authors of the code will work > together to complete the ASF IP Clearance process > (http://incubator.apache.org/ip-clearance/) and import the Rust > implementation > into the Avro codebase. > > +1 : Accept contribution of Rust implementation > 0 : No opinion > -1 : Reject contribution because... > > Here is my vote: +1 > > The vote will be open for at least 72 hours. > > Thanks, > Ismaël >
[VOTE] Accept donation of Avro Rust implementation
Dear all, The developers of https://github.com/flavray/avro-rs/ have been in touch with some members of the Apache Avro Project Management Committee (PMC). Based on these discussions, it is being proposed to donate this Avro Rust implementation into the Apache Avro project to continue developing it together with the Apache Avro community following the Apache Software Foundation (ASF) guidelines. This vote is to determine if the Avro PMC is in favor of accepting this donation. If the vote passes, the PMC and the authors of the code will work together to complete the ASF IP Clearance process (http://incubator.apache.org/ip-clearance/) and import the Rust implementation into the Avro codebase. +1 : Accept contribution of Rust implementation 0 : No opinion -1 : Reject contribution because... Here is my vote: +1 The vote will be open for at least 72 hours. Thanks, Ismaël
