[jira] [Commented] (AVRO-3185) Cut a release for Ruby gem
[ https://issues.apache.org/jira/browse/AVRO-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401677#comment-17401677 ] Daniel Orner commented on AVRO-3185: Great, thanks! To be honest I'd be happy with a 1.10.3 release just for Ruby if we can get that done faster :) I know the mills of Avro grind slow (although it does look better than it did a couple of years ago). > Cut a release for Ruby gem > -- > > Key: AVRO-3185 > URL: https://issues.apache.org/jira/browse/AVRO-3185 > Project: Apache Avro > Issue Type: Task > Components: ruby >Reporter: Daniel Orner >Priority: Major > Fix For: 1.11.0 > > > There are a number of fixes (most critically, adding support for decimal > types) which have been merged in the last few months. The last release for > the Avro Ruby gem was in March. Can we please cut a new release? We'd love to > use this feature in our production app. > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AVRO-3185) Cut a release for Ruby gem
Daniel Orner created AVRO-3185: -- Summary: Cut a release for Ruby gem Key: AVRO-3185 URL: https://issues.apache.org/jira/browse/AVRO-3185 Project: Apache Avro Issue Type: Task Components: ruby Reporter: Daniel Orner There are a number of fixes (most critically, adding support for decimal types) which have been merged in the last few months. The last release for the Avro Ruby gem was in March. Can we please cut a new release? We'd love to use this feature in our production app. Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2821) Add default values to enums
[ https://issues.apache.org/jira/browse/AVRO-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094862#comment-17094862 ] Daniel Orner commented on AVRO-2821: Please! You can close this as a duplicate! :D > Add default values to enums > --- > > Key: AVRO-2821 > URL: https://issues.apache.org/jira/browse/AVRO-2821 > Project: Apache Avro > Issue Type: Improvement > Components: ruby >Affects Versions: 1.9.2 >Reporter: Daniel Orner >Assignee: Daniel Orner >Priority: Major > > Avro specification 1.9.2 includes the ability to specify default values for > enums: > [https://avro.apache.org/docs/1.9.2/spec.html#Enums] > This is currently missing from the Ruby specification and any enums that > don't match exactly will throw validation errors. > Will start working on a PR for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AVRO-2821) Add default values to enums
Daniel Orner created AVRO-2821: -- Summary: Add default values to enums Key: AVRO-2821 URL: https://issues.apache.org/jira/browse/AVRO-2821 Project: Apache Avro Issue Type: Improvement Components: ruby Affects Versions: 1.9.2 Reporter: Daniel Orner Assignee: Daniel Orner Avro specification 1.9.2 includes the ability to specify default values for enums: [https://avro.apache.org/docs/1.9.2/spec.html#Enums] This is currently missing from the Ruby specification and any enums that don't match exactly will throw validation errors. Will start working on a PR for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AVRO-2645) Ruby Avro does not validate record names
Daniel Orner created AVRO-2645:
--
Summary: Ruby Avro does not validate record names
Key: AVRO-2645
URL: https://issues.apache.org/jira/browse/AVRO-2645
Project: Apache Avro
Issue Type: Bug
Components: ruby
Affects Versions: 1.9.1
Reporter: Daniel Orner
Currently, the following Avro schema is considered valid and throws no errors:
{code:java}
{
"type": "record",
"name": "my-schema",
"fields": [
{
"name": "id",
"type": "long"
}
]
}
{code}
However, according to the Avro specification, names must:
* start with [A-Za-z_]
* subsequently contain only [A-Za-z0-9_]
When using e.g. the Confluent Schema Registry, registering this schema fails
because the Java Avro client correctly identifies this as an invalid schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (AVRO-2199) Validate that field defaults have the correct type
[ https://issues.apache.org/jira/browse/AVRO-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Orner updated AVRO-2199: --- Comment: was deleted (was: [~theturtle32] I definitely feel your pain. :( But the fact is that the current implementation is incorrect - the fact that you have bad data out there is a result of the incorrect implementation. In my case we had other Avro consumers not written in Ruby whose parsers were stricter that were crashing because we were sending bad data, so IMO it's more important to fix the behavior in Ruby which doesn't match the Avro specification. We should definitely make this a breaking change (1.9.0 instead of 1.8.3) so people can be made aware of this.) > Validate that field defaults have the correct type > --- > > Key: AVRO-2199 > URL: https://issues.apache.org/jira/browse/AVRO-2199 > Project: Avro > Issue Type: Improvement > Components: ruby >Affects Versions: 1.8.2 >Reporter: Daniel Orner >Priority: Minor > > Currently, on the master branch, when a schema is parsed, it is possible to > define a field with a type and a default of a totally different type. E.g. if > the field has type "string", the default can be set to "null". > I'd like to open a PR which will fix this by running the default through the > SchemaValidator whenever a new Field is created. See > [https://github.com/salsify/avro-patches/pull/16] > cc: [~tjwp] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2199) Validate that field defaults have the correct type
[ https://issues.apache.org/jira/browse/AVRO-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645606#comment-16645606 ] Daniel Orner commented on AVRO-2199: [~theturtle32] I definitely feel your pain. :( But the fact is that the current implementation is incorrect - the fact that you have bad data out there is a result of the incorrect implementation. In my case we had other Avro consumers not written in Ruby whose parsers were stricter that were crashing because we were sending bad data, so IMO it's more important to fix the behavior in Ruby which doesn't match the Avro specification. > Validate that field defaults have the correct type > --- > > Key: AVRO-2199 > URL: https://issues.apache.org/jira/browse/AVRO-2199 > Project: Avro > Issue Type: Improvement > Components: ruby >Affects Versions: 1.8.2 >Reporter: Daniel Orner >Priority: Minor > > Currently, on the master branch, when a schema is parsed, it is possible to > define a field with a type and a default of a totally different type. E.g. if > the field has type "string", the default can be set to "null". > I'd like to open a PR which will fix this by running the default through the > SchemaValidator whenever a new Field is created. See > [https://github.com/salsify/avro-patches/pull/16] > cc: [~tjwp] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2199) Validate that field defaults have the correct type
[ https://issues.apache.org/jira/browse/AVRO-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Orner updated AVRO-2199: --- Priority: Minor (was: Major) > Validate that field defaults have the correct type > --- > > Key: AVRO-2199 > URL: https://issues.apache.org/jira/browse/AVRO-2199 > Project: Avro > Issue Type: Improvement > Components: ruby >Affects Versions: 1.8.2 >Reporter: Daniel Orner >Priority: Minor > > Currently, on the master branch, when a schema is parsed, it is possible to > define a field with a type and a default of a totally different type. E.g. if > the field has type "string", the default can be set to "null". > I'd like to open a PR which will fix this by running the default through the > SchemaValidator whenever a new Field is created. See > [https://github.com/salsify/avro-patches/pull/16] > cc: [~tjwp] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AVRO-2200) Option to fail when extra fields are in the payload
Daniel Orner created AVRO-2200: -- Summary: Option to fail when extra fields are in the payload Key: AVRO-2200 URL: https://issues.apache.org/jira/browse/AVRO-2200 Project: Avro Issue Type: Improvement Components: ruby Reporter: Daniel Orner Currently, when passing a datum into the schema validator, the datum will pass even if the datum has more fields than the schema does. This can be dangerous because the client code is assuming that the schema has these values, but they are actually being silently swallowed when they are encoded. I'd like to open a PR where we can provide an option to make the validator fail on any extra fields. See https://github.com/salsify/avro-patches/pull/15 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2199) Validate that field defaults have the correct type
[ https://issues.apache.org/jira/browse/AVRO-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Orner updated AVRO-2199: --- Description: Currently, on the master branch, when a schema is parsed, it is possible to define a field with a type and a default of a totally different type. E.g. if the field has type "string", the default can be set to "null". I'd like to open a PR which will fix this by running the default through the SchemaValidator whenever a new Field is created. See [https://github.com/salsify/avro-patches/pull/16] cc: [~tjwp] was: Currently, on the master branch, when a schema is parsed, it is possible to define a field with a type and a default of a totally different type. E.g. if the field has type "string", the default can be set to "null". I'd like to open a PR which will fix this by running the default through the SchemaValidator whenever a new Field is created. See https://github.com/salsify/avro-patches/pull/16 > Validate that field defaults have the correct type > --- > > Key: AVRO-2199 > URL: https://issues.apache.org/jira/browse/AVRO-2199 > Project: Avro > Issue Type: Improvement > Components: ruby >Affects Versions: 1.8.2 >Reporter: Daniel Orner >Priority: Major > > Currently, on the master branch, when a schema is parsed, it is possible to > define a field with a type and a default of a totally different type. E.g. if > the field has type "string", the default can be set to "null". > I'd like to open a PR which will fix this by running the default through the > SchemaValidator whenever a new Field is created. See > [https://github.com/salsify/avro-patches/pull/16] > cc: [~tjwp] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AVRO-2199) Validate that field defaults have the correct type
Daniel Orner created AVRO-2199: -- Summary: Validate that field defaults have the correct type Key: AVRO-2199 URL: https://issues.apache.org/jira/browse/AVRO-2199 Project: Avro Issue Type: Improvement Components: ruby Affects Versions: 1.8.2 Reporter: Daniel Orner Currently, on the master branch, when a schema is parsed, it is possible to define a field with a type and a default of a totally different type. E.g. if the field has type "string", the default can be set to "null". I'd like to open a PR which will fix this by running the default through the SchemaValidator whenever a new Field is created. See https://github.com/salsify/avro-patches/pull/16 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
