[GitHub] avro pull request #272: AVRO-2120: Fix NullPointerException thrown by Schema...

2018-01-02 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/272


---


[GitHub] avro pull request #266: AVRO-2117: Code cleanup

2017-12-29 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/266


---


[GitHub] avro pull request #272: AVRO-2120: Fix NullPointerException thrown by Schema...

2017-12-23 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/272

AVRO-2120: Fix NullPointerException thrown by Schema.Parser#parse("")

Fix for master for https://issues.apache.org/jira/browse/AVRO-2120 .
TODO: Also backport to branch 1.8

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro 
AVRO-2120-Fix-NPE-parse-empty-string

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #272


commit 5f7a3a28549ff21aebfb379a197dd1c7211f8352
Author: Niels Basjes <nbasjes@...>
Date:   2017-12-23T12:24:52Z

AVRO-2120: Fix NullPointerException thrown by Schema.Parser#parse("")




---


[GitHub] avro pull request #264: Backporting two NPE fixes from master to branch-1.8

2017-12-22 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/264


---


[GitHub] avro pull request #265: AVRO-2119: Run Apache Rat check on every java build

2017-12-22 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/265


---


[GitHub] avro pull request #271: AVRO 2118+2119 Fix licensing issues

2017-12-22 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/271

AVRO 2118+2119 Fix licensing issues

I have combined the various actions from AVRO-2118 (licensing issues) and 
AVRO-2119 (Run rat always) into this set of commits.
I also updated Apache Rat to the latest version and fixed the problem that 
rat would not only be run at the top level (desired) but also in all 
subprojects (undesired and failing). 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2118-combined

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #271


commit c7a3c960902abffcbd3e9caf084f0dc5fae9f7f0
Author: Niels Basjes <nbasjes@...>
Date:   2017-12-21T17:24:35Z

AVRO-2118: Reverting changes by Thiruvalluvan M G 
<th...@startsmartlabs.com> from commit 9132015450a2ad6f56cd582b393e8f1b8df573c9

commit 48b2abca0f3b7873519f3566eb46a49cb4d15db7
Author: Zoltan Farkas <zolyfarkas@...>
Date:   2017-12-14T13:36:24Z

AVRO-2118: Fix license headers

commit 41653853c66143796e0bac503064e24cc0353a87
Author: Niels Basjes <nbasjes@...>
Date:   2017-12-22T09:48:40Z

AVRO-2118: Remove @author tag. Dangling JavaDoc fix.

commit a79b4366305d8796aeac60bb7b68bfc86fbde804
Author: Niels Basjes <nbasjes@...>
Date:   2017-12-22T09:51:53Z

AVRO-2119: Run Apache Rat check on every java build

commit 2e25d2edd2d06c665502afe788c197a63ce663fa
Author: Niels Basjes <nbasjes@...>
Date:   2017-12-22T11:04:36Z

AVRO-2119: Update Apache Rat. Fix build problem




---


[GitHub] avro pull request #269: Avro 2114 for branch-1.8

2017-12-18 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/269


---


[GitHub] avro pull request #269: Avro 2114 for branch-1.8

2017-12-18 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/269

Avro 2114 for branch-1.8

I backported the fix for https://issues.apache.org/jira/browse/AVRO-2114 
(see https://github.com/apache/avro/pull/263 ) to branch-1.8

The only real change between the two is in the 
AvroMissingFieldException.java where the `new ArrayList<>(8);` had to be 
changed into `new ArrayList(8);` because the diamond is not supported in 
java 1.6.

@nandorKollar can you please do a quick review? Thanks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2114-1.8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #269


commit ac587d27c6e9092503f096f83b42443a55f463ce
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-12T12:09:40Z

AVRO-2114: Make missing value exceptions in nested structures easier to 
read.




---


[GitHub] avro pull request #266: Avro 2117 code cleanup

2017-12-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/266

Avro 2117 code cleanup

This is a massive set of changes to reduce the number of needless warnings 
in the (mostly Java) code base.
I have kept each type of change in a separate commit so we can cherry-pick 
if one or more are unwanted.

Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2117-CodeCleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #266


commit 6a2adc9403c8c70332d7fd988d203232be165792
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T13:56:00Z

AVRO-2117: Cleanup Java - Fix spelling errors

commit 8f9ff6cdd39019621912ebba085227a86f870660
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T14:24:49Z

AVRO-2117: Cleanup Java - Remove trailing spaces

commit 40df4ebee2d98a3f83276a5b22ce84b46d2c1843
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T14:25:01Z

AVRO-2117: Cleanup C# - Remove trailing spaces

commit 723eb369485d3377b9da32a448fd0828fae47289
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T14:48:24Z

AVRO-2117: Cleanup Java - Explicit types replaced with <>

commit 501e6f21ec2db7a975ed9ca243a2253d72d5085a
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T14:54:13Z

AVRO-2117: Cleanup Java - Copyright block is reported as 'Dangling Javadoc'

commit 3d8791143dd4a0d2fa2a0ddd17138cc2711f01b5
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T15:01:18Z

AVRO-2117: Cleanup Java - Remove unused imports

commit 2204c502997e836f1cea065ebe373e98197a200b
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-13T16:03:34Z

AVRO-2117: Cleanup Java - Cleanup tests

commit fd43dafe106b1858b70973770fa42acba905d670
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-14T09:56:21Z

AVRO-2117: Cleanup Java - Remove redundant type arguments




---


[GitHub] avro pull request #265: AVRO-2119: Run Apache Rat check on every java build

2017-12-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/265

AVRO-2119: Run Apache Rat check on every java build

This simply forces Apache Rat to run on every Java build.
Must be committed to branch-1.7 branch-1.8 and master.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2119-Run-rat-always

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit 8c2d37c912610cff49101aab6bff02425ed50c3a
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-14T10:27:55Z

AVRO-2119: Run Apache Rat check on every java build




---


[GitHub] avro pull request #264: Backporting two NPE fixes from master to branch-1.8

2017-12-12 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/264

Backporting two NPE fixes from master to branch-1.8

I cherry-picked the commits for AVRO-1966 and AVRO-1967 which are both 
fixes for NPE situations that I would really like to be part of the next 1.8.x 
release.

I only had conflicts in the CHANGES.txt and the build ran fine on my 
machine.

Please double check if I did it correctly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1966-1.8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #264


commit 50d63a1bf1ee7cfa11303cc9d2b7ae5d8c707265
Author: Niels Basjes <nielsbas...@apache.org>
Date:   2016-11-30T20:50:13Z

AVRO-1966: Java: Fix NPE When copying builder with nullable record.

commit 4ed487786bb75732d8d86f7cd4be39f7a615b705
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-12-01T12:44:57Z

AVRO-1967: Java: Fix NPE when calling getXyzBuilder on instance where the 
xyz is null




---


[GitHub] avro pull request #263: AVRO-2114: Make missing value exceptions in nested s...

2017-12-12 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/263

AVRO-2114: Make missing value exceptions in nested structures easier to 
read.

With this patch the exception of a missing nested fields looks like this 
below.
The developer can now clearly see the path in the schema where the problem 
occurred.

Please review.

```
Field networkAddress type:STRING pos:1 not set and has no default value
Path in schema: --> connection --> networkAddress
at 
org.apache.avro.generic.GenericData.getDefaultValue(GenericData.java:999)
at 
org.apache.avro.data.RecordBuilderBase.defaultValue(RecordBuilderBase.java:138)
at 
org.apache.avro.test.http.NetworkConnection$Builder.build(NetworkConnection.java:290)
at org.apache.avro.test.http.Request$Builder.build(Request.java:440)
at 
org.apache.avro.specific.TestSpecificBuilderTree.failOnIncompleteTree(TestSpecificBuilderTree.java:78)

```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2114

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #263


commit 830b10627dbffc6d054579e250bfafc603f55e49
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-12T12:09:40Z

AVRO-2114: Make missing value exceptions in nested structures easier to 
read.




---


[GitHub] avro pull request #262: AVRO-2043: Remove pre JDK 1.8 surefire specific conf...

2017-12-11 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/262

AVRO-2043: Remove pre JDK 1.8 surefire specific configuration

I found a few remnants of the transition from Java 1.7 to 1.8 that can be 
removed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2043

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 7bbbf92cd699dd82240caa395ee5f6136f22f2b0
Author: Niels Basjes <nbas...@bol.com>
Date:   2017-12-11T17:04:09Z

AVRO-2043: Remove pre JDK 1.8 surefire specific configuration




---


[GitHub] avro pull request #168: AVRO-1967: Java: Fix NPE when calling getXyzBuilder ...

2016-12-17 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/168


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #168: AVRO-1967: Java: Fix NPE when calling getXyzBuilder ...

2016-12-01 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/168

AVRO-1967: Java: Fix NPE when calling getXyzBuilder on instance where the 
xyz is null



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1967

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #168


commit f249b18d937e20c3457f010658e0e7e477724033
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-12-01T12:44:57Z

AVRO-1967: Java: Fix NPE when calling getXyzBuilder on instance where the 
xyz is null




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #166: AVRO-1966: Java: Fix NPE When copying builder with n...

2016-11-30 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/166

AVRO-1966: Java: Fix NPE When copying builder with nullable record.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #166


commit a53a4fd10072471aa7c8170499a10792e61e0d95
Author: Niels Basjes <nielsbas...@apache.org>
Date:   2016-11-30T20:50:13Z

AVRO-1966: Java: Fix NPE When copying builder with nullable record.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #162: AVRO-1961: Java: Generate getters that return a Java...

2016-11-23 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/162

AVRO-1961: Java: Generate getters that return a Java 8 Optional.

NOTE: This must wait until AFTER the release of Avro 1.8.2.

This is a first attempt at making the Java code generator have the option 
(default is off) to generate Java 8 Optional getters.

A few things about this that open and must be discussed before committing:

1. This will change the building of Avro to require JDK 8 to be installed. 
Building with JDK 7 will simply fail.
2. The main runtime is still compiled with the setting "JDK 6". So in 
theory that should remain backward compatible for systems that still rely in 
JDK 6.
3. This is my first time playing with Optionals so a thorough review is 
really needed.

Also a big question is: Do we want this? 
I think it is a good idea to use the new Java features that make it easier 
for downstream developers.
Yet the risk of breaking backward compatibility may be considered to be a 
problem.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1961

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #162


commit 2394bcf5f7abfd38239bdafd7f30666cc3bfc32a
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-11-22T16:23:18Z

AVRO-1961: Java: Generate getters that return a Java 8 Optional.

commit 99b6adaa4407bdf02c893ab655ae514ccaf57f9b
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-11-23T10:27:37Z

AVRO-1961: Upgrade docker to jdk 8




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #153: AVRO-1956 Workaround incompatibility in testing CSha...

2016-11-10 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/153

AVRO-1956 Workaround incompatibility in testing CSharp code

I'm not quite sure this is the right solution direction.
An alternative would be to verify if the 'missing component is installed or 
not.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1956

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153


commit 3fd8ffd668e5a58b98c1e9de80e7ef5d29460197
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-11-10T15:13:17Z

AVRO-1956 Workaround incompatibility in testing CSharp code depending on 
environment




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #149: AVRO-1944: Fixed invalid toString in records with du...

2016-11-01 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #149: AVRO-1944: Fixed invalid toString in records with du...

2016-10-26 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/149

AVRO-1944: Fixed invalid toString in records with duplicate values

I ran into the effect that a record with two fields with the same value (or 
even both null) would result in a toString that shows the "CIRCULAR REFERENCE" 
message. This is incorrect and this fixes that.

Please verify.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1944

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #149


commit c7549f6b4a375e4aac0942092c1a006c0c469eb2
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-10-26T13:36:02Z

AVRO-1944: Fixed invalid toString in records with duplicate values




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #141: AVRO-1932: Java: Allow setting the SchemaStore on ge...

2016-10-15 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #141: AVRO-1932: Java: Allow setting the SchemaStore on ge...

2016-10-10 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/141

AVRO-1932: Java: Allow setting the SchemaStore on generated classes.

This change is needed to allow setting a different SchemaStore in the IDL 
generated classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1932

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit eb2bdbe10bb75e842deaa1d04e35c8bfb19e3069
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-10-10T11:04:06Z

AVRO-1932: Java: Allow setting the SchemaStore on generated classes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #128: AVRO-1923: Stop infinite recursion in GenericData.to...

2016-10-04 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #128: AVRO-1923: Stop infinite recursion in GenericData.to...

2016-09-22 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/128

AVRO-1923: Stop infinite recursion in GenericData.toString

Simply keep count of the recursion depth and stop at 50 (which seems to me 
like a good value)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1923

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit 1a0c0ee22e891537e58f713d3e5dee11b3396da7
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-09-22T12:42:47Z

AVRO-1923: Stop infinite recursion in GenericData.toString




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #125: AVRO-1914: Fix licencing errors reported by rat.

2016-09-15 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #124: AVRO-1913: No warnings in the generated Java code.

2016-09-15 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #125: AVRO-1914: Fix licencing errors reported by rat.

2016-09-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/125

AVRO-1914: Fix licencing errors reported by rat.

./build.sh rat now succeeds

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1914

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit d2bf6bb33ec63fe827d97e8fd07c5b31b8667591
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-09-14T08:57:22Z

AVRO-1914: Fix licencing errors reported by rat.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request #124: AVRO-1913: No warnings in the generated Java code.

2016-09-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/124

AVRO-1913: No warnings in the generated Java code.

In my projects this reduces the compiler warnings to 0 in the generated 
code.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #124


commit bce25786bd0782a806499bc76d968c9bc06c0943
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-09-14T07:43:32Z

AVRO-1913: No warnings in the generated Java code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request: AVRO-1814: Fixed name collision between field n...

2016-04-11 Thread nielsbasjes
Github user nielsbasjes closed the pull request at:

https://github.com/apache/avro/pull/80


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] avro pull request: AVRO-1814: Fixed name collision between field n...

2016-03-25 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/80

AVRO-1814: Fixed name collision between field names and toplevel package 
names



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-1814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #80


commit 960e0fdb011ab84a0ea0072fe0e46fb78a902793
Author: Niels Basjes <nbas...@bol.com>
Date:   2016-03-25T15:58:57Z

AVRO-1814: Fixed name collision between field names and toplevel package 
names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---