[GitHub] [avro] zolyfarkas commented on pull request #864: [AVRO-2278] getter semantics confusing.

2020-05-05 Thread GitBox 


zolyfarkas commented on pull request #864:
URL: https://github.com/apache/avro/pull/864#issuecomment-624052220


   @iemejia what do you think?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [avro] zolyfarkas commented on pull request #864: [AVRO-2278] getter semantics confusing.

2020-04-30 Thread GitBox 


zolyfarkas commented on pull request #864:
URL: https://github.com/apache/avro/pull/864#issuecomment-621804272


   @Fokko @RyanSkraba can you let me know what you think about the latests 
updates to this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [avro] zolyfarkas commented on pull request #864: [AVRO-2278] getter semantics confusing.

2020-04-28 Thread GitBox 


zolyfarkas commented on pull request #864:
URL: https://github.com/apache/avro/pull/864#issuecomment-620588755


   Updated this PR based on the comments of @RyanSkraba , please review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [avro] zolyfarkas commented on pull request #864: [AVRO-2278] getter semantics confusing.

2020-04-27 Thread GitBox 


zolyfarkas commented on pull request #864:
URL: https://github.com/apache/avro/pull/864#issuecomment-620157564


   removed FullRecordV1$Builder.class, was comited by mistake



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [avro] zolyfarkas commented on pull request #864: [AVRO-2278] getter semantics confusing.

2020-04-27 Thread GitBox 


zolyfarkas commented on pull request #864:
URL: https://github.com/apache/avro/pull/864#issuecomment-620154213


   My proposal is to introduce this to release 1.10+
   We should keep 1.9.x and 1.8.x, behavior compatible.
   
   We have been using the fixed behavior for a while now, when we upgraded, we 
have only seen one instance of a bug suddenly becoming visible, which we were 
actually happy about.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org