[jira] [Commented] (AVRO-1425) Fallback to thread context class loader in SpecificData.getClass()
[ https://issues.apache.org/jira/browse/AVRO-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694783#comment-16694783 ] Manuel Richter commented on AVRO-1425: -- FYI - this issue is still active: Here's an issue I had with Spring-Boot: https://github.com/spring-projects/spring-boot/issues/14622 And here the minimum reproducible example I set up: https://github.com/TeNNoX/spring-boot-devtools-with-avro > Fallback to thread context class loader in SpecificData.getClass() > -- > > Key: AVRO-1425 > URL: https://issues.apache.org/jira/browse/AVRO-1425 > Project: Apache Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.7.5 >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: AVRO-1425.patch > > > While trying to implement a simple Avro serializer that works in an OSGi > environment I stumbled on the fact that SpecificData.getClass() only uses its > own ClassLoader. Letting it fallback to the thread context class loader > (TCCL) makes it more OSGi-friendly, as callers can then set the TCCL as > needed. > AVRO-987, which hasn't been applied and is now stale, is about making Avro > fully OSGi compliant and would fix my issue as well, but I tried to aim for > the minimal changes that work for me (patch follows). > My use case is at https://github.com/bdelacretaz/avro-osgi-test - at commit > e3b4c47839 there my test passes with the attached patch applied to avro trunk > revision 1552851. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1425) Fallback to thread context class loader in SpecificData.getClass()
[ https://issues.apache.org/jira/browse/AVRO-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862841#comment-13862841 ] Bertrand Delacretaz commented on AVRO-1425: --- Ok, I'm happy to test the AVRO-987 changes on my use cases, I'll keep an eye on that. Fallback to thread context class loader in SpecificData.getClass() -- Key: AVRO-1425 URL: https://issues.apache.org/jira/browse/AVRO-1425 Project: Avro Issue Type: Improvement Components: java Affects Versions: 1.7.5 Reporter: Bertrand Delacretaz Priority: Minor Attachments: AVRO-1425.patch While trying to implement a simple Avro serializer that works in an OSGi environment I stumbled on the fact that SpecificData.getClass() only uses its own ClassLoader. Letting it fallback to the thread context class loader (TCCL) makes it more OSGi-friendly, as callers can then set the TCCL as needed. AVRO-987, which hasn't been applied and is now stale, is about making Avro fully OSGi compliant and would fix my issue as well, but I tried to aim for the minimal changes that work for me (patch follows). My use case is at https://github.com/bdelacretaz/avro-osgi-test - at commit e3b4c47839 there my test passes with the attached patch applied to avro trunk revision 1552851. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (AVRO-1425) Fallback to thread context class loader in SpecificData.getClass()
[ https://issues.apache.org/jira/browse/AVRO-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861749#comment-13861749 ] Doug Cutting commented on AVRO-1425: I'd prefer we fix this more generally, as in AVRO-987. Let me see if I can revive that patch. Fallback to thread context class loader in SpecificData.getClass() -- Key: AVRO-1425 URL: https://issues.apache.org/jira/browse/AVRO-1425 Project: Avro Issue Type: Improvement Components: java Affects Versions: 1.7.5 Reporter: Bertrand Delacretaz Priority: Minor Attachments: AVRO-1425.patch While trying to implement a simple Avro serializer that works in an OSGi environment I stumbled on the fact that SpecificData.getClass() only uses its own ClassLoader. Letting it fallback to the thread context class loader (TCCL) makes it more OSGi-friendly, as callers can then set the TCCL as needed. AVRO-987, which hasn't been applied and is now stale, is about making Avro fully OSGi compliant and would fix my issue as well, but I tried to aim for the minimal changes that work for me (patch follows). My use case is at https://github.com/bdelacretaz/avro-osgi-test - at commit e3b4c47839 there my test passes with the attached patch applied to avro trunk revision 1552851. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
