[jira] [Commented] (AVRO-1572) Avro-C misses EOF on 4K boundary
[ https://issues.apache.org/jira/browse/AVRO-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075212#comment-15075212 ] Hudson commented on AVRO-1572: -- SUCCESS: Integrated in AvroJava #563 (See [https://builds.apache.org/job/AvroJava/563/]) AVRO-1572: C: Fix EOF handling on data files that are multiples of 4096 bytes. Contributed by Ben Walsh. (martinkl: rev 1722359) * trunk/CHANGES.txt * trunk/lang/c/src/datafile.c * trunk/lang/c/tests/CMakeLists.txt * trunk/lang/c/tests/test_avro_1572.c > Avro-C misses EOF on 4K boundary > > > Key: AVRO-1572 > URL: https://issues.apache.org/jira/browse/AVRO-1572 > Project: Avro > Issue Type: Bug > Components: c >Reporter: Ben Walsh >Assignee: Martin Kleppmann > Fix For: 1.8.0 > > Attachments: AVRO-1572.patch > > > As noted in AVRO-1405, Avro C is still missing EOF in the case that the sync > section ends exactly on a 4096 byte boundary (4096 bytes is the buffer size > used by the reader). > I have fixed this bug (the suggested fix for AVRO-1364 actually works fine). > Also I added some more extensive testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1572) Avro-C misses EOF on 4K boundary
[ https://issues.apache.org/jira/browse/AVRO-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075115#comment-15075115 ] ASF subversion and git services commented on AVRO-1572: --- Commit 1722359 from [~martinkl] in branch 'avro/trunk' [ https://svn.apache.org/r1722359 ] AVRO-1572: C: Fix EOF handling on data files that are multiples of 4096 bytes. Contributed by Ben Walsh. > Avro-C misses EOF on 4K boundary > > > Key: AVRO-1572 > URL: https://issues.apache.org/jira/browse/AVRO-1572 > Project: Avro > Issue Type: Bug > Components: c >Reporter: Ben Walsh > Attachments: AVRO-1572.patch > > > As noted in AVRO-1405, Avro C is still missing EOF in the case that the sync > section ends exactly on a 4096 byte boundary (4096 bytes is the buffer size > used by the reader). > I have fixed this bug (the suggested fix for AVRO-1364 actually works fine). > Also I added some more extensive testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1572) Avro-C misses EOF on 4K boundary
[ https://issues.apache.org/jira/browse/AVRO-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075111#comment-15075111 ] ASF subversion and git services commented on AVRO-1572: --- Commit 1722355 from [~martinkl] in branch 'avro/branches/branch-1.8' [ https://svn.apache.org/r1722355 ] AVRO-1572: C: Fix EOF handling on data files that are multiples of 4096 bytes. (Ben Walsh via martinkl) > Avro-C misses EOF on 4K boundary > > > Key: AVRO-1572 > URL: https://issues.apache.org/jira/browse/AVRO-1572 > Project: Avro > Issue Type: Bug > Components: c >Reporter: Ben Walsh > Attachments: AVRO-1572.patch > > > As noted in AVRO-1405, Avro C is still missing EOF in the case that the sync > section ends exactly on a 4096 byte boundary (4096 bytes is the buffer size > used by the reader). > I have fixed this bug (the suggested fix for AVRO-1364 actually works fine). > Also I added some more extensive testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1572) Avro-C misses EOF on 4K boundary
[ https://issues.apache.org/jira/browse/AVRO-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072926#comment-15072926 ] Douglas Creager commented on AVRO-1572: --- +1 > Avro-C misses EOF on 4K boundary > > > Key: AVRO-1572 > URL: https://issues.apache.org/jira/browse/AVRO-1572 > Project: Avro > Issue Type: Bug > Components: c >Reporter: Ben Walsh > Attachments: AVRO-1572.patch > > > As noted in AVRO-1405, Avro C is still missing EOF in the case that the sync > section ends exactly on a 4096 byte boundary (4096 bytes is the buffer size > used by the reader). > I have fixed this bug (the suggested fix for AVRO-1364 actually works fine). > Also I added some more extensive testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1572) Avro-C misses EOF on 4K boundary
[ https://issues.apache.org/jira/browse/AVRO-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058082#comment-15058082 ] Martin Kleppmann commented on AVRO-1572: +1 I think this patch looks great. I will commit it soon if there are no objections. > Avro-C misses EOF on 4K boundary > > > Key: AVRO-1572 > URL: https://issues.apache.org/jira/browse/AVRO-1572 > Project: Avro > Issue Type: Bug > Components: c >Reporter: Ben Walsh > Attachments: AVRO-1572.patch > > > As noted in AVRO-1405, Avro C is still missing EOF in the case that the sync > section ends exactly on a 4096 byte boundary (4096 bytes is the buffer size > used by the reader). > I have fixed this bug (the suggested fix for AVRO-1364 actually works fine). > Also I added some more extensive testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
