[jira] [Commented] (AVRO-1769) Depend on external libjansson instead of a bundled copy
[ https://issues.apache.org/jira/browse/AVRO-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107409#comment-15107409 ] ASF subversion and git services commented on AVRO-1769: --- Commit 1725610 from [~martinkl] in branch 'avro/trunk' [ https://svn.apache.org/r1725610 ] AVRO-1769. C: Use operating system's libjansson instead of bundling it with Avro. Contributed by Magnus Edenhill. > Depend on external libjansson instead of a bundled copy > --- > > Key: AVRO-1769 > URL: https://issues.apache.org/jira/browse/AVRO-1769 > Project: Avro > Issue Type: Improvement > Components: c >Affects Versions: 1.7.7 >Reporter: Martin Kleppmann >Assignee: Martin Kleppmann > Attachments: AVRO-1769-2.patch.gz, AVRO-1769.patch.gz > > > To fix AVRO-1691 we need to update to a newer version of Jansson. However, > rather than updating the version of Jansson that is bundled with Avro-C, this > would be a good time to switch to a dynamically linked version. As > [~edenhill] pointed out, libjansson is widely available in distributions > nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1769) Depend on external libjansson instead of a bundled copy
[ https://issues.apache.org/jira/browse/AVRO-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106822#comment-15106822 ] Douglas Creager commented on AVRO-1769: --- +1 > Depend on external libjansson instead of a bundled copy > --- > > Key: AVRO-1769 > URL: https://issues.apache.org/jira/browse/AVRO-1769 > Project: Avro > Issue Type: Improvement > Components: c >Affects Versions: 1.7.7 >Reporter: Martin Kleppmann >Assignee: Martin Kleppmann > Attachments: AVRO-1769-2.patch.gz, AVRO-1769.patch.gz > > > To fix AVRO-1691 we need to update to a newer version of Jansson. However, > rather than updating the version of Jansson that is bundled with Avro-C, this > would be a good time to switch to a dynamically linked version. As > [~edenhill] pointed out, libjansson is widely available in distributions > nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1769) Depend on external libjansson instead of a bundled copy
[ https://issues.apache.org/jira/browse/AVRO-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107650#comment-15107650 ] Hudson commented on AVRO-1769: -- SUCCESS: Integrated in AvroJava #571 (See [https://builds.apache.org/job/AvroJava/571/]) AVRO-1769. C: Use operating system's libjansson instead of bundling it with Avro. Contributed by Magnus Edenhill. (martinkl: rev 1725610) * trunk/CHANGES.txt * trunk/LICENSE.txt * trunk/lang/c/CMakeLists.txt * trunk/lang/c/INSTALL * trunk/lang/c/LICENSE * trunk/lang/c/README.maintaining_win32.txt * trunk/lang/c/docs/index.txt * trunk/lang/c/jansson * trunk/lang/c/src/CMakeLists.txt * trunk/lang/c/tests/test_avro_data.c * trunk/share/docker/Dockerfile > Depend on external libjansson instead of a bundled copy > --- > > Key: AVRO-1769 > URL: https://issues.apache.org/jira/browse/AVRO-1769 > Project: Avro > Issue Type: Improvement > Components: c >Affects Versions: 1.7.7 >Reporter: Martin Kleppmann >Assignee: Martin Kleppmann > Fix For: 1.8.0 > > Attachments: AVRO-1769-2.patch.gz, AVRO-1769.patch.gz > > > To fix AVRO-1691 we need to update to a newer version of Jansson. However, > rather than updating the version of Jansson that is bundled with Avro-C, this > would be a good time to switch to a dynamically linked version. As > [~edenhill] pointed out, libjansson is widely available in distributions > nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1769) Depend on external libjansson instead of a bundled copy
[ https://issues.apache.org/jira/browse/AVRO-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105556#comment-15105556 ] Martin Kleppmann commented on AVRO-1769: Does anyone have further comments on this? I'll commit this soon if there are no objections. > Depend on external libjansson instead of a bundled copy > --- > > Key: AVRO-1769 > URL: https://issues.apache.org/jira/browse/AVRO-1769 > Project: Avro > Issue Type: Improvement > Components: c >Affects Versions: 1.7.7 >Reporter: Martin Kleppmann >Assignee: Martin Kleppmann > Attachments: AVRO-1769-2.patch.gz, AVRO-1769.patch.gz > > > To fix AVRO-1691 we need to update to a newer version of Jansson. However, > rather than updating the version of Jansson that is bundled with Avro-C, this > would be a good time to switch to a dynamically linked version. As > [~edenhill] pointed out, libjansson is widely available in distributions > nowadays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1769) Depend on external libjansson instead of a bundled copy
[
https://issues.apache.org/jira/browse/AVRO-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072916#comment-15072916
]
Douglas Creager commented on AVRO-1769:
---
This looks good, though the FindJansson module is pretty old. Jansson ships a
pkg-config file, so you could use {{pkg_check_modules(JANSSON jansson>=2.3)}}
instead, like we do for lzma/xz. That has the added benefit of having CMake
verify that the Jansson that we find meets our >=2.3 version requirement.
> Depend on external libjansson instead of a bundled copy
> ---
>
> Key: AVRO-1769
> URL: https://issues.apache.org/jira/browse/AVRO-1769
> Project: Avro
> Issue Type: Improvement
> Components: c
>Affects Versions: 1.7.7
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Attachments: AVRO-1769.patch.gz
>
>
> To fix AVRO-1691 we need to update to a newer version of Jansson. However,
> rather than updating the version of Jansson that is bundled with Avro-C, this
> would be a good time to switch to a dynamically linked version. As
> [~edenhill] pointed out, libjansson is widely available in distributions
> nowadays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
