[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748533#comment-16748533
]
Ismaël Mejía commented on AVRO-2145:
Is this one done? So we can resolve/close this ticket [~Fokko]?
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640538#comment-16640538
]
ASF GitHub Bot commented on AVRO-2145:
--
Fokko commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427543093
Ok, I'll create a new PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640052#comment-16640052
]
ASF GitHub Bot commented on AVRO-2145:
--
nandorKollar edited a comment on issue #334: [AVRO-2145] Cannot create Javadoc
on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427423523
I think in some cases it would make sense to fix the Javadoc, but adding
obvious comments only for DocLint doesn't give too much value. For example (at
least in my opinion) we should keep changes like
[this](https://github.com/apache/avro/pull/334/files#diff-8c641f2365208209cae8dd63a6d186f7R35),
but changes only related to the comment style like
[this](https://github.com/apache/avro/pull/334/files#diff-6e7994042bf667704678c9395ace00bcL103)
don't give too much value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640050#comment-16640050
]
ASF GitHub Bot commented on AVRO-2145:
--
nandorKollar commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427423523
I think in some cases it would make sense to fix the Javadoc, but adding
obvious comments only for DocLint doesn't give too much value. For example (at
least in my opinion) we should keep changes like
[this](https://github.com/apache/avro/pull/334/files#diff-8c641f2365208209cae8dd63a6d186f7L35),
but changes only related to the comment style like
[this](https://github.com/apache/avro/pull/334/files#diff-6e7994042bf667704678c9395ace00bcL103)
don't give too much value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640036#comment-16640036
]
ASF GitHub Bot commented on AVRO-2145:
--
Fokko commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427421219
Currently it breaks the `dist` step.
Personally I would prefer to add the JavaDoc. But if the majority prefers to
turn it off, I'm fine with it as well. Beside the missing JavaDoc, I've also
corrected a lot of the invalid JavaDoc in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640026#comment-16640026
]
ASF GitHub Bot commented on AVRO-2145:
--
nandorKollar commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427420122
In this case I'd recommend simply turning off DocLint. I remember we did
similar things on Parquet,
[here's](https://github.com/apache/parquet-format/commit/28ead3fd157842247ac71c5ec1fac94f1ff83ec4)
how it was turned off there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1664#comment-1664
]
ASF GitHub Bot commented on AVRO-2145:
--
cutting commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427416331
I'm not fond of whitespace changes. Are all of these really required to
pass JavaDoc lint? In particular, a lot of existing Javadoc comments have
content on the first line. When these are moved to a new line it causes the
rest of the comment to be re-indented. I'd prefer we don't make that style
change here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637720#comment-16637720
]
ASF GitHub Bot commented on AVRO-2145:
--
kojiromike commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-426861821
I can confirm this passes all the java-related tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637710#comment-16637710
]
ASF GitHub Bot commented on AVRO-2145:
--
kojiromike commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-426860151
@cutting I'm happy to help review stuff when I can, but 157 files is a bit
much for manual review. Can I help here by confirming I have run the tests
locally?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628173#comment-16628173
]
ASF GitHub Bot commented on AVRO-2145:
--
Fokko opened a new pull request #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334
From Java 8 on the JavaDoc is being linted and it will fail early if there
are issues with the JavaDoc: http://openjdk.java.net/jeps/172
This patch will add the missing Javadoc with some stubs. Additionally I
updated the docs of some of the public API by hand to make the Javadoc more
verbose.
The JavaDoc needs to be updated in the future, but this commit will let the
compiler pass the javadoc check step.
Tested locally and it passes the tests. This patch only changes the Javadoc
and does not change the logic of the code.
Cheers, Fokko
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
