[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344601#comment-17344601 ] Dimo Velev commented on AVRO-2353: -- This change broke compatibility with oracle nosql due to changing some methods from public to default visibility (Schema defaultValue() particularly). I am not sure why this was required to do but it is a big pain if one wants to use avro with kafka and nosql as there are no compatible versions any more that work with both. I am writing this hoping that developers that change visibility of public interfaces think about the consequences of these changes. > Auto format/validate Java code > -- > > Key: AVRO-2353 > URL: https://issues.apache.org/jira/browse/AVRO-2353 > Project: Apache Avro > Issue Type: Task > Components: java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 1.9.0 > > > In order to have consistent code formatting and make contribution validations > simpler we should consider auto formatting our Java codebase and checking it > with spotless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801729#comment-16801729 ] Hudson commented on AVRO-2353: -- FAILURE: Integrated in Jenkins build AvroJava #623 (See [https://builds.apache.org/job/AvroJava/623/]) AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java (fokko: [https://github.com/apache/avro/commit/8026c8ffe4ef67ab419dba73910636bf2c1a691c]) * (edit) lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibilityFixedSizeMismatch.java * (edit) lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServer.java * (edit) lang/java/trevni/avro/src/test/java/org/apache/trevni/avro/mapreduce/TestKeyWordCount.java * (edit) lang/java/ipc/src/test/java/org/apache/avro/TestProtocolDatagram.java * (edit) lang/java/mapred/src/test/java/org/apache/avro/mapreduce/TestWordCount.java * (edit) lang/java/tools/pom.xml * (edit) lang/java/avro/src/main/java/org/apache/avro/file/SeekableByteArrayInput.java * (edit) lang/java/trevni/core/src/main/java/org/apache/trevni/NullChecksum.java * (edit) lang/java/avro/src/main/java/org/apache/avro/Schema.java * (edit) lang/java/avro/src/test/java/org/apache/avro/FooBarSpecificRecord.java * (edit) lang/java/thrift/src/test/java/org/apache/avro/thrift/TestThrift.java * (edit) lang/java/trevni/core/src/test/java/org/apache/trevni/TestInputBytes.java * (edit) lang/java/tools/src/test/java/org/apache/avro/tool/TestToTrevniTool.java * (edit) lang/java/mapred/src/main/java/org/apache/avro/mapred/SequenceFileReader.java * (edit) lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StaticServlet.java * (edit) lang/java/compiler/src/test/java/org/apache/avro/compiler/idl/TestSchemaResolver.java * (edit) lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Foo.java * (edit) lang/java/mapred/src/main/java/org/apache/avro/mapred/SequenceFileInputFormat.java * (edit) lang/java/tools/src/main/java/org/apache/avro/tool/IdlToSchemataTool.java * (edit) lang/java/mapred/src/main/java/org/apache/avro/hadoop/io/AvroDatumConverterFactory.java * (edit) lang/java/mapred/src/test/java/org/apache/avro/mapred/tether/TetherTaskRunner.java * (edit) lang/java/mapred/src/main/java/org/apache/avro/mapred/DelegatingMapper.java * (edit) lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectionUtil.java * (edit) lang/java/integration-test/codegen-test/src/test/java/org/apache/avro/codegentest/TestNullableLogicalTypes.java * (edit) lang/java/trevni/core/src/test/java/org/apache/trevni/TestIOBuffers.java * (edit) lang/java/avro/src/main/java/org/apache/avro/io/parsing/JsonGrammarGenerator.java * (edit) lang/java/tools/src/test/java/org/apache/avro/tool/TestRecodecTool.java * (edit) lang/java/avro/src/main/java/org/apache/avro/io/Decoder.java * (edit) lang/java/avro/src/main/java/org/apache/avro/reflect/CustomEncoding.java * (edit) lang/java/avro/src/main/java/org/apache/avro/specific/SpecificFixed.java * (edit) lang/java/tools/src/main/java/org/apache/avro/tool/JsonToBinaryFragmentTool.java * (edit) lang/java/ipc/src/test/java/org/apache/avro/TestNamespaceSpecific.java * (edit) lang/java/tools/src/main/java/org/apache/avro/tool/DataFileRepairTool.java * (edit) lang/java/tools/src/test/java/org/apache/avro/tool/TestDataFileTools.java * (edit) lang/java/avro/src/main/java/org/apache/avro/io/ValidatingEncoder.java * (edit) lang/java/avro/src/main/java/org/apache/avro/file/Syncable.java * (edit) lang/java/avro/src/test/java/org/apache/avro/data/TestTimeConversions.java * (edit) lang/java/avro/src/test/java/org/apache/avro/util/CaseFinder.java * (edit) lang/java/thrift/src/test/java/org/apache/avro/thrift/test/E.java * (edit) lang/java/integration-test/pom.xml * (edit) lang/java/avro/src/test/java/org/apache/avro/TestDataFile.java * (edit) lang/java/ipc/src/test/java/org/apache/avro/TestSchema.java * (edit) lang/java/ipc/src/test/java/org/apache/avro/message/TestCustomSchemaStore.java * (edit) lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericLogicalTypes.java * (edit) lang/java/ipc/src/main/java/org/apache/avro/ipc/Transceiver.java * (edit) lang/java/ipc/src/main/java/org/apache/avro/ipc/generic/GenericRequestor.java * (edit) lang/java/mapred/src/test/java/org/apache/avro/mapreduce/AvroFiles.java * (edit) lang/java/trevni/core/src/main/java/org/apache/trevni/Crc32Checksum.java * (edit) lang/java/avro/src/test/java/org/apache/avro/io/TestEncoders.java * (edit) lang/java/avro/src/main/java/org/apache/avro/io/BlockingBinaryEncoder.java * (edit) lang/java/avro/src/main/java/org/apache/avro/io/parsing/Parser.java * (edit) lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Test.java * (edit) lang/java/compiler/pom.xml * (edit) lang/java/mapred/src/test/java/org/apache/avro/hadoop/io/TestAvroSerialization.java * (edit) lang/java/trevni/core/src/main/java/org/apache/trevni/SnappyCodec.j
[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801697#comment-16801697 ] ASF subversion and git services commented on AVRO-2353: --- Commit 8026c8ffe4ef67ab419dba73910636bf2c1a691c in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=8026c8f ] AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code (#487) * AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code * AVRO-2353: Adapt code formatter to Avro default style (2 spaces) * AVRO-2353: Remove trailing spaces check from checkstyle This is a bug of eclipse-jdt-formatter so we should disable the trailing validation temporally. For more info see https://bugs.eclipse.org/bugs/show_bug.cgi?id=488229 * AVRO-2353: Auto-format existing code > Auto format/validate Java code > -- > > Key: AVRO-2353 > URL: https://issues.apache.org/jira/browse/AVRO-2353 > Project: Apache Avro > Issue Type: Task > Components: java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > In order to have consistent code formatting and make contribution validations > simpler we should consider auto formatting our Java codebase and checking it > with spotless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801699#comment-16801699 ] ASF subversion and git services commented on AVRO-2353: --- Commit 8026c8ffe4ef67ab419dba73910636bf2c1a691c in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=8026c8f ] AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code (#487) * AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code * AVRO-2353: Adapt code formatter to Avro default style (2 spaces) * AVRO-2353: Remove trailing spaces check from checkstyle This is a bug of eclipse-jdt-formatter so we should disable the trailing validation temporally. For more info see https://bugs.eclipse.org/bugs/show_bug.cgi?id=488229 * AVRO-2353: Auto-format existing code > Auto format/validate Java code > -- > > Key: AVRO-2353 > URL: https://issues.apache.org/jira/browse/AVRO-2353 > Project: Apache Avro > Issue Type: Task > Components: java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > In order to have consistent code formatting and make contribution validations > simpler we should consider auto formatting our Java codebase and checking it > with spotless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801698#comment-16801698 ] ASF subversion and git services commented on AVRO-2353: --- Commit 8026c8ffe4ef67ab419dba73910636bf2c1a691c in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=8026c8f ] AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code (#487) * AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code * AVRO-2353: Adapt code formatter to Avro default style (2 spaces) * AVRO-2353: Remove trailing spaces check from checkstyle This is a bug of eclipse-jdt-formatter so we should disable the trailing validation temporally. For more info see https://bugs.eclipse.org/bugs/show_bug.cgi?id=488229 * AVRO-2353: Auto-format existing code > Auto format/validate Java code > -- > > Key: AVRO-2353 > URL: https://issues.apache.org/jira/browse/AVRO-2353 > Project: Apache Avro > Issue Type: Task > Components: java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > In order to have consistent code formatting and make contribution validations > simpler we should consider auto formatting our Java codebase and checking it > with spotless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801696#comment-16801696 ] ASF subversion and git services commented on AVRO-2353: --- Commit 8026c8ffe4ef67ab419dba73910636bf2c1a691c in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=8026c8f ] AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code (#487) * AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code * AVRO-2353: Adapt code formatter to Avro default style (2 spaces) * AVRO-2353: Remove trailing spaces check from checkstyle This is a bug of eclipse-jdt-formatter so we should disable the trailing validation temporally. For more info see https://bugs.eclipse.org/bugs/show_bug.cgi?id=488229 * AVRO-2353: Auto-format existing code > Auto format/validate Java code > -- > > Key: AVRO-2353 > URL: https://issues.apache.org/jira/browse/AVRO-2353 > Project: Apache Avro > Issue Type: Task > Components: java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > In order to have consistent code formatting and make contribution validations > simpler we should consider auto formatting our Java codebase and checking it > with spotless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2353) Auto format/validate Java code
[ https://issues.apache.org/jira/browse/AVRO-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801695#comment-16801695 ] ASF subversion and git services commented on AVRO-2353: --- Commit 8026c8ffe4ef67ab419dba73910636bf2c1a691c in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=8026c8f ] AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code (#487) * AVRO-2353: Configure spotless-maven-plugin to auto format/validate Java code * AVRO-2353: Adapt code formatter to Avro default style (2 spaces) * AVRO-2353: Remove trailing spaces check from checkstyle This is a bug of eclipse-jdt-formatter so we should disable the trailing validation temporally. For more info see https://bugs.eclipse.org/bugs/show_bug.cgi?id=488229 * AVRO-2353: Auto-format existing code > Auto format/validate Java code > -- > > Key: AVRO-2353 > URL: https://issues.apache.org/jira/browse/AVRO-2353 > Project: Apache Avro > Issue Type: Task > Components: java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > In order to have consistent code formatting and make contribution validations > simpler we should consider auto formatting our Java codebase and checking it > with spotless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
