[jira] [Commented] (AVRO-2562) Expose the JavaScript BlockEncoder's piped stream
[
https://issues.apache.org/jira/browse/AVRO-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960666#comment-16960666
]
Hudson commented on AVRO-2562:
--
SUCCESS: Integrated in Jenkins build AvroJava #756 (See
[https://builds.apache.org/job/AvroJava/756/])
AVRO-2562: Expose the JavaScript BlockEncoder's piped stream (#650) (fokko:
[https://github.com/apache/avro/commit/a684f3e0b1859ba05c17b18407c2e9905701079a])
* (edit) lang/js/test/test_files.js
* (edit) lang/js/lib/files.js
> Expose the JavaScript BlockEncoder's piped stream
> -
>
> Key: AVRO-2562
> URL: https://issues.apache.org/jira/browse/AVRO-2562
> Project: Apache Avro
> Issue Type: New Feature
> Components: javascript
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
> Fix For: 1.10.0
>
>
> The "createFileEncoder" test for the JavaScript implementation is flaky. It
> sometimes fails in docker mode, as follows:
> {code}
> ~/repos/avro$ git checkout master
> ~/repos/avro$ ./build.sh docker
> sekikn@13d38772b8e6:~/avro$ ./build.sh veryclean
> sekikn@13d38772b8e6:~/avro$ cd lang/js
> sekikn@13d38772b8e6:~/avro/lang/js$ node -v
> v6.17.1
> sekikn@13d38772b8e6:~/avro/lang/js$ npm i
> sekikn@13d38772b8e6:~/avro/lang/js$ for i in $(seq 1 100); do echo "#${i}";
> if ! npm t; then break; fi; done
> #1
> > avro-js@1.9.0 test /home/sekikn/avro/lang/js
> > mocha
>
> ․
>
> ․
>
> ․․․
> 381 passing (557ms)
> (snip)
> #7
> > avro-js@1.9.0 test /home/sekikn/avro/lang/js
> > mocha
>
> ․
>
> ․
>
> ․․․
> 380 passing (554ms)
> 1 failing
> 1) files createFileEncoder:
> Uncaught AssertionError: 0 == 2
> + expected - actual
> -0
> +2
>
> at BlockDecoder. (test/test_files.js:574:18)
> at endReadableNT (_stream_readable.js:978:12)
> at _combinedTickCallback (internal/process/next_tick.js:80:11)
> at process._tickCallback (internal/process/next_tick.js:104:9)
> npm ERR! Test failed. See above for more details.
> {code}
> And it always fails with Node.js v8.10.0, which is installed by apt-get on
> Ubuntu 18.04 LTS.
> {code}
> ~/repos/avro$ git checkout master
> ~/repos/avro$ cd lang/js
> ~/repos/avro/lang/js$ ./build.sh test
> > avro-js@1.9.0 cover /home/sekikn/repos/avro/lang/js
> > istanbul cover _mocha
>
> ․
>
> ․
>
> ․․․
> 380 passing (537ms)
> 1 failing
> 1) files createFileEncoder:
> Uncaught AssertionError [ERR_ASSERTION]: 0 == 2
> + expected - actual
> -0
> +2
>
> at BlockDecoder. (test/test_files.js:574:18)
> at endReadableNT (_stream_readable.js:1064:12)
> at _combinedTickCallback (internal/process/next_tick.js:138:11)
> at process._tickCallback (internal/process/next_tick.js:180:9)
> =
> Writing coverage object
> [/home/sekikn/repos/avro/lang/js/coverage/coverage.json]
> Writing coverage reports at [/home/sekikn/repos/avro/lang/js/coverage]
> =
> === Coverage summary
> ===
> Statements : 100% ( 2529/2529 )
> Branches : 100% ( 996/996 )
> Functions: 100% ( 414/414 )
> Lines: 100% ( 2443/2443 )
>
> npm ERR! Linux 5.0.0-25-generic
> npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "cover"
> npm ERR! node v8.10.0
> npm ERR! npm v3.5.2
> npm ERR! code ELIFECYCLE
> npm ERR! avro-js@1.9.0 cover: `istanbul cover _mocha`
> npm ERR! Exit status 1
> npm ERR!
> npm ERR!
[jira] [Commented] (AVRO-2562) Expose the JavaScript BlockEncoder's piped stream
[
https://issues.apache.org/jira/browse/AVRO-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960663#comment-16960663
]
ASF subversion and git services commented on AVRO-2562:
---
Commit a684f3e0b1859ba05c17b18407c2e9905701079a in avro's branch
refs/heads/master from Kengo Seki
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=a684f3e ]
AVRO-2562: Expose the JavaScript BlockEncoder's piped stream (#650)
> Expose the JavaScript BlockEncoder's piped stream
> -
>
> Key: AVRO-2562
> URL: https://issues.apache.org/jira/browse/AVRO-2562
> Project: Apache Avro
> Issue Type: New Feature
> Components: javascript
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
>
> The "createFileEncoder" test for the JavaScript implementation is flaky. It
> sometimes fails in docker mode, as follows:
> {code}
> ~/repos/avro$ git checkout master
> ~/repos/avro$ ./build.sh docker
> sekikn@13d38772b8e6:~/avro$ ./build.sh veryclean
> sekikn@13d38772b8e6:~/avro$ cd lang/js
> sekikn@13d38772b8e6:~/avro/lang/js$ node -v
> v6.17.1
> sekikn@13d38772b8e6:~/avro/lang/js$ npm i
> sekikn@13d38772b8e6:~/avro/lang/js$ for i in $(seq 1 100); do echo "#${i}";
> if ! npm t; then break; fi; done
> #1
> > avro-js@1.9.0 test /home/sekikn/avro/lang/js
> > mocha
>
> ․
>
> ․
>
> ․․․
> 381 passing (557ms)
> (snip)
> #7
> > avro-js@1.9.0 test /home/sekikn/avro/lang/js
> > mocha
>
> ․
>
> ․
>
> ․․․
> 380 passing (554ms)
> 1 failing
> 1) files createFileEncoder:
> Uncaught AssertionError: 0 == 2
> + expected - actual
> -0
> +2
>
> at BlockDecoder. (test/test_files.js:574:18)
> at endReadableNT (_stream_readable.js:978:12)
> at _combinedTickCallback (internal/process/next_tick.js:80:11)
> at process._tickCallback (internal/process/next_tick.js:104:9)
> npm ERR! Test failed. See above for more details.
> {code}
> And it always fails with Node.js v8.10.0, which is installed by apt-get on
> Ubuntu 18.04 LTS.
> {code}
> ~/repos/avro$ git checkout master
> ~/repos/avro$ cd lang/js
> ~/repos/avro/lang/js$ ./build.sh test
> > avro-js@1.9.0 cover /home/sekikn/repos/avro/lang/js
> > istanbul cover _mocha
>
> ․
>
> ․
>
> ․․․
> 380 passing (537ms)
> 1 failing
> 1) files createFileEncoder:
> Uncaught AssertionError [ERR_ASSERTION]: 0 == 2
> + expected - actual
> -0
> +2
>
> at BlockDecoder. (test/test_files.js:574:18)
> at endReadableNT (_stream_readable.js:1064:12)
> at _combinedTickCallback (internal/process/next_tick.js:138:11)
> at process._tickCallback (internal/process/next_tick.js:180:9)
> =
> Writing coverage object
> [/home/sekikn/repos/avro/lang/js/coverage/coverage.json]
> Writing coverage reports at [/home/sekikn/repos/avro/lang/js/coverage]
> =
> === Coverage summary
> ===
> Statements : 100% ( 2529/2529 )
> Branches : 100% ( 996/996 )
> Functions: 100% ( 414/414 )
> Lines: 100% ( 2443/2443 )
>
> npm ERR! Linux 5.0.0-25-generic
> npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "cover"
> npm ERR! node v8.10.0
> npm ERR! npm v3.5.2
> npm ERR! code ELIFECYCLE
> npm ERR! avro-js@1.9.0 cover: `istanbul cover _mocha`
> npm ERR! Exit status 1
> npm ERR!
> npm ERR! Failed at the avro-js@1.9.0 cover script 'istanbul cover _mocha'.
> npm ERR! Make
