[jira] [Commented] (AVRO-2593) test_tether_word_counts errors obscured
[
https://issues.apache.org/jira/browse/AVRO-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025712#comment-17025712
]
ASF subversion and git services commented on AVRO-2593:
---
Commit 8de8fb33d7a14ba276d360db22144178aeaefa34 in avro's branch
refs/heads/branch-1.9 from Michael A. Smith
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=8de8fb3 ]
AVRO-2593: Ensure exfile is Always Defined
Fixes a bug where when a test fails the cleanup code tries to access a variable
that might not have been defined when the error occurred.
> test_tether_word_counts errors obscured
> ---
>
> Key: AVRO-2593
> URL: https://issues.apache.org/jira/browse/AVRO-2593
> Project: Apache Avro
> Issue Type: Bug
> Components: python
>Affects Versions: 1.9.1
>Reporter: Michael A. Smith
>Assignee: Michael A. Smith
>Priority: Major
> Fix For: 1.9.2
>
>
> lang/py/test/test_tether_word_count.py is somewhat fragile. When it fails,
> the true failure is obscured by [a secondary
> error|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L210]
> because {{exfile}} is first defined on [line
> 179|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L179]
> and may not even exist in the {{finally}} block.
> I propose a significant refactor of this test to make the results clearer and
> to adhere to more idiomatic testing and python by:
> # Isolating the main test from its setup and teardown using standard setUp
> and tearDown.
> # Isolating the subprocess try/finally from the entire test setup/teardown.
> # Avoid having to manage multiple temporary files by running the entire test
> in a temporary directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2593) test_tether_word_counts errors obscured
[
https://issues.apache.org/jira/browse/AVRO-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956568#comment-16956568
]
Hudson commented on AVRO-2593:
--
SUCCESS: Integrated in Jenkins build AvroJava #748 (See
[https://builds.apache.org/job/AvroJava/748/])
AVRO-2593: Ensure exfile is Always Defined (michael:
[https://github.com/apache/avro/commit/0f9b051ce95c88f53cb3dd91d86479100ba6f698])
* (edit) lang/py/test/test_tether_word_count.py
> test_tether_word_counts errors obscured
> ---
>
> Key: AVRO-2593
> URL: https://issues.apache.org/jira/browse/AVRO-2593
> Project: Apache Avro
> Issue Type: Bug
> Components: python
>Affects Versions: 1.9.1
>Reporter: Michael A. Smith
>Assignee: Michael A. Smith
>Priority: Major
> Fix For: 1.9.2
>
>
> lang/py/test/test_tether_word_count.py is somewhat fragile. When it fails,
> the true failure is obscured by [a secondary
> error|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L210]
> because {{exfile}} is first defined on [line
> 179|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L179]
> and may not even exist in the {{finally}} block.
> I propose a significant refactor of this test to make the results clearer and
> to adhere to more idiomatic testing and python by:
> # Isolating the main test from its setup and teardown using standard setUp
> and tearDown.
> # Isolating the subprocess try/finally from the entire test setup/teardown.
> # Avoid having to manage multiple temporary files by running the entire test
> in a temporary directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2593) test_tether_word_counts errors obscured
[
https://issues.apache.org/jira/browse/AVRO-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956546#comment-16956546
]
ASF subversion and git services commented on AVRO-2593:
---
Commit 0f9b051ce95c88f53cb3dd91d86479100ba6f698 in avro's branch
refs/heads/master from Michael A. Smith
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0f9b051 ]
AVRO-2593: Ensure exfile is Always Defined
Fixes a bug where when a test fails the cleanup code tries to access a variable
that might not have been defined when the error occurred.
> test_tether_word_counts errors obscured
> ---
>
> Key: AVRO-2593
> URL: https://issues.apache.org/jira/browse/AVRO-2593
> Project: Apache Avro
> Issue Type: Bug
> Components: python
>Affects Versions: 1.9.1
>Reporter: Michael A. Smith
>Assignee: Michael A. Smith
>Priority: Major
>
> lang/py/test/test_tether_word_count.py is somewhat fragile. When it fails,
> the true failure is obscured by [a secondary
> error|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L210]
> because {{exfile}} is first defined on [line
> 179|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L179]
> and may not even exist in the {{finally}} block.
> I propose a significant refactor of this test to make the results clearer and
> to adhere to more idiomatic testing and python by:
> # Isolating the main test from its setup and teardown using standard setUp
> and tearDown.
> # Isolating the subprocess try/finally from the entire test setup/teardown.
> # Avoid having to manage multiple temporary files by running the entire test
> in a temporary directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
