[jira] [Created] (AVRO-2142) SchemaBuilder Java documentation code snipped is not valid
Ismaël Mejía created AVRO-2142: -- Summary: SchemaBuilder Java documentation code snipped is not valid Key: AVRO-2142 URL: https://issues.apache.org/jira/browse/AVRO-2142 Project: Avro Issue Type: Improvement Components: doc, java Reporter: Ismaël Mejía The code snippet in SchemaBuilder is invalid, it has invalid quotes and misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360707#comment-16360707 ] ASF GitHub Bot commented on AVRO-2142: -- iemejia opened a new pull request #282: AVRO-2142: Fix SchemaBuilder javadoc code snippet URL: https://github.com/apache/avro/pull/282 The code snippet in SchemaBuilder is invalid, it has invalid quotes and misses one call in the builder chain. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía updated AVRO-2142: --- Summary: SchemaBuilder Java documentation code snippet is not valid (was: SchemaBuilder Java documentation code snipped is not valid) > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2118) Rat tool fails over several files.
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360774#comment-16360774 ] ASF GitHub Bot commented on AVRO-2118: -- busbey closed pull request #267: AVRO-2118-license-headers URL: https://github.com/apache/avro/pull/267 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/ResolvingVisitor.java b/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/ResolvingVisitor.java index 5323b183d..e279e6aee 100644 --- a/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/ResolvingVisitor.java +++ b/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/ResolvingVisitor.java @@ -1,4 +1,20 @@ - +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.avro.compiler.idl; import com.google.common.base.Function; diff --git a/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/SchemaResolver.java b/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/SchemaResolver.java index 0195df452..a3860e36b 100644 --- a/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/SchemaResolver.java +++ b/lang/java/compiler/src/main/java/org/apache/avro/compiler/idl/SchemaResolver.java @@ -1,11 +1,13 @@ -/* - * Copyright 2015 The Apache Software Foundation. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/CloningVisitor.java b/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/CloningVisitor.java index ccc222a02..a5002f14a 100644 --- a/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/CloningVisitor.java +++ b/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/CloningVisitor.java @@ -1,4 +1,20 @@ - +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.avro.compiler.schema; import java.util.ArrayList; diff --git a/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java b/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java index 8000314f8..978ded834 100644 --- a/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java +++
[jira] [Updated] (AVRO-2127) Throwing more specific exception if an avro file has currupted magic
[ https://issues.apache.org/jira/browse/AVRO-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated AVRO-2127: -- Status: Patch Available (was: Open) > Throwing more specific exception if an avro file has currupted magic > > > Key: AVRO-2127 > URL: https://issues.apache.org/jira/browse/AVRO-2127 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.8.2 >Reporter: Dmitrii Bundin >Assignee: Dmitrii Bundin >Priority: Minor > > Curently we have IOException thrown if an avro file has incorrect magic. > It seems reasonable to throw a subclass of IOException to be able to handle > incorrect magic (in case length are match) in user code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated AVRO-2142: -- Status: Patch Available (was: Open) > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2127) Throwing more specific exception if an avro file has currupted magic
[
https://issues.apache.org/jira/browse/AVRO-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360773#comment-16360773
]
ASF GitHub Bot commented on AVRO-2127:
--
busbey commented on a change in pull request #273: AVRO-2127 Make
InvalidAvroMagicException thrown if stream header is corrupted
URL: https://github.com/apache/avro/pull/273#discussion_r167560725
##
File path:
lang/java/avro/src/main/java/org/apache/avro/file/DataFileStream.java
##
@@ -102,7 +102,7 @@ void initialize(InputStream in) throws IOException {
throw new IOException("Not an Avro data file.", e);
Review comment:
Is there an analogous case here to the EOF above? If there weren't enough
bytes in the stream for the magic check, right now here we throw a bare IOE,
right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Throwing more specific exception if an avro file has currupted magic
>
>
> Key: AVRO-2127
> URL: https://issues.apache.org/jira/browse/AVRO-2127
> Project: Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.8.2
>Reporter: Dmitrii Bundin
>Assignee: Dmitrii Bundin
>Priority: Minor
>
> Curently we have IOException thrown if an avro file has incorrect magic.
> It seems reasonable to throw a subclass of IOException to be able to handle
> incorrect magic (in case length are match) in user code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned AVRO-2142: - Assignee: Ismaël Mejía > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360760#comment-16360760 ] ASF GitHub Bot commented on AVRO-2142: -- iemejia commented on issue #282: AVRO-2142: Fix SchemaBuilder javadoc code snippet URL: https://github.com/apache/avro/pull/282#issuecomment-364924876 Nice, thanks :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2112) c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies
[ https://issues.apache.org/jira/browse/AVRO-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated AVRO-2112: -- Status: Patch Available (was: Open) > c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies > > > Key: AVRO-2112 > URL: https://issues.apache.org/jira/browse/AVRO-2112 > Project: Avro > Issue Type: Improvement > Components: csharp > Environment: - Visual Studio For Mac > - Visual Studio 2017 > - mono 5.4.1.7 MacOSX > - dotnet 2.0 (MacOSX and Windows 10) >Reporter: Miljenko Cvjetko >Assignee: Miljenko Cvjetko >Priority: Minor > Original Estimate: 0h > Remaining Estimate: 0h > > Suugestion is to add .NET Standard/Core support. > In order to support modern/new .NET (both standard netfx and dotnet core) it > is necessary to convert projects to support .NET Standard Libraries. > - conversion to .NET Standard [DONE] > - added dotnet core sample (Avro.perf) [DONE] > - added netfx (standrd .NET) sample Avro.perf.netfx [DONE] > - unit testing updated to use NUnit 3 > Url for the github forked repo with branch will be added. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (AVRO-2112) c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies
[ https://issues.apache.org/jira/browse/AVRO-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned AVRO-2112: - Assignee: Miljenko Cvjetko > c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies > > > Key: AVRO-2112 > URL: https://issues.apache.org/jira/browse/AVRO-2112 > Project: Avro > Issue Type: Improvement > Components: csharp > Environment: - Visual Studio For Mac > - Visual Studio 2017 > - mono 5.4.1.7 MacOSX > - dotnet 2.0 (MacOSX and Windows 10) >Reporter: Miljenko Cvjetko >Assignee: Miljenko Cvjetko >Priority: Minor > Original Estimate: 0h > Remaining Estimate: 0h > > Suugestion is to add .NET Standard/Core support. > In order to support modern/new .NET (both standard netfx and dotnet core) it > is necessary to convert projects to support .NET Standard Libraries. > - conversion to .NET Standard [DONE] > - added dotnet core sample (Avro.perf) [DONE] > - added netfx (standrd .NET) sample Avro.perf.netfx [DONE] > - unit testing updated to use NUnit 3 > Url for the github forked repo with branch will be added. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (AVRO-2127) Throwing more specific exception if an avro file has currupted magic
[ https://issues.apache.org/jira/browse/AVRO-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned AVRO-2127: - Assignee: Dmitrii Bundin > Throwing more specific exception if an avro file has currupted magic > > > Key: AVRO-2127 > URL: https://issues.apache.org/jira/browse/AVRO-2127 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.8.2 >Reporter: Dmitrii Bundin >Assignee: Dmitrii Bundin >Priority: Minor > > Curently we have IOException thrown if an avro file has incorrect magic. > It seems reasonable to throw a subclass of IOException to be able to handle > incorrect magic (in case length are match) in user code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2127) Throwing more specific exception if an avro file has currupted magic
[
https://issues.apache.org/jira/browse/AVRO-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360772#comment-16360772
]
ASF GitHub Bot commented on AVRO-2127:
--
busbey commented on a change in pull request #273: AVRO-2127 Make
InvalidAvroMagicException thrown if stream header is corrupted
URL: https://github.com/apache/avro/pull/273#discussion_r167560025
##
File path:
lang/java/avro/src/main/java/org/apache/avro/file/DataFileReader.java
##
@@ -47,7 +47,7 @@
DatumReader reader)
throws IOException {
if (in.length() < MAGIC.length)
- throw new IOException("Not an Avro data file");
+ throw new EOFException("Not an Avro data file");
Review comment:
Will this be confusing? Say I want to take files and throw them at the wall
to see what sticks. With this change as-is I'll need to see if the IOE is
either EOF or IAM. Is that desirable? Do we gain enough by being able to
distinguish the case where the magic header was invalid due to not enough bytes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Throwing more specific exception if an avro file has currupted magic
>
>
> Key: AVRO-2127
> URL: https://issues.apache.org/jira/browse/AVRO-2127
> Project: Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.8.2
>Reporter: Dmitrii Bundin
>Assignee: Dmitrii Bundin
>Priority: Minor
>
> Curently we have IOException thrown if an avro file has incorrect magic.
> It seems reasonable to throw a subclass of IOException to be able to handle
> incorrect magic (in case length are match) in user code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2143) ReflectData should determine inner class names in a different way.
[
https://issues.apache.org/jira/browse/AVRO-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361306#comment-16361306
]
Doug Cutting commented on AVRO-2143:
Does it work if you specify the name and space separately in the alias? This
might look like:
@AvroAlias(name="Type", space="example com.company.avro.House")
> ReflectData should determine inner class names in a different way.
> --
>
> Key: AVRO-2143
> URL: https://issues.apache.org/jira/browse/AVRO-2143
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.7.7
>Reporter: Miguel
>Priority: Major
>
> I used ReflectData to generate schemas containing inner classes. These
> classes were named automatically by ReflectData with dollar ('$'), with, for
> example com.company.avro.House$Type. Nevertheless @AvroAlias does not support
> aliases containing '$' in names. In particulr, it fails in validateName in
> Schema core class. The failure is correct given that AVRO name specs does
> notinclude the '$' symbol.
> I suppose that ReflectData should, for example, generate inner class names in
> a different way, such as replacing '$' by dots ('.'), or it should fail.
> And a detail: Although I cannot add aliases with '$', I can still encode and
> decode such objects and inner classes using that schema.
> I think that it newer versions it is also happening.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AVRO-2143) ReflectData should determine inner class names in a different way.
Miguel created AVRO-2143:
Summary: ReflectData should determine inner class names in a
different way.
Key: AVRO-2143
URL: https://issues.apache.org/jira/browse/AVRO-2143
Project: Avro
Issue Type: Improvement
Affects Versions: 1.7.7
Reporter: Miguel
I used ReflectData to generate schemas containing inner classes. These classes
were named automatically by ReflectData with dollar ('$'). Nevertheless
@AvroAlias does not support aliases containing '$' in names. It fails in
validateName in Schema core class. The failure is correct given that AVRO name
specs state that the names cannot contain '$'.
Therefore, ReflectData should, for example, generate inner class names in a
different way, such as replacing '$' by dots ('.'), or should fail.
Although I cannot add aliases, I can still encode and decode such objects and
inner classes using that schema.
I think that newer versions are also affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AVRO-2143) ReflectData should determine inner class names in a different way.
[
https://issues.apache.org/jira/browse/AVRO-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Miguel updated AVRO-2143:
-
Description:
I used ReflectData to generate schemas containing inner classes. These classes
were named automatically by ReflectData with dollar ('$'), with, for example
com.company.avro.House$Type. Nevertheless @AvroAlias does not support aliases
containing '$' in names. In particulr, it fails in validateName in Schema core
class. The failure is correct given that AVRO name specs does notinclude the
'$' symbol.
I suppose that ReflectData should, for example, generate inner class names in a
different way, such as replacing '$' by dots ('.'), or it should fail.
And a detail: Although I cannot add aliases with '$', I can still encode and
decode such objects and inner classes using that schema.
I think that it newer versions it is also happening.
was:
I used ReflectData to generate schemas containing inner classes. These classes
were named automatically by ReflectData with dollar ('$'). Nevertheless
@AvroAlias does not support aliases containing '$' in names. It fails in
validateName in Schema core class. The failure is correct given that AVRO name
specs state that the names cannot contain '$'.
Therefore, ReflectData should, for example, generate inner class names in a
different way, such as replacing '$' by dots ('.'), or should fail.
Although I cannot add aliases, I can still encode and decode such objects and
inner classes using that schema.
I think that newer versions are also affected.
> ReflectData should determine inner class names in a different way.
> --
>
> Key: AVRO-2143
> URL: https://issues.apache.org/jira/browse/AVRO-2143
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.7.7
>Reporter: Miguel
>Priority: Major
>
> I used ReflectData to generate schemas containing inner classes. These
> classes were named automatically by ReflectData with dollar ('$'), with, for
> example com.company.avro.House$Type. Nevertheless @AvroAlias does not support
> aliases containing '$' in names. In particulr, it fails in validateName in
> Schema core class. The failure is correct given that AVRO name specs does
> notinclude the '$' symbol.
> I suppose that ReflectData should, for example, generate inner class names in
> a different way, such as replacing '$' by dots ('.'), or it should fail.
> And a detail: Although I cannot add aliases with '$', I can still encode and
> decode such objects and inner classes using that schema.
> I think that it newer versions it is also happening.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2041) set up gitbox integration
[ https://issues.apache.org/jira/browse/AVRO-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361208#comment-16361208 ] Niels Basjes commented on AVRO-2041: Seems like the transition was already done. TODO: Update [http://avro.apache.org/version_control.html] and other places (if any) where we mention the git repo for developers. > set up gitbox integration > - > > Key: AVRO-2041 > URL: https://issues.apache.org/jira/browse/AVRO-2041 > Project: Avro > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Niels Basjes >Priority: Major > > We got consensus back in may about [turning on gitbox > integration|https://lists.apache.org/thread.html/cdd8ba14c1bf8aca2d71d09862e9780f2dc46af414ed78b1e3fd9c56@%3Cdev.avro.apache.org%3E] > so do it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
