[jira] [Commented] (AVRO-1996) incompatibility with ruby 2.4

2018-03-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388703#comment-16388703
 ] 

ASF GitHub Bot commented on AVRO-1996:
--

dsolomadin commented on issue #191: AVRO-1996: compatibility with Ruby 2.4
URL: https://github.com/apache/avro/pull/191#issuecomment-370966466
 
 
    Do you guys know when the next release going to happen? Really want those 
deprecation messages to be gone


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> incompatibility with ruby 2.4
> -
>
> Key: AVRO-1996
> URL: https://issues.apache.org/jira/browse/AVRO-1996
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Reporter: Tim Perkins
>Assignee: Tim Perkins
>Priority: Minor
>  Labels: test
> Fix For: 1.9.0
>
>
> On master, there are failing tests with ruby 2.4.
> The problem is due to the unification of Fixnum and Bignum types as Integer 
> in ruby 2.4.
> The only loss of functionality is minor: in schema validation messages the 
> datum is reported as long instead of int.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AVRO-2155) Generate documentation for C# classes and enums

2018-03-06 Thread Brian Lachniet (JIRA)
Brian Lachniet created AVRO-2155:


 Summary: Generate documentation for C# classes and enums
 Key: AVRO-2155
 URL: https://issues.apache.org/jira/browse/AVRO-2155
 Project: Avro
  Issue Type: New Feature
  Components: csharp
Affects Versions: 1.8.2
Reporter: Brian Lachniet


Update the C# "avrogen" code generation to populate documentation for code 
entities (classes and enums) that are generated from named schemas (record, 
enum and fixed). At this time, it only generates documentation for Avro fields 
(C# fields and properties).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AVRO-2156) Allow custom namespace for C# generated code

2018-03-06 Thread Brian Lachniet (JIRA)
Brian Lachniet created AVRO-2156:


 Summary: Allow custom namespace for C# generated code
 Key: AVRO-2156
 URL: https://issues.apache.org/jira/browse/AVRO-2156
 Project: Avro
  Issue Type: New Feature
  Components: csharp
Affects Versions: 1.8.2
Reporter: Brian Lachniet


The namespace used in Avro schemas/protocols does not always map nicely to a 
standard C# namespace. Avrogen (the C# code generator) currently uses the Avro 
namespace as the C# namespace. I propose that we update the avrogen utility to 
allow the user to override the namespace used in the generated code via a 
command line parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AVRO-2154) Python to Java IPC converts boolean inside a union to integer

2018-03-06 Thread Usman Shahid (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387641#comment-16387641
 ] 

Usman Shahid commented on AVRO-2154:


The problem occurs on python client in the `DatumWriter.write_union()` method. 
The method iterates over all the types in a union and performs an 
`isinstance()` on the value with each type. Incidentally, due to [python design 
decision regarding booleans|https://www.python.org/dev/peps/pep-0285/], 
`isinstance(True, int)` returns `True` to maintain backward compatibility and 
since the loop in `write_union` doesn't break, the type that returns true last 
in the sequence of the union gets selected. If we reverse the sequence of the 
types in the union definition, it works fine and a boolean is returned on the 
server side.

> Python to Java IPC converts boolean inside a union to integer
> -
>
> Key: AVRO-2154
> URL: https://issues.apache.org/jira/browse/AVRO-2154
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.8.2
> Environment: macOS 10.13.3
> Java(TM) SE Runtime Environment (build 1.8.0_161-b12)
> Python 2.7.10
>Reporter: Usman Shahid
>Priority: Major
>
> Using the following IDL:
> {code:java}
> @namespace("us.codemug")
> protocol BooleanTestProtocol {
>   void booleanInUnion(union{boolean, int, string} myunion);
> }
> {code}
> and the following Java implementation:
> {code:java}
> package us.codemug;
> import java.util.Map;
> import org.apache.avro.AvroRemoteException;
> public class BooleanTestResponder implements BooleanTestProtocol {
>   public Void booleanInUnion(Object myunion) throws AvroRemoteException {
> print(myunion);
> return null;
>   }
>   private void print(Object value) {
> System.out.println("Type: " + value.getClass().getName());
> System.out.println("Value: " + value);
>   }
> }
> {code}
> When performing the IPC from python with the input:
> {code}
> args = dict()
> args['myunion'] = True
> requestor.request('booleanInUnion', args)
> {code}
> Produces this output at the server side:
> {code:java}
> Type: java.lang.Integer
> Value: 1
> {code}
> The booleans are being converted to integers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)