[jira] [Comment Edited] (BAHIR-85) Redis Sink Connector should allow update of command without reinstatiation

2018-02-01 Thread shukun.lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/BAHIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349858#comment-16349858
 ] 

shukun.lee edited comment on BAHIR-85 at 2/2/18 6:31 AM:
-

[~atharvai] [~rmetzger]

I think the reasonable way to support is add a function variable in RedisSink 
like
{code:java}
private Function updateFuc;
{code}
And provide set method like
{code:java}
public RedisSink setUpdateFuc(Function fuc) {
updateFuc = fuc;
return this;
}
{code}
there are some advantages below:

1、Backward compatibility,No need change 'RedisMapper' interface

2、comfortable style when use like
{code:java}
new RedisSink[(String, ItemsSketch[String])](conf, new XXRedisMapper)
.setUpdateFuc(v->{...}){code}


was (Author: desugun):
I think the reasonable way to support is add a function variable in RedisSink 
like
{code:java}
private Function updateFuc;
{code}
And provide set method like
{code:java}
public RedisSink setUpdateFuc(Function fuc) {
updateFuc = fuc;
return this;
}
{code}
there are some advantages below:

1、Backward compatibility,No need change 'RedisMapper' interface

2、comfortable style when use like
{code:java}
new RedisSink[(String, ItemsSketch[String])](conf, new XXRedisMapper)
.setUpdateFuc(v->{...}){code}

> Redis Sink Connector should allow update of command without reinstatiation 
> ---
>
> Key: BAHIR-85
> URL: https://issues.apache.org/jira/browse/BAHIR-85
> Project: Bahir
>  Issue Type: Improvement
>  Components: Flink Streaming Connectors
>Reporter: Atharva Inamdar
>Priority: Major
>
> ref: FLINK-5478
> `getCommandDescription()` gets called when RedisSink is instantiated. This 
> happens only once and thus doesn't allow the command to be updated during run 
> time.
> Use Case:
> As a dev I want to store some data by day. So each key will have some date 
> specified. this will change over course of time. for example: 
> `counts_for_148426560` for 2017-01-13. This is not limited to any 
> particular command.
> connector: 
> https://github.com/apache/bahir-flink/blob/master/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java#L114
> I wish `getCommandDescription()` could be called in `invoke()` so that the 
> key can be updated without having to restart.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BAHIR-85) Redis Sink Connector should allow update of command without reinstatiation

2018-02-01 Thread shukun.lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/BAHIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349858#comment-16349858
 ] 

shukun.lee commented on BAHIR-85:
-

I think the reasonable way to support is add a function variable in RedisSink 
like
{code:java}
private Function updateFuc;
{code}
And provide set method like
{code:java}
public RedisSink setUpdateFuc(Function fuc) {
updateFuc = fuc;
return this;
}
{code}
there are some advantages below:

1、Backward compatibility,No need change 'RedisMapper' interface

2、comfortable style when use like
{code:java}
new RedisSink[(String, ItemsSketch[String])](conf, new XXRedisMapper)
.setUpdateFuc(v->{...}){code}

> Redis Sink Connector should allow update of command without reinstatiation 
> ---
>
> Key: BAHIR-85
> URL: https://issues.apache.org/jira/browse/BAHIR-85
> Project: Bahir
>  Issue Type: Improvement
>  Components: Flink Streaming Connectors
>Reporter: Atharva Inamdar
>Priority: Major
>
> ref: FLINK-5478
> `getCommandDescription()` gets called when RedisSink is instantiated. This 
> happens only once and thus doesn't allow the command to be updated during run 
> time.
> Use Case:
> As a dev I want to store some data by day. So each key will have some date 
> specified. this will change over course of time. for example: 
> `counts_for_148426560` for 2017-01-13. This is not limited to any 
> particular command.
> connector: 
> https://github.com/apache/bahir-flink/blob/master/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java#L114
> I wish `getCommandDescription()` could be called in `invoke()` so that the 
> key can be updated without having to restart.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BAHIR-85) Redis Sink Connector should allow update of command without reinstatiation

2018-02-01 Thread shukun.lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/BAHIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349749#comment-16349749
 ] 

shukun.lee commented on BAHIR-85:
-

hello everyone,

I have the same case when use flink-connector-redis. 
 In my use case,I need use HSET command to update data, which shcema like 
(ts,field,value).So I must get ts(timestamp) as addtionalKey according to input 
data.
 Therefore,I think it's no need to new a 'RedisCommandDescription' when every 
data is comming,however we need a way to update addtionalKey.

Unfortunately,I can't find any way for update it.

> Redis Sink Connector should allow update of command without reinstatiation 
> ---
>
> Key: BAHIR-85
> URL: https://issues.apache.org/jira/browse/BAHIR-85
> Project: Bahir
>  Issue Type: Improvement
>  Components: Flink Streaming Connectors
>Reporter: Atharva Inamdar
>Priority: Major
>
> ref: FLINK-5478
> `getCommandDescription()` gets called when RedisSink is instantiated. This 
> happens only once and thus doesn't allow the command to be updated during run 
> time.
> Use Case:
> As a dev I want to store some data by day. So each key will have some date 
> specified. this will change over course of time. for example: 
> `counts_for_148426560` for 2017-01-13. This is not limited to any 
> particular command.
> connector: 
> https://github.com/apache/bahir-flink/blob/master/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java#L114
> I wish `getCommandDescription()` could be called in `invoke()` so that the 
> key can be updated without having to restart.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (BAHIR-157) The current documentation for extensions contains bad version (2.2.0.1.0.0-SNAPSHOT)

2018-02-01 Thread Luciano Resende (JIRA) 

 [ 
https://issues.apache.org/jira/browse/BAHIR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luciano Resende resolved BAHIR-157.
---
   Resolution: Fixed
Fix Version/s: Not Applicable

Good catch, and thanks for describing the solution as well.

> The current documentation for extensions contains bad version 
> (2.2.0.1.0.0-SNAPSHOT)
> 
>
> Key: BAHIR-157
> URL: https://issues.apache.org/jira/browse/BAHIR-157
> Project: Bahir
>  Issue Type: Bug
>  Components: Website
>Reporter: Sergii Iarovyi
>Assignee: Sergii Iarovyi
>Priority: Minor
> Fix For: Not Applicable
>
>
> On  [https://bahir.apache.org/docs/spark/current/documentation/] where 
> {{{\{site.SPARK_VERSION seem to be replaced with the version instead of 
> expected 2.3.0-SNAPSHOT there is 2.2.0.1.0.0-SNAPSHOT
> e.g. [https://bahir.apache.org/docs/spark/current/spark-sql-cloudant/]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (BAHIR-157) The current documentation for extensions contains bad version (2.2.0.1.0.0-SNAPSHOT)

2018-02-01 Thread Luciano Resende (JIRA) 

 [ 
https://issues.apache.org/jira/browse/BAHIR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luciano Resende reassigned BAHIR-157:
-

Assignee: Sergii Iarovyi

> The current documentation for extensions contains bad version 
> (2.2.0.1.0.0-SNAPSHOT)
> 
>
> Key: BAHIR-157
> URL: https://issues.apache.org/jira/browse/BAHIR-157
> Project: Bahir
>  Issue Type: Bug
>  Components: Website
>Reporter: Sergii Iarovyi
>Assignee: Sergii Iarovyi
>Priority: Minor
>
> On  [https://bahir.apache.org/docs/spark/current/documentation/] where 
> {{{\{site.SPARK_VERSION seem to be replaced with the version instead of 
> expected 2.3.0-SNAPSHOT there is 2.2.0.1.0.0-SNAPSHOT
> e.g. [https://bahir.apache.org/docs/spark/current/spark-sql-cloudant/]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BAHIR-157) The current documentation for extensions contains bad version (2.2.0.1.0.0-SNAPSHOT)

2018-02-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/BAHIR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349713#comment-16349713
 ] 

ASF subversion and git services commented on BAHIR-157:
---

Commit d7e1bf9a21ec68842b736bcab316801ee7e3f038 in bahir-website's branch 
refs/heads/master from [~luciano resende]
[ https://git-wip-us.apache.org/repos/asf?p=bahir-website.git;h=d7e1bf9 ]

[BAHIR-157] Fix current spark version for documentation


> The current documentation for extensions contains bad version 
> (2.2.0.1.0.0-SNAPSHOT)
> 
>
> Key: BAHIR-157
> URL: https://issues.apache.org/jira/browse/BAHIR-157
> Project: Bahir
>  Issue Type: Bug
>  Components: Website
>Reporter: Sergii Iarovyi
>Priority: Minor
>
> On  [https://bahir.apache.org/docs/spark/current/documentation/] where 
> {{{\{site.SPARK_VERSION seem to be replaced with the version instead of 
> expected 2.3.0-SNAPSHOT there is 2.2.0.1.0.0-SNAPSHOT
> e.g. [https://bahir.apache.org/docs/spark/current/spark-sql-cloudant/]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (BAHIR-157) The current documentation for extensions contains bad version (2.2.0.1.0.0-SNAPSHOT)

2018-02-01 Thread Sergii Iarovyi (JIRA) 
Sergii Iarovyi created BAHIR-157:


 Summary: The current documentation for extensions contains bad 
version (2.2.0.1.0.0-SNAPSHOT)
 Key: BAHIR-157
 URL: https://issues.apache.org/jira/browse/BAHIR-157
 Project: Bahir
  Issue Type: Bug
  Components: Website
Reporter: Sergii Iarovyi


On  [https://bahir.apache.org/docs/spark/current/documentation/] where 
{{{\{site.SPARK_VERSION seem to be replaced with the version instead of 
expected 2.3.0-SNAPSHOT there is 2.2.0.1.0.0-SNAPSHOT

e.g. [https://bahir.apache.org/docs/spark/current/spark-sql-cloudant/]

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)