Re: Assigning Reviewers in GitHub?
This is unfortunate, as the reviewers pulldown at least gives some reasonable suggestions for new users (which is why I suggested it). But, yes, R: @ is the convention. On Fri, Jun 21, 2019 at 5:56 PM Lukasz Cwik wrote: > > Only a few people have permission to update the 'Reviewers' section and I > believe you either have to be a project PMC member or committer to be able to > update it which is why all people should use "R: @GITHUB-USERNAME" as > specified in the contribution guide[1]. > > 1: https://beam.apache.org/contribute/#make-your-change > > On Thu, Jun 20, 2019 at 11:00 PM Bruce Arctor > wrote: >> >> Hi Dev, >> >> Today at Beam Summit, in Contributing workshop, Robert suggested adding >> reviewer by assigning someone to 'Reviewers' to the section on the right >> (where labels, assignees, milestones, etc live). This was not possible >> without some additional permissions, but it is not clear what that requires? >> Is it somehow joining the Apache Org on GitHub, having contributor >> permissions, etc? >> >> The other suggestion was to include "R: @GITHUB-USERNAME". to mark/notify >> people. Which does work. But would be interested in understanding the >> practices for assigning reviewers in the method mentioned above. >> >> Please advise; this was also written on list, so that this knowledge can be >> findable/referenced in the future. >> >> Thanks, >> Austin >>
Re: Assigning Reviewers in GitHub?
Only a few people have permission to update the 'Reviewers' section and I believe you either have to be a project PMC member or committer to be able to update it which is why all people should use "R: @GITHUB-USERNAME" as specified in the contribution guide[1]. 1: https://beam.apache.org/contribute/#make-your-change On Thu, Jun 20, 2019 at 11:00 PM Bruce Arctor wrote: > Hi Dev, > > Today at Beam Summit, in Contributing workshop, Robert suggested adding > reviewer by assigning someone to 'Reviewers' to the section on the right > (where labels, assignees, milestones, etc live). This was not possible > without some additional permissions, but it is not clear what that > requires? Is it somehow joining the Apache Org on GitHub, having > contributor permissions, etc? > > The other suggestion was to include "R: @GITHUB-USERNAME". to mark/notify > people. Which does work. But would be interested in understanding the > practices for assigning reviewers in the method mentioned above. > > Please advise; this was also written on list, so that this knowledge can > be findable/referenced in the future. > > Thanks, > Austin > >
Assigning Reviewers in GitHub?
Hi Dev, Today at Beam Summit, in Contributing workshop, Robert suggested adding reviewer by assigning someone to 'Reviewers' to the section on the right (where labels, assignees, milestones, etc live). This was not possible without some additional permissions, but it is not clear what that requires? Is it somehow joining the Apache Org on GitHub, having contributor permissions, etc? The other suggestion was to include "R: @GITHUB-USERNAME". to mark/notify people. Which does work. But would be interested in understanding the practices for assigning reviewers in the method mentioned above. Please advise; this was also written on list, so that this knowledge can be findable/referenced in the future. Thanks, Austin
