Re: [VOTE] Upgrade gradle to 6.2

2020-03-05 Thread Alex Van Boxel
https://issues.apache.org/jira/browse/BEAM-9456

I'll take it step-by-step, expect slow proces as till now haven't focussed
on Python, Go and other runners. So be patient.


 _/
_/ Alex Van Boxel


On Thu, Mar 5, 2020 at 9:13 PM Jean-Baptiste Onofre  wrote:

> Fair enough, we have the consensus, so agree to create Jira and move
> forward about this update.
>
> Regards
> JB
>
> > Le 5 mars 2020 à 20:16, Ismaël Mejía  a écrit :
> >
> > Looks like we have consensus on this one. Can you create a JIRA to
> > track this Alex.
> > I found this interesting presentation and associated repo, for the
> > interested on new improvements we can win with the move to version
> > 6.x.x
> > https://melix.github.io/gradle-6-whats-new/#/
> >
> https://github.com/melix/gradle-6-whats-new/tree/master/demos/hello-gradle-6
> >
> > On Tue, Feb 25, 2020 at 7:24 PM Luke Cwik  wrote:
> >>
> >> +1
> >>
> >> On Tue, Feb 25, 2020 at 12:49 AM Gleb Kanterov 
> wrote:
> >>>
> >>> +1 (non-binding)
> >>>
> >>> On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía 
> wrote:
> 
>  +1 great to have our build updated, please share if there are new
> interesting features/plugin advantages we can benefit from too.
> 
>  On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré 
> wrote:
> >
> > Hi Alex
> >
> > I also have couple of contacts at Gradle. Let me know if needed.
> >
> > Regards
> > JB
> >
> > Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a
> ?crit :
> >>
> >> OK, great. I know someone that works at gradle, so I can ping them
> when I have some problems.
> >>
> >> Any other know pitfalls I can expect, let me know :-)
> >>
> >> _/
> >> _/ Alex Van Boxel
> >>
> >>
> >> On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr? <
> j...@nanthrax.net> wrote:
> >>
> >> +1
> >>
> >> It makes sense.
> >>
> >> Thanks.
> >> Regards
> >> JB
> >>
> >> Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a
> ?crit :
> >>
> >> Anyone objections that I upgrade gradle to 6.2. If ok this will be
> done over several commits where I will:
> >>
> >> Upgrade plugins
> >> Upgrade gradle to 6.2
> >> See where we can use some of the new features
> >>
> >>
> >> _/
> >> _/ Alex Van Boxel
>
>


Re: [VOTE] Upgrade gradle to 6.2

2020-03-05 Thread Jean-Baptiste Onofre
Fair enough, we have the consensus, so agree to create Jira and move forward 
about this update.

Regards
JB

> Le 5 mars 2020 à 20:16, Ismaël Mejía  a écrit :
> 
> Looks like we have consensus on this one. Can you create a JIRA to
> track this Alex.
> I found this interesting presentation and associated repo, for the
> interested on new improvements we can win with the move to version
> 6.x.x
> https://melix.github.io/gradle-6-whats-new/#/
> https://github.com/melix/gradle-6-whats-new/tree/master/demos/hello-gradle-6
> 
> On Tue, Feb 25, 2020 at 7:24 PM Luke Cwik  wrote:
>> 
>> +1
>> 
>> On Tue, Feb 25, 2020 at 12:49 AM Gleb Kanterov  wrote:
>>> 
>>> +1 (non-binding)
>>> 
>>> On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía  wrote:
 
 +1 great to have our build updated, please share if there are new 
 interesting features/plugin advantages we can benefit from too.
 
 On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré  
 wrote:
> 
> Hi Alex
> 
> I also have couple of contacts at Gradle. Let me know if needed.
> 
> Regards
> JB
> 
> Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a ?crit :
>> 
>> OK, great. I know someone that works at gradle, so I can ping them when 
>> I have some problems.
>> 
>> Any other know pitfalls I can expect, let me know :-)
>> 
>> _/
>> _/ Alex Van Boxel
>> 
>> 
>> On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr?  
>> wrote:
>> 
>> +1
>> 
>> It makes sense.
>> 
>> Thanks.
>> Regards
>> JB
>> 
>> Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a ?crit 
>> :
>> 
>> Anyone objections that I upgrade gradle to 6.2. If ok this will be done 
>> over several commits where I will:
>> 
>> Upgrade plugins
>> Upgrade gradle to 6.2
>> See where we can use some of the new features
>> 
>> 
>> _/
>> _/ Alex Van Boxel



Re: [VOTE] Upgrade gradle to 6.2

2020-03-05 Thread Alex Van Boxel
I will

 _/
_/ Alex Van Boxel


On Thu, Mar 5, 2020 at 8:17 PM Ismaël Mejía  wrote:

> Looks like we have consensus on this one. Can you create a JIRA to
> track this Alex.
> I found this interesting presentation and associated repo, for the
> interested on new improvements we can win with the move to version
> 6.x.x
> https://melix.github.io/gradle-6-whats-new/#/
>
> https://github.com/melix/gradle-6-whats-new/tree/master/demos/hello-gradle-6
>
> On Tue, Feb 25, 2020 at 7:24 PM Luke Cwik  wrote:
> >
> > +1
> >
> > On Tue, Feb 25, 2020 at 12:49 AM Gleb Kanterov  wrote:
> >>
> >> +1 (non-binding)
> >>
> >> On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía  wrote:
> >>>
> >>> +1 great to have our build updated, please share if there are new
> interesting features/plugin advantages we can benefit from too.
> >>>
> >>> On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré 
> wrote:
> 
>  Hi Alex
> 
>  I also have couple of contacts at Gradle. Let me know if needed.
> 
>  Regards
>  JB
> 
>  Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a
> ?crit :
> >
> > OK, great. I know someone that works at gradle, so I can ping them
> when I have some problems.
> >
> > Any other know pitfalls I can expect, let me know :-)
> >
> >  _/
> > _/ Alex Van Boxel
> >
> >
> > On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr? <
> j...@nanthrax.net> wrote:
> >
> > +1
> >
> > It makes sense.
> >
> > Thanks.
> > Regards
> > JB
> >
> > Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a
> ?crit :
> >
> > Anyone objections that I upgrade gradle to 6.2. If ok this will be
> done over several commits where I will:
> >
> > Upgrade plugins
> > Upgrade gradle to 6.2
> > See where we can use some of the new features
> >
> >
> >  _/
> > _/ Alex Van Boxel
>


Re: [VOTE] Upgrade gradle to 6.2

2020-03-05 Thread Ismaël Mejía
Looks like we have consensus on this one. Can you create a JIRA to
track this Alex.
I found this interesting presentation and associated repo, for the
interested on new improvements we can win with the move to version
6.x.x
https://melix.github.io/gradle-6-whats-new/#/
https://github.com/melix/gradle-6-whats-new/tree/master/demos/hello-gradle-6

On Tue, Feb 25, 2020 at 7:24 PM Luke Cwik  wrote:
>
> +1
>
> On Tue, Feb 25, 2020 at 12:49 AM Gleb Kanterov  wrote:
>>
>> +1 (non-binding)
>>
>> On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía  wrote:
>>>
>>> +1 great to have our build updated, please share if there are new 
>>> interesting features/plugin advantages we can benefit from too.
>>>
>>> On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré  
>>> wrote:

 Hi Alex

 I also have couple of contacts at Gradle. Let me know if needed.

 Regards
 JB

 Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a ?crit :
>
> OK, great. I know someone that works at gradle, so I can ping them when I 
> have some problems.
>
> Any other know pitfalls I can expect, let me know :-)
>
>  _/
> _/ Alex Van Boxel
>
>
> On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr?  
> wrote:
>
> +1
>
> It makes sense.
>
> Thanks.
> Regards
> JB
>
> Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a ?crit :
>
> Anyone objections that I upgrade gradle to 6.2. If ok this will be done 
> over several commits where I will:
>
> Upgrade plugins
> Upgrade gradle to 6.2
> See where we can use some of the new features
>
>
>  _/
> _/ Alex Van Boxel


Re: [VOTE] Upgrade gradle to 6.2

2020-02-25 Thread Luke Cwik
+1

On Tue, Feb 25, 2020 at 12:49 AM Gleb Kanterov  wrote:

> +1 (non-binding)
>
> On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía  wrote:
>
>> +1 great to have our build updated, please share if there are new
>> interesting features/plugin advantages we can benefit from too.
>>
>> On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré 
>> wrote:
>>
>>> Hi Alex
>>>
>>> I also have couple of contacts at Gradle. Let me know if needed.
>>>
>>> Regards
>>> JB
>>>
>>> Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a
>>> ?crit :
>>>
 OK, great. I know someone that works at gradle, so I can ping them when
 I have some problems.

 Any other know pitfalls I can expect, let me know :-)

  _/
 _/ Alex Van Boxel


 On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr? 
 wrote:

 +1

 It makes sense.

 Thanks.
 Regards
 JB

 Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a
 ?crit :

 Anyone objections that I upgrade gradle to 6.2. If ok this will be done
 over several commits where I will:

- Upgrade plugins
- Upgrade gradle to 6.2
- See where we can use some of the new features


  _/
 _/ Alex Van Boxel




Re: [VOTE] Upgrade gradle to 6.2

2020-02-25 Thread Gleb Kanterov
+1 (non-binding)

On Tue, Feb 25, 2020 at 9:38 AM Ismaël Mejía  wrote:

> +1 great to have our build updated, please share if there are new
> interesting features/plugin advantages we can benefit from too.
>
> On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré 
> wrote:
>
>> Hi Alex
>>
>> I also have couple of contacts at Gradle. Let me know if needed.
>>
>> Regards
>> JB
>>
>> Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a
>> ?crit :
>>
>>> OK, great. I know someone that works at gradle, so I can ping them when
>>> I have some problems.
>>>
>>> Any other know pitfalls I can expect, let me know :-)
>>>
>>>  _/
>>> _/ Alex Van Boxel
>>>
>>>
>>> On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr? 
>>> wrote:
>>>
>>> +1
>>>
>>> It makes sense.
>>>
>>> Thanks.
>>> Regards
>>> JB
>>>
>>> Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a
>>> ?crit :
>>>
>>> Anyone objections that I upgrade gradle to 6.2. If ok this will be done
>>> over several commits where I will:
>>>
>>>- Upgrade plugins
>>>- Upgrade gradle to 6.2
>>>- See where we can use some of the new features
>>>
>>>
>>>  _/
>>> _/ Alex Van Boxel
>>>
>>>


Re: [VOTE] Upgrade gradle to 6.2

2020-02-25 Thread Ismaël Mejía
+1 great to have our build updated, please share if there are new
interesting features/plugin advantages we can benefit from too.

On Tue, Feb 25, 2020 at 8:24 AM Jean-Baptiste Onofré 
wrote:

> Hi Alex
>
> I also have couple of contacts at Gradle. Let me know if needed.
>
> Regards
> JB
>
> Le mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a ?crit :
>
>> OK, great. I know someone that works at gradle, so I can ping them when I
>> have some problems.
>>
>> Any other know pitfalls I can expect, let me know :-)
>>
>>  _/
>> _/ Alex Van Boxel
>>
>>
>> On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr? 
>> wrote:
>>
>> +1
>>
>> It makes sense.
>>
>> Thanks.
>> Regards
>> JB
>>
>> Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a
>> ?crit :
>>
>> Anyone objections that I upgrade gradle to 6.2. If ok this will be done
>> over several commits where I will:
>>
>>- Upgrade plugins
>>- Upgrade gradle to 6.2
>>- See where we can use some of the new features
>>
>>
>>  _/
>> _/ Alex Van Boxel
>>
>>


Re: [VOTE] Upgrade gradle to 6.2

2020-02-24 Thread Jean-Baptiste Onofré
Hi AlexI also have couple of contacts at Gradle. Let me know if needed. Regards JBLe mar. 25 f?vr. 2020 ? 08:20, Alex Van Boxel  a ?crit :OK, great. I know someone that works at gradle, so I can ping them when I have some problems.Any other know pitfalls I can expect, let me know :-) _/_/ Alex Van BoxelOn Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofr?  wrote:+1It makes sense. Thanks. Regards JBLe lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a ?crit :Anyone objections that I upgrade gradle to 6.2. If ok this will be done over several commits where I will:Upgrade pluginsUpgrade gradle to 6.2See where we can use some of the new features _/_/ Alex Van Boxel

Re: [VOTE] Upgrade gradle to 6.2

2020-02-24 Thread Alex Van Boxel
OK, great. I know someone that works at gradle, so I can ping them when I
have some problems.

Any other know pitfalls I can expect, let me know :-)

 _/
_/ Alex Van Boxel


On Tue, Feb 25, 2020 at 7:20 AM Jean-Baptiste Onofré 
wrote:

> +1
>
> It makes sense.
>
> Thanks.
> Regards
> JB
>
> Le lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a ?crit :
>
>> Anyone objections that I upgrade gradle to 6.2. If ok this will be done
>> over several commits where I will:
>>
>>- Upgrade plugins
>>- Upgrade gradle to 6.2
>>- See where we can use some of the new features
>>
>>
>>  _/
>> _/ Alex Van Boxel
>>
>


Re: [VOTE] Upgrade gradle to 6.2

2020-02-24 Thread Jean-Baptiste Onofré
+1It makes sense. Thanks. Regards JBLe lun. 24 f?vr. 2020 ? 22:37, Alex Van Boxel  a ?crit :Anyone objections that I upgrade gradle to 6.2. If ok this will be done over several commits where I will:Upgrade pluginsUpgrade gradle to 6.2See where we can use some of the new features _/_/ Alex Van Boxel

Re: [VOTE] Upgrade gradle to 6.2

2020-02-24 Thread Luke Cwik
+1

Can you try testing removing -Ppublishing and no parallel build requirement
when doing the release?
(some of the Gradle release related plugins had issues when running in
parallel which manifested as build errors when doing the release).

On Mon, Feb 24, 2020 at 5:43 PM Kenneth Knowles  wrote:

> +1
>
> On Mon, Feb 24, 2020 at 5:42 PM Kenneth Knowles  wrote:
>
>> If I recall correctly, upgrading gradle would unblock getting some better
>> static analysis plugins. That would be stellar, since we lost a lot of our
>> analysis when we switched from findbugs to spotbugs (it seems to just not
>> care as much about some errors, which have since flourished)
>>
>> Kenn
>>
>> On Mon, Feb 24, 2020 at 1:38 PM Alex Van Boxel  wrote:
>>
>>> Anyone objections that I upgrade gradle to 6.2. If ok this will be done
>>> over several commits where I will:
>>>
>>>- Upgrade plugins
>>>- Upgrade gradle to 6.2
>>>- See where we can use some of the new features
>>>
>>>
>>>  _/
>>> _/ Alex Van Boxel
>>>
>>


Re: [VOTE] Upgrade gradle to 6.2

2020-02-24 Thread Kenneth Knowles
+1

On Mon, Feb 24, 2020 at 5:42 PM Kenneth Knowles  wrote:

> If I recall correctly, upgrading gradle would unblock getting some better
> static analysis plugins. That would be stellar, since we lost a lot of our
> analysis when we switched from findbugs to spotbugs (it seems to just not
> care as much about some errors, which have since flourished)
>
> Kenn
>
> On Mon, Feb 24, 2020 at 1:38 PM Alex Van Boxel  wrote:
>
>> Anyone objections that I upgrade gradle to 6.2. If ok this will be done
>> over several commits where I will:
>>
>>- Upgrade plugins
>>- Upgrade gradle to 6.2
>>- See where we can use some of the new features
>>
>>
>>  _/
>> _/ Alex Van Boxel
>>
>


Re: [VOTE] Upgrade gradle to 6.2

2020-02-24 Thread Kenneth Knowles
If I recall correctly, upgrading gradle would unblock getting some better
static analysis plugins. That would be stellar, since we lost a lot of our
analysis when we switched from findbugs to spotbugs (it seems to just not
care as much about some errors, which have since flourished)

Kenn

On Mon, Feb 24, 2020 at 1:38 PM Alex Van Boxel  wrote:

> Anyone objections that I upgrade gradle to 6.2. If ok this will be done
> over several commits where I will:
>
>- Upgrade plugins
>- Upgrade gradle to 6.2
>- See where we can use some of the new features
>
>
>  _/
> _/ Alex Van Boxel
>