Re: Review request for 2 Python BigQuery IO related PRs

[Pablo Estrada]

Thanks! Yes, I'll take a look!

On Wed, Mar 3, 2021 at 1:19 PM Ahmet Altay  wrote:

> +Pablo Estrada 
>
> On Wed, Mar 3, 2021 at 1:08 PM Chuck Yang 
> wrote:
>
>> Hi Beam devs,
>>
>> Could I have reviews on the following two PRs?
>>
>> * [BEAM-11884] Pass destination as str rather than TableReference
>> within BigQueryBatchFileLoads #14112 [1]
>> * [BEAM-11277] Respect schemaUpdateOptions during BigQuery load with
>> temporary tables #14113 [2]
>>
>> The first PR fixes a bug I encountered in master around serialization
>> of BigQuery table references.
>>
>> The second PR addresses a bug in which BigQuery schema update options
>> are not respected during WriteToBigQuery with temporary tables.
>> Ideally BigQuery copy jobs which append data to a table can be
>> configured with schema update options, but since that's not the case,
>> I hope the PR provides an acceptable workaround.
>>
>> I'd like to get these in before the release cut next week if possible.
>>
>> Thanks!
>> Chuck
>>
>> [1] https://github.com/apache/beam/pull/14112
>> [2] https://github.com/apache/beam/pull/14113
>>
>> --
>>
>>
>> *Confidentiality Note:* We care about protecting our proprietary
>> information, confidential material, and trade secrets. This message may
>> contain some or all of those things. Cruise will suffer material harm if
>> anyone other than the intended recipient disseminates or takes any action
>> based on this message. If you have received this message (including any
>> attachments) in error, please delete it immediately and notify the sender
>> promptly.
>>
>

Re: Review request for 2 Python BigQuery IO related PRs

[Ahmet Altay]

+Pablo Estrada 

On Wed, Mar 3, 2021 at 1:08 PM Chuck Yang  wrote:

> Hi Beam devs,
>
> Could I have reviews on the following two PRs?
>
> * [BEAM-11884] Pass destination as str rather than TableReference
> within BigQueryBatchFileLoads #14112 [1]
> * [BEAM-11277] Respect schemaUpdateOptions during BigQuery load with
> temporary tables #14113 [2]
>
> The first PR fixes a bug I encountered in master around serialization
> of BigQuery table references.
>
> The second PR addresses a bug in which BigQuery schema update options
> are not respected during WriteToBigQuery with temporary tables.
> Ideally BigQuery copy jobs which append data to a table can be
> configured with schema update options, but since that's not the case,
> I hope the PR provides an acceptable workaround.
>
> I'd like to get these in before the release cut next week if possible.
>
> Thanks!
> Chuck
>
> [1] https://github.com/apache/beam/pull/14112
> [2] https://github.com/apache/beam/pull/14113
>
> --
>
>
> *Confidentiality Note:* We care about protecting our proprietary
> information, confidential material, and trade secrets. This message may
> contain some or all of those things. Cruise will suffer material harm if
> anyone other than the intended recipient disseminates or takes any action
> based on this message. If you have received this message (including any
> attachments) in error, please delete it immediately and notify the sender
> promptly.
>

Review request for 2 Python BigQuery IO related PRs

[Chuck Yang]

Hi Beam devs,

Could I have reviews on the following two PRs?

* [BEAM-11884] Pass destination as str rather than TableReference
within BigQueryBatchFileLoads #14112 [1]
* [BEAM-11277] Respect schemaUpdateOptions during BigQuery load with
temporary tables #14113 [2]

The first PR fixes a bug I encountered in master around serialization
of BigQuery table references.

The second PR addresses a bug in which BigQuery schema update options
are not respected during WriteToBigQuery with temporary tables.
Ideally BigQuery copy jobs which append data to a table can be
configured with schema update options, but since that's not the case,
I hope the PR provides an acceptable workaround.

I'd like to get these in before the release cut next week if possible.

Thanks!
Chuck

[1] https://github.com/apache/beam/pull/14112
[2] https://github.com/apache/beam/pull/14113

-- 


*Confidentiality Note:* We care about protecting our proprietary 
information, confidential material, and trade secrets. This message may 
contain some or all of those things. Cruise will suffer material harm if 
anyone other than the intended recipient disseminates or takes any action 
based on this message. If you have received this message (including any 
attachments) in error, please delete it immediately and notify the sender 
promptly.

[BEAM-8078] Code review request

[Алексей Высотин]

Hi Team,

Could someone please take a look at the PR for [BEAM-8078]
streaming_wordcount_debugging.py is missing a test
?

Thank you in advance.

Best Regards,

Alex Vysotin.

Re: Review Request

[Pablo Estrada]

Thanks! I'll take a look today.

On Mon, Feb 24, 2020 at 5:19 PM Wenbing Bai 
wrote:

> Hi there,
>
> Can I get a review on this PR https://github.com/apache/beam/pull/10901?
>
> --
>
>
>
>
>
> Wenbing Bai
>
> Senior Software Engineer, MLP
>
> Cruise
>
> Pronouns: She/Her
>
>
>
> *Confidentiality Note:* We care about protecting our proprietary
> information, confidential material, and trade secrets. This message may
> contain some or all of those things. Cruise will suffer material harm if
> anyone other than the intended recipient disseminates or takes any action
> based on this message. If you have received this message (including any
> attachments) in error, please delete it immediately and notify the sender
> promptly.

Review Request

[Wenbing Bai]

Hi there,

Can I get a review on this PR https://github.com/apache/beam/pull/10901?

-- 





Wenbing Bai

Senior Software Engineer, MLP

Cruise

Pronouns: She/Her

-- 


*Confidentiality Note:* We care about protecting our proprietary 
information, confidential material, and trade secrets. This message may 
contain some or all of those things. Cruise will suffer material harm if 
anyone other than the intended recipient disseminates or takes any action 
based on this message. If you have received this message (including any 
attachments) in error, please delete it immediately and notify the sender 
promptly.

Review Request - BEAM-7990 Add ReadFromParquetBatched to Python

[Brian Hulette]

Could someone take a look at https://github.com/apache/beam/pull/9361. I
already have a review from Heejong, who wrote the original ReadFromParquet,
but it still needs a committer's review.

Brian