Re: TestPipeline drops options with JsonIgnore annotation

2018-01-22 Thread Paul Gerver
I am hitting this issue on several integration tests, but these tests are only 
using options set by the `beamTestPipelineOptions` system property and not 
going through convertToArgs from my side.

I apologize for the email switch but the mail list isn’t letting log in through 
Google+.

On 2018/01/22 21:14:15, Lukasz Cwik  wrote:
> Are your talking about integration tests that use a main like WordCountIT?>
>
> If so, then https://github.com/apache/beam/pull/4346 was an attempt to get>
> around this limitation but I suggested that we get rid of convertToArgs>
> completely so there is no serialization round trip before the args are>
> passed to the TestPipeline.>
> If you have some ideas in this space, feel free to contribute a PR.>
>
> On Fri, Jan 19, 2018 at 4:54 PM, Paul Gerver  wrote:>
>
> > Hello,>
> >>
> > With Beam 2.2 it looks like the TestPipeline now serializes options before>
> > giving them to the parent Pipeline to run (in order to utilize runtime>
> > options). I have some options that were marked with the `JsonIgnore`>
> > annotation which now seem to be getting dropped for my runner.>
> >>
> > Is there something I'm missing which would allow me to skip this>
> > serialization piece in the TestPipeline? If not, this seems like a side>
> > effect of 2.2.>
> >>
> > Let me know!>
> >>
> > Thanks,>
> > -->
> > *Paul Gerver*>
> >>
>
Sent from Mail for Windows 10



Re: TestPipeline drops options with JsonIgnore annotation

2018-01-22 Thread Lukasz Cwik
Are your talking about integration tests that use a main like WordCountIT?

If so, then https://github.com/apache/beam/pull/4346 was an attempt to get
around this limitation but I suggested that we get rid of convertToArgs
completely so there is no serialization round trip before the args are
passed to the TestPipeline.
If you have some ideas in this space, feel free to contribute a PR.

On Fri, Jan 19, 2018 at 4:54 PM, Paul Gerver  wrote:

> Hello,
>
> With Beam 2.2 it looks like the TestPipeline now serializes options before
> giving them to the parent Pipeline to run (in order to utilize runtime
> options). I have some options that were marked with the `JsonIgnore`
> annotation which now seem to be getting dropped for my runner.
>
> Is there something I'm missing which would allow me to skip this
> serialization piece in the TestPipeline? If not, this seems like a side
> effect of 2.2.
>
> Let me know!
>
> Thanks,
> --
> *Paul Gerver*
>


TestPipeline drops options with JsonIgnore annotation

2018-01-21 Thread Paul Gerver
Hello,

With Beam 2.2 it looks like the TestPipeline now serializes options before
giving them to the parent Pipeline to run (in order to utilize runtime
options). I have some options that were marked with the `JsonIgnore`
annotation which now seem to be getting dropped for my runner.

Is there something I'm missing which would allow me to skip this
serialization piece in the TestPipeline? If not, this seems like a side
effect of 2.2.

Let me know!

Thanks,
-- 
*Paul Gerver*