Re: ULR Tests on commit?

2018-12-12 Thread Robert Burke
Woohoo! Thanks for the info.

On Wed, Dec 12, 2018, 2:26 PM Daniel Oliveira 
wrote:

> Yeah, this is in-progress. The tests should get in for various languages
> throughout the next two weeks and I'll add them to the PR template as I add
> them.
>
> I do have a JIRA for tracking (BEAM-5449
> ) but I
> haven't been updating it regularly. I'll try to keep it updated.
>
> On Wed, Dec 12, 2018 at 11:03 AM Scott Wegner  wrote:
>
>> +Daniel Oliveira  who has been working on the
>> ULR.
>>
>> I believe this is in-progress. Dan, do you have a JIRA for tracking?
>>
>> On Wed, Dec 12, 2018 at 10:08 AM Robert Burke  wrote:
>>
>>> In our auto populated github PR template, we have a variety of SDK
>>> languages to runner combos, but the Universal Local Runner (ULR) is absent.
>>>
>>> Do we currently run tests on the ULR as pre-commit or post commit? If
>>> not, why not?
>>>
>>> If so, can we add a ULR column to the PR template?
>>>
>>> Mostly curious. Thanks!
>>> Robert Burke
>>> @lostluck, distributed gopher wrangler
>>>
>>
>>
>> --
>>
>>
>>
>>
>> Got feedback? tinyurl.com/swegner-feedback
>>
>


Re: ULR Tests on commit?

2018-12-12 Thread Daniel Oliveira
Yeah, this is in-progress. The tests should get in for various languages
throughout the next two weeks and I'll add them to the PR template as I add
them.

I do have a JIRA for tracking (BEAM-5449
) but I haven't
been updating it regularly. I'll try to keep it updated.

On Wed, Dec 12, 2018 at 11:03 AM Scott Wegner  wrote:

> +Daniel Oliveira  who has been working on the ULR.
>
> I believe this is in-progress. Dan, do you have a JIRA for tracking?
>
> On Wed, Dec 12, 2018 at 10:08 AM Robert Burke  wrote:
>
>> In our auto populated github PR template, we have a variety of SDK
>> languages to runner combos, but the Universal Local Runner (ULR) is absent.
>>
>> Do we currently run tests on the ULR as pre-commit or post commit? If
>> not, why not?
>>
>> If so, can we add a ULR column to the PR template?
>>
>> Mostly curious. Thanks!
>> Robert Burke
>> @lostluck, distributed gopher wrangler
>>
>
>
> --
>
>
>
>
> Got feedback? tinyurl.com/swegner-feedback
>


Re: ULR Tests on commit?

2018-12-12 Thread Scott Wegner
+Daniel Oliveira  who has been working on the ULR.

I believe this is in-progress. Dan, do you have a JIRA for tracking?

On Wed, Dec 12, 2018 at 10:08 AM Robert Burke  wrote:

> In our auto populated github PR template, we have a variety of SDK
> languages to runner combos, but the Universal Local Runner (ULR) is absent.
>
> Do we currently run tests on the ULR as pre-commit or post commit? If not,
> why not?
>
> If so, can we add a ULR column to the PR template?
>
> Mostly curious. Thanks!
> Robert Burke
> @lostluck, distributed gopher wrangler
>


-- 




Got feedback? tinyurl.com/swegner-feedback


ULR Tests on commit?

2018-12-12 Thread Robert Burke
In our auto populated github PR template, we have a variety of SDK
languages to runner combos, but the Universal Local Runner (ULR) is absent.

Do we currently run tests on the ULR as pre-commit or post commit? If not,
why not?

If so, can we add a ULR column to the PR template?

Mostly curious. Thanks!
Robert Burke
@lostluck, distributed gopher wrangler