Re: 4.7.0 Release

2018-04-03 Thread Enrico Olivelli
Il mar 3 apr 2018, 21:36 Sijie Guo  ha scritto:

> Hi all,
>
> I am going to create branch-4.7 and start the 4.7.0 release process this
> week. If you have any issues need to be included at 4.7.0, please label
> them as 4.7.0.
>

Sounds good
No request from my part.

Maybe it would be useful to add some doc about digest autodetection and an
help to switch to CRC32C.

The other point on docs is about config changes and the new URI based
configuration

New client API is becoming stable but I would wait for 4.8 before an
official launch as preferred API.

Cheers
Enrico



> - Sijie
>
-- 


-- Enrico Olivelli


4.7.0 Release

2018-04-03 Thread Sijie Guo
Hi all,

I am going to create branch-4.7 and start the 4.7.0 release process this
week. If you have any issues need to be included at 4.7.0, please label
them as 4.7.0.

- Sijie


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #2

2018-04-03 Thread Enrico Olivelli
+1 (binding)

- Run manually basic tests with local bookie (on Fedora, with jdk8)
- Packaged bookkeeper-server.jar into real application (with known java9
issues with BK) and run cleanly on jdk10
- Verified artifacts and signatures on staging repository


Enrico


2018-04-03 15:17 GMT+02:00 Ivan Kelly :

> +1 lgtm
>
> RAT, FINDBUGS & TESTS:
>
> Runs cleanly. I had -Dsurefire.rerunFailingTestsCount=2 set, but I
> don't think anything even flaked.
>
> Minor issue: Vertx http tests expect 8080 to be free
>
> SHA1 & SIGs:
>
> Good.
>
> LICENSE & NOTICE:
>
> Nothing changed since 4.6.1, so looks good.
>
> Minor: Copyright in notice should include 2018
>
> -Ivan
>
> On Tue, Apr 3, 2018 at 1:57 PM, Enrico Olivelli 
> wrote:
> > Hi everyone,
> > Please review and vote on the release candidate #2 for the version 4.6.2,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "release-4.6.2" [4] with git sha
> > f142315ec18deec84cd2acf28aa4a8a932b24baf
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Enrico Olivelli
> >
> > [1] https://github.com/apache/bookkeeper/pull/1297/
> > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/
> bookkeeper-4.6.2-rc2/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachebookkeeper-1026/
> > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
>


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #2

2018-04-03 Thread Ivan Kelly
+1 lgtm

RAT, FINDBUGS & TESTS:

Runs cleanly. I had -Dsurefire.rerunFailingTestsCount=2 set, but I
don't think anything even flaked.

Minor issue: Vertx http tests expect 8080 to be free

SHA1 & SIGs:

Good.

LICENSE & NOTICE:

Nothing changed since 4.6.1, so looks good.

Minor: Copyright in notice should include 2018

-Ivan

On Tue, Apr 3, 2018 at 1:57 PM, Enrico Olivelli  wrote:
> Hi everyone,
> Please review and vote on the release candidate #2 for the version 4.6.2,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "release-4.6.2" [4] with git sha
> f142315ec18deec84cd2acf28aa4a8a932b24baf
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Enrico Olivelli
>
> [1] https://github.com/apache/bookkeeper/pull/1297/
> [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.2-rc2/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1026/
> [4] https://github.com/apache/bookkeeper/commits/release-4.6.2


[VOTE] Apache BookKeeper Release 4.6.2, release candidate #2

2018-04-03 Thread Enrico Olivelli
Hi everyone,
Please review and vote on the release candidate #2 for the version 4.6.2,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "release-4.6.2" [4] with git sha
f142315ec18deec84cd2acf28aa4a8a932b24baf

BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think
it is important to a release.

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Enrico Olivelli

[1] https://github.com/apache/bookkeeper/pull/1297/
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.2-rc2/
[3]
https://repository.apache.org/content/repositories/orgapachebookkeeper-1026/
[4] https://github.com/apache/bookkeeper/commits/release-4.6.2


Re: Old DistributedLog 0.5.0 RC1 on dist.apache.org

2018-04-03 Thread Enrico Olivelli
2018-04-03 13:48 GMT+02:00 Ivan Kelly :

> Kill it. If 0.5.0 is out, then it serves no purpose.
>


Dropped

Enrico


>
> -Ivan
>
>
> On Tue, Apr 3, 2018 at 1:36 PM, Enrico Olivelli 
> wrote:
> > Hi,
> > there is this old directory
> > https://dist.apache.org/repos/dist/dev/bookkeeper/
> distributedlog/0.5.0-rc1/
> >
> > can I drop it ?
> > I think Jia left it during the release process of 0.5.0
> >
> > Enrico
>


Re: Old DistributedLog 0.5.0 RC1 on dist.apache.org

2018-04-03 Thread Ivan Kelly
Kill it. If 0.5.0 is out, then it serves no purpose.

-Ivan


On Tue, Apr 3, 2018 at 1:36 PM, Enrico Olivelli  wrote:
> Hi,
> there is this old directory
> https://dist.apache.org/repos/dist/dev/bookkeeper/distributedlog/0.5.0-rc1/
>
> can I drop it ?
> I think Jia left it during the release process of 0.5.0
>
> Enrico


Old DistributedLog 0.5.0 RC1 on dist.apache.org

2018-04-03 Thread Enrico Olivelli
Hi,
there is this old directory
https://dist.apache.org/repos/dist/dev/bookkeeper/distributedlog/0.5.0-rc1/

can I drop it ?
I think Jia left it during the release process of 0.5.0

Enrico


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Ivan Kelly
On Tue, Apr 3, 2018 at 12:48 PM, Enrico Olivelli  wrote:
> We found an issue and this is the fix
> https://github.com/apache/bookkeeper/pull/1312
>
> Will send a new RC as soon as the patch is merged to branch-4.6

Taking a look.

-Ivan


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Ivan Kelly
> I cannot check on the 4.6.0 one because we are only keeping the latest
> version on dist.apache.org

archive.apache.org has older releases.

-Ivan


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Enrico Olivelli
We found an issue and this is the fix
https://github.com/apache/bookkeeper/pull/1312

Will send a new RC as soon as the patch is merged to branch-4.6

Enrico



2018-04-03 12:21 GMT+02:00 Enrico Olivelli :

>
>
> 2018-04-03 12:14 GMT+02:00 Enrico Olivelli :
>
>>
>>
>> 2018-04-03 12:02 GMT+02:00 Ivan Kelly :
>>
>>> Hey Enrico,
>>>
>>> Thanks for putting the release together. I'm afraid there's an issue
>>> with the source package though.
>>>
>>> ~/blah/4.6.2-rc1 $ ls -l bookkeeper-4.6.2/bookkeeper-server/bin
>>> total 20
>>> -rw-r--r-- 1 ivan ivan 7364 Mar 28 09:24 bookkeeper
>>> -rw-r--r-- 1 ivan ivan 2869 Mar 28 09:24 bookkeeper-cluster.sh
>>> -rw-r--r-- 1 ivan ivan 4357 Mar 28 09:24 bookkeeper-daemon.sh
>>>
>>> This also makes some tests fail (the rack awareness with script one).
>>>
>>> So, a -1 from me, for the package that's up there.
>>>
>>> Otherwise everything else was looking good. I may not even need to cut
>>> a new RC though, since this looks like a package generation issue, not
>>> something that needs to be in the branch. Did you generate on a fat32
>>> filesystem or something?
>>>
>>
>>
>> I am using my "usual" Linux Fedora box with ext4
>>
>> On "binary distribution package"  bookkeeper-server-4.6.2-bin.tar.gz
>> 
>> permissions are okay.
>> I confirm that on the staged version I can reproduce your issue.
>>
>> I am canceling this vote now, I will be back with a new RC very soon.
>>
>> I will start a new email thread about this problem if I can resolve it
>> locally.
>>
>> Thank you
>>
>
>
> @Ivan
> The same problem is with the current 4.6.1 released src distribution.
>
> I think we are hitting a similar problem to the one on current master.
>
> I cannot check on the 4.6.0 one because we are only keeping the latest
> version on dist.apache.org
>
> Enrico
>
>
>
>
>>
>> Enrico
>>
>>
>>
>>
>>> Cheers,
>>> Ivan
>>>
>>> On Tue, Apr 3, 2018 at 9:26 AM, Enrico Olivelli 
>>> wrote:
>>> > Hi everyone,
>>> > Please review and vote on the release candidate #1 for the version
>>> 4.6.2,
>>> > as follows:
>>> > [ ] +1, Approve the release
>>> > [ ] -1, Do not approve the release (please provide specific comments)
>>> >
>>> > The complete staging area is available for your review, which includes:
>>> > * Release notes [1]
>>> > * The official Apache source and binary distributions to be deployed to
>>> > dist.apache.org [2]
>>> > * All artifacts to be deployed to the Maven Central Repository [3]
>>> > * Source code tag "release-4.6.2" [4] with git sha
>>> > 70c613f1700d4c19e36c10b5b51e841b138569fb
>>> >
>>> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
>>> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>> >
>>> > Please download these packages and review this release candidate:
>>> >
>>> > - Review release notes
>>> > - Download the source package (verify shasum, and asc) and follow the
>>> > instructions to build and run the bookkeeper service.
>>> > - Download the binary package (verify shasum, and asc) and follow the
>>> > instructions to run the bookkeeper service.
>>> > - Review maven repo, release tag, licenses, and any other things you
>>> think
>>> > it is important to a release.
>>> >
>>> > The vote will be open for at least 72 hours. It is adopted by majority
>>> > approval, with at least 3 PMC affirmative votes.
>>> >
>>> > Thanks,
>>> > Enrico Olivelli
>>> >
>>> > [1] https://github.com/apache/bookkeeper/pull/1297/
>>> > [2]
>>> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper
>>> /bookkeeper-4.6.2-rc1/
>>> > [3]
>>> > https://repository.apache.org/content/repositories/orgapache
>>> bookkeeper-1025/
>>> > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
>>>
>>
>>
>


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Enrico Olivelli
2018-04-03 12:14 GMT+02:00 Enrico Olivelli :

>
>
> 2018-04-03 12:02 GMT+02:00 Ivan Kelly :
>
>> Hey Enrico,
>>
>> Thanks for putting the release together. I'm afraid there's an issue
>> with the source package though.
>>
>> ~/blah/4.6.2-rc1 $ ls -l bookkeeper-4.6.2/bookkeeper-server/bin
>> total 20
>> -rw-r--r-- 1 ivan ivan 7364 Mar 28 09:24 bookkeeper
>> -rw-r--r-- 1 ivan ivan 2869 Mar 28 09:24 bookkeeper-cluster.sh
>> -rw-r--r-- 1 ivan ivan 4357 Mar 28 09:24 bookkeeper-daemon.sh
>>
>> This also makes some tests fail (the rack awareness with script one).
>>
>> So, a -1 from me, for the package that's up there.
>>
>> Otherwise everything else was looking good. I may not even need to cut
>> a new RC though, since this looks like a package generation issue, not
>> something that needs to be in the branch. Did you generate on a fat32
>> filesystem or something?
>>
>
>
> I am using my "usual" Linux Fedora box with ext4
>
> On "binary distribution package"  bookkeeper-server-4.6.2-bin.tar.gz
> 
> permissions are okay.
> I confirm that on the staged version I can reproduce your issue.
>
> I am canceling this vote now, I will be back with a new RC very soon.
>
> I will start a new email thread about this problem if I can resolve it
> locally.
>
> Thank you
>


@Ivan
The same problem is with the current 4.6.1 released src distribution.

I think we are hitting a similar problem to the one on current master.

I cannot check on the 4.6.0 one because we are only keeping the latest
version on dist.apache.org

Enrico




>
> Enrico
>
>
>
>
>> Cheers,
>> Ivan
>>
>> On Tue, Apr 3, 2018 at 9:26 AM, Enrico Olivelli 
>> wrote:
>> > Hi everyone,
>> > Please review and vote on the release candidate #1 for the version
>> 4.6.2,
>> > as follows:
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> > * Release notes [1]
>> > * The official Apache source and binary distributions to be deployed to
>> > dist.apache.org [2]
>> > * All artifacts to be deployed to the Maven Central Repository [3]
>> > * Source code tag "release-4.6.2" [4] with git sha
>> > 70c613f1700d4c19e36c10b5b51e841b138569fb
>> >
>> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
>> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>> >
>> > Please download these packages and review this release candidate:
>> >
>> > - Review release notes
>> > - Download the source package (verify shasum, and asc) and follow the
>> > instructions to build and run the bookkeeper service.
>> > - Download the binary package (verify shasum, and asc) and follow the
>> > instructions to run the bookkeeper service.
>> > - Review maven repo, release tag, licenses, and any other things you
>> think
>> > it is important to a release.
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PMC affirmative votes.
>> >
>> > Thanks,
>> > Enrico Olivelli
>> >
>> > [1] https://github.com/apache/bookkeeper/pull/1297/
>> > [2]
>> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper
>> /bookkeeper-4.6.2-rc1/
>> > [3]
>> > https://repository.apache.org/content/repositories/orgapache
>> bookkeeper-1025/
>> > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
>>
>
>


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Enrico Olivelli
2018-04-03 12:02 GMT+02:00 Ivan Kelly :

> Hey Enrico,
>
> Thanks for putting the release together. I'm afraid there's an issue
> with the source package though.
>
> ~/blah/4.6.2-rc1 $ ls -l bookkeeper-4.6.2/bookkeeper-server/bin
> total 20
> -rw-r--r-- 1 ivan ivan 7364 Mar 28 09:24 bookkeeper
> -rw-r--r-- 1 ivan ivan 2869 Mar 28 09:24 bookkeeper-cluster.sh
> -rw-r--r-- 1 ivan ivan 4357 Mar 28 09:24 bookkeeper-daemon.sh
>
> This also makes some tests fail (the rack awareness with script one).
>
> So, a -1 from me, for the package that's up there.
>
> Otherwise everything else was looking good. I may not even need to cut
> a new RC though, since this looks like a package generation issue, not
> something that needs to be in the branch. Did you generate on a fat32
> filesystem or something?
>


I am using my "usual" Linux Fedora box with ext4

On "binary distribution package"  bookkeeper-server-4.6.2-bin.tar.gz

permissions are okay.
I confirm that on the staged version I can reproduce your issue.

I am canceling this vote now, I will be back with a new RC very soon.

I will start a new email thread about this problem if I can resolve it
locally.

Thank you

Enrico




> Cheers,
> Ivan
>
> On Tue, Apr 3, 2018 at 9:26 AM, Enrico Olivelli 
> wrote:
> > Hi everyone,
> > Please review and vote on the release candidate #1 for the version 4.6.2,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "release-4.6.2" [4] with git sha
> > 70c613f1700d4c19e36c10b5b51e841b138569fb
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Enrico Olivelli
> >
> > [1] https://github.com/apache/bookkeeper/pull/1297/
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/
> bookkeeper/bookkeeper-4.6.2-rc1/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachebookkeeper-1025/
> > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
>


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Ivan Kelly
Hey Enrico,

Thanks for putting the release together. I'm afraid there's an issue
with the source package though.

~/blah/4.6.2-rc1 $ ls -l bookkeeper-4.6.2/bookkeeper-server/bin
total 20
-rw-r--r-- 1 ivan ivan 7364 Mar 28 09:24 bookkeeper
-rw-r--r-- 1 ivan ivan 2869 Mar 28 09:24 bookkeeper-cluster.sh
-rw-r--r-- 1 ivan ivan 4357 Mar 28 09:24 bookkeeper-daemon.sh

This also makes some tests fail (the rack awareness with script one).

So, a -1 from me, for the package that's up there.

Otherwise everything else was looking good. I may not even need to cut
a new RC though, since this looks like a package generation issue, not
something that needs to be in the branch. Did you generate on a fat32
filesystem or something?

Cheers,
Ivan

On Tue, Apr 3, 2018 at 9:26 AM, Enrico Olivelli  wrote:
> Hi everyone,
> Please review and vote on the release candidate #1 for the version 4.6.2,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "release-4.6.2" [4] with git sha
> 70c613f1700d4c19e36c10b5b51e841b138569fb
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Enrico Olivelli
>
> [1] https://github.com/apache/bookkeeper/pull/1297/
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper/bookkeeper-4.6.2-rc1/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1025/
> [4] https://github.com/apache/bookkeeper/commits/release-4.6.2


[VOTE] Apache BookKeeper Release 4.6.2, release candidate #1

2018-04-03 Thread Enrico Olivelli
Hi everyone,
Please review and vote on the release candidate #1 for the version 4.6.2,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "release-4.6.2" [4] with git sha
70c613f1700d4c19e36c10b5b51e841b138569fb

BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS

Please download these packages and review this release candidate:

- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think
it is important to a release.

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Enrico Olivelli

[1] https://github.com/apache/bookkeeper/pull/1297/
[2]
https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper/bookkeeper-4.6.2-rc1/
[3]
https://repository.apache.org/content/repositories/orgapachebookkeeper-1025/
[4] https://github.com/apache/bookkeeper/commits/release-4.6.2


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #0

2018-04-03 Thread Enrico Olivelli
-1

I am cancelling this vote due to a problem in a signature file

As Jia has pointed you bookkeeper-server-4.6.2-bin.tar.gz.asc

does not contain a "detached signature" but the whole file + the signature.

I will send a new RC package very soon

Thank you
Enrico


2018-04-03 9:17 GMT+02:00 Sijie Guo :

> On Tue, Apr 3, 2018 at 12:07 AM, Enrico Olivelli 
> wrote:
>
> > 2018-04-03 4:13 GMT+02:00 Jia Zhai :
> >
> > > Hi Enrico,
> > > Thanks for the work. Seems this asc file has some error:
> > > https://dist.apache.org/repos/dist/dev/bookkeeper/
> > > bookkeeper/bookkeeper-4.6.2-rc0/bookkeeper-server-4.6.2-bin.tar.gz.asc
> > >
> > >
> >
> > That was was not generated automatically. I used the wrong command and
> > actually now it contains the whole file + the signature.
> >
> > I don't know which is the best procedure.
> >
> > Should I roll a new RC or simply update the .asc file ?
>
>
> You need to cancel this vote. but you don't need to redo the whole process.
>
> - cancel this vote.
> - bump rc0 to rc1
> - upload to bookkeeper-rc1 with new packages
> - call a new vote.
>
>
> >
>
>
> > Enrico
> >
> >
> > > Thanks.
> > > -Jia
> > >
> > > On Wed, Mar 28, 2018 at 11:23 PM, Enrico Olivelli  >
> > > wrote:
> > >
> > > > +1 (binding)
> > > > - run tests (on jdk8, linux Fedora 26)
> > > > - run bookie (single machine cluster) on jdk10+fedora 26 and run
> simple
> > > > tests from bookkeeper shell
> > > > - tested on staging environments with jdk9+CentOS7 (machines which
> > > reported
> > > > request/response corruptions with 4.6.1)
> > > >
> > > > Enrico
> > > >
> > > >
> > > >
> > > > 2018-03-28 10:35 GMT+02:00 Enrico Olivelli :
> > > >
> > > > > Hi everyone,
> > > > > Please review and vote on the release candidate #0 for the version
> > > 4.6.2,
> > > > > as follows:
> > > > > [ ] +1, Approve the release
> > > > > [ ] -1, Do not approve the release (please provide specific
> comments)
> > > > >
> > > > > The complete staging area is available for your review, which
> > includes:
> > > > > * Release notes [1]
> > > > > * The official Apache source and binary distributions to be
> deployed
> > to
> > > > > dist.apache.org [2]
> > > > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > > > * Source code tag "release-4.6.2" [4] with git sha
> > > > > 70c613f1700d4c19e36c10b5b51e841b138569fb
> > > > >
> > > > > BookKeeper's KEYS file contains PGP keys we used to sign this
> > release:
> > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > > > >
> > > > > Please download these packages and review this release candidate:
> > > > >
> > > > > - Review release notes
> > > > > - Download the source package (verify md5, shasum, and asc) and
> > follow
> > > > the
> > > > > instructions to build and run the bookkeeper service.
> > > > > - Download the binary package (verify md5, shasum, and asc) and
> > follow
> > > > the
> > > > > instructions to run the bookkeeper service.
> > > > > - Review maven repo, release tag, licenses, and any other things
> you
> > > > think
> > > > > it is important to a release.
> > > > >
> > > > > The vote will be open for at least 72 hours. It is adopted by
> > majority
> > > > > approval, with at least 3 PMC affirmative votes.
> > > > >
> > > > > Thanks,
> > > > > Enrico Olivelli
> > > > >
> > > > > [1] https://github.com/apache/bookkeeper/pull/1297/
> > > > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/
> > > > > bookkeeper/bookkeeper-4.6.2-rc0/
> > > > > [3] https://repository.apache.org/content/repositories/
> > > > > orgapachebookkeeper-1025/
> > > > > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
> > > > >
> > > > >
> > > >
> > >
> >
>


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #0

2018-04-03 Thread Sijie Guo
On Tue, Apr 3, 2018 at 12:07 AM, Enrico Olivelli 
wrote:

> 2018-04-03 4:13 GMT+02:00 Jia Zhai :
>
> > Hi Enrico,
> > Thanks for the work. Seems this asc file has some error:
> > https://dist.apache.org/repos/dist/dev/bookkeeper/
> > bookkeeper/bookkeeper-4.6.2-rc0/bookkeeper-server-4.6.2-bin.tar.gz.asc
> >
> >
>
> That was was not generated automatically. I used the wrong command and
> actually now it contains the whole file + the signature.
>
> I don't know which is the best procedure.
>
> Should I roll a new RC or simply update the .asc file ?


You need to cancel this vote. but you don't need to redo the whole process.

- cancel this vote.
- bump rc0 to rc1
- upload to bookkeeper-rc1 with new packages
- call a new vote.


>


> Enrico
>
>
> > Thanks.
> > -Jia
> >
> > On Wed, Mar 28, 2018 at 11:23 PM, Enrico Olivelli 
> > wrote:
> >
> > > +1 (binding)
> > > - run tests (on jdk8, linux Fedora 26)
> > > - run bookie (single machine cluster) on jdk10+fedora 26 and run simple
> > > tests from bookkeeper shell
> > > - tested on staging environments with jdk9+CentOS7 (machines which
> > reported
> > > request/response corruptions with 4.6.1)
> > >
> > > Enrico
> > >
> > >
> > >
> > > 2018-03-28 10:35 GMT+02:00 Enrico Olivelli :
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #0 for the version
> > 4.6.2,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * Release notes [1]
> > > > * The official Apache source and binary distributions to be deployed
> to
> > > > dist.apache.org [2]
> > > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > > * Source code tag "release-4.6.2" [4] with git sha
> > > > 70c613f1700d4c19e36c10b5b51e841b138569fb
> > > >
> > > > BookKeeper's KEYS file contains PGP keys we used to sign this
> release:
> > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > > >
> > > > Please download these packages and review this release candidate:
> > > >
> > > > - Review release notes
> > > > - Download the source package (verify md5, shasum, and asc) and
> follow
> > > the
> > > > instructions to build and run the bookkeeper service.
> > > > - Download the binary package (verify md5, shasum, and asc) and
> follow
> > > the
> > > > instructions to run the bookkeeper service.
> > > > - Review maven repo, release tag, licenses, and any other things you
> > > think
> > > > it is important to a release.
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Enrico Olivelli
> > > >
> > > > [1] https://github.com/apache/bookkeeper/pull/1297/
> > > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/
> > > > bookkeeper/bookkeeper-4.6.2-rc0/
> > > > [3] https://repository.apache.org/content/repositories/
> > > > orgapachebookkeeper-1025/
> > > > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
> > > >
> > > >
> > >
> >
>


Re: [VOTE] Apache BookKeeper Release 4.6.2, release candidate #0

2018-04-03 Thread Enrico Olivelli
2018-04-03 4:13 GMT+02:00 Jia Zhai :

> Hi Enrico,
> Thanks for the work. Seems this asc file has some error:
> https://dist.apache.org/repos/dist/dev/bookkeeper/
> bookkeeper/bookkeeper-4.6.2-rc0/bookkeeper-server-4.6.2-bin.tar.gz.asc
>
>

That was was not generated automatically. I used the wrong command and
actually now it contains the whole file + the signature.

I don't know which is the best procedure.

Should I roll a new RC or simply update the .asc file ?

Enrico


> Thanks.
> -Jia
>
> On Wed, Mar 28, 2018 at 11:23 PM, Enrico Olivelli 
> wrote:
>
> > +1 (binding)
> > - run tests (on jdk8, linux Fedora 26)
> > - run bookie (single machine cluster) on jdk10+fedora 26 and run simple
> > tests from bookkeeper shell
> > - tested on staging environments with jdk9+CentOS7 (machines which
> reported
> > request/response corruptions with 4.6.1)
> >
> > Enrico
> >
> >
> >
> > 2018-03-28 10:35 GMT+02:00 Enrico Olivelli :
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #0 for the version
> 4.6.2,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed to
> > > dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "release-4.6.2" [4] with git sha
> > > 70c613f1700d4c19e36c10b5b51e841b138569fb
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify md5, shasum, and asc) and follow
> > the
> > > instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify md5, shasum, and asc) and follow
> > the
> > > instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > think
> > > it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Enrico Olivelli
> > >
> > > [1] https://github.com/apache/bookkeeper/pull/1297/
> > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/
> > > bookkeeper/bookkeeper-4.6.2-rc0/
> > > [3] https://repository.apache.org/content/repositories/
> > > orgapachebookkeeper-1025/
> > > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
> > >
> > >
> >
>