Re: [VOTE] Release 4.9.1, release candidate #0

2019-04-04 Thread Ivan Kelly 
Sorry about the delay on getting to this, Enrico.

+1 (binding)

 ✓ tag matches sha
 ✓ check sha512
 ✓ check gpg
 ✓ test licenses
 ✓ rat check
 ✓ compile -src
 ✓ spotbugs
 ✓ build tag
 ✓ compiled tag matches -src
 ✓ maven artifacts sigs are correct
 ✓ unit tests
 ✓ integration tests

A few minor non-blocking things:
- The tag isn't signed which may be a good thing to add to the process.
- Building from -src, results in 2 maven artifacts that are not pushed to nexus,
  * 
./org/apache/bookkeeper/bookkeeper-server/4.9.1/bookkeeper-server-4.9.1-javadoc.jar
  * 
./org/apache/bookkeeper/stats/bookkeeper-stats-api/4.9.1/bookkeeper-stats-api-4.9.1-javadoc.jar

-Ivan

Re: [VOTE] Release 4.9.1, release candidate #0

2019-04-04 Thread Jia Zhai 
+1 (binding)

Environment: macOS 10.14.2

- verified 4 packages checksum ( asc and sha all good)

- the source package build and test all run successfully.

- in both binary package(server & all), 'bin/bookkeeper standalone' and
'bin/bookkeeper shell bookiesanity' runs well.


Best Regards.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Tue, Apr 2, 2019 at 5:50 AM Enrico Olivelli  wrote:

> Up
>
> Il mer 27 mar 2019, 15:14 Enrico Olivelli  ha
> scritto:
>
> > Please take a look
> >
> > Enrico
> >
> > Il gio 21 mar 2019, 23:43 Enrico Olivelli  ha
> > scritto:
> >
> >> Hi everyone,
> >> Please review and vote on the release candidate #0 for the version
> >> 4.9.1, as follows:
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >> The complete staging area is available for your review, which includes:
> >> * Release notes [1]
> >> * The official Apache source and binary distributions to be deployed
> >> to dist.apache.org [2]
> >> * All artifacts to be deployed to the Maven Central Repository [3]
> >> * Source code tag "v4.9.1-rc0" [4] with git sha
> >> c053b81be43845122a0627f12e1cf7e08330a3c5
> >>
> >> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> >> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >>
> >> Please download these packages and review this release candidate:
> >>
> >> - Review release notes
> >> - Download the source package (verify shasum, and asc) and follow the
> >> instructions to build and run the bookkeeper service.
> >> - Download the binary package (verify shasum, and asc) and follow the
> >> instructions to run the bookkeeper service.
> >> - Review maven repo, release tag, licenses, and any other things you
> think
> >> it is important to a release.
> >>
> >> The vote will be open for at least 72 hours. It is adopted by majority
> >> approval, with at least 3 PMC affirmative votes.
> >>
> >> Thanks,
> >> Enrico Olivelli
> >>
> >> [1]
> >>
> https://github.com/apache/bookkeeper/pull/1992/commits/e24b8f98c0c435a0bba9dda0e4c37d9e88107187
> >> [2]
> >> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.1-rc0/
> >> [3]
> >>
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1040/
> >> [4] https://github.com/apache/bookkeeper/tree/v4.9.1-rc0
> >>
> >
>