[GitHub] eolivelli commented on issue #313: Issue 300: EnsemblePlacementPolicy must not use com.google.common.base.Optional but java.util.Optional

2017-07-28 Thread git
eolivelli commented on issue #313: Issue 300: EnsemblePlacementPolicy must not 
use com.google.common.base.Optional but java.util.Optional
URL: https://github.com/apache/bookkeeper/pull/313#issuecomment-318600828
 
 
   we can go with your patch if you prefer @merlimat already approved my pr and 
it is ready for merge
   you addressed checkstyle too, maybe your patch is better
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] eolivelli commented on issue #313: Issue 300: EnsemblePlacementPolicy must not use com.google.common.base.Optional but java.util.Optional

2017-07-28 Thread git
eolivelli commented on issue #313: Issue 300: EnsemblePlacementPolicy must not 
use com.google.common.base.Optional but java.util.Optional
URL: https://github.com/apache/bookkeeper/pull/313#issuecomment-318600647
 
 
   @zhaijack 
   I have already sent a PR #302
   I am sorry for this duplicate work
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services