[jira] [Commented] (BOOKKEEPER-759) bookkeeper: delay ensemble change if it doesn't break ack quorum requirement
[ https://issues.apache.org/jira/browse/BOOKKEEPER-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070148#comment-16070148 ] Hudson commented on BOOKKEEPER-759: --- FAILURE: Integrated in Jenkins build bookkeeper-master #1801 (See [https://builds.apache.org/job/bookkeeper-master/1801/]) BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble Change (sijie: [https://github.com/apache/bookkeeper/commit/5e399df67c2aa1e5f228c62ba8533ca3293ab147]) * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingWriteLacOp.java * (add) bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestDisableEnsembleChange.java * (edit) bookkeeper-server/src/test/java/org/apache/bookkeeper/client/RoundRobinDistributionScheduleTest.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java * (add) bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestDelayEnsembleChange.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/util/BookKeeperConstants.java * (edit) bookkeeper-server/src/test/resources/log4j.properties * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java * (edit) bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadLacOp.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RoundRobinDistributionSchedule.java * (edit) bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java * (edit) bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java > bookkeeper: delay ensemble change if it doesn't break ack quorum requirement > > > Key: BOOKKEEPER-759 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-759 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-client >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.5.0 > > > flag to allow delay ensemble change. if that is set to change, will not do > ensemble change until it breaks ack quorum requirement -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BOOKKEEPER-759) bookkeeper: delay ensemble change if it doesn't break ack quorum requirement
[ https://issues.apache.org/jira/browse/BOOKKEEPER-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069081#comment-16069081 ] ASF GitHub Bot commented on BOOKKEEPER-759: --- Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/202 > bookkeeper: delay ensemble change if it doesn't break ack quorum requirement > > > Key: BOOKKEEPER-759 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-759 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-client >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.5.0 > > > flag to allow delay ensemble change. if that is set to change, will not do > ensemble change until it breaks ack quorum requirement -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BOOKKEEPER-759) bookkeeper: delay ensemble change if it doesn't break ack quorum requirement
[ https://issues.apache.org/jira/browse/BOOKKEEPER-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058542#comment-16058542 ] ASF GitHub Bot commented on BOOKKEEPER-759: --- GitHub user sijie opened a pull request: https://github.com/apache/bookkeeper/pull/202 BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble Change Descriptions of the changes in this PR: This pull request contains the changes around ensemble change. - Delay Ensemble Change: Provide a flag to allow delay ensemble change. if that is set to change, will not do ensemble change until it breaks ack quorum requirements. - Disable Ensemble Change: Provide a runtime feature flag to allow disabling ensemble change. The ensemble change behavior can be disabled on-the-fly via the FeatureProvider. --- Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `: Description of pull request` `e.g. Issue 123: Description ...` - [x] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`. - [x] Replace `` in the title with the actual Issue number, if there is one. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/bookkeeper client_changes/delay_ensemble_changes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bookkeeper/pull/202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #202 commit b75dbf32f0831457980d976c50bb1df1a26726de Author: Sijie GuoDate: 2014-03-11T23:09:38Z bookkeeper: delay ensemble change if it doesn't break ack quorum requirement - flag to allow delay ensemble change. if that is set to change, will not do ensemble change until it breaks ack quorum requirements - add test case for delaying ensemble changes. > bookkeeper: delay ensemble change if it doesn't break ack quorum requirement > > > Key: BOOKKEEPER-759 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-759 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-client >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.5.0 > > > flag to allow delay ensemble change. if that is set to change, will not do > ensemble change until it breaks ack quorum requirement -- This message was sent by Atlassian JIRA (v6.4.14#64029)