[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644293#comment-14644293 ] Hudson commented on BOOKKEEPER-760: --- SUCCESS: Integrated in bookkeeper-master #1133 (See [https://builds.apache.org/job/bookkeeper-master/1133/]) BOOKKEEPER-760: Don't close PCBC proactively if bookies disappeared from zookeeper znodes (sijie via fpj) (fpj: rev 8bf97fb5ba115b1d053bbc9a779335455e6926c5) * bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java * bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java * CHANGES.txt Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- Key: BOOKKEEPER-760 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-client Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.4.0 Attachments: BOOKKEEPER-760.diff, BOOKKEEPER-760.patch, BOOKKEEPER-760.v2.patch Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618147#comment-14618147 ] Sijie Guo commented on BOOKKEEPER-760: -- Yup. I attached a new patch to remove closeClients. re-kicking the QA now. Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- Key: BOOKKEEPER-760 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-client Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.4.0 Attachments: BOOKKEEPER-760.diff, BOOKKEEPER-760.patch, BOOKKEEPER-760.v2.patch Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618293#comment-14618293
]
Hadoop QA commented on BOOKKEEPER-760:
--
Testing JIRA BOOKKEEPER-760
Patch
[BOOKKEEPER-760.v2.patch|https://issues.apache.org/jira/secure/attachment/12744160/BOOKKEEPER-760.v2.patch]
downloaded at Wed Jul 8 08:59:11 UTC 2015
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 951
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/938/
Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
--
Key: BOOKKEEPER-760
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-client
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.4.0
Attachments: BOOKKEEPER-760.diff, BOOKKEEPER-760.patch,
BOOKKEEPER-760.v2.patch
Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619259#comment-14619259 ] Flavio Junqueira commented on BOOKKEEPER-760: - +1, looks good. The test failure is coming from jms and it's unrelated to this patch. If no one has an issue with it, I'll check this one in shortly. Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- Key: BOOKKEEPER-760 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-client Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.4.0 Attachments: BOOKKEEPER-760.diff, BOOKKEEPER-760.patch, BOOKKEEPER-760.v2.patch Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616262#comment-14616262 ] Sijie Guo commented on BOOKKEEPER-760: -- [~fpj] since you had comments in this jira before, could you review my comment above? Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- Key: BOOKKEEPER-760 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-client Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.4.0 Attachments: BOOKKEEPER-760.diff, BOOKKEEPER-760.patch Don't close PCBC proactively if bookies disappeared from zookeeper znodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358346#comment-14358346
]
Hadoop QA commented on BOOKKEEPER-760:
--
Testing JIRA BOOKKEEPER-760
Patch
[BOOKKEEPER-760.diff|https://issues.apache.org/jira/secure/attachment/12644375/BOOKKEEPER-760.diff]
downloaded at Thu Mar 12 08:30:24 UTC 2015
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1 FINDBUGS{color}
.{color:red}-1{color} the patch seems to introduce 1 new Findbugs
warning(s) in module(s) [bookkeeper-server]
{color:green}+1 TESTS{color}
.Tests run: 949
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/902/
Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
--
Key: BOOKKEEPER-760
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-760
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-client
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.4.0
Attachments: BOOKKEEPER-760.diff
Don't close PCBC proactively if bookies disappeared from zookeeper znodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
