[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965076#comment-14965076 ] Hudson commented on BOOKKEEPER-866: --- FAILURE: Integrated in bookkeeper-master #1170 (See [https://builds.apache.org/job/bookkeeper-master/1170/]) BOOKKEEPER-866: Fix compile issue when Updating junit to latest release (sijie: rev 8a3922e00d5fc3f82cb28ca032595b02db1a516e) * bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorBookieTest.java * CHANGES.txt * bookkeeper-server/src/test/java/org/apache/bookkeeper/zookeeper/TestZooKeeperClient.java * bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CookieTest.java * bookkeeper-server/pom.xml * bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTest.java * bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java * bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java * bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpdateCookieCmdTest.java * bookkeeper-server/src/test/java/org/apache/bookkeeper/client/UpdateLedgerCmdTest.java > Fix compile issue when Updating junit to latest release version( 4.12) in the > test of Bookkeeper-server. > - > > Key: BOOKKEEPER-866 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Reporter: Jia Zhai >Assignee: Jia Zhai > Labels: test > Fix For: 4.4.0 > > Attachments: BOOKKEEPER-866-2.patch, BOOKKEEPER-866.patch > > > When write test cases for BOOKKEEPER-865, It appears that current version of > junit could not support some new features well, such as Parameterized test. > Then we try to update junit to latest release version, but found " > junit.framework.Assert in junit.framework has been deprecated" . > So using this new ticket to trace this to make the objective more clear. > The fix is simple, > replace > import junit.framework.Assert; > to > import org.junit.Assert; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958545#comment-14958545
]
Hadoop QA commented on BOOKKEEPER-866:
--
Testing JIRA BOOKKEEPER-866
Patch
[BOOKKEEPER-866-2.patch|https://issues.apache.org/jira/secure/attachment/12766012/BOOKKEEPER-866-2.patch]
downloaded at Thu Oct 15 08:12:25 UTC 2015
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 8 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 526
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/961/
> Fix compile issue when Updating junit to latest release version( 4.12) in the
> test of Bookkeeper-server.
> -
>
> Key: BOOKKEEPER-866
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
>Reporter: Jia Zhai
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-866-2.patch, BOOKKEEPER-866.patch
>
>
> When write test cases for BOOKKEEPER-865, It appears that current version of
> junit could not support some new features well, such as Parameterized test.
> Then we try to update junit to latest release version, but found "
> junit.framework.Assert in junit.framework has been deprecated" .
> So using this new ticket to trace this to make the objective more clear.
> The fix is simple,
> replace
> import junit.framework.Assert;
> to
> import org.junit.Assert;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909756#comment-14909756
]
Jia Zhai commented on BOOKKEEPER-866:
-
For the first error, seem code in Junit is not working very well with
ZooKeeperUtil.sleepServer
{code}
FailOnTimeout.java
@Override
public void evaluate() throws Throwable {
CallableStatement callable = new CallableStatement();
FutureTask task = new FutureTask(callable);
threadGroup = new ThreadGroup("FailOnTimeoutGroup");
Thread thread = new Thread(threadGroup, task, "Time-limited test");
< ==
thread.setDaemon(true);
thread.start();
callable.awaitStarted();
Throwable throwable = getResult(task, thread);
if (throwable != null) {
throw throwable;
}
}
{code}
code of sleepServer()
{code}
public void sleepServer(final int seconds, final CountDownLatch l)
throws InterruptedException, IOException {
Thread[] allthreads = new Thread[Thread.activeCount()];
Thread.enumerate(allthreads);
< == Here could only get thread "Time-limited test", which
created by above code of junit.
for (final Thread t : allthreads) {
if (t.getName().contains("SyncThread:0")) {
Thread sleeper = new Thread() {
@SuppressWarnings("deprecation")
public void run() {
try {
t.suspend();
l.countDown();
Thread.sleep(seconds*1000);
t.resume();
} catch (Exception e) {
LOG.error("Error suspending thread", e);
}
}
};
sleeper.start();
return;
}
}
throw new IOException("ZooKeeper thread not found");< ===
so will not find wanted thread, and got this exception.
}
{code}
> Fix compile issue when Updating junit to latest release version( 4.12) in the
> test of Bookkeeper-server.
> -
>
> Key: BOOKKEEPER-866
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
>Reporter: Jia Zhai
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-866.patch
>
>
> When write test cases for BOOKKEEPER-865, It appears that current version of
> junit could not support some new features well, such as Parameterized test.
> Then we try to update junit to latest release version, but found "
> junit.framework.Assert in junit.framework has been deprecated" .
> So using this new ticket to trace this to make the objective more clear.
> The fix is simple,
> replace
> import junit.framework.Assert;
> to
> import org.junit.Assert;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909326#comment-14909326 ] Jia Zhai commented on BOOKKEEPER-866: - org.apache.bookkeeper.client.BookKeeperTest.testConstructionZkDelay[0] org.apache.bookkeeper.client.BookKeeperTest.testConstructionNotConnectedExplicitZk[0] org.apache.bookkeeper.client.BookKeeperTest.testConstructionZkDelay[1] org.apache.bookkeeper.client.BookKeeperTest.testConstructionNotConnectedExplicitZk[1] These 4 tests failed at here: java.io.IOException: ZooKeeper thread not found at org.apache.bookkeeper.test.ZooKeeperUtil.sleepServer(ZooKeeperUtil.java:134) org.apache.bookkeeper.zookeeper.TestZooKeeperClient.testReconnectAfterExipred this test failed at here: java.lang.NullPointerException at org.apache.bookkeeper.zookeeper.ZooWorker.syncCallWithRetries(ZooWorker.java:148) at org.apache.bookkeeper.zookeeper.ZooKeeperClient.exists(ZooKeeperClient.java:763) at org.apache.bookkeeper.zookeeper.TestZooKeeperClient.testReconnectAfterExipred(TestZooKeeperClient.java:165) suspect this is related to zookeeper or some changes in Junit. Will study more on them. > Fix compile issue when Updating junit to latest release version( 4.12) in the > test of Bookkeeper-server. > - > > Key: BOOKKEEPER-866 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Reporter: Jia Zhai >Assignee: Jia Zhai > Attachments: BOOKKEEPER-866.patch > > > When write test cases for BOOKKEEPER-865, It appears that current version of > junit could not support some new features well, such as Parameterized test. > Then we try to update junit to latest release version, but found " > junit.framework.Assert in junit.framework has been deprecated" . > So using this new ticket to trace this to make the objective more clear. > The fix is simple, > replace > import junit.framework.Assert; > to > import org.junit.Assert; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908923#comment-14908923 ] Jia Zhai commented on BOOKKEEPER-866: - The failed test case looks related to zookeeper, will investigate this. > Fix compile issue when Updating junit to latest release version( 4.12) in the > test of Bookkeeper-server. > - > > Key: BOOKKEEPER-866 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Reporter: Jia Zhai >Assignee: Jia Zhai > Attachments: BOOKKEEPER-866.patch > > > When write test cases for BOOKKEEPER-865, It appears that current version of > junit could not support some new features well, such as Parameterized test. > Then we try to update junit to latest release version, but found " > junit.framework.Assert in junit.framework has been deprecated" . > So using this new ticket to trace this to make the objective more clear. > The fix is simple, > replace > import junit.framework.Assert; > to > import org.junit.Assert; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14900115#comment-14900115 ] Jia Zhai commented on BOOKKEEPER-866: - It is strange that this change involved some test error: Test Result (失败) org.apache.bookkeeper.client.BookKeeperTest.testConstructionZkDelay[0] org.apache.bookkeeper.client.BookKeeperTest.testConstructionNotConnectedExplicitZk[0] org.apache.bookkeeper.client.BookKeeperTest.testConstructionZkDelay[1] org.apache.bookkeeper.client.BookKeeperTest.testConstructionNotConnectedExplicitZk[1] org.apache.bookkeeper.zookeeper.TestZooKeeperClient.testReconnectAfterExipred > Fix compile issue when Updating junit to latest release version( 4.12) in the > test of Bookkeeper-server. > - > > Key: BOOKKEEPER-866 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Reporter: Jia Zhai >Assignee: Jia Zhai > Attachments: BOOKKEEPER-866.patch > > > When write test cases for BOOKKEEPER-865, It appears that current version of > junit could not support some new features well, such as Parameterized test. > Then we try to update junit to latest release version, but found " > junit.framework.Assert in junit.framework has been deprecated" . > So using this new ticket to trace this to make the objective more clear. > The fix is simple, > replace > import junit.framework.Assert; > to > import org.junit.Assert; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733960#comment-14733960
]
Hadoop QA commented on BOOKKEEPER-866:
--
Testing JIRA BOOKKEEPER-866
Patch
[BOOKKEEPER-866.patch|https://issues.apache.org/jira/secure/attachment/12753285/BOOKKEEPER-866.patch]
downloaded at Mon Sep 7 17:27:10 UTC 2015
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 7 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 951
.Tests failed: 0
.Tests errors: 5
.The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/957/
> Fix compile issue when Updating junit to latest release version( 4.12) in the
> test of Bookkeeper-server.
> -
>
> Key: BOOKKEEPER-866
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
>Reporter: Jia Zhai
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-866.patch
>
>
> When write test cases for BOOKKEEPER-865, It appears that current version of
> junit could not support some new features well, such as Parameterized test.
> Then we try to update junit to latest release version, but found "
> junit.framework.Assert in junit.framework has been deprecated" .
> So using this new ticket to trace this to make the objective more clear.
> The fix is simple,
> replace
> import junit.framework.Assert;
> to
> import org.junit.Assert;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-866) Fix compile issue when Updating junit to latest release version( 4.12) in the test of Bookkeeper-server.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733970#comment-14733970 ] Sijie Guo commented on BOOKKEEPER-866: -- the patch looks good to me. +1 > Fix compile issue when Updating junit to latest release version( 4.12) in the > test of Bookkeeper-server. > - > > Key: BOOKKEEPER-866 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Reporter: Jia Zhai >Assignee: Jia Zhai > Attachments: BOOKKEEPER-866.patch > > > When write test cases for BOOKKEEPER-865, It appears that current version of > junit could not support some new features well, such as Parameterized test. > Then we try to update junit to latest release version, but found " > junit.framework.Assert in junit.framework has been deprecated" . > So using this new ticket to trace this to make the objective more clear. > The fix is simple, > replace > import junit.framework.Assert; > to > import org.junit.Assert; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
