Build failed in Jenkins: brooklyn-master-windows #145

2016-06-09 Thread Apache Jenkins Server
See 

--
[...truncated 30769 lines...]
  Run 6: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 7: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 8: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 9: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 10: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 11: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 12: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 13: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...


Tests run: 338, Failures: 1, Errors: 0, Skipped: 289

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 50.879 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.368 s]
[INFO] Brooklyn Parent Project  SUCCESS [  5.780 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  7.125 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  1.104 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 40.894 s]
[INFO] Brooklyn API ... SUCCESS [  3.822 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.657 s]
[INFO] CAMP Base .. SUCCESS [  5.564 s]
[INFO] Brooklyn Test Support .. SUCCESS [  3.997 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  3.810 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  1.382 s]
[INFO] CAMP Server  SUCCESS [ 10.771 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.950 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.785 s]
[INFO] Brooklyn Core .. SUCCESS [04:21 min]
[INFO] Brooklyn Policies .. SUCCESS [01:20 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [  9.702 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 11.161 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  0.999 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 26.403 s]
[INFO] Brooklyn Software Base . SUCCESS [01:27 min]
[INFO] Brooklyn CAMP REST API . FAILURE [ 53.635 s]
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] hello-world-webapp Maven Webapp 

Build failed in Jenkins: brooklyn-master-windows #144

2016-06-09 Thread Apache Jenkins Server
See 

--
[...truncated 20658 lines...]
2016-06-10 02:07:35,448 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2016-06-10 02:07:35,452 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 4 ms
2016-06-10 02:07:35,452 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.setUp()
SUREFIRE-859: [GC 523056K->285308K(775808K), 0.0349603 secs]
2016-06-10 02:07:35,727 WARN  Task 
Task[LSM.publish(TestEntityImpl{id=cbjl0apfq6}.Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1465520854587 / Fri Jun 10 02:07:34 BST 2016 @ 
1465520854587);[subscription-delivery-entity-cbjl0apfq6[TestEntityImpl{id=cbjl0apfq6}]]]@FFJbjdiw
 is being finalized before completion
2016-06-10 02:07:35,733 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.setUp() 
finished in 281 ms
2016-06-10 02:07:35,733 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.feed.ConfigToAttributesTest.testApplyTemplatedConfigWithEntity()
2016-06-10 02:07:35,757 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.feed.ConfigToAttributesTest.testApplyTemplatedConfigWithEntity()
 finished in 24 ms
2016-06-10 02:07:35,758 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.tearDown()
2016-06-10 02:07:35,860 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.tearDown() 
finished in 103 ms
2016-06-10 02:07:35,861 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.setUp()
2016-06-10 02:07:36,111 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.setUp() 
finished in 250 ms
2016-06-10 02:07:36,111 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.feed.ConfigToAttributesTest.testApplyTemplatedConfigWithManagementContext()
2016-06-10 02:07:36,113 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.feed.ConfigToAttributesTest.testApplyTemplatedConfigWithManagementContext()
 finished in 2 ms
2016-06-10 02:07:36,113 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.tearDown()
2016-06-10 02:07:36,222 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.core.feed.ConfigToAttributesTest.tearDown() 
finished in 109 ms
2016-06-10 02:07:36,433 INFO  TESTNG 
===
Surefire test
Tests run: 1743, Failures: 1, Skips: 1
===
2016-06-10 02:07:36,434 INFO  BrooklynLeakListener.onFinish attempting to 
terminate all extant ManagementContexts: name=Surefire test; includedGroups=[]; 
excludedGroups=[Integration, Live-sanity, Acceptance, Live, Broken, WIP]; 
suiteName=Surefire suite; 
outDir=F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\surefire-reports\Surefire
 suite: no org.apache.brooklyn.core.management.internal.LocalManagementContext 
available, so skipped
SUREFIRE-859: [GC 525948K->284165K(775552K), 0.0261441 secs]
SUREFIRE-859: [GC 524805K->283871K(775168K), 0.0337398 secs]
Tests run: 1743, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 393.768 sec 
<<< FAILURE! - in TestSuite
testExecutionManagerPerformance(org.apache.brooklyn.util.core.task.BasicTaskExecutionPerformanceTest)
  Time elapsed: 11.055 sec  <<< FAILURE!
java.lang.AssertionError: warmup=141; times=[282, 1174, 149, 384, 8423, 113, 
51, 34, 95, 73] expected [null] but found [8423]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotSame(Assert.java:490)
at org.testng.Assert.assertNull(Assert.java:426)
at 
org.apache.brooklyn.util.core.task.BasicTaskExecutionPerformanceTest.testExecutionManagerPerformance(BasicTaskExecutionPerformanceTest.java:180)

2016-06-10 02:07:39,578 INFO  Brooklyn shutdown: stopping entities 
[TestEntityImpl{id=qqldjsrp5m}, TestEntityImpl{id=sbi29fs8af}, 
BlockingEntityImpl{id=nidisbj8e1}]

Results :

Failed tests: 
  BasicTaskExecutionPerformanceTest.testExecutionManagerPerformance:180 
warmup=141; times=[282, 1174, 149, 384, 8423, 113, 51, 34, 95, 73] expected 
[null] but found [8423]

Tests run: 1743, Failures: 1, Errors: 0, Skipped: 1

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn 

Jenkins build is back to normal : brooklyn-server-master #128

2016-06-09 Thread Apache Jenkins Server
See 



[GitHub] brooklyn-server pull request #180: prevent OOME on big streams and better lo...

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #180: prevent OOME on big streams and better logging f...

2016-06-09 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/180
  
LGTM; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #180: prevent OOME on big streams and better lo...

2016-06-09 Thread aledsage
Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/180#discussion_r66537291
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTaskTags.java ---
@@ -190,9 +190,16 @@ protected WrappedStream(String streamType, 
ByteArrayOutputStream stream) {
 public Integer getStreamSize() {
 return streamSize.get();
 }
-// there is a stream api so don't return everything unless 
explicitly requested!
+// there is a stream call on Activity REST api which accesses 
streamContent.get() directly;
+// so when serializing the tag, abbreviate things
 @JsonProperty("streamContents")
 public String getStreamContentsAbbreviated() {
+// TODO would be nice to just get the first 80 chars but 
that's a refactoring
+// which might affect persistence.  if stream is very large 
(100MB+) then we sometimes
--- End diff --

Agree we should be cautious about breaking persistence, so am happy to 
merge as-is. But would be really nice if we refactor in a safe way (e.g. 
keeping the old field, but changing the constructor args and adding a new 
field), so we can write something that gets the truncated data. (And in the 
future it could return it paginated, but not sure if that would be at all 
sensible?!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-server-master #127

2016-06-09 Thread Apache Jenkins Server
See 

Changes:

[alex.heneveld] fix for issue where $brooklyn:external refs in 
provisioning.properties

[alex.heneveld] tidy test / logging as per PR comments

--
[...truncated 24170 lines...]
2016-06-09 19:32:30,965 INFO  No Camp-YAML parser registered for parsing 
catalog item DSL; skipping DSL-parsing
2016-06-09 19:32:30,978 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp() 
finished in 75 ms
2016-06-09 19:32:30,978 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testNoopIfDemandIsSimilarToCurrentLocation()
2016-06-09 19:32:31,329 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testNoopIfDemandIsSimilarToCurrentLocation()
 finished in 351 ms
2016-06-09 19:32:31,330 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
2016-06-09 19:32:31,342 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
 finished in 12 ms
2016-06-09 19:32:31,342 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp()
2016-06-09 19:32:31,401 INFO  No Camp-YAML parser registered for parsing 
catalog item DSL; skipping DSL-parsing
2016-06-09 19:32:31,403 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp() 
finished in 61 ms
2016-06-09 19:32:31,403 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testNoopIfDemandIsTiny()
2016-06-09 19:32:31,719 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testNoopIfDemandIsTiny()
 finished in 316 ms
2016-06-09 19:32:31,720 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
2016-06-09 19:32:31,742 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
 finished in 22 ms
2016-06-09 19:32:31,744 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp()
2016-06-09 19:32:31,816 INFO  No Camp-YAML parser registered for parsing 
catalog item DSL; skipping DSL-parsing
2016-06-09 19:32:31,833 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp() 
finished in 90 ms
2016-06-09 19:32:31,833 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testPolicyAcceptsLocationFinder()
2016-06-09 19:32:31,852 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testPolicyAcceptsLocationFinder()
 finished in 19 ms
2016-06-09 19:32:31,852 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
2016-06-09 19:32:31,858 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
 finished in 6 ms
2016-06-09 19:32:31,859 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp()
2016-06-09 19:32:31,923 INFO  No Camp-YAML parser registered for parsing 
catalog item DSL; skipping DSL-parsing
2016-06-09 19:32:31,937 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.setUp() 
finished in 78 ms
2016-06-09 19:32:31,938 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testPolicyUpdatesModel()
2016-06-09 19:32:32,025 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.policy.followthesun.FollowTheSunPolicyTest.testPolicyUpdatesModel()
 finished in 87 ms
2016-06-09 19:32:32,026 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
2016-06-09 19:32:32,062 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.policy.followthesun.AbstractFollowTheSunPolicyTest.tearDown()
 finished in 36 ms
2016-06-09 19:32:32,064 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod 

[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/193


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #193: fix for issue where $brooklyn:external refs in p...

2016-06-09 Thread ahgittin
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn-server/pull/193
  
thx @nakomis, all addressed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread nakomis
Github user nakomis commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/193#discussion_r66481067
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java
 ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.camp.brooklyn;
+
+import static org.testng.Assert.assertEquals;
+
+import java.io.StringReader;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.location.Location;
+import 
org.apache.brooklyn.camp.brooklyn.ExternalConfigYamlTest.MyExternalConfigSupplier;
+import 
org.apache.brooklyn.camp.brooklyn.ExternalConfigYamlTest.MyExternalConfigSupplierWithoutMapArg;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.entity.StartableApplication;
+import org.apache.brooklyn.core.internal.BrooklynProperties;
+import org.apache.brooklyn.core.objs.BrooklynObjectInternal;
+import org.apache.brooklyn.entity.software.base.EmptySoftwareProcess;
+import org.apache.brooklyn.util.core.task.DeferredSupplier;
+import org.apache.brooklyn.util.guava.Maybe;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Iterables;
+
+public class LocationExternalConfigYamlTest extends AbstractYamlRebindTest 
{
+
+   private static final Logger log = 
LoggerFactory.getLogger(ExternalConfigYamlTest.class);
+
+private static final ConfigKey MY_CONFIG_KEY = 
ConfigKeys.newStringConfigKey("my.config.key");
+
+@Override
+protected BrooklynProperties createBrooklynProperties() {
+BrooklynProperties props = super.createBrooklynProperties();
+props.put("brooklyn.external.myprovider", 
MyExternalConfigSupplier.class.getName());
+props.put("brooklyn.external.myprovider.mykey", "myval");
+props.put("brooklyn.external.myproviderWithoutMapArg", 
MyExternalConfigSupplierWithoutMapArg.class.getName());
+return props;
+}
+
+@Test(groups="Integration")
+public void testLocalhostInheritance() throws Exception {
+String yaml = Joiner.on("\n").join(
+"services:",
+"- type: "+EmptySoftwareProcess.class.getName(),
+"location:",
+"  localhost:",
+"my.config.key: $brooklyn:external(\"myprovider\", 
\"mykey\")");
+
+origApp = (StartableApplication) createAndStartApplication(new 
StringReader(yaml));
+
+Entity entity = Iterables.getOnlyElement( origApp.getChildren() );
+Location l = Iterables.getOnlyElement( entity.getLocations() );
+log.info("Location: "+l);
--- End diff --

These log statements don't really give much info in the context of reading 
a log file, should be removed, or give more context


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread nakomis
Github user nakomis commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/193#discussion_r66480706
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java
 ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.camp.brooklyn;
+
+import static org.testng.Assert.assertEquals;
+
+import java.io.StringReader;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.location.Location;
+import 
org.apache.brooklyn.camp.brooklyn.ExternalConfigYamlTest.MyExternalConfigSupplier;
+import 
org.apache.brooklyn.camp.brooklyn.ExternalConfigYamlTest.MyExternalConfigSupplierWithoutMapArg;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.entity.StartableApplication;
+import org.apache.brooklyn.core.internal.BrooklynProperties;
+import org.apache.brooklyn.core.objs.BrooklynObjectInternal;
+import org.apache.brooklyn.entity.software.base.EmptySoftwareProcess;
+import org.apache.brooklyn.util.core.task.DeferredSupplier;
+import org.apache.brooklyn.util.guava.Maybe;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Iterables;
+
+public class LocationExternalConfigYamlTest extends AbstractYamlRebindTest 
{
+
+   private static final Logger log = 
LoggerFactory.getLogger(ExternalConfigYamlTest.class);
+
+private static final ConfigKey MY_CONFIG_KEY = 
ConfigKeys.newStringConfigKey("my.config.key");
+
+@Override
+protected BrooklynProperties createBrooklynProperties() {
+BrooklynProperties props = super.createBrooklynProperties();
+props.put("brooklyn.external.myprovider", 
MyExternalConfigSupplier.class.getName());
+props.put("brooklyn.external.myprovider.mykey", "myval");
+props.put("brooklyn.external.myproviderWithoutMapArg", 
MyExternalConfigSupplierWithoutMapArg.class.getName());
+return props;
+}
+
+@Test(groups="Integration")
+public void testLocalhostInheritance() throws Exception {
+String yaml = Joiner.on("\n").join(
+"services:",
+"- type: "+EmptySoftwareProcess.class.getName(),
+"location:",
+"  localhost:",
+"my.config.key: $brooklyn:external(\"myprovider\", 
\"mykey\")");
+
+origApp = (StartableApplication) createAndStartApplication(new 
StringReader(yaml));
+
+Entity entity = Iterables.getOnlyElement( origApp.getChildren() );
+Location l = Iterables.getOnlyElement( entity.getLocations() );
+log.info("Location: "+l);
+assertEquals(l.config().get(MY_CONFIG_KEY), "myval");
+
+Maybe rawConfig = 
((BrooklynObjectInternal.ConfigurationSupportInternal)l.config()).getRaw(MY_CONFIG_KEY);
+log.info("Raw config: "+rawConfig);
+Assert.assertTrue(rawConfig.isPresentAndNonNull());
+Assert.assertTrue(rawConfig.get() instanceof DeferredSupplier, 
"Expected deferred raw value; got "+rawConfig.get());
+}
+
+@Test(groups="Integration")
+public void testLocationFromCatalogInheritanceAndRebind() throws 
Exception {
+ImmutableList.Builder yamlL = 
ImmutableList.builder().add(
+"brooklyn.catalog:",
+"  id: l1",
+"  item.type: location",
+"  item:",
+"type: localhost",
+"brooklyn.config:",
+"  simple: 42",
+"  my.config.key: 

[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread nakomis
Github user nakomis commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/193#discussion_r66480033
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/LocationExternalConfigYamlTest.java
 ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.camp.brooklyn;
+
+import static org.testng.Assert.assertEquals;
+
+import java.io.StringReader;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.location.Location;
+import 
org.apache.brooklyn.camp.brooklyn.ExternalConfigYamlTest.MyExternalConfigSupplier;
+import 
org.apache.brooklyn.camp.brooklyn.ExternalConfigYamlTest.MyExternalConfigSupplierWithoutMapArg;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.entity.StartableApplication;
+import org.apache.brooklyn.core.internal.BrooklynProperties;
+import org.apache.brooklyn.core.objs.BrooklynObjectInternal;
+import org.apache.brooklyn.entity.software.base.EmptySoftwareProcess;
+import org.apache.brooklyn.util.core.task.DeferredSupplier;
+import org.apache.brooklyn.util.guava.Maybe;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Iterables;
+
+public class LocationExternalConfigYamlTest extends AbstractYamlRebindTest 
{
+
+   private static final Logger log = 
LoggerFactory.getLogger(ExternalConfigYamlTest.class);
--- End diff --

Tab character...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #193: fix for issue where $brooklyn:external re...

2016-06-09 Thread ahgittin
GitHub user ahgittin opened a pull request:

https://github.com/apache/brooklyn-server/pull/193

fix for issue where $brooklyn:external refs in provisioning.properties are 
resolved too early

several more tests, including one which failed before the fix -- and of 
course the fix itself

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ahgittin/brooklyn-server 
external-in-provisioning-properties-breaks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #193


commit cae88d9e10f03ad87d840b1cb9e71c440d800269
Author: Alex Heneveld 
Date:   2016-06-09T16:01:49Z

fix for issue where $brooklyn:external refs in provisioning.properties are 
resolved too early

several more tests, including one which failed before the fix -- and of 
course the fix itself




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

2016-06-09 Thread aledsage
GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/192

Adds OnSubnetNetworkEnricher

Some entities publish their endpoint using the public hostname (e.g. 
`MySqlNode` publishes `datastore.url` using the sensor `host.name`). If trying 
to connect to it from within the same subnet, this can fail if the public 
ip/hostname is not accessible.

This topic is covered in the "Working with Multiple Networks" proposal (see 
dev@brooklyn email thread). That suggests we should use the subnet address in 
things like the datastore.url. That will likely break things for some of our 
users. But while we discuss/finalise that proposal...

This enricher allows one to publish another sensor that definitely uses the 
subnet address. It will publish the sensor as things like 
`datastore.url.mapping.subnet`.

This is really a temporary solution (hence marking this as `@Beta`).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server 
OnSubnetNetworkEnricher

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #192


commit 1660790c9c98b9993631f9107dd1c10c570de420
Author: Aled Sage 
Date:   2016-06-09T15:49:48Z

Adds OnSubnetNetworkEnricher




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-master-windows #143

2016-06-09 Thread Apache Jenkins Server
See 

--
[...truncated 28340 lines...]
at 
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:205)
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
at 
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Results :

Failed tests: 
  
SoftwareProcessPersisterInMemorySizeIntegrationTest>BrooklynMementoPersisterInMemorySizeIntegrationTest.testPersistenceVolumeFastNoTrigger:67->BrooklynMementoPersisterInMemorySizeIntegrationTest.doTestPersistenceVolume:95
 should have written less than 150k, wrote 152607 expected [true] but found 
[false]

Tests run: 159, Failures: 1, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 46.593 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.277 s]
[INFO] Brooklyn Parent Project  SUCCESS [  5.179 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  6.862 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  1.130 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 28.212 s]
[INFO] Brooklyn API ... SUCCESS [  3.877 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.822 s]
[INFO] CAMP Base .. SUCCESS [  4.630 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.240 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  3.652 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.774 s]
[INFO] CAMP Server  SUCCESS [  8.630 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.430 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.541 s]
[INFO] Brooklyn Core .. SUCCESS [04:21 min]
[INFO] Brooklyn Policies .. SUCCESS [01:18 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [  9.063 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 10.387 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  1.134 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 26.980 s]
[INFO] Brooklyn Software Base . FAILURE [01:21 min]
[INFO] Brooklyn CAMP REST API . SKIPPED
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn 

[GitHub] brooklyn-server issue #157: Windows helper script for using Invoke-Command -...

2016-06-09 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/157
  
@bostko Ideally, *all* of the scripts and config file should be copied some 
path relative to `C:\brooklyn-managed-processes\install`. If they're copied to 
the temp folder, there's always the chance that they'll disappear and not be 
present if the entity is restarted at a later date. Let's copy to 
`C:\brooklyn-managed-processes\install` in the mssql-test blueprint, then it's 
up to individual blueprint authors to chose a different folder if they wish. 
https://github.com/apache/brooklyn-library/pull/40 will need to be updated to 
use the new file name too

I'd still like to look at exporting this as a function, and have a 
mechanism to have it run before other scripts, but I'm happy for that to come 
in a later PR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #177: Adds PublicNetworkFaceEnricher

2016-06-09 Thread neykov
Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/177#discussion_r66411519
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/network/OnPublicNetworkEnricher.java
 ---
@@ -0,0 +1,496 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.core.network;
+
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.net.URL;
+import java.util.Collection;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.entity.EntityLocal;
+import org.apache.brooklyn.api.location.Location;
+import org.apache.brooklyn.api.location.MachineLocation;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.api.sensor.Sensor;
+import org.apache.brooklyn.api.sensor.SensorEvent;
+import org.apache.brooklyn.api.sensor.SensorEventListener;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.enricher.AbstractEnricher;
+import org.apache.brooklyn.core.entity.AbstractEntity;
+import org.apache.brooklyn.core.location.Machines;
+import org.apache.brooklyn.core.location.access.PortForwardManager;
+import 
org.apache.brooklyn.core.location.access.PortForwardManagerLocationResolver;
+import 
org.apache.brooklyn.core.location.access.PortForwardManager.AssociationListener;
+import 
org.apache.brooklyn.core.location.access.PortForwardManager.AssociationMetadata;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.util.core.flags.TypeCoercions;
+import org.apache.brooklyn.util.exceptions.Exceptions;
+import org.apache.brooklyn.util.guava.Maybe;
+import org.apache.brooklyn.util.net.Networking;
+import org.apache.brooklyn.util.text.StringPredicates;
+import org.apache.brooklyn.util.text.Strings;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.annotations.Beta;
+import com.google.common.base.Function;
+import com.google.common.base.Optional;
+import com.google.common.base.Predicate;
+import com.google.common.base.Predicates;
+import com.google.common.collect.Lists;
+import com.google.common.net.HostAndPort;
+import com.google.common.reflect.TypeToken;
+
+/**
+ * Can be added to an entity so that it advertises its mapped ports 
(according to the port-mappings
+ * recorded in the PortForwardManager). This can be used with sensors of 
type URI, HostAndPort
+ * or plain integer port values. The port-mappings is retrieved by looking 
up the entity's machine
+ * and the private port, in the PortForwardManager's recorded 
port-mappings.
+ * 
+ * For example, to configure each Tomcat node to publish its mapped uri, 
and to use that sensor
+ * in Nginx for the target servers:
+ * 
+ * {@code
+ * services:
+ * - type: cluster
+ *   id: cluster
+ *   brooklyn.config:
+ *memberSpec:
+ *  $brooklyn:entitySpec:
+ *type: org.apache.brooklyn.entity.webapp.tomcat.TomcatServer
+ *brooklyn.enrichers:
+ *- type: 
org.apache.brooklyn.core.location.access.PublicNetworkFaceEnricher
+ *  brooklyn.config:
+ *sensor: main.uri
+ * - type: org.apache.brooklyn.entity.proxy.nginx.NginxController
+ *   brooklyn.config:
+ * member.sensor.hostandport: 
$brooklyn:sensor("main.uri.mapped.public")
+ * serverPool: cluster
+ * }
+ * 
+ */
+@Beta
+public class OnPublicNetworkEnricher extends AbstractEnricher {
+
+// TODO Is this the best package for the enricher?
+//
+// TODO Need more logging, particularly for when the value has *not* 
been transformed.
+//
+// TODO What if the sensor has an unrelated hostname - we will 
currently still transform this!
+// That seems acceptable: if the user configures it to look at the 
sensor, then we can make
  

[GitHub] brooklyn-server issue #157: Windows helper script for using Invoke-Command -...

2016-06-09 Thread bostko
Github user bostko commented on the issue:

https://github.com/apache/brooklyn-server/pull/157
  
@nakomis this way the install command can be chained with other commands 
very easily inside the yaml.
The common use case for the `invoke-command-credssp.ps` helper is to be 
used as a native command helper. And I do not know whether it is possible to 
export a module in a native command?
Also it looks more native to me to use it just with one line like I 
suggested in the previous comment.

Regarding moving the scripts in different folder.
The most sensible destinations for these scripts would be `$env:TEMP` (or 
`%TEMP%`)
or `C:\brooklyn-managed-processes\install` the install folder which is used 
in Apache Brooklyn.
I am not sure whether C:\brooklyn-managed-processes is appropriate location 
either for installing or it should be located in user's folder?
If you think that $env:TEMP is the most sensible location then I can change 
their location.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #191: Add AbstractTransformer.ALLOW_CYCLIC_PUBL...

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/191


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #191: Add AbstractTransformer.ALLOW_CYCLIC_PUBLISHING

2016-06-09 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/191
  
Thanks @nakomis - merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #191: Add AbstractTransformer.ALLOW_CYCLIC_PUBLISHING

2016-06-09 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/191
  
One comment, but other than that, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---