date:20160616

Build failed in Jenkins: brooklyn-master-windows #156

2016-06-16 Thread Apache Jenkins Server

See 

--
[...truncated 47843 lines...]
Compressed 785.49 KB of artifacts by 85.6% relative to #22
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\pom.xml
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-test-sources.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT-test-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-dist\shared-packaging\pom.xml
 to 
org.apache.brooklyn/shared-packaging/0.10.0-SNAPSHOT/shared-packaging-0.10.0-SNAPSHOT.pom
No prior successful build to compare, so performing full copy of artifacts
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\rest\rest-resources\pom.xml
 to 
org.apache.brooklyn/brooklyn-rest-resources/0.10.0-SNAPSHOT/brooklyn-rest-resources-0.10.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\rest\rest-resources\target\brooklyn-rest-resources-0.10.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-rest-resources/0.10.0-SNAPSHOT/brooklyn-rest-resources-0.10.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\rest\rest-resources\target\brooklyn-rest-resources-0.10.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-rest-resources/0.10.0-SNAPSHOT/brooklyn-rest-resources-0.10.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\rest\rest-resources\target\brooklyn-rest-resources-0.10.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-rest-resources/0.10.0-SNAPSHOT/brooklyn-rest-resources-0.10.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\rest\rest-resources\target\brooklyn-rest-resources-0.10.0-SNAPSHOT-test-sources.jar
 to 
org.apache.brooklyn/brooklyn-rest-resources/0.10.0-SNAPSHOT/brooklyn-rest-resources-0.10.0-SNAPSHOT-test-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-ui\pom.xml to 
org.apache.brooklyn/brooklyn-jsgui/0.10.0-SNAPSHOT/brooklyn-jsgui-0.10.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-ui\target\brooklyn-jsgui-0.10.0-SNAPSHOT.war
 to 
org.apache.brooklyn/brooklyn-jsgui/0.10.0-SNAPSHOT/brooklyn-jsgui-0.10.0-SNAPSHOT.war
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-ui\target\brooklyn-jsgui-0.10.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-jsgui/0.10.0-SNAPSHOT/brooklyn-jsgui-0.10.0-SNAPSHOT-tests.jar
Compressed 2.84 MB of artifacts by 85.9% relative to #155
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\pom.xml
 to 
org.apache.brooklyn/brooklyn-utils-common/0.10.0-SNAPSHOT/brooklyn-utils-common-0.10.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.10.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.10.0-SNAPSHOT/brooklyn-utils-common-0.10.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.10.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.10.0-SNAPSHOT/brooklyn-utils-common-0.10.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.10.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.10.0-SNAPSHOT/brooklyn-utils-common-0.10.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.10.0-SNAPSHOT-test-sources.jar
 to

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread grkvlt

Github user grkvlt commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
Tested on various clouds and works well as input to an `AutoScalerPolicy` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-master-windows #155

2016-06-16 Thread Apache Jenkins Server

See 

--
[...truncated 38040 lines...]
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 39.597 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.245 s]
[INFO] Brooklyn Parent Project  SUCCESS [  4.417 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  6.053 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  2.508 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 25.354 s]
[INFO] Brooklyn API ... SUCCESS [  3.283 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.582 s]
[INFO] CAMP Base .. SUCCESS [  3.706 s]
[INFO] Brooklyn Test Support .. SUCCESS [  1.943 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  2.488 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.547 s]
[INFO] CAMP Server  SUCCESS [  7.501 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  3.986 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.325 s]
[INFO] Brooklyn Core .. SUCCESS [04:19 min]
[INFO] Brooklyn Policies .. SUCCESS [01:19 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [ 11.902 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 12.367 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  1.557 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 26.737 s]
[INFO] Brooklyn Software Base . SUCCESS [01:25 min]
[INFO] Brooklyn CAMP REST API . SUCCESS [04:15 min]
[INFO] Brooklyn Hazelcast Storage . SUCCESS [  4.398 s]
[INFO] Brooklyn Launcher Common ... SUCCESS [ 10.003 s]
[INFO] Brooklyn REST API .. SUCCESS [ 11.988 s]
[INFO] Brooklyn REST Resources  FAILURE [01:55 min]
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] hello-world-webapp Maven Webapp  SKIPPED
[INFO] hello-world-sql-webapp Maven Webapp  SKIPPED
[INFO] Brooklyn Simple Web Cluster Example  SKIPPED
[INFO] Brooklyn Global Web Fabric Example . SKIPPED
[INFO] Brooklyn Simple Messaging Publish-Subscribe Example  SKIPPED
[INFO] Brooklyn NoSQL Cluster Examples  SKIPPED
[INFO] Brooklyn Downstream Project Parent . SKIPPED
[INFO] Brooklyn Dist Root . SKIPPED
[INFO] Brooklyn All Things  SKIPPED
[INFO] Brooklyn Distribution .. SKIPPED
[INFO] Brooklyn Vagrant Getting Started Environment ... SKIPPED
[INFO] Brooklyn Quick-Start Project Archetype . SKIPPED
[INFO] Brooklyn Shared Package Files .. SKIPPED
[INFO] Brooklyn DEB Package

Build failed in Jenkins: brooklyn-server-master #139

2016-06-16 Thread Apache Jenkins Server

See 

Changes:

[aled.sage] BROOKLYN-303: Fix EmptyWindowsProcess

--
[...truncated 33610 lines...]
at 
org.apache.brooklyn.util.core.flags.TypeCoercions.coerce(TypeCoercions.java:285)
 ~[brooklyn-core-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
2016-06-16 17:06:59,465 INFO  Stopping application 
BasicApplicationImpl{id=l6n8t2ctm8}
2016-06-16 17:06:59,467 INFO  Stopped application 
BasicApplicationImpl{id=l6n8t2ctm8}
2016-06-16 17:06:59,548 INFO  CAMP created 'BasicApplicationImpl{id=mbu4kyz0t2}'
2016-06-16 17:06:59,548 INFO  Test - created 
org.apache.brooklyn.camp.spi.Assembly@39442ad2[id=mbu4kyz0t2; type=Assembly]
2016-06-16 17:06:59,548 INFO  App - BasicApplicationImpl{id=mbu4kyz0t2}
2016-06-16 17:06:59,573 INFO  Started application 
BasicApplicationImpl{id=mbu4kyz0t2}
2016-06-16 17:06:59,574 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.camp.brooklyn.catalog.CatalogYamlRebindTest.testRebindWithCatalogPropertiesForDeprecationAndEnablementAbsent()
 finished in 2163 ms
2016-06-16 17:06:59,574 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.camp.brooklyn.AbstractYamlRebindTest.tearDown()
2016-06-16 17:06:59,576 INFO  Stopping application 
BasicApplicationImpl{id=l6n8t2ctm8}
2016-06-16 17:06:59,576 INFO  Stopped application 
BasicApplicationImpl{id=l6n8t2ctm8}
2016-06-16 17:06:59,585 WARN  Entities.destroyAll invoked on non-deployment 
NonDeploymentManagementContext{entity=l6n8t2ctm8, mode=MANAGEMENT_STOPPED} - 
not likely to have much effect! (This usually means the mgmt context has been 
taken from an entity that has been destroyed. To destroy other things on the 
management context ensure you keep a handle to the context before the entity is 
destroyed, such as by creating the management context first.)
2016-06-16 17:06:59,586 INFO  Stopping application 
BasicApplicationImpl{id=mbu4kyz0t2}
2016-06-16 17:06:59,587 INFO  Stopped application 
BasicApplicationImpl{id=mbu4kyz0t2}
2016-06-16 17:06:59,647 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod 
org.apache.brooklyn.camp.brooklyn.AbstractYamlRebindTest.tearDown() finished in 
73 ms
2016-06-16 17:06:59,647 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.camp.brooklyn.AbstractYamlRebindTest.setUp()
2016-06-16 17:06:59,657 INFO  Test class 
org.apache.brooklyn.camp.brooklyn.catalog.CatalogYamlRebindTest persisting to 
/tmp/CatalogYamlRebindTest-nHr3
2016-06-16 17:06:59,657 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.camp.brooklyn.AbstractYamlRebindTest.setUp() 
finished in 10 ms
2016-06-16 17:06:59,657 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.camp.brooklyn.catalog.CatalogYamlRebindTest.testRebindWithCatalogUpgradedWithOldDeletedAndAppExisting()
2016-06-16 17:06:59,866 INFO  CAMP created 'BasicApplicationImpl{id=s41u0s06jk}'
2016-06-16 17:06:59,867 INFO  Test - created 
org.apache.brooklyn.camp.spi.Assembly@19fca0e6[id=s41u0s06jk; type=Assembly]
2016-06-16 17:06:59,867 INFO  App - BasicApplicationImpl{id=s41u0s06jk}
2016-06-16 17:06:59,888 INFO  Started application 
BasicApplicationImpl{id=s41u0s06jk}
2016-06-16 17:06:59,992 INFO  Rebinding app, using mementoDir 
/tmp/CatalogYamlRebindTest-nHr3; object store null
2016-06-16 17:07:00,104 INFO  Rebinding from /tmp/CatalogYamlRebindTest-nHr3 
for master CDixT1Ra...
2016-06-16 17:07:00,107 WARN  No catalog item found with id 
my.catalog.app.id.load:0.1.0; dangling reference on rebind
2016-06-16 17:07:00,107 WARN  Unable to load catalog item 
my.catalog.app.id.load:0.1.0 for wvzv2s6cga (Entity); will auto-upgrade to 
my.catalog.app.id.load:0.2.0
SUREFIRE-859: [Full GC 745116K->532069K(763904K), 3.2136130 secs]
2016-06-16 17:07:03,377 WARN  No catalog item found with id 
my.catalog.app.id.load:0.1.0; dangling reference on rebind
2016-06-16 17:07:03,378 WARN  Unable to load catalog item 
my.catalog.app.id.load:0.1.0 for x9cmwpiqlh (Policy); will auto-upgrade to 
my.catalog.app.id.load:0.2.0
2016-06-16 17:07:03,379 WARN  No catalog item found with id 
my.catalog.app.id.load:0.1.0; dangling reference on rebind
2016-06-16 17:07:03,379 WARN  Unable to load catalog item 
my.catalog.app.id.load:0.1.0 for c23gk3179j (Enricher); will auto-upgrade to 
my.catalog.app.id.load:0.2.0
2016-06-16 17:07:03,380 WARN  No catalog item found with id 
my.catalog.app.id.load:0.1.0; dangling reference on rebind
2016-06-16 17:07:03,380 WARN  Unable to load catalog item 
my.catalog.app.id.load:0.1.0 for iapm30so5a (Enricher); will auto-upgrade to 
my.catalog.app.id.load:0.2.0
2016-06-16 17:07:03,381 WARN  No catalog item found with id 
my.catalog.app.id.load:0.1.0; dangling reference on rebind
2016-06-16 17:07:03,381 WARN  Unable to load catalog item 
my.catalog.app.id.load:0.1.0 for syysefh1dd (Enricher); will auto-upgrade to

[GitHub] brooklyn-server issue #203: Fix CAS operations on AtomicBoolean

2016-06-16 Thread neykov

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/203
  
Nice cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #203: Fix CAS operations on AtomicBoolean

2016-06-16 Thread neykov

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/203#discussion_r67383792
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/internal/BrooklynInitialization.java
 ---
@@ -61,21 +61,22 @@ public static void initLegacyLanguageExtensions() {
  * 
  */
 
-public synchronized static void initAll() {
-if (done.get()) return;
-initTypeCoercionStandardAdapters();
-initSecureKeysBouncyCastleProvider();
-initNetworking();
-initPortRanges();
-initLegacyLanguageExtensions();
-done.set(true);
+public static void initAll() {
+if (done.compareAndSet(false, true)) {
+initTypeCoercionStandardAdapters();
+initSecureKeysBouncyCastleProvider();
+initNetworking();
+initPortRanges();
+initLegacyLanguageExtensions();
+}
 }
 
 @SuppressWarnings("deprecation")
 public synchronized static void reinitAll() {
-done.set(false);
-org.apache.brooklyn.util.core.BrooklynLanguageExtensions.reinit();
-initAll();
+if (done.compareAndSet(true, false)) {
--- End diff --

This changes the behaviour - won't run if `initAll` is not called before 
that. Better stick to the original, wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : brooklyn-library-master #35

2016-06-16 Thread Apache Jenkins Server

See

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread grkvlt

Github user grkvlt commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
@neykov it just doesn't do anything (well, throws an exception and returns 
`null`) until it can actually SSH


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #207: Ensure detection of failed pre.install.command a...

2016-06-16 Thread neykov

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/207
  
Looks great - will be very useful to have this merged. A very minor 
comment, happy to be merged as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #207: Ensure detection of failed pre.install.co...

2016-06-16 Thread neykov

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/207#discussion_r67381349
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessSshDriver.java
 ---
@@ -285,45 +296,54 @@ public void copyInstallResources() {
 }
 }
 
+private void executeSuccessfully(ConfigKey configKey, String 
label) {
+log.debug("Executing {} on entity {}", label, 
entity.getDisplayName());
+int result = 
execute(ImmutableList.of(getEntity().getConfig(configKey)), label);
+if (0 != result) {
+log.debug("Executing {} failed with return code {}", label, 
result);
+throw new IllegalStateException("commands for " + 
configKey.getName() + " failed with return code " + result);
--- End diff --

Don't think `execute` logs the stdin/stdout/stderr on error - could be 
useful. For the time being a TODO here will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #207: Ensure detection of failed pre.install.co...

2016-06-16 Thread neykov

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/207#discussion_r67380947
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessSshDriver.java
 ---
@@ -285,45 +296,54 @@ public void copyInstallResources() {
 }
 }
 
+private void executeSuccessfully(ConfigKey configKey, String 
label) {
+log.debug("Executing {} on entity {}", label, 
entity.getDisplayName());
+int result = 
execute(ImmutableList.of(getEntity().getConfig(configKey)), label);
+if (0 != result) {
+log.debug("Executing {} failed with return code {}", label, 
result);
+throw new IllegalStateException("commands for " + 
configKey.getName() + " failed with return code " + result);
+}
+}
+
 @Override
 public void runPreInstallCommand() {
 
if(Strings.isNonBlank(getEntity().getConfig(BrooklynConfigKeys.PRE_INSTALL_COMMAND)))
 {
--- End diff --

Could move all of these checks to the `executeSuccessfully` method, but 
happy to merge as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BROOKLYN-303) EmptyWindowsProcess provisioning fails with NPE

2016-06-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/BROOKLYN-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334124#comment-15334124
 ] 

ASF GitHub Bot commented on BROOKLYN-303:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/205


> EmptyWindowsProcess provisioning fails with NPE
> ---
>
> Key: BROOKLYN-303
> URL: https://issues.apache.org/jira/browse/BROOKLYN-303
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> When using {{EmptyWindowsProcess}}, provisioning fails with a 
> NullPointerException.
> The workaround is to supply a "port" config value - it can be any 
> valid-looking port number, as we would expect it to be not actually used! For 
> example:
> {noformat}
> location: byon:(hosts="1.2.3.4",osFamily=windows)
> services:
> - type: org.apache.brooklyn.entity.software.base.EmptyWindowsProcess
>   brooklyn.config:
> winrmMonitoring.enabled: false
> onbox.base.dir.skipResolution: true"
> port: 1234
> {noformat}
> The NPE is shown below (as demonstrated by the test 
> {{EmptyWindowsProcessYamlTest.testNoWinrm}}):
> {noformat}
> FAILED: testNoWinrm
> java.util.concurrent.ExecutionException: 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException:
>  Error invoking start at BasicApplicationImpl{id=vg4qzlljih}: Error invoking 
> start at EmptyWindowsProcessImpl{id=ztdk56w3yo}: NullPointerException
>   at java.util.concurrent.FutureTask.report(FutureTask.java:122)
>   at java.util.concurrent.FutureTask.get(FutureTask.java:188)
>   at 
> com.google.common.util.concurrent.ForwardingFuture.get(ForwardingFuture.java:63)
>   at org.apache.brooklyn.util.core.task.BasicTask.get(BasicTask.java:361)
>   at 
> org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.createAndStartApplication(AbstractYamlTest.java:139)
>   at 
> org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.createAndStartApplication(AbstractYamlTest.java:132)
>   at 
> org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.createAndStartApplication(AbstractYamlTest.java:124)
>   at 
> org.apache.brooklyn.camp.brooklyn.EmptyWindowsProcessYamlTest.testNoWinrm(EmptyWindowsProcessYamlTest.java:37)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
>   at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
>   at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
>   at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
>   at 
> org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
>   at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
>   at org.testng.TestRunner.privateRun(TestRunner.java:767)
>   at org.testng.TestRunner.run(TestRunner.java:617)
>   at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
>   at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
>   at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
>   at org.testng.SuiteRunner.run(SuiteRunner.java:254)
>   at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
>   at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
>   at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
>   at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
>   at org.testng.TestNG.run(TestNG.java:1057)
>   at org.testng.remote.RemoteTestNG.run(RemoteTestNG.java:115)
>   at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:207)
>   at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:178)
> Caused by: 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException:
>  Error invoking start at BasicApplicationImpl{id=vg4qzlljih}: Error invoking 
> start at EmptyWindowsProcessImpl{id=ztdk56w3yo}: NullPointerException
>   at 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException.propagate(EffectorUtils.java:320)
>   at 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException.access$0(EffectorUtils.java:313)
>   at 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils.handleEffectorException(EffectorUtils.java:327)
>   at 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils.invokeMethodEffector(EffectorUtils.java:281)
>   at 
>

[GitHub] brooklyn-server pull request #205: BROOKLYN-303: Fix EmptyWindowsProcess

2016-06-16 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/205


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #207: Ensure detection of failed pre.install.co...

2016-06-16 Thread geomacy

GitHub user geomacy opened a pull request:

https://github.com/apache/brooklyn-server/pull/207

Ensure detection of failed pre.install.command and related commands.

Currently 'pre.install.command' and related steps do not fail if the 
command(s) returns a non-zero exit.
This can mean your install will fail but Brooklyn won't detect it (perhaps 
until some subsequent stage, or not at all).

This change adds detection of the return code and failure if it is 
non-zero. The 'contract' for the methods is added as a comment.  The 
AbstractSoftwareProcessSshDriver is changed to detect the failure and throw an 
exception. The AbstractSoftwareProcessWinRmDriver already does the right thing 
and doesn't need changed.

While this could break some existing blueprints, I think in such cases it's 
more likely that it is highlighting a problem that has been missed, rather than 
causing a problem because someone is explicitly relying on that behaviour.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-server result-codes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #207


commit 7ece3a8d5f3a302a1c1635632e7d616f27ca3d07
Author: Geoff Macartney 
Date:   2016-06-16T08:57:28Z

Ensure detection of failed pre.install.command and related commands.

Currently 'pre.install.command' and related steps do not fail if the 
command(s) returns a non-zero exit.
This can mean your install will fail but Brooklyn won't detect it (perhaps 
until some subsequent stage, or not at all).

This change adds detection of the return code and failure if it is 
non-zero. The 'contract' for the methods is added as a comment.  The 
AbstractSoftwareProcessSshDriver is changed to detect the failure and throw an 
exception. The AbstractSoftwareProcessWinRmDriver already does the right thing 
and doesn't need changed.

While this could break some existing blueprints, I think in such cases it's 
more likely that it is highlighting a problem that has been missed, rather than 
causing a problem because someone is explicitly relying on that behaviour.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread neykov

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
Not convinced. What happens when SshFeed can't find the machine on a 
stopped entity? Does it start logging errors or is that silently discarded?
There's a similar problem on creation - `apply` is called just after 
`init`, so there's no machine available yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread grkvlt

Github user grkvlt commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
@neykov the feed stopping should be addressed in another PR I think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread neykov

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
Looks like Brooklyn will handle starting them (on 
[creation](https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/org/apache/brooklyn/feed/ssh/SshFeed.java#L168)
 and on 
[rebind](https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicEntityRebindSupport.java#L169)).
 But looks like they are not stopped as part of the entity lifecycle - couldn't 
find anything in the sources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #194: Prevents premature resolving of external config

2016-06-16 Thread nakomis

Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/194
  
PR comments addressed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

2016-06-16 Thread nakomis

Github user nakomis commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/194#discussion_r67360931
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
 ---
@@ -2422,7 +2437,7 @@ protected JcloudsWinRmMachineLocation 
createWinRmMachineLocation(ComputeService
 .configure(WinRmMachineLocation.WINRM_CONFIG_PORT, 
sshHostAndPort.isPresent() ? sshHostAndPort.get().getPort() : 
node.getLoginPort())
 .configure("user", getUser(setup))
 .configure(WinRmMachineLocation.USER, setup.get(USER))
-.configure(WinRmMachineLocation.PASSWORD, 
setup.get(PASSWORD))
+.configure(ConfigBag.newInstance().copyRaw(setup, 
PASSWORD, WinRmMachineLocation.PASSWORD).getAllConfigRaw())
--- End diff --

This would require adding a dependency on brooklyn-core to brooklyn-api, 
which would create a circular dependency


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread grkvlt

Github user grkvlt commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
Still needs a bit of testing done with deployed clusters


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-server-master #138

2016-06-16 Thread Apache Jenkins Server

See 

--
Started by user svet
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (docker Ubuntu ubuntu yahoo-not-h2 ubuntu1) in 
workspace 
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/brooklyn-server.git
 > git init  # 
 > timeout=10
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Could not init 

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:655)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:462)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to ubuntu-1(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:220)
at hudson.remoting.Channel.call(Channel.java:781)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor787.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at com.sun.proxy.$Proxy151.execute(Unknown Source)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1013)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1053)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1738)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:531)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: hudson.plugins.git.GitException: Error performing command: git init 

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1700)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:653)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:462)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Cannot run program "git" (in directory 
": error=11, 
Resource temporarily unavailable
at

Build failed in Jenkins: brooklyn-server-master #137

2016-06-16 Thread Apache Jenkins Server

See 

--
Started by user svet
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (docker Ubuntu ubuntu yahoo-not-h2 ubuntu1) in 
workspace 
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/brooklyn-server.git
 > git init  # 
 > timeout=10
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Could not init 

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:655)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:462)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to ubuntu-1(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:220)
at hudson.remoting.Channel.call(Channel.java:781)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor787.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at com.sun.proxy.$Proxy151.execute(Unknown Source)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1013)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1053)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1738)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:531)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: hudson.plugins.git.GitException: Error performing command: git init 

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1700)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:653)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:462)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Cannot run program "git" (in directory 
": error=11, 
Resource temporarily unavailable
at

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread grkvlt

Github user grkvlt commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
@neykov the feeds are managed by `FeedSupport` in the entity - I think this 
should stop them, and also handle rebind


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (BROOKLYN-303) EmptyWindowsProcess provisioning fails with NPE

2016-06-16 Thread Aled Sage (JIRA)

Aled Sage created BROOKLYN-303:
--

 Summary: EmptyWindowsProcess provisioning fails with NPE
 Key: BROOKLYN-303
 URL: https://issues.apache.org/jira/browse/BROOKLYN-303
 Project: Brooklyn
  Issue Type: Bug
Reporter: Aled Sage


When using {{EmptyWindowsProcess}}, provisioning fails with a 
NullPointerException.

The workaround is to supply a "port" config value - it can be any valid-looking 
port number, as we would expect it to be not actually used! For example:

{noformat}
location: byon:(hosts="1.2.3.4",osFamily=windows)
services:
- type: org.apache.brooklyn.entity.software.base.EmptyWindowsProcess
  brooklyn.config:
winrmMonitoring.enabled: false
onbox.base.dir.skipResolution: true"
port: 1234
{noformat}

The NPE is shown below (as demonstrated by the test 
{{EmptyWindowsProcessYamlTest.testNoWinrm}}):

{noformat}
FAILED: testNoWinrm
java.util.concurrent.ExecutionException: 
org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException:
 Error invoking start at BasicApplicationImpl{id=vg4qzlljih}: Error invoking 
start at EmptyWindowsProcessImpl{id=ztdk56w3yo}: NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:188)
at 
com.google.common.util.concurrent.ForwardingFuture.get(ForwardingFuture.java:63)
at org.apache.brooklyn.util.core.task.BasicTask.get(BasicTask.java:361)
at 
org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.createAndStartApplication(AbstractYamlTest.java:139)
at 
org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.createAndStartApplication(AbstractYamlTest.java:132)
at 
org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.createAndStartApplication(AbstractYamlTest.java:124)
at 
org.apache.brooklyn.camp.brooklyn.EmptyWindowsProcessYamlTest.testNoWinrm(EmptyWindowsProcessYamlTest.java:37)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
at org.testng.SuiteRunner.run(SuiteRunner.java:254)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
at org.testng.TestNG.run(TestNG.java:1057)
at org.testng.remote.RemoteTestNG.run(RemoteTestNG.java:115)
at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:207)
at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:178)
Caused by: 
org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException:
 Error invoking start at BasicApplicationImpl{id=vg4qzlljih}: Error invoking 
start at EmptyWindowsProcessImpl{id=ztdk56w3yo}: NullPointerException
at 
org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException.propagate(EffectorUtils.java:320)
at 
org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException.access$0(EffectorUtils.java:313)
at 
org.apache.brooklyn.core.mgmt.internal.EffectorUtils.handleEffectorException(EffectorUtils.java:327)
at 
org.apache.brooklyn.core.mgmt.internal.EffectorUtils.invokeMethodEffector(EffectorUtils.java:281)
at 
org.apache.brooklyn.core.effector.MethodEffector.call(MethodEffector.java:148)
at 
org.apache.brooklyn.core.entity.trait.Startable$StartEffectorBody.call(Startable.java:56)
at 
org.apache.brooklyn.core.entity.trait.Startable$StartEffectorBody.call(Startable.java:1)
at 
org.apache.brooklyn.core.effector.EffectorTasks$EffectorBodyTaskFactory$1.call(EffectorTasks.java:82)
at

[GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...

2016-06-16 Thread grkvlt

Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/204#discussion_r67329989
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
 ---
@@ -287,6 +299,89 @@ protected void postDriverStart() {
  */
 protected void connectSensors() {
 connectedSensors = true;
+boolean retrieveMachineMetrics = 
config().get(RETRIEVE_MACHINE_METRICS);
+if (retrieveMachineMetrics) connectMachineSensors();
+}
+
+/**
+ * Adds sensors returning details about the machine the process is 
running on.
+ * 
+ * The machine must be SSHable and running Linux.
+ */
+protected void connectMachineSensors() {
+Maybe location = 
Machines.findUniqueMachineLocation(getLocations(), SshMachineLocation.class);
+if (location.isPresent() && 
location.get().getOsDetails().isLinux()) {
+machineSensorFeed = SshFeed.builder()
+.entity(this)
+.period(Duration.THIRTY_SECONDS)
+.poll(SshPollConfig.forSensor(UPTIME)
+.command("cat /proc/uptime")
+
.onFailureOrException(Functions.constant(null))
+.onSuccess(new Function() {
+@Override
+public Duration apply(SshPollValue input) {
+return Duration.seconds( 
Double.valueOf( Strings.getFirstWord(input.getStdout()) ) );
+}
+}))
+.poll(SshPollConfig.forSensor(LOAD_AVERAGE)
+.command("uptime")
+.onFailureOrException(Functions.constant(-1d))
+.onSuccess(new Function() {
+@Override
+public Double apply(SshPollValue input) {
+String loadAverage = 
Strings.getFirstWordAfter(input.getStdout(), "load average:").replace(",", "");
+return Double.valueOf(loadAverage);
+}
+}))
+.poll(SshPollConfig.forSensor(CPU_USAGE)
+.command("cat /proc/stat")
--- End diff --

@ceeaspb I changed this to a command that sums the CPU field of the `ps` 
output, which should work on almost all Linux machines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-master-windows #154

2016-06-16 Thread Apache Jenkins Server

See 

--
[...truncated 29604 lines...]
at 
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:205)
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
at 
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Results :

Failed tests: 
  
SoftwareProcessPersisterInMemorySizeIntegrationTest>BrooklynMementoPersisterInMemorySizeIntegrationTest.testPersistenceVolumeFastNoTrigger:67->BrooklynMementoPersisterInMemorySizeIntegrationTest.doTestPersistenceVolume:95
 should have written less than 150k, wrote 155312 expected [true] but found 
[false]

Tests run: 161, Failures: 1, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 37.506 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.218 s]
[INFO] Brooklyn Parent Project  SUCCESS [  4.613 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  6.990 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  0.905 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 24.373 s]
[INFO] Brooklyn API ... SUCCESS [  3.320 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.349 s]
[INFO] CAMP Base .. SUCCESS [  3.882 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.060 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  3.250 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.750 s]
[INFO] CAMP Server  SUCCESS [  7.346 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.000 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.172 s]
[INFO] Brooklyn Core .. SUCCESS [04:24 min]
[INFO] Brooklyn Policies .. SUCCESS [01:19 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [  8.205 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 10.450 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  1.121 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 26.392 s]
[INFO] Brooklyn Software Base . FAILURE [01:23 min]
[INFO] Brooklyn CAMP REST API . SKIPPED
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn

[GitHub] brooklyn-server pull request #205: Fix EmptyWindowsProcess

2016-06-16 Thread aledsage

GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/205

Fix EmptyWindowsProcess

Previously gave NPE in driver

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server 
fix/EmptyWindowsProcess

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #205


commit 9da193b3833e3a11b8122c7ab917b18643ca314b
Author: Aled Sage 
Date:   2016-06-16T11:33:12Z

Fix EmptyWindowsProcess

Previously gave NPE in driver




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Machine Metrics

2016-06-16 Thread Geoff Macartney

I agree with Sam and Svet, + 1 to making it an enricher, if possible, or at 
least somehow keeping it separate from SoftwareProcess.



Gnu PGP key - http://is.gd/uI


> On 16 Jun 2016, at 10:41, Sam Corbett  wrote:
> 
> I share your concern that the placement of the feed is wrong. I feel like we 
> would be bending Brooklyn's abstractions to fit the case rather than working 
> out a better abstraction. Of course, deciding what data reflects a software 
> process is subjective and as you point out we already break the encapsulation 
> in a variety of places. Was the plan not always to make locations into 
> entities too? This would be trivial if that were the case.
> 
> I also think we're continually making SoftwareProcess too important. Svet's 
> suggestion of an enricher is a good one - I want to explicitly mix the 
> capability in to entities, not enable it with a flag.
> 
> Sam
> 
> 
> On 16/06/2016 09:13, Andrew Kennedy wrote:
>> Hi.
>> 
>> For the project I am working on, we would like to use the CPU utilization
>> as one of the metrics for scaling a cluster. The existing `MachineEntity`
>> has a sensor feed that produces this data, along with uptime and memory
>> usage information. The feed works on Linux VMs only, currently, as is uses
>> SSH commands on the host to generate the values i.e. the `uptime` command,
>> or the contents of files in `/proc/`.
>> 
>> I would like to propose moving the feed to `SoftwareProcess` so that it is
>> available to all entities. It would be disabled normally, set by a
>> `ConfigKey` flag. This would be named "metrics.machine.retrieve"
>> to correspond to "metrics.usage.retrieve" which enables sensors in feeds
>> that return application or process specific information. The
>> `MachineEntity` would obviously have the default value set to "true", to
>> maintain current behaviour.
>> 
>> The only issue with this change is that the placement of the sensor feed
>> feels slightly wrong. These are returning data about the _machine_ but the
>> entity represents a _process_ on that machine, and there may in fact be
>> multiple entities sharing a single machine, via `SameServerEntity`. The
>> `MachineEntity` is used to represent a VM without any applications running
>> on it, and would not normally be part of a blueprint, so these sensors are
>> not normally accessible. There is some precedent for placing machine data
>> on an entity, such as the `HOSTNAME` sensor, so I think the break in
>> encapsulation is quite small.
>> 
>> The PR containing the change is here:
>> 
>> - https://github.com/apache/brooklyn-server/pull/204
>> 
>> I'd appreciate any comments on whether this is a useful change, as well as
>> a review of the pull request...
>> 
>> Thanks,
>> Andrew.
>

Jenkins build became unstable: brooklyn-server-master #136

2016-06-16 Thread Apache Jenkins Server

See

[GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...

2016-06-16 Thread ceeaspb

Github user ceeaspb commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/204#discussion_r67323169
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
 ---
@@ -287,6 +299,89 @@ protected void postDriverStart() {
  */
 protected void connectSensors() {
 connectedSensors = true;
+boolean retrieveMachineMetrics = 
config().get(RETRIEVE_MACHINE_METRICS);
+if (retrieveMachineMetrics) connectMachineSensors();
+}
+
+/**
+ * Adds sensors returning details about the machine the process is 
running on.
+ * 
+ * The machine must be SSHable and running Linux.
+ */
+protected void connectMachineSensors() {
+Maybe location = 
Machines.findUniqueMachineLocation(getLocations(), SshMachineLocation.class);
+if (location.isPresent() && 
location.get().getOsDetails().isLinux()) {
+machineSensorFeed = SshFeed.builder()
+.entity(this)
+.period(Duration.THIRTY_SECONDS)
+.poll(SshPollConfig.forSensor(UPTIME)
+.command("cat /proc/uptime")
+
.onFailureOrException(Functions.constant(null))
+.onSuccess(new Function() {
+@Override
+public Duration apply(SshPollValue input) {
+return Duration.seconds( 
Double.valueOf( Strings.getFirstWord(input.getStdout()) ) );
+}
+}))
+.poll(SshPollConfig.forSensor(LOAD_AVERAGE)
+.command("uptime")
+.onFailureOrException(Functions.constant(-1d))
+.onSuccess(new Function() {
+@Override
+public Double apply(SshPollValue input) {
+String loadAverage = 
Strings.getFirstWordAfter(input.getStdout(), "load average:").replace(",", "");
+return Double.valueOf(loadAverage);
+}
+}))
+.poll(SshPollConfig.forSensor(CPU_USAGE)
+.command("cat /proc/stat")
+.onFailureOrException(Functions.constant(-1d))
+.onSuccess(new Function() {
+@Override
+public Double apply(SshPollValue input) {
+List cpuData = Splitter.on(" 
").omitEmptyStrings().splitToList(Strings.getFirstLine(input.getStdout()));
+Integer system = 
Integer.parseInt(cpuData.get(1));
+Integer user = 
Integer.parseInt(cpuData.get(3));
+Integer idle = 
Integer.parseInt(cpuData.get(4));
+return (double) (system + user) / 
(double) (system + user + idle);
--- End diff --

the divisor total time is missing some fields new in 2.6.3* and later 
kernels, eg. see 
http://procps.cvs.sourceforge.net/viewvc/procps/procps/vmstat.c
eg.
Div= duse+dsys+didl+diow+dstl;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-library-master #34

2016-06-16 Thread Apache Jenkins Server

See 

Changes:

[svetoslav.neykov] Close streams after usage

--
[...truncated 20 lines...]
<===[JENKINS REMOTING CAPACITY]===>   channel started
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/1 clean 
install
[INFO] Scanning for projects...
[INFO] 
[INFO] Reactor Build Order:
[INFO] 
[INFO] Brooklyn Library Root
[INFO] Brooklyn CM SaltStack
[INFO] Brooklyn CM Ansible
[INFO] Brooklyn CM Integration Root
[INFO] Brooklyn Network Software Entities
[INFO] Brooklyn OSGi Software Entities
[INFO] Brooklyn Database Software Entities
[INFO] Brooklyn Web App Software Entities
[INFO] Brooklyn Messaging Software Entities
[INFO] Brooklyn NoSQL Data Store Software Entities
[INFO] Brooklyn Monitoring Software Entities
[INFO] Brooklyn QA
[INFO] Brooklyn Examples Aggregator Project
[INFO] Brooklyn Examples Aggregator Project - Webapps
[INFO] hello-world-webapp Maven Webapp
[INFO] hello-world-sql-webapp Maven Webapp
[INFO] Brooklyn Simple Web Cluster Example
[INFO] Brooklyn Global Web Fabric Example
[INFO] Brooklyn Simple Messaging Publish-Subscribe Example
[INFO] Brooklyn NoSQL Cluster Examples
[INFO] 
[INFO] 
[INFO] Building Brooklyn Library Root 0.10.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ brooklyn-library ---
[INFO] Deleting 

[INFO] Deleting  
(includes = [brooklyn*.log, brooklyn*.log.*, stacktrace.log, test-output, 
prodDb.*], excludes = [])
[INFO] 
[INFO] --- maven-replacer-plugin:1.4.1:replace 
(fix-eclipse-dot-classpath-mangling) @ brooklyn-library ---
[INFO] Ignoring missing file
[INFO] Replacement run on 0 file.
[INFO] 
[INFO] --- buildnumber-maven-plugin:1.3:create (default) @ brooklyn-library ---
[INFO] Executing: /bin/sh -c cd 
 && git rev-parse 
--verify HEAD
[INFO] Working directory: 

[INFO] Storing buildNumber: 7ceb3c254ca834fd1fc668a150fc61bc850c51c0 at 
timestamp: 1466072607372
[WARNING] Cannot get the branch information from the git repository: 
Detecting the current branch failed: fatal: ref HEAD is not a symbolic ref

[INFO] Executing: /bin/sh -c cd 
 && git rev-parse 
--verify HEAD
[INFO] Working directory: 

[INFO] Storing buildScmBranch: UNKNOWN
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (brooklyn-build-req) @ 
brooklyn-library ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
brooklyn-library ---
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.13:check (verify-style) @ brooklyn-library 
---
[INFO] 
[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
brooklyn-library ---
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ brooklyn-library ---
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: sandbox/**
[INFO] Exclude: release/**
[INFO] Exclude: README.md
[INFO] Exclude: **/nbactions.xml
[INFO] Exclude: **/nb-configuration.xml
[INFO] Exclude: **/.git/**
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.repository/**
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/.classpath/**
[INFO] Exclude: **/.project
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/*.log
[INFO] Exclude: **/brooklyn*.log.*
[INFO] Exclude: **/target/**
[INFO] Exclude: ignored/**
[INFO] Exclude: LICENSE.md
[INFO] Exclude: **/src/main/license/**
[INFO] Exclude: **/src/test/license/**
[INFO] Exclude: **/MANIFEST.MF
[INFO] Exclude: **/test-output/**
[INFO] Exclude: **/*.pem.pub
[INFO] Exclude: **/*.pem
[INFO] Exclude: **/*_rsa.pub
[INFO] Exclude: **/*_rsa
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/*.crt
[INFO] Exclude: **/*.csr
[INFO] Exclude: **/*.key
[INFO] Exclude: **/*.key.org
[INFO] Exclude: **/*.psd
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.plxarc
[INFO] Exclude: 
**/src/test/resources/org/apache/brooklyn/entity/software/base/template_with_extra_substitutions.txt
[INFO] Exclude: **/src/main/resources/banner.txt
[INFO] Exclude: **/src/test/resources/ssl/certs/localhost/info.txt
[INFO] Exclude: **/src/main/history/dependencies.xml
[INFO] Exclude: **/sandbox/examples/src/main/scripts/amis.txt
[INFO] Exclude: docs/**
[INFO] 3 resources included (use -debug for more details)
[INFO] Rat check: Summary of

[GitHub] brooklyn-library pull request #43: Close streams after usage

2016-06-16 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-library/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-16 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/196


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-master-windows #153

2016-06-16 Thread Apache Jenkins Server

See 

--
[...truncated 31343 lines...]
  Run 6: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 7: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 8: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 9: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 10: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 11: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 12: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...
  Run 13: ConfigInheritanceYamlTest.tearDown:139 » FileSystem 
C:\Users\CHRIST~1\AppData\...


Tests run: 343, Failures: 1, Errors: 0, Skipped: 294

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 46.825 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.557 s]
[INFO] Brooklyn Parent Project  SUCCESS [  5.255 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  6.885 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  2.068 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 27.048 s]
[INFO] Brooklyn API ... SUCCESS [  4.602 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.684 s]
[INFO] CAMP Base .. SUCCESS [  4.091 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.300 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  4.039 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.642 s]
[INFO] CAMP Server  SUCCESS [  8.411 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.300 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  4.354 s]
[INFO] Brooklyn Core .. SUCCESS [04:33 min]
[INFO] Brooklyn Policies .. SUCCESS [01:20 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [  9.958 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 10.872 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  1.313 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 27.719 s]
[INFO] Brooklyn Software Base . SUCCESS [01:27 min]
[INFO] Brooklyn CAMP REST API . FAILURE [ 53.760 s]
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] hello-world-webapp Maven Webapp

Jenkins build is back to normal : brooklyn-master-build #262

2016-06-16 Thread Apache Jenkins Server

See

Re: Machine Metrics

2016-06-16 Thread Sam Corbett

I share your concern that the placement of the feed is wrong. I feel 
like we would be bending Brooklyn's abstractions to fit the case rather 
than working out a better abstraction. Of course, deciding what data 
reflects a software process is subjective and as you point out we 
already break the encapsulation in a variety of places. Was the plan not 
always to make locations into entities too? This would be trivial if 
that were the case.


I also think we're continually making SoftwareProcess too important. 
Svet's suggestion of an enricher is a good one - I want to explicitly 
mix the capability in to entities, not enable it with a flag.


Sam


On 16/06/2016 09:13, Andrew Kennedy wrote:

Hi.

For the project I am working on, we would like to use the CPU utilization
as one of the metrics for scaling a cluster. The existing `MachineEntity`
has a sensor feed that produces this data, along with uptime and memory
usage information. The feed works on Linux VMs only, currently, as is uses
SSH commands on the host to generate the values i.e. the `uptime` command,
or the contents of files in `/proc/`.

I would like to propose moving the feed to `SoftwareProcess` so that it is
available to all entities. It would be disabled normally, set by a
`ConfigKey` flag. This would be named "metrics.machine.retrieve"
to correspond to "metrics.usage.retrieve" which enables sensors in feeds
that return application or process specific information. The
`MachineEntity` would obviously have the default value set to "true", to
maintain current behaviour.

The only issue with this change is that the placement of the sensor feed
feels slightly wrong. These are returning data about the _machine_ but the
entity represents a _process_ on that machine, and there may in fact be
multiple entities sharing a single machine, via `SameServerEntity`. The
`MachineEntity` is used to represent a VM without any applications running
on it, and would not normally be part of a blueprint, so these sensors are
not normally accessible. There is some precedent for placing machine data
on an entity, such as the `HOSTNAME` sensor, so I think the break in
encapsulation is quite small.

The PR containing the change is here:

- https://github.com/apache/brooklyn-server/pull/204

I'd appreciate any comments on whether this is a useful change, as well as
a review of the pull request...

Thanks,
Andrew.

[jira] [Commented] (BROOKLYN-302) SSLException: close_notify in ResourceUtils getResourceAsString against https url

2016-06-16 Thread Duncan Grant (JIRA)


[ 
https://issues.apache.org/jira/browse/BROOKLYN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333421#comment-15333421
 ] 

Duncan Grant commented on BROOKLYN-302:
---

Tried again from home in the evening and this failed as before.  I'll add some 
more details later.

> SSLException: close_notify in ResourceUtils getResourceAsString against https 
> url
> -
>
> Key: BROOKLYN-302
> URL: https://issues.apache.org/jira/browse/BROOKLYN-302
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.10.0
>Reporter: Duncan Grant
>Priority: Minor
>
> This can be reproduced by running the following in the groovy console of 
> brooklyn but I'm not sure when it will fail.
> {code}
> org.apache.brooklyn.util.core.ResourceUtils utils = 
> org.apache.brooklyn.util.core.ResourceUtils.create();
> String result = 
> utils.getResourceAsString("https://github.com/apache/brooklyn-library/raw/master/examples/simple-web-cluster/src/main/resources/visitors-creation-script.sql;);
> System.out.println(result);
> {code}
> I have seen this consistently fail for the last few days and have tried with 
> java versions 1.7.0_71, 1.8.0_45, and 1.8.0_92.
> Error on failure is:
> {noformat}
> 2016-06-14 16:43:13,301 WARN  Problem in user-supplied script: 
> org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: SSLException: 
> Received fatal alert: close_notify
> org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: 
>   at 
> org.apache.brooklyn.util.exceptions.Exceptions.propagate(Exceptions.java:128) 
> ~[brooklyn-utils-common-0.10.0-20160613.090333-51.jar:0.10.0-SNAPSHOT]
> Caused by: javax.net.ssl.SSLException: Received fatal alert: close_notify
>   at sun.security.ssl.Alerts.getSSLException(Alerts.java:208) 
> ~[na:1.8.0_92]
> {noformat}
> However this is working for me today.  This may be because I am running this 
> from the office rather than from home so I will try again at home this 
> evening.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Machine Metrics

2016-06-16 Thread Thomas Bouron

+0.5

Hi Andrew. While I see the benefit of moving those sensors to the
`SoftwareProcess` (which I quite like), that can lead to incorrect
policies' trigger when multiple `SoftwareProcess` will grouped into a
`SameServerEntity`.
That's my only concern about this change.

Now, the question is: what is the most common use-case? If using a policy
watching those sensors on multiple entities grouped into a `SameServerEntity`
is (or will be?) an edge case, then OK. Otherwise, @Svet suggestion might
be the way to go.

My £0.02.

Best.

On Thu, 16 Jun 2016 at 09:35 Svetoslav Neykov <
svetoslav.ney...@cloudsoftcorp.com> wrote:

> +1
>
> I think attaching an enricher would be a better approach than activating
> the polling through a config key, but not sure how feasible that is.
>
> Svet.
>
>
> > On 16.06.2016 г., at 11:13, Andrew Kennedy <
> andrew.kenn...@cloudsoftcorp.com> wrote:
> >
> > Hi.
> >
> > For the project I am working on, we would like to use the CPU utilization
> > as one of the metrics for scaling a cluster. The existing `MachineEntity`
> > has a sensor feed that produces this data, along with uptime and memory
> > usage information. The feed works on Linux VMs only, currently, as is
> uses
> > SSH commands on the host to generate the values i.e. the `uptime`
> command,
> > or the contents of files in `/proc/`.
> >
> > I would like to propose moving the feed to `SoftwareProcess` so that it
> is
> > available to all entities. It would be disabled normally, set by a
> > `ConfigKey` flag. This would be named "metrics.machine.retrieve"
> > to correspond to "metrics.usage.retrieve" which enables sensors in feeds
> > that return application or process specific information. The
> > `MachineEntity` would obviously have the default value set to "true", to
> > maintain current behaviour.
> >
> > The only issue with this change is that the placement of the sensor feed
> > feels slightly wrong. These are returning data about the _machine_ but
> the
> > entity represents a _process_ on that machine, and there may in fact be
> > multiple entities sharing a single machine, via `SameServerEntity`. The
> > `MachineEntity` is used to represent a VM without any applications
> running
> > on it, and would not normally be part of a blueprint, so these sensors
> are
> > not normally accessible. There is some precedent for placing machine data
> > on an entity, such as the `HOSTNAME` sensor, so I think the break in
> > encapsulation is quite small.
> >
> > The PR containing the change is here:
> >
> > - https://github.com/apache/brooklyn-server/pull/204
> >
> > I'd appreciate any comments on whether this is a useful change, as well
> as
> > a review of the pull request...
> >
> > Thanks,
> > Andrew.
> > --
> >
> > Andrew Kennedy ; Founder clocker.io project ; @grkvlt ; Cloudsoft
>
> --

Thomas Bouron • Software Engineer @ Cloudsoft Corporation •
http://www.cloudsoftcorp.com/
Github: https://github.com/tbouron
Twitter: https://twitter.com/eltibouron

[GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...

2016-06-16 Thread ceeaspb

Github user ceeaspb commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/204#discussion_r67308359
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
 ---
@@ -287,6 +299,89 @@ protected void postDriverStart() {
  */
 protected void connectSensors() {
 connectedSensors = true;
+boolean retrieveMachineMetrics = 
config().get(RETRIEVE_MACHINE_METRICS);
+if (retrieveMachineMetrics) connectMachineSensors();
+}
+
+/**
+ * Adds sensors returning details about the machine the process is 
running on.
+ * 
+ * The machine must be SSHable and running Linux.
+ */
+protected void connectMachineSensors() {
+Maybe location = 
Machines.findUniqueMachineLocation(getLocations(), SshMachineLocation.class);
+if (location.isPresent() && 
location.get().getOsDetails().isLinux()) {
+machineSensorFeed = SshFeed.builder()
+.entity(this)
+.period(Duration.THIRTY_SECONDS)
+.poll(SshPollConfig.forSensor(UPTIME)
+.command("cat /proc/uptime")
+
.onFailureOrException(Functions.constant(null))
+.onSuccess(new Function() {
+@Override
+public Duration apply(SshPollValue input) {
+return Duration.seconds( 
Double.valueOf( Strings.getFirstWord(input.getStdout()) ) );
+}
+}))
+.poll(SshPollConfig.forSensor(LOAD_AVERAGE)
+.command("uptime")
+.onFailureOrException(Functions.constant(-1d))
+.onSuccess(new Function() {
+@Override
+public Double apply(SshPollValue input) {
+String loadAverage = 
Strings.getFirstWordAfter(input.getStdout(), "load average:").replace(",", "");
+return Double.valueOf(loadAverage);
+}
+}))
+.poll(SshPollConfig.forSensor(CPU_USAGE)
+.command("cat /proc/stat")
--- End diff --

A problem with the cpu stats is that they are avarage since boot time, not 
since the last feed poll [ .period(Duration.THIRTY_SECONDS) ]
likely a separate issue but can we change this so it only accounts for 
usage since the last poll. It would require maintaining the counters as at the 
last poll time to calculate the difference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Machine Metrics

2016-06-16 Thread Svetoslav Neykov

+1

I think attaching an enricher would be a better approach than activating the 
polling through a config key, but not sure how feasible that is.

Svet.


> On 16.06.2016 г., at 11:13, Andrew Kennedy  
> wrote:
> 
> Hi.
> 
> For the project I am working on, we would like to use the CPU utilization
> as one of the metrics for scaling a cluster. The existing `MachineEntity`
> has a sensor feed that produces this data, along with uptime and memory
> usage information. The feed works on Linux VMs only, currently, as is uses
> SSH commands on the host to generate the values i.e. the `uptime` command,
> or the contents of files in `/proc/`.
> 
> I would like to propose moving the feed to `SoftwareProcess` so that it is
> available to all entities. It would be disabled normally, set by a
> `ConfigKey` flag. This would be named "metrics.machine.retrieve"
> to correspond to "metrics.usage.retrieve" which enables sensors in feeds
> that return application or process specific information. The
> `MachineEntity` would obviously have the default value set to "true", to
> maintain current behaviour.
> 
> The only issue with this change is that the placement of the sensor feed
> feels slightly wrong. These are returning data about the _machine_ but the
> entity represents a _process_ on that machine, and there may in fact be
> multiple entities sharing a single machine, via `SameServerEntity`. The
> `MachineEntity` is used to represent a VM without any applications running
> on it, and would not normally be part of a blueprint, so these sensors are
> not normally accessible. There is some precedent for placing machine data
> on an entity, such as the `HOSTNAME` sensor, so I think the break in
> encapsulation is quite small.
> 
> The PR containing the change is here:
> 
> - https://github.com/apache/brooklyn-server/pull/204
> 
> I'd appreciate any comments on whether this is a useful change, as well as
> a review of the pull request...
> 
> Thanks,
> Andrew.
> -- 
> 
> Andrew Kennedy ; Founder clocker.io project ; @grkvlt ; Cloudsoft

[GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity

2016-06-16 Thread neykov

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/204
  
LGTM. Will hold off merging so people get the chance to read and respond 
the dev@ mail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...

2016-06-16 Thread neykov

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/204#discussion_r67305518
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
 ---
@@ -373,6 +468,8 @@ protected void postRestart() {
  */
 protected void disconnectSensors() {
 connectedSensors = false;
+boolean retrieveMachineMetrics = 
config().get(RETRIEVE_MACHINE_METRICS);
+if (retrieveMachineMetrics) disconnectMachineSensors();
--- End diff --

(minor) I'd always call that and depend on the null check inside.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...

2016-06-16 Thread neykov

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/204#discussion_r67304808
  
--- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
 ---
@@ -85,15 +89,23 @@
  * It exposes sensors for service state (Lifecycle) and status (String), 
and for host info, log file location.
  */
 public abstract class SoftwareProcessImpl extends AbstractEntity 
implements SoftwareProcess, DriverDependentEntity {
-private static final Logger log = 
LoggerFactory.getLogger(SoftwareProcessImpl.class);
-
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftwareProcess.class);
--- End diff --

Did you remove the `Impl` suffix on purpose? I think we should keep it - it 
points to the file where the logging occurs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : brooklyn-server-master #135

2016-06-16 Thread Apache Jenkins Server

See

Machine Metrics

2016-06-16 Thread Andrew Kennedy

Hi.

For the project I am working on, we would like to use the CPU utilization
as one of the metrics for scaling a cluster. The existing `MachineEntity`
has a sensor feed that produces this data, along with uptime and memory
usage information. The feed works on Linux VMs only, currently, as is uses
SSH commands on the host to generate the values i.e. the `uptime` command,
or the contents of files in `/proc/`.

I would like to propose moving the feed to `SoftwareProcess` so that it is
available to all entities. It would be disabled normally, set by a
`ConfigKey` flag. This would be named "metrics.machine.retrieve"
to correspond to "metrics.usage.retrieve" which enables sensors in feeds
that return application or process specific information. The
`MachineEntity` would obviously have the default value set to "true", to
maintain current behaviour.

The only issue with this change is that the placement of the sensor feed
feels slightly wrong. These are returning data about the _machine_ but the
entity represents a _process_ on that machine, and there may in fact be
multiple entities sharing a single machine, via `SameServerEntity`. The
`MachineEntity` is used to represent a VM without any applications running
on it, and would not normally be part of a blueprint, so these sensors are
not normally accessible. There is some precedent for placing machine data
on an entity, such as the `HOSTNAME` sensor, so I think the break in
encapsulation is quite small.

The PR containing the change is here:

- https://github.com/apache/brooklyn-server/pull/204

I'd appreciate any comments on whether this is a useful change, as well as
a review of the pull request...

Thanks,
Andrew.
-- 

Andrew Kennedy ; Founder clocker.io project ; @grkvlt ; Cloudsoft

[GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...

2016-06-16 Thread grkvlt

GitHub user grkvlt opened a pull request:

https://github.com/apache/brooklyn-server/pull/204

Move machine metrics to SoftwareProcess entity

Moves the sensor feed for machine metrics to the SoftwareProcess, 
controlled by a configuration key with default set to _false_ normally and 
_true_ for `MachineEntity`. Also contributes static helper methods for feed 
`PollConfig` creation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/grkvlt/brooklyn-server move-machine-metrics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #204


commit 84b4d3fabd0d083d7ae4b6ab8faa7364467fa31a
Author: Andrew Donald Kennedy 
Date:   2016-06-16T07:08:39Z

Add static helper method to PollConfig objects

commit 4bb20b614f807cefb67bfa91a893760f5fdbbe42
Author: Andrew Donald Kennedy 
Date:   2016-06-16T07:12:45Z

Moved sensor feed for machine metrics to SoftwareProcess




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #203: Fix CAS operations on AtomicBoolean

2016-06-16 Thread grkvlt

GitHub user grkvlt opened a pull request:

https://github.com/apache/brooklyn-server/pull/203

Fix CAS operations on AtomicBoolean

Change to use correct idiom when using `AtomicBoolean` to guard against 
multiple invocations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/grkvlt/brooklyn-server fix-atomic-boolean-cas

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #203


commit 08432bec90209d20d2ac5efd21417ba32640a781
Author: Andrew Donald Kennedy 
Date:   2016-06-16T07:17:24Z

Fix usage of AtomicBooleas CAS idiom




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #202: Fix failing tests - handle newly introduc...

2016-06-16 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/202


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #202: Fix failing tests - handle newly introduc...

2016-06-16 Thread neykov

GitHub user neykov opened a pull request:

https://github.com/apache/brooklyn-server/pull/202

Fix failing tests - handle newly introduced config key



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/neykov/brooklyn-server fix/failing-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #202


commit 9a6de8ccb46ab9cdfbb4f51ff0b6eef05d364a60
Author: Svetoslav Neykov 
Date:   2016-06-16T06:57:14Z

Fix failing tests - handle newly introduced config key




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

49 matches

Mail list logo