[GitHub] brooklyn-server issue #572: Increase timeout in ReachableSocketFinderTest

2017-02-27 Thread sjcorbett
Github user sjcorbett commented on the issue:

https://github.com/apache/brooklyn-server/pull/572
  
@geomacy @neykov could you review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #462: Inherit config default values

2017-02-27 Thread ahgittin
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn-server/pull/462
  
Seems there may be a pathway by which REST does not populate an entity's 
`EntityType.configKeys` in this PR, reported by @sjcorbett .  Looking in to 
this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #572: wip: debug ReachableSocketFinderTest.getR...

2017-02-27 Thread sjcorbett
GitHub user sjcorbett opened a pull request:

https://github.com/apache/brooklyn-server/pull/572

wip: debug ReachableSocketFinderTest.getReachableSockets

Don't merge. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sjcorbett/brooklyn-server socket-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #572


commit cb8107c52699c898ef78fbf906f1313521bb7c02
Author: Sam Corbett 
Date:   2017-02-27T15:08:52Z

wip: debug ReachableSocketFinderTest#getReachableSockets




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Jenkins build is back to normal : brooklyn-master-build #866

2017-02-27 Thread Apache Jenkins Server
See 



Re: [PROPOSAL] Remove java 7 support

2017-02-27 Thread Robert Moss
Aled,

WRT Java 8 features.  Is it still recommended to use named inner classes
over anonymous inner classes? Can we now simplify those areas to use
lambdas?  There are a number of classes now built into Java that were
previously provided by Guava etc. e.g. Optional, Predicate - should we
start using the Java 8 classes instead where possible?

Robert

On 27 February 2017 at 13:08, Aled Sage  wrote:

> Hi all,
>
> I propose we switch to Java 8 for Apache Brooklyn (i.e. require Java 8;
> remove support for using Java 7 when running Brooklyn).
>
> This will make our testing simpler, improving coverage (e.g. we don't
> currently test everything with Brooklyn running both on Java 7 and Java 8).
> It will make our lives easier as developers (e.g. don't need to worry about
> Java 7 versus Java 8 when compiling, running tests and manually testing
> Brooklyn; and we can use Java 8 features).
>
> Java 7 reached end of life in April 2015 [1]; Java 8 was released March
> 2014.
>
> We can do this in three stages:
>
>  * Switch to Java 8 as "official target"
>  o Update our jenkins etc to always build/run with Java 8.
>  o All developers/testers switch to Java 8 locally.
>  o Add to the next release notes that Java 7 is no longer supported.
>  * Update our poms so they don't compile/check for Java 7 compatibility
>[3,4,5].
>  * Developers free to start using Java 8 language features!
>
> Stage 1 would be the bare minimum for the next release; I think we should
> do all three stages before the 0.11.0 release.
>
> Aled
>
> [1] https://java.com/en/download/faq/java_7.xml
> [2] https://www.infoq.com/news/2015/05/Oracle-Ends-Java-7Public-Updates
> [3] https://github.com/apache/brooklyn-server/blob/master/pom.xml#L91
> [4] https://github.com/apache/brooklyn-server/blob/master/parent
> /pom.xml#L557-L558
> [5] https://github.com/apache/brooklyn-server/blob/master/parent
> /pom.xml#L950
>
>


Re: [PROPOSAL] Remove java 7 support

2017-02-27 Thread Valentin Aitken

+1.

However because of intense usage of Lambdas in Java 8, we should bring 
up guide lines for writing persistable code [1]

and elaborate more on the paragraph from [1]
"Never use anonymous inner classes - even in static contexts. The 
auto-generated class names are brittle, making backwards compatibility 
harder.".

The above is especially true for config values.

Valentin.

[1] 
https://brooklyn.apache.org/v/latest/ops/persistence/index.html#writing-persistable-code

На 27/02/17 в 16:06, Thomas Bouron написа:

Like the others: +1

On Mon, 27 Feb 2017 at 13:47 Mark Mc Kenna  wrote:


+1

*Mark McKenna*

*Web :: markmckenna.ie *

*Work :: mark.mcke...@cloudsoft.io *

*PGP :: A7A9 24DE 638C 681A 8DEA FAD4 2B5D C759 B1EB 76A7
*

On 27 February 2017 at 13:42, Andrea Turli  wrote:


Hi all,

I propose we switch to Java 8 for Apache Brooklyn (i.e. require Java

8;

remove support for using Java 7 when running Brooklyn).

This will make our testing simpler, improving coverage (e.g. we don't
currently test everything with Brooklyn running both on Java 7 and

Java

8). It will make our lives easier as developers (e.g. don't need to
worry about Java 7 versus Java 8 when compiling, running tests and
manually testing Brooklyn; and we can use Java 8 features).

Java 7 reached end of life in April 2015 [1]; Java 8 was released

March

2014.

We can do this in three stages:

   * Switch to Java 8 as "official target"
   o Update our jenkins etc to always build/run with Java 8.
   o All developers/testers switch to Java 8 locally.
   o Add to the next release notes that Java 7 is no longer

supported.

   * Update our poms so they don't compile/check for Java 7

compatibility

 [3,4,5].
   * Developers free to start using Java 8 language features!

Stage 1 would be the bare minimum for the next release; I think we
should do all three stages before the 0.11.0 release.

Aled

[1] https://java.com/en/download/faq/java_7.xml
[2] https://www.infoq.com/news/2015/05/Oracle-Ends-Java-

7Public-Updates

[3]

https://github.com/apache/brooklyn-server/blob/master/pom.xml#L91

[4]

https://github.com/apache/brooklyn-server/blob/master/

parent/pom.xml#L557-L558

[5]
https://github.com/apache/brooklyn-server/blob/master/

parent/pom.xml#L950




--
Valentin Aitken
Software Engineer
Cloudsoft Corporation Ltd.
www.cloudsoft.io



Re: [PROPOSAL] Remove java 7 support

2017-02-27 Thread Thomas Bouron
Like the others: +1

On Mon, 27 Feb 2017 at 13:47 Mark Mc Kenna  wrote:

> +1
>
> *Mark McKenna*
>
> *Web :: markmckenna.ie *
>
> *Work :: mark.mcke...@cloudsoft.io *
>
> *PGP :: A7A9 24DE 638C 681A 8DEA FAD4 2B5D C759 B1EB 76A7
> *
>
> On 27 February 2017 at 13:42, Andrea Turli  >
> wrote:
>
> > +1
> >
> > Il 27/feb/2017 14:35, "Geoff Macartney" <
> geoff.macart...@cloudsoftcorp.com
> > >
> > ha scritto:
> >
> > > +1
> > >
> > > I have been hoping we could get round to this soon, think it's a good
> > idea.
> > >
> > >
> > >
> > > On Mon, 27 Feb 2017 at 13:09 Aled Sage  wrote:
> > >
> > > > Hi all,
> > > >
> > > > I propose we switch to Java 8 for Apache Brooklyn (i.e. require Java
> 8;
> > > > remove support for using Java 7 when running Brooklyn).
> > > >
> > > > This will make our testing simpler, improving coverage (e.g. we don't
> > > > currently test everything with Brooklyn running both on Java 7 and
> Java
> > > > 8). It will make our lives easier as developers (e.g. don't need to
> > > > worry about Java 7 versus Java 8 when compiling, running tests and
> > > > manually testing Brooklyn; and we can use Java 8 features).
> > > >
> > > > Java 7 reached end of life in April 2015 [1]; Java 8 was released
> March
> > > > 2014.
> > > >
> > > > We can do this in three stages:
> > > >
> > > >   * Switch to Java 8 as "official target"
> > > >   o Update our jenkins etc to always build/run with Java 8.
> > > >   o All developers/testers switch to Java 8 locally.
> > > >   o Add to the next release notes that Java 7 is no longer
> > supported.
> > > >   * Update our poms so they don't compile/check for Java 7
> > compatibility
> > > > [3,4,5].
> > > >   * Developers free to start using Java 8 language features!
> > > >
> > > > Stage 1 would be the bare minimum for the next release; I think we
> > > > should do all three stages before the 0.11.0 release.
> > > >
> > > > Aled
> > > >
> > > > [1] https://java.com/en/download/faq/java_7.xml
> > > > [2] https://www.infoq.com/news/2015/05/Oracle-Ends-Java-
> > 7Public-Updates
> > > > [3]
> https://github.com/apache/brooklyn-server/blob/master/pom.xml#L91
> > > > [4]
> > > >
> > > > https://github.com/apache/brooklyn-server/blob/master/
> > > parent/pom.xml#L557-L558
> > > > [5]
> > > > https://github.com/apache/brooklyn-server/blob/master/
> > > parent/pom.xml#L950
> > > >
> > > >
> > >
> >
>
-- 

Thomas Bouron • Software Engineer @ Cloudsoft Corporation •
http://www.cloudsoftcorp.com/
Github: https://github.com/tbouron
Twitter: https://twitter.com/eltibouron


[GitHub] brooklyn-ui pull request #42: Use the "itemType" to redirect the user to the...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-ui/pull/42


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-master-build #865

2017-02-27 Thread Apache Jenkins Server
See 

--
[...truncated 252.88 KB...]
2017-02-27 13:40:48,565 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizing()
2017-02-27 13:40:48,566 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizing() 
finished in 1 ms
2017-02-27 13:40:48,566 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizingBuilder()
2017-02-27 13:40:48,567 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizingBuilder() 
finished in 1 ms
2017-02-27 13:40:48,567 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testContainsLiteral()
2017-02-27 13:40:48,567 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testContainsLiteral() 
finished in 0 ms
2017-02-27 13:40:48,567 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testEqualToAny()
2017-02-27 13:40:48,568 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testEqualToAny() finished in 
1 ms
2017-02-27 13:40:48,568 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testIsBlank()
2017-02-27 13:40:48,569 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testIsBlank() finished in 1 
ms
2017-02-27 13:40:48,570 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testMatches()
2017-02-27 13:40:48,571 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testMatches() finished in 2 
ms
2017-02-27 13:40:48,571 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testStartsWith()
2017-02-27 13:40:48,572 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testStartsWith() finished in 
1 ms
2017-02-27 13:40:48,572 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testElvis()
2017-02-27 13:40:48,574 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testElvis() finished in 2 ms
2017-02-27 13:40:48,574 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testTruth()
2017-02-27 13:40:48,574 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testTruth() finished in 0 ms
2017-02-27 13:40:48,575 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventually()
2017-02-27 13:40:48,576 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventually() finished in 
1 ms
2017-02-27 13:40:48,577 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyPropagatesException()
Exception in thread 
"assertReturnsEventually(org.apache.brooklyn.test.AssertsTest$4@366913d0)" 
java.lang.IllegalStateException: Simulating failure
at org.apache.brooklyn.test.AssertsTest$4.run(AssertsTest.java:92)
at org.apache.brooklyn.test.Asserts$3.run(Asserts.java:1117)
at java.lang.Thread.run(Thread.java:745)
2017-02-27 13:40:48,578 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyPropagatesException()
 finished in 1 ms
2017-02-27 13:40:48,579 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyTimesOut()
2017-02-27 13:40:48,594 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyTimesOut() 
finished in 15 ms
2017-02-27 13:40:48,595 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertStrings()
2017-02-27 13:40:48,595 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertStrings() finished in 0 ms
2017-02-27 13:40:48,595 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testExpectedFailures()
2017-02-27 13:40:48,596 WARN  Detail of unexpected error: 
java.lang.IllegalStateException
java.lang.IllegalStateException: null
at 
org.apache.brooklyn.test.AssertsTest.testExpectedFailures(AssertsTest.java:140) 
[test-classes/:na]
2017-02-27 13:40:48,597 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testExpectedFailures() finished in 2 ms
2017-02-27 13:40:48,597 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testShouldHaveFailed()
2017-02-27 13:40:48,598 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testShouldHaveFailed() finished in 1 ms

Re: [PROPOSAL] Remove java 7 support

2017-02-27 Thread Mark Mc Kenna
+1

*Mark McKenna*

*Web :: markmckenna.ie *

*Work :: mark.mcke...@cloudsoft.io *

*PGP :: A7A9 24DE 638C 681A 8DEA FAD4 2B5D C759 B1EB 76A7
*

On 27 February 2017 at 13:42, Andrea Turli 
wrote:

> +1
>
> Il 27/feb/2017 14:35, "Geoff Macartney"  >
> ha scritto:
>
> > +1
> >
> > I have been hoping we could get round to this soon, think it's a good
> idea.
> >
> >
> >
> > On Mon, 27 Feb 2017 at 13:09 Aled Sage  wrote:
> >
> > > Hi all,
> > >
> > > I propose we switch to Java 8 for Apache Brooklyn (i.e. require Java 8;
> > > remove support for using Java 7 when running Brooklyn).
> > >
> > > This will make our testing simpler, improving coverage (e.g. we don't
> > > currently test everything with Brooklyn running both on Java 7 and Java
> > > 8). It will make our lives easier as developers (e.g. don't need to
> > > worry about Java 7 versus Java 8 when compiling, running tests and
> > > manually testing Brooklyn; and we can use Java 8 features).
> > >
> > > Java 7 reached end of life in April 2015 [1]; Java 8 was released March
> > > 2014.
> > >
> > > We can do this in three stages:
> > >
> > >   * Switch to Java 8 as "official target"
> > >   o Update our jenkins etc to always build/run with Java 8.
> > >   o All developers/testers switch to Java 8 locally.
> > >   o Add to the next release notes that Java 7 is no longer
> supported.
> > >   * Update our poms so they don't compile/check for Java 7
> compatibility
> > > [3,4,5].
> > >   * Developers free to start using Java 8 language features!
> > >
> > > Stage 1 would be the bare minimum for the next release; I think we
> > > should do all three stages before the 0.11.0 release.
> > >
> > > Aled
> > >
> > > [1] https://java.com/en/download/faq/java_7.xml
> > > [2] https://www.infoq.com/news/2015/05/Oracle-Ends-Java-
> 7Public-Updates
> > > [3] https://github.com/apache/brooklyn-server/blob/master/pom.xml#L91
> > > [4]
> > >
> > > https://github.com/apache/brooklyn-server/blob/master/
> > parent/pom.xml#L557-L558
> > > [5]
> > > https://github.com/apache/brooklyn-server/blob/master/
> > parent/pom.xml#L950
> > >
> > >
> >
>


[jira] [Commented] (BROOKLYN-444) Effector call works from GUI but fails from CLI

2017-02-27 Thread Geoff Macartney (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885799#comment-15885799
 ] 

Geoff Macartney commented on BROOKLYN-444:
--

Looks like the CLI is sending a parameter for the operation, even though it 
should not be; the parameter name is, however, a null string.  Not sure exactly 
of the cause but will have a look at it.



> Effector call works from GUI but fails from CLI
> ---
>
> Key: BROOKLYN-444
> URL: https://issues.apache.org/jira/browse/BROOKLYN-444
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.10.0
> Environment: Brooklyn Version 0.10.0 on Mac
>Reporter: Murdo Aird
>Assignee: Geoff Macartney
>Priority: Critical
>
> The following simple BP adds an Effector to an entity. The entity can be 
> called from the web UI and succeeds. Drilling into the Activity logs shows 
> the simple bash command works.
> However if I try to invoke the Effector via the CLI [1], the call fails:
> br app "effector-test" entity "Empty Software Process" effector DoStuff invoke
> For the CLI failure, it looks like a random (?) environment variable is being 
> injected via the CLI [2].
> {code:none}
> name: effector-test
> location: localhost
> services:
>   - type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess
> install.command: echo True
> launch.command: echo True
> checkRunning.command: echo true
> brooklyn.initializers:
>   - type: org.apache.brooklyn.core.effector.ssh.SshCommandEffector
> brooklyn.config:
>   name: DoStuff
>   command: whoami
> {code}
> * Calling a standard Effector (e.g. stop) via the CLI works. 
> * If the DoSuff Effector via CLI fails, I can subsequently call it from the 
> web UI and it works
> Not to muddy the waters, but calling the same Effector from the REST API also 
> results in an error - but it's a different one [3].
> [1] https://gist.github.com/murdoaird/0ba46476b8ec1e5039097b3754f720f7
> [2] https://gist.github.com/murdoaird/50777a5fa398a79611b4ec5bbfdc1d7d#env-1
> [3] https://gist.github.com/murdoaird/e153c5b3502d5475dee7358e2d9c3472



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (BROOKLYN-444) Effector call works from GUI but fails from CLI

2017-02-27 Thread Geoff Macartney (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Geoff Macartney reassigned BROOKLYN-444:


Assignee: Geoff Macartney

> Effector call works from GUI but fails from CLI
> ---
>
> Key: BROOKLYN-444
> URL: https://issues.apache.org/jira/browse/BROOKLYN-444
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.10.0
> Environment: Brooklyn Version 0.10.0 on Mac
>Reporter: Murdo Aird
>Assignee: Geoff Macartney
>Priority: Critical
>
> The following simple BP adds an Effector to an entity. The entity can be 
> called from the web UI and succeeds. Drilling into the Activity logs shows 
> the simple bash command works.
> However if I try to invoke the Effector via the CLI [1], the call fails:
> br app "effector-test" entity "Empty Software Process" effector DoStuff invoke
> For the CLI failure, it looks like a random (?) environment variable is being 
> injected via the CLI [2].
> {code:none}
> name: effector-test
> location: localhost
> services:
>   - type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess
> install.command: echo True
> launch.command: echo True
> checkRunning.command: echo true
> brooklyn.initializers:
>   - type: org.apache.brooklyn.core.effector.ssh.SshCommandEffector
> brooklyn.config:
>   name: DoStuff
>   command: whoami
> {code}
> * Calling a standard Effector (e.g. stop) via the CLI works. 
> * If the DoSuff Effector via CLI fails, I can subsequently call it from the 
> web UI and it works
> Not to muddy the waters, but calling the same Effector from the REST API also 
> results in an error - but it's a different one [3].
> [1] https://gist.github.com/murdoaird/0ba46476b8ec1e5039097b3754f720f7
> [2] https://gist.github.com/murdoaird/50777a5fa398a79611b4ec5bbfdc1d7d#env-1
> [3] https://gist.github.com/murdoaird/e153c5b3502d5475dee7358e2d9c3472



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [PROPOSAL] Remove java 7 support

2017-02-27 Thread Andrea Turli
+1

Il 27/feb/2017 14:35, "Geoff Macartney" 
ha scritto:

> +1
>
> I have been hoping we could get round to this soon, think it's a good idea.
>
>
>
> On Mon, 27 Feb 2017 at 13:09 Aled Sage  wrote:
>
> > Hi all,
> >
> > I propose we switch to Java 8 for Apache Brooklyn (i.e. require Java 8;
> > remove support for using Java 7 when running Brooklyn).
> >
> > This will make our testing simpler, improving coverage (e.g. we don't
> > currently test everything with Brooklyn running both on Java 7 and Java
> > 8). It will make our lives easier as developers (e.g. don't need to
> > worry about Java 7 versus Java 8 when compiling, running tests and
> > manually testing Brooklyn; and we can use Java 8 features).
> >
> > Java 7 reached end of life in April 2015 [1]; Java 8 was released March
> > 2014.
> >
> > We can do this in three stages:
> >
> >   * Switch to Java 8 as "official target"
> >   o Update our jenkins etc to always build/run with Java 8.
> >   o All developers/testers switch to Java 8 locally.
> >   o Add to the next release notes that Java 7 is no longer supported.
> >   * Update our poms so they don't compile/check for Java 7 compatibility
> > [3,4,5].
> >   * Developers free to start using Java 8 language features!
> >
> > Stage 1 would be the bare minimum for the next release; I think we
> > should do all three stages before the 0.11.0 release.
> >
> > Aled
> >
> > [1] https://java.com/en/download/faq/java_7.xml
> > [2] https://www.infoq.com/news/2015/05/Oracle-Ends-Java-7Public-Updates
> > [3] https://github.com/apache/brooklyn-server/blob/master/pom.xml#L91
> > [4]
> >
> > https://github.com/apache/brooklyn-server/blob/master/
> parent/pom.xml#L557-L558
> > [5]
> > https://github.com/apache/brooklyn-server/blob/master/
> parent/pom.xml#L950
> >
> >
>


[PROPOSAL] Remove java 7 support

2017-02-27 Thread Aled Sage

Hi all,

I propose we switch to Java 8 for Apache Brooklyn (i.e. require Java 8; 
remove support for using Java 7 when running Brooklyn).


This will make our testing simpler, improving coverage (e.g. we don't 
currently test everything with Brooklyn running both on Java 7 and Java 
8). It will make our lives easier as developers (e.g. don't need to 
worry about Java 7 versus Java 8 when compiling, running tests and 
manually testing Brooklyn; and we can use Java 8 features).


Java 7 reached end of life in April 2015 [1]; Java 8 was released March 
2014.


We can do this in three stages:

 * Switch to Java 8 as "official target"
 o Update our jenkins etc to always build/run with Java 8.
 o All developers/testers switch to Java 8 locally.
 o Add to the next release notes that Java 7 is no longer supported.
 * Update our poms so they don't compile/check for Java 7 compatibility
   [3,4,5].
 * Developers free to start using Java 8 language features!

Stage 1 would be the bare minimum for the next release; I think we 
should do all three stages before the 0.11.0 release.


Aled

[1] https://java.com/en/download/faq/java_7.xml
[2] https://www.infoq.com/news/2015/05/Oracle-Ends-Java-7Public-Updates
[3] https://github.com/apache/brooklyn-server/blob/master/pom.xml#L91
[4] 
https://github.com/apache/brooklyn-server/blob/master/parent/pom.xml#L557-L558
[5] 
https://github.com/apache/brooklyn-server/blob/master/parent/pom.xml#L950




[GitHub] brooklyn-server issue #571: Better error reporting

2017-02-27 Thread ahgittin
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn-server/pull/571
  
Test failure due to Apache build system configuration:  `insufficient 
memory for the Java Runtime Environment to continue`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #567: Add catalog "itemType" to the CatalogItem...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/567


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request #571: Better error reporting

2017-02-27 Thread ahgittin
GitHub user ahgittin opened a pull request:

https://github.com/apache/brooklyn-server/pull/571

Better error reporting

populate error field of `ApiError`, and better logging on REST errors

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ahgittin/brooklyn-server 
rest-error-codes-and-messages

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #571


commit 178475859424a1c27bc3900c5fba780369981960
Author: Alex Heneveld 
Date:   2017-02-27T12:48:59Z

populate error field of `ApiError`, and better logging on REST errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #567: Add catalog "itemType" to the CatalogItemSummary...

2017-02-27 Thread tbouron
Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-server/pull/567
  
@drigodwin Tests pass on Jenkins now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Beginner's issue in launching brooklyn from vagrant

2017-02-27 Thread Svetoslav Neykov
Please ignore.

Obviously wrong reply :).

Svet.


> On 26.02.2017 г., at 20:34, Svetoslav Neykov 
>  wrote:
> 
> +1 (non-binding)
> 
> I successfully ran:
>   * the verification script on Java 7
>   * the live tests for the vagrant provider (with pre-loaded images 
> ubuntu/xenial64, ubuntu/trusty64, boxcutter/eval-win2012r2-standard)
>   * sanity checked simple deployments on Amazon, Bluebox, Vagrant.
> 
> Svet.
> 
> 
>> On 25.02.2017 г., at 4:57, Rupinder Singh > > wrote:
>> 
>> Hi Svet, John
>> 
>> I changed the Vagrantfile as suggested, as attached here. The output remains 
>> as before.
>> 
>> Rupinder
>> 
>> On Sat, Feb 25, 2017 at 7:00 AM, John McCabe > > wrote:
>> Hi Rupinder,
>> I think you've added Svets suggested config update in the wrong place. It
>> should be added in the following block (note you're just adding the
>> vb.customize here):
>> 
>>   server_config.vm.provider :virtualbox do |vb|
>> vb.name  = server["name"]
>> vb.memory = server["ram"]
>> vb.cpus = server["cpus"]
>> vb.customize ["modifyvm", :id, "--hwvirtex", "off"]
>>   end
>> 
>> Make sure to remove your earlier changes.
>> 
>> (Note: I don't have a non-VT-X system to validate this on)
>> 
>> /John
>> 
>> On Sat, 25 Feb 2017 at 00:57 Rupinder Singh > > wrote:
>> 
>> attachments, which I missed in earlier email, here.
>> 
>> On Sat, Feb 25, 2017 at 5:57 AM, Rupinder Singh > > wrote:
>> 
>> Hi Svet,
>> Thanks for your continued support.
>> I tried to change Vagrantfile as attached here in raw. The output remains
>> as before as attached here.
>> 
>> Rupinder
>> 
>> On Fri, Feb 24, 2017 at 9:42 PM, Svetoslav Neykov <
>> svetoslav.ney...@cloudsoftcorp.com 
>> > wrote:
>> 
>> Hi rupinder,
>> 
>> In the Vagrantfile try to disable virtualization. Insert the following
>> before the end of the configure section [1]:
>> 
>> config.vm.provider :virtualbox do |vb|
>>   vb.customize ["modifyvm", :id, "--hwvirtex", "off"]
>> end
>> 
>> Svet.
>> 
>> [1]
>> https://github.com/apache/brooklyn-dist/blob/c9c688ccdea150817800b05d0a39aa0e812e27f4/vagrant/src/main/vagrant/Vagrantfile#L84
>>  
>> 
>> 
>> > On 24.02.2017 г., at 18:06, Rupinder Singh > > > wrote:
>> >
>> > 1. my pc doesn't have VT-X for sure.
>> >
>> > 2. But I run ubuntu out of Oracle VirtualBox and installation works.
>> >
>> > rupinder
>> >
>> >
>> >
>> > On Mon, Feb 20, 2017 at 9:02 PM, Rupinder Singh > > >
>> wrote:
>> >>
>> >>
>> >> Hi Svet
>> >> 1. No. I am not running vagrant inside another VM.
>> >>
>> >> 2. Windows 7. So it doesn't have hyper-V installed.
>> >>
>> >> rupinder
>> >>
>> >> On Mon, Feb 20, 2017 at 8:43 PM, Svetoslav Neykov <
>> > svetoslav.ney...@cloudsoftcorp.com 
>> > > wrote:
>> >>>
>> >>> Hi Rupinder,
>> >>>
>> >>> If your machine doesn't support virtualisation you can still give
>> > Brooklyn a try by executing it directly in Windows.
>> >>> Download the zip[1] archive, extract it and run "bin/brooklyn launch"
>> > from the extracted folder. You can configure a cloud location
>> >>> and deploy an example blueprint to it. Drop by in our IRC channel
>> > #brooklyncentral (on FreeNode) if you need guidance on how to do that.
>> >>>
>> >>> Having said that, all recent processors should support virtualisation.
>> > If you don't have the option it could mean that it's already enabled.
>> >>> The error you get could (alternatively) be caused by one of the
>> > following:
>> >>>  * You are trying to run vagrant inside another VM. Is your Windows
>> > running locally in a VM? Are you working through an RDP session?
>> >>>  * You have Hyper-V (which is Microsoft's alternative to Virtualbox)
>> > enabled. Need to disable it - see the stackoverflow link sent by Mike
>> below.
>> >>>
>> >>>
>> >>> Svet.
>> >>>
>> >>>
>> >>> [1]
>> >
>> https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.10.0/apache-brooklyn-0.10.0-bin.zip
>>  
>> 
>> >>>
>> >>>
>>  On 20.02.2017 г., at 16:13, Rupinder Singh >  > wrote:
>> 
>>  I have Compaq R191B. Virtualization option is not there in BIOS.
>> > Doesn't
>>  support VT-X.
>> 
>>  On Mon, Feb 20, 2017 at 1:06 AM, Valentin Aitken <
>>  valentin.ait...@cloudsoftcorp.com 
>>  > 

[GitHub] brooklyn-server issue #567: Add catalog "itemType" to the CatalogItemSummary...

2017-02-27 Thread tbouron
Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-server/pull/567
  
@drigodwin Tried 2 times locally, the tests pass. I'll trigger another 
jenkins build to make sure it was not a false-positive


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-master-build #864

2017-02-27 Thread Apache Jenkins Server
See 

--
[...truncated 252.65 KB...]
2017-02-27 09:56:15,103 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testQuoting()
2017-02-27 09:56:15,104 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testQuoting() finished 
in 1 ms
2017-02-27 09:56:15,105 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizing()
2017-02-27 09:56:15,106 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizing() 
finished in 1 ms
2017-02-27 09:56:15,107 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizingBuilder()
2017-02-27 09:56:15,108 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizingBuilder() 
finished in 1 ms
2017-02-27 09:56:15,109 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testContainsLiteral()
2017-02-27 09:56:15,111 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testContainsLiteral() 
finished in 1 ms
2017-02-27 09:56:15,111 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testEqualToAny()
2017-02-27 09:56:15,113 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testEqualToAny() finished in 
2 ms
2017-02-27 09:56:15,114 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testIsBlank()
2017-02-27 09:56:15,116 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testIsBlank() finished in 2 
ms
2017-02-27 09:56:15,116 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testMatches()
2017-02-27 09:56:15,119 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testMatches() finished in 3 
ms
2017-02-27 09:56:15,120 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testStartsWith()
2017-02-27 09:56:15,122 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.text.StringPredicatesTest.testStartsWith() finished in 
2 ms
2017-02-27 09:56:15,123 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testElvis()
2017-02-27 09:56:15,125 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testElvis() finished in 2 ms
2017-02-27 09:56:15,133 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testTruth()
2017-02-27 09:56:15,137 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.JavaGroovyEquivalentsTest.testTruth() finished in 4 ms
2017-02-27 09:56:15,140 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventually()
2017-02-27 09:56:15,149 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventually() finished in 
8 ms
2017-02-27 09:56:15,152 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyPropagatesException()
Exception in thread 
"assertReturnsEventually(org.apache.brooklyn.test.AssertsTest$4@276e2428)" 
java.lang.IllegalStateException: Simulating failure
at org.apache.brooklyn.test.AssertsTest$4.run(AssertsTest.java:92)
at org.apache.brooklyn.test.Asserts$3.run(Asserts.java:1117)
at java.lang.Thread.run(Thread.java:745)
2017-02-27 09:56:15,162 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyPropagatesException()
 finished in 10 ms
2017-02-27 09:56:15,163 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyTimesOut()
2017-02-27 09:56:15,182 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertReturnsEventuallyTimesOut() 
finished in 19 ms
2017-02-27 09:56:15,183 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertStrings()
2017-02-27 09:56:15,185 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testAssertStrings() finished in 2 ms
2017-02-27 09:56:15,185 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.test.AssertsTest.testExpectedFailures()
2017-02-27 09:56:15,190 WARN  Detail of unexpected error: 
java.lang.IllegalStateException
java.lang.IllegalStateException: null
at 
org.apache.brooklyn.test.AssertsTest.testExpectedFailures(AssertsTest.java:140) 
[test-classes/:na]
2017-02-27 09:56:15,191 INFO  TESTNG PASSED: "Surefire test" - 

[GitHub] brooklyn-docs pull request #148: Adds doc for urlEncode DSL

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/148


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs issue #148: Adds doc for urlEncode DSL

2017-02-27 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-docs/pull/148
  
@neykov's comment addressed; @drigodwin deferred for a future PR. Merging 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request #148: Adds doc for urlEncode DSL

2017-02-27 Thread aledsage
Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/148#discussion_r103166453
  
--- Diff: guide/yaml/yaml-reference.md ---
@@ -213,6 +213,9 @@ concise DSL defined here:
   `$brooklyn:root()`.
 * `$brooklyn:formatString("pattern e.g. %s %s", "field 1", "field 2")` 
returns a future which creates the formatted string
   with the given parameters, where parameters may be strings *or* other 
tasks such as `attributeWhenReady`
+* `$brooklyn:urlEncode("val")` returns a future which creates a string 
with the characters escaped
--- End diff --

@drigodwin agreed - the wording I used here is consistent with the rest of 
the descriptions. I'll leave it as-is for this PR. We should revisit to rewrite 
the descriptions of the entire "DSL Commands" section. An introductory 
paragraph that says about how the DSL is resolved is probably worth while (it's 
important that users understand it's a future for any non-trivial use-case, so 
they can understand when/if it will block (and also what happens if you compose 
DSL).

---
We are also missing a better description and examples of how to compose the 
DSL - e.g. are we recommending what to me feels like "idiomatic yaml" like:
```
$brooklyn:formatString:
- "http://%s; 
- $brooklyn:attributeWhenReady("host.subnet.hostname")
```

versus `$brooklyn:formatString("http://%s;, 
$brooklyn:attributeWhenReady("host.subnet.hostname"))`, which looks more like a 
programming language and less like configuration. (I get that it is effectively 
programming, but that doesn't mean the user needs to write it like that!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request #86: switch vagrant boxes to bento images

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-dist/pull/86


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist issue #86: switch vagrant boxes to bento images

2017-02-27 Thread geomacy
Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-dist/pull/86
  
looks good thanks @johnmccabe - merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request #148: Adds doc for urlEncode DSL

2017-02-27 Thread aledsage
Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/148#discussion_r103165332
  
--- Diff: guide/yaml/yaml-reference.md ---
@@ -213,6 +213,9 @@ concise DSL defined here:
   `$brooklyn:root()`.
 * `$brooklyn:formatString("pattern e.g. %s %s", "field 1", "field 2")` 
returns a future which creates the formatted string
   with the given parameters, where parameters may be strings *or* other 
tasks such as `attributeWhenReady`
+* `$brooklyn:urlEncode("val")` returns a future which creates a string 
with the characters escaped
+  so it is a valid part of a URL. The parameter can be a string *or* 
another task. For example,
+  `$brooklyn:urlEncode($brooklyn:config(\"mykey\"))`
--- End diff --

Agreed - I've added:
```
It uses "www-form-urlencoded" for the encoding, which is appropriate for 
query 
parameters but not for some other parts of the URL (e.g. space is encoded 
as '+').
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---