[GitHub] brooklyn-server issue #953: Defers reading of config in SshCommandSensor

[nakomis]

Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/953
  
PR comments addressed


---

[GitHub] brooklyn-docs pull request #252: Update event notice styling

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/252


---

[GitHub] brooklyn-docs issue #251: Add ApacheCon logo button to landing page

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-docs/pull/251
  
Cool, I'll merge yours


---

[GitHub] brooklyn-docs pull request #252: Update event notice styling

[tbouron]

GitHub user tbouron opened a pull request:

https://github.com/apache/brooklyn-docs/pull/252

Update event notice styling

This builds on top of #251 


![screencapture-127-0-0-1-4000-2018-04-17-16_44_32](https://user-images.githubusercontent.com/2082759/38882250-90a4af92-4261-11e8-90fd-9f03b1e567c7.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tbouron/brooklyn-docs apachecon-notice

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-docs/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit aace9bf9bfdf726f315e70deaa0ceab2d1025618
Author: Geoff Macartney 
Date:   2018-04-11T20:57:33Z

Add ApacheCon logo button to landing page

As requested by Rich Bowen:

On Mon, 9 Apr 2018 at 14:07 Rich Bowen  wrote:
Dear PMCs,

ApacheCon is our official community event, and is coming up in
September, in Montreal. We need your help getting the word out to your
user communities. (Details at http://apachecon.com/ )

We've made this as easy as possible - it's just a cut-and-paste
snippet that we ask you to add to your site to display the logo of the
nearest future event. That process is documented here:
http://apache.org/events/README.txt  You can see it in action on, for
example, http://httpd.apache.org/

If you follow these steps, it will automatically update for the next
event, and the one after that. We have two other events planned for
this year, and are already working on 5 events for 2019.

Note: If you don't like the available image sizes, please pitch in and
help us define better sizes/dimensions. Patches welcome. We also have
these banners - http://apachecon.com/acna18/banners/ - which can be
used instead, and can also be used for other, non-ASF sites.

This is also a good time to remind you that we have general site
requirements. These are outlined at
https://www.apache.org/foundation/marks/pmcs#navigation and you can
check your project's compliance at https://whimsy.apache.org/site/

Thanks, and don't hesitate to get in touch if you have any questions,
comments, or concerns.

Rich Bowen, VP, Events

commit 741dbd3234353bef9d6cabc39e64cb156b4bbbeb
Author: Thomas Bouron 
Date:   2018-04-17T15:58:35Z

Update event alert styling




---

[GitHub] brooklyn-docs issue #251: Add ApacheCon logo button to landing page

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-docs/pull/251
  
That looks super, by all means go ahead.


---

[GitHub] brooklyn-docs issue #251: Add ApacheCon logo button to landing page

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-docs/pull/251
  
@geomacy LGTM.

While this is very nice, I took the liberty to play a bit with it and ended 
up with this:

![screencapture-127-0-0-1-4000-2018-04-17-16_44_32](https://user-images.githubusercontent.com/2082759/38880866-a15f0bb4-425e-11e8-9df7-91948d14b063.png)

That way, a user can close the "notification" if they don't want to see it. 
Tell me if you like that and I can commit on top of yours. Otherwise, happy to 
merge as it is.


---

Re: [DISCUSSION] Kubernetes Helm

[Andrea Turli]

Thomas,

thanks for taking care of this.

Geomacy,

I've built brooklyn-{server,dist} on OSX and ran it from CentOS 7 and it
works fine as I think `os-maven-plugin` is doing the right incantation

Richard,

I think helm is a well appreciated tool for kubernetes ecoystem.

I think I can donate my work as community-supported addon although it is
designed as a Brooklyn location not a simple application blueprint, but
worth noticing that it was not part of the core but was committed in
`brooklyn-server/locations/container` module, which seems a perfect match
to me,
I undestand the helm location works with the classic launcher, but there is
an extra complexity to OSGify grpc (a transitive dependency of
microbean-helm) to make it work with brooklyn-karaf.

I may resubmit the contribution without bringing in the microbean-helm java
client but writing a simpler restful client for Helm/Tiller, but not sure
how hard it would be to refactor the location yet.

Best,
Andrea



On Tue, 17 Apr 2018 at 11:50 Richard Downer  wrote:

> All,
>
> I'm sorry but I'm not really aware of the Kubernetes ecosystem in much
> detail. Do we have an indication of how much demand there is for Helm
> support in Brooklyn?
>
> This sounds like a significant change - both to our build process, but also
> our release process and website (supporting multiple platform downloads).
> I'd be opposed to doing it unless there's a significant demand for Helm.
> I'd prefer to see this as a community-supported addon (like most of our
> blueprints are) instead of being core Brooklyn, until there's evidence of
> demand for this to be in core.
>
> Richard.
>
>
>
> On 17 April 2018 at 09:07, Geoff Macartney 
> wrote:
>
> > hi Thomas
> >
> > It certainly doesn't sound right to have to have separate builds of
> > Brooklyn for different platforms, and especially not just for this
> > feature.  Can we build the dependency package into a bundle for each
> > platform, so that it is the only thing that is platform specific, and
> > provide all three bundles along with the distribution of Brooklyn? Then
> on
> > whatever target platform you are on, OSX, Linux, Windows, you install the
> > right dependency bundle for that platform into Brooklyn's Karaf?
> >
> > Geoff
> >
> >
> >
> > On Mon, 16 Apr 2018 at 12:18 Thomas Bouron  > com>
> > wrote:
> >
> > > Hi Brooklyners.
> > >
> > > You might have noticed that the Brooklyn builds started to fail more
> than
> > > usual recently. I spent some time last week to fix those issues but I
> > just
> > > realised that there is a deeper one with the recent change I merged
> > (about
> > > Kubernetes Helm)
> > >
> > > This change requires a dependency, which depends on some native code.
> > Now,
> > > this dependency exists for 3 platforms: macOS, Linux and Window. The
> > issue
> > > is that the "right" dependency is included at build time via the maven
> > > classifier, and the way it is picked is by looking at the current build
> > OS
> > > and selecting the corresponding one[1]. Obviously, this leads to nasty
> > > problem: as all our builds are done on Linux, Brooklyn artifacts only
> > work
> > > on Linux. Not only that, the classifier is dynamically picked and set
> as
> > > envvar by a plugin. This is also an issue for any downstream projects.
> > >
> > > While we want this feature in Brooklyn, I don't think this is
> acceptable
> > > for our users therefore I reverted the changes and started this
> > > conversation. What do you think would be the best approach to fix this?
> > > Having 1 build per platform doesn't sound good as it won't be portable
> > > anymore. Maybe we can find another dependency without a link to native
> > > code?
> > >
> > > Best.
> > >
> > > [1]
> > >
> > > https://github.com/apache/brooklyn-dist/pull/119/files#diff-
> > 01b5eceed5fb6499e99a42e711695648R139
> > > --
> > >
> > > Thomas Bouron • Senior Software Engineer @ Cloudsoft Corporation •
> > > https://cloudsoft.io/
> > > Github: https://github.com/tbouron
> > > Twitter: https://twitter.com/eltibouron
> > >
> >
>

[GitHub] brooklyn-server pull request #954: Changes access of `StringPredicates` clas...

[nakomis]

Github user nakomis closed the pull request at:

https://github.com/apache/brooklyn-server/pull/954


---