[GitHub] brooklyn issue #15: edit Brooklyn license info so that GitHub recognizes it

2018-06-21 Thread dankohn
Github user dankohn commented on the issue:

https://github.com/apache/brooklyn/pull/15
  
It's up to the project if you'd prefer that 
https://landscape.cncf.io/selected=apache-brooklyn point to 
https://github.com/apache/brooklyn instead of 
https://github.com/apache/brooklyn-server. The issue I had with the former is 
that GitHub doesn't show an updated date when the subprojects are updated. So, 
until your April 30th update, it was showing the last update as November 2017. 
This is a problem because we have a policy to remove projects if they haven't 
been updated in 3 months.

The real issue here is that the metadata from sub-projects doesn't 
percolate up to the parent project. My workaround was just to point to Brooklyn 
Server.


---


[GitHub] brooklyn issue #15: edit Brooklyn license info so that GitHub recognizes it

2018-06-21 Thread eirinikos
Github user eirinikos commented on the issue:

https://github.com/apache/brooklyn/pull/15
  
Thank you @geomacy and @ahgittin !

@ahgittin in response to your feedback ...

(1) Yes, I do have an ICLA on file (as of 6/18/18).
(2) Yes, it does seem like the Appendix is required for `licensee` to work. 
I agree with your point re: Google, but it seems that `licensee` gets easily 
confused if it does not detect the entirety of the Apache license text 
(Appendix, and all).

I also agree that the current approach isn't ideal, and that it could make 
sense to have `LICENSE` include only the Apache License and to have `NOTICE` 
include the other items. Looking forward to seeing what the ML has to say about 
this.

Also, thanks @geomacy for pointing out the discrepancy between this PR (on 
the `brooklyn` repo) and the actual URL on the [Landscape 
page](https://landscape.cncf.io/selected=apache-brooklyn). It looks like you 
and @ahgittin have a solution in place (i.e., updating the scripts). I wonder 
if it might also make sense for the Landscape page to point to the [Brooklyn 
repo](https://github.com/apache/brooklyn) rather than the [Brooklyn-Server 
repo](https://github.com/apache/brooklyn-server) (@dankohn would be the one who 
could advise on that.)


---


Build failed in Jenkins: brooklyn-library-master-docker #234

2018-06-21 Thread Apache Jenkins Server
See 


--
[...truncated 9.55 KB...]
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 94 implicit excludes (use -debug for more details).
[INFO] Exclude: sandbox/**
[INFO] Exclude: release/**
[INFO] Exclude: README.md
[INFO] Exclude: **/.git/**
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.repository/**
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/.classpath/**
[INFO] Exclude: **/.project
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/*.log
[INFO] Exclude: **/brooklyn*.log.*
[INFO] Exclude: **/target/**
[INFO] Exclude: **/nbactions.xml
[INFO] Exclude: **/nb-configuration.xml
[INFO] Exclude: ignored/**
[INFO] Exclude: LICENSE.md
[INFO] Exclude: .mvn/jvm.config
[INFO] Exclude: **/src/main/license/**
[INFO] Exclude: **/src/test/license/**
[INFO] Exclude: **/MANIFEST.MF
[INFO] Exclude: **/test-output/**
[INFO] Exclude: **/*.pem.pub
[INFO] Exclude: **/*.pem
[INFO] Exclude: **/*_rsa.pub
[INFO] Exclude: **/*_rsa
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/*.crt
[INFO] Exclude: **/*.csr
[INFO] Exclude: **/*.key
[INFO] Exclude: **/*.key.org
[INFO] Exclude: **/*.psd
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.plxarc
[INFO] Exclude: 
**/src/test/resources/org/apache/brooklyn/entity/software/base/template_with_extra_substitutions.txt
[INFO] Exclude: **/src/main/resources/banner.txt
[INFO] Exclude: **/src/test/resources/ssl/certs/localhost/info.txt
[INFO] Exclude: **/src/main/history/dependencies.xml
[INFO] Exclude: **/sandbox/examples/src/main/scripts/amis.txt
[INFO] Exclude: docs/**
[INFO] Exclude: **/.m2/**
[INFO] 828 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 82, unknown: 82, 
generated: 0, approved: 691 licenses.
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from /usr/build/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 94 implicit excludes (use -debug for more details).
[INFO] Exclude: sandbox/**
[INFO] Exclude: release/**
[INFO] Exclude: README.md
[INFO] Exclude: **/.git/**
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.repository/**
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/.classpath/**
[INFO] Exclude: **/.project
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/*.log
[INFO] Exclude: **/brooklyn*.log.*
[INFO] Exclude: **/target/**
[INFO] Exclude: **/nbactions.xml
[INFO] Exclude: **/nb-configuration.xml
[INFO] Exclude: ignored/**
[INFO] Exclude: LICENSE.md
[INFO] Exclude: .mvn/jvm.config
[INFO] Exclude: **/src/main/license/**
[INFO] Exclude: **/src/test/license/**
[INFO] Exclude: **/MANIFEST.MF
[INFO] Exclude: **/test-output/**
[INFO] Exclude: **/*.pem.pub
[INFO] Exclude: **/*.pem
[INFO] Exclude: **/*_rsa.pub
[INFO] Exclude: **/*_rsa
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/*.crt
[INFO] Exclude: **/*.csr
[INFO] Exclude: **/*.key
[INFO] Exclude: **/*.key.org
[INFO] Exclude: **/*.psd
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.plxarc
[INFO] Exclude: 
**/src/test/resources/org/apache/brooklyn/entity/software/base/template_with_extra_substitutions.txt
[INFO] Exclude: **/src/main/resources/banner.txt
[INFO] Exclude: **/src/test/resources/ssl/certs/localhost/info.txt
[INFO] Exclude: **/src/main/history/dependencies.xml
[INFO] Exclude: **/sandbox/examples/src/main/scripts/amis.txt
[INFO] Exclude: docs/**
[INFO] Exclude: **/.m2/**
[INFO] 828 resources included (use -debug for more details)
[WARNING] Files with unapproved licenses:
  repo/software/nosql/src/test/resources/test-mongodb-configserver.conf
  repo/software/nosql/src/test/resources/mongodb-keyfile
  repo/software/nosql/src/test/resources/test-mongodb.conf
  repo/software/nosql/src/test/resources/test-mongodb-router.conf
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/couchdb/couch.uri
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/couchdb/couch.ini
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/solr/solr.xml
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/cassandra/cassandra-rackdc.properties
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/cassandra/cassandra-1.2.yaml
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/cassandra/cassandra-2.0.yaml
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/riak/app.config
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/riak/riak.conf
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/riak/vm.args
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/riak/riak-mac.conf
  
repo/software/nosql/src/main/resources/org/apache/brooklyn/entity/nosql/hazelcast/hazelcast-brooklyn.xml
  

[GitHub] brooklyn issue #15: edit Brooklyn license info so that GitHub recognizes it

2018-06-21 Thread geomacy
Github user geomacy commented on the issue:

https://github.com/apache/brooklyn/pull/15
  
Sounds good to me @ahgittin 

Yes it was my intention to update the scripts to change the licenses 
elsewhere, if you are happy to pick this up as part of changes you are making 
anyway that's grand.

@eirinikos sorry I should have asked about an ICLA, it would be great if 
you could file one. The Apache Brooklyn docs contain guidance about this at 
https://brooklyn.apache.org/developers/how-to-contribute.html.  Thanks!


---


[GitHub] brooklyn issue #15: edit Brooklyn license info so that GitHub recognizes it

2018-06-21 Thread ahgittin
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn/pull/15
  
@eirinikos TY.  i agree with the objective and this is a good partial 
implementation.  two main questions:

(1) do you have an Apache ICLA on file with the ASF so we can merge this?

(2) is the "APPENDIX: How to apply the Apache License to your work." 
required for `licensee` to work?  given the existence of google etc it seems 
pointless.


@geomacy your point is correct, this should be done for all the 
sub-projects too.  however the LICENSE files are auto-generated so rather than 
do them piecemeal i suggest we:

(A) agree the approach
(B) apply it to the scripts
(C) rerun the scripts

regarding (A) @eirinikos @geomacy, i'm not thrilled about moving the 
current header to 1000 lines down as it means a person reading it won't easily 
find it and probably won't have any clue that there is anything present in the 
file other than the main license.  but i can see why the tool requires it to be 
the first or the only text in the file.  however apache requires us to include 
much of that other info -- it doesn't _need_ the header but i think a header 
makes the information much more useful.  which is a bit of a catch-22.

i wonder whether we could make `LICENSE` be _just_ the Apache License, and 
move other items into `NOTICE`.  the ASF docs vary as to what should go into 
`NOTICE` but on the surface of it, given the trend that tools expect `LICENSE` 
to be a standard license nothing more nothing less, it seems a logical move to 
make `NOTICE` be the guy who holds all the other stuff.  i will ask on the 
relevent ML and report back.

regarding (B) i've been working on that for a related issue as per ML so 
happy to pick this up once we settle (A).

in the meantime i think this should be merged once we have ICLA 
confirmation so that CNCF and other tools get the right idea, and we should 
check once we've done (C) that they still get the right idea.


---


Re: LICENSE file questions - MIT, binary, process

2018-06-21 Thread Geoff Macartney
Hi Alex,

I'm not an expert on licensing requirements but the above sounds convincing
to me.  Your proposal sounds like a good plan.  Re. question 3 I think it
is okay to include the Apache licensed dependencies in the binary LICENSE
too.

A minor note  - have you seen https://github.com/apache/brooklyn/pull/15 "edit
Brooklyn license info so that GitHub recognizes it"?  I intend to merge
this but added the comment to clarify whether we should do the same for all
our repos (I assume so).  I intend to raise PRs to do this if so.

Geoff



On Wed, 20 Jun 2018 at 13:47 Alex Heneveld 
wrote:

>
> Hi Brooklyn devs-
>
> In prepping the new UI contribution I've been working on the LICENSE
> file generation.  It is rather extensive because by using Angular we
> pull in hundreds of JS deps for the binary, most of them under MIT
> license which as I understand it means copyright information must be
> reproduced in the LICENSE for the binary dist.  This is based on the MIT
> clause "The above copyright notice and this permission notice shall be
> included in all copies or substantial portions of the Software" in
> accordance with the principle that copyright extends to translations.
> While it would be tempting to treat the compiled/minified version as not
> a copy and so not requiring the copyright -- and that may well be the
> intention of many MIT license users (contrasted with BSD which
> explicitly calls out binaries as requiring the copyright) -- I don't
> believe we can hide behind that.  (So JS devs please take note, please
> use the Apache License! :) )
>
>
> Question 1:  Is this correct, our binaries LICENSE files need to list
> all MIT, BSD, ISC licensed dependencies whose minified/compiled output
> is included in our binary dist?
>
>
> In the process I've noticed we in Brooklyn don't currently distinguish
> consistently between the source LICENSE and binary LICENSE.  As I
> understand it from [1], the LICENSE file included with source projects
> -- including I believe the one at the root of the git repo -- should
> refer to resources included in the source only.  Dependencies that are
> downloaded as part of the build and included in the binary should not be
> listed in those LICENSE files, but they must be included in any binary
> build (eg the RPM, TGZ).
>
> It's not yet a big issue as it doesn't matter for Apache licensed
> dependencies as they do not require copyright inclusion or attribution
> and these are the bulk of what we do.  Where we do need to look more
> closely I think are:
>
> (A) The Go CLI -- we use a few libraries (mainly MIT licensed)
> downloaded at build time.  The LICENSE file [2] includes these
> libraries.  This is included in the binary build, which is correct, but
> it is also present at the root of that sub-project where it is
> incorrect, and our source build also references these libraries which is
> incorrect.
>
> (B) JS in "brooklyn-server" -- we have a few JS libraries included in
> the source tree of brooklyn-server (not downloaded during the build),
> for some of the CLI commands; these are indicated in that project's
> LICENSE [3], correctly, and in the binary build's LICENSE, also
> correctly.  But the project source LICENSE [3] seems to include all the
> JS used in the "brooklyn-ui" project which is not correct.
>
> (C) JS in existing (old) "brooklyn-ui" -- this source project includes
> all the JS deps checked in, and it is listed in the LICENSE [4],
> correctly, and is included in the build binary, also correctly; no
> action is needed here
>
> (D) JS in new (proposed) "brooklyn-ui" -- this project updates to use
> npm and package.json so downloads dependencies, with no dependencies in
> the source tree, so the project source LICENSE shouldn't list any
> dependencies.  However the binary license should include the ~100
> dependencies that npm downloads and uglifies. Fortunately npm
> license-checker [5] automates much of this (although the copyright line
> will sometimes have to be teased out manually).
>
>
> Question 2:  Does the above sound right?
>
>
> I'm reasonably confident of this so if no objections I will adjust our
> LICENSE generation process to distinguish between binary and source, and
> tidy up (A) and (B) above, and set up the contribution as per (D).
>
> Finally one more question -- it's easy to tweak the process to include
> Apache-licensed dependencies used in the binary.  While this isn't
> legally required AFAIK it seems like a nice thing to do.
>
>
> Question 3:  Is everyone okay with giving a shout-out to Apache-licensed
> deps in addition to MIT, BSD, etc, within our binary LICENSE ?
>
>
> Best
> Alex
>
>
> [1]  https://apache.org/dev/licensing-howto.html
> [2] https://github.com/apache/brooklyn-client/blob/master/cli/LICENSE
> [3]  https://github.com/apache/brooklyn-server/blob/master/LICENSE
> [4]  https://github.com/apache/brooklyn-ui/blob/master/LICENSE
> [5]  https://www.npmjs.com/package/license-checker
>


Build failed in Jenkins: brooklyn-master-build-docker #484

2018-06-21 Thread Apache Jenkins Server
See 


--
Started by upstream project "brooklyn-server-master-docker" build number 92
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H33 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/brooklyn.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/brooklyn.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/brooklyn.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae
Commit message: "Merge and close #14"
 > git rev-list --no-walk d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae # timeout=10
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule init # timeout=10
 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10
 > git config --get submodule.brooklyn-ui.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-ui.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-ui
 > git config --get submodule.brooklyn-server.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-server.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-server
 > git config --get submodule.brooklyn-library.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-library.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-library
 > git config --get submodule.brooklyn-dist.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-dist.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-dist
 > git config --get submodule.brooklyn-docs.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-docs.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-docs
 > git config --get submodule.brooklyn-client.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-client.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-client
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins3516105132182269326.sh
+ mkdir -p .m2
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins1173558975416536898.sh
+ git submodule update --remote --merge --recursive
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins7293575387517123579.sh
+ docker build -t brooklyn:latest .
Error checking context: 'can't stat 
'
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: Test reports were found 
but none of them are new. Did leafNodes run? 
For example, 

 is 1 mo 3 days old

TestNG Reports Processing: START
Looking for TestNG results report in workspace using pattern: 
**/testng-results.xml
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build 

Jenkins build is back to normal : brooklyn-server-master-docker #92

2018-06-21 Thread Apache Jenkins Server
See 




[GitHub] brooklyn-docs pull request #260: Use the official AWS CLI instead of s3cmd

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/260


---


[GitHub] brooklyn-docs issue #260: Use the official AWS CLI instead of s3cmd

2018-06-21 Thread duncangrant
Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-docs/pull/260
  
Merging - thanks @tbouron 


---


[GitHub] brooklyn-docs pull request #258: Fix copy-state usage for brooklyn-karaf

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/258


---


[jira] [Commented] (BROOKLYN-594) REST api /v1/server/ha/persist/export fails in brooklyn karaf

2018-06-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/BROOKLYN-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519409#comment-16519409
 ] 

ASF GitHub Bot commented on BROOKLYN-594:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/972


> REST api /v1/server/ha/persist/export fails in brooklyn karaf
> -
>
> Key: BROOKLYN-594
> URL: https://issues.apache.org/jira/browse/BROOKLYN-594
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.12.0
>Reporter: Aled Sage
>Priority: Major
>
> I tried to make the REST api call below:
> {noformat}
> curl -v -u ":" http://localhost:8081/v1/server/ha/persist/export
> {noformat}
> With Brooklyn classic, it works. But for karaf, it fails with the error shown 
> below:
> {noformat}
> 2018-06-20T14:47:59,576 - WARN  348 o.a.b.r.r.ServerResource 
> [qtp923543361-204] Unable to serve persistence data (rethrowing): 
> java.lang.ClassCastException: Proxyfbab2eff_60a1_4850_831a_cea0ce1d588a 
> cannot be cast to org.apache.brook
> lyn.core.mgmt.internal.LocalManagementContext
> java.lang.ClassCastException: Proxyfbab2eff_60a1_4850_831a_cea0ce1d588a 
> cannot be cast to 
> org.apache.brooklyn.core.mgmt.internal.LocalManagementContext
> at 
> org.apache.brooklyn.core.mgmt.persist.BrooklynPersistenceUtils.newStateMementoFromLocal(BrooklynPersistenceUtils.java:195)
>  [127:org.apache.brooklyn.core:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.core.mgmt.persist.BrooklynPersistenceUtils.newStateMemento(BrooklynPersistenceUtils.java:149)
>  [127:org.apache.brooklyn.core:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.core.mgmt.persist.BrooklynPersistenceUtils.writeMemento(BrooklynPersistenceUtils.java:215)
>  [127:org.apache.brooklyn.core:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.rest.resources.ServerResource.exportPersistenceData(ServerResource.java:486)
>  [348:org.apache.brooklyn.rest-resources:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.rest.resources.ServerResource.exportPersistenceData(ServerResource.java:471)
>  [348:org.apache.brooklyn.rest-resources:1.0.0.SNAPSHOT]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]
> at 
> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:189) 
> [163:org.apache.cxf.cxf-rt-frontend-jaxrs:3.1.10]
> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:99) 
> [163:org.apache.cxf.cxf-rt-frontend-jaxrs:3.1.10]
> at 
> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:59)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:96)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:262)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:180)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:299)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.AbstractHTTPServlet.doGet(AbstractHTTPServlet.java:223)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 

[GitHub] brooklyn-server pull request #972: BROOKLYN-594: fix REST api /v1/server/ha/...

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/972


---


[jira] [Commented] (BROOKLYN-594) REST api /v1/server/ha/persist/export fails in brooklyn karaf

2018-06-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/BROOKLYN-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519398#comment-16519398
 ] 

ASF GitHub Bot commented on BROOKLYN-594:
-

Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-server/pull/972
  
I'll merge - thanks @nakomis 


> REST api /v1/server/ha/persist/export fails in brooklyn karaf
> -
>
> Key: BROOKLYN-594
> URL: https://issues.apache.org/jira/browse/BROOKLYN-594
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.12.0
>Reporter: Aled Sage
>Priority: Major
>
> I tried to make the REST api call below:
> {noformat}
> curl -v -u ":" http://localhost:8081/v1/server/ha/persist/export
> {noformat}
> With Brooklyn classic, it works. But for karaf, it fails with the error shown 
> below:
> {noformat}
> 2018-06-20T14:47:59,576 - WARN  348 o.a.b.r.r.ServerResource 
> [qtp923543361-204] Unable to serve persistence data (rethrowing): 
> java.lang.ClassCastException: Proxyfbab2eff_60a1_4850_831a_cea0ce1d588a 
> cannot be cast to org.apache.brook
> lyn.core.mgmt.internal.LocalManagementContext
> java.lang.ClassCastException: Proxyfbab2eff_60a1_4850_831a_cea0ce1d588a 
> cannot be cast to 
> org.apache.brooklyn.core.mgmt.internal.LocalManagementContext
> at 
> org.apache.brooklyn.core.mgmt.persist.BrooklynPersistenceUtils.newStateMementoFromLocal(BrooklynPersistenceUtils.java:195)
>  [127:org.apache.brooklyn.core:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.core.mgmt.persist.BrooklynPersistenceUtils.newStateMemento(BrooklynPersistenceUtils.java:149)
>  [127:org.apache.brooklyn.core:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.core.mgmt.persist.BrooklynPersistenceUtils.writeMemento(BrooklynPersistenceUtils.java:215)
>  [127:org.apache.brooklyn.core:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.rest.resources.ServerResource.exportPersistenceData(ServerResource.java:486)
>  [348:org.apache.brooklyn.rest-resources:1.0.0.SNAPSHOT]
> at 
> org.apache.brooklyn.rest.resources.ServerResource.exportPersistenceData(ServerResource.java:471)
>  [348:org.apache.brooklyn.rest-resources:1.0.0.SNAPSHOT]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]
> at 
> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:189) 
> [163:org.apache.cxf.cxf-rt-frontend-jaxrs:3.1.10]
> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:99) 
> [163:org.apache.cxf.cxf-rt-frontend-jaxrs:3.1.10]
> at 
> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:59)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:96)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>  [159:org.apache.cxf.cxf-core:3.1.10]
> at 
> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:262)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:180)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:299)
>  [171:org.apache.cxf.cxf-rt-transports-http:3.1.10]
> at 
> org.apache.cxf.transport.servlet.AbstractHTTPServlet.doGet(AbstractHTTPServlet.java:223)
>  

[GitHub] brooklyn-server issue #972: BROOKLYN-594: fix REST api /v1/server/ha/persist...

2018-06-21 Thread duncangrant
Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-server/pull/972
  
I'll merge - thanks @nakomis 


---


[GitHub] brooklyn-docs issue #260: Use the official AWS CLI instead of s3cmd

2018-06-21 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-docs/pull/260
  
LGTM


---


[GitHub] brooklyn-docs pull request #260: Use the official AWS CLI instead of s3cmd

2018-06-21 Thread tbouron
GitHub user tbouron opened a pull request:

https://github.com/apache/brooklyn-docs/pull/260

Use the official AWS CLI instead of s3cmd

Based on this comment: 
https://github.com/apache/brooklyn-docs/pull/258#discussion_r197133399

Note: I checked the docs and this is the only place where we suggested to 
use `s3cmd`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tbouron/brooklyn-docs patch-7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-docs/pull/260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #260


commit 60b3f515adf46515bc16f6857ffdabcc13eec82f
Author: Thomas Bouron 
Date:   2018-06-21T13:40:27Z

Use the official AWS CLI instead of s3cmd




---


[GitHub] brooklyn-docs issue #258: Fix copy-state usage for brooklyn-karaf

2018-06-21 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-docs/pull/258
  
One minor comment, other than that LGTM


---


[GitHub] brooklyn-docs pull request #258: Fix copy-state usage for brooklyn-karaf

2018-06-21 Thread nakomis
Github user nakomis commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/258#discussion_r197133399
  
--- Diff: guide/ops/persistence/index.md ---
@@ -246,16 +246,16 @@ The state can be downloaded periodically from the 
object store, archived and bac
 An example script to be invoked by CRON is shown below:
 
 DATE=`date "+%Y%m%d.%H%M.%S"`
-BACKUP_FILENAME=/path/to/archives/back-${DATE}.tar.gz
-TEMP_DATA_DIR=/path/to/tempdir
-
-brooklyn copy-state \
---persistenceLocation named:my-persistence-location \
---persistenceDir /path/to/bucket \
---destinationDir $TEMP_DATA_DIR
+BACKUP_FILENAME=/path/to/archives/back-${DATE}.zip
+HOSTNAME=localhost
+USERNAME=admin
+PASSWORD=pa55wOrd
+
+curl -v -u "${USERNAME}:${PASSWORD}" \
+https://${HOSTNAME}:8443/v1/server/ha/persist/export \
+> ${BACKUP_FILENAME}
 
-tar --exclude '*/backups/*' -czvf $BACKUP_FILENAME $TEMP_DATA_DIR
 # For s3cmd installation see http://s3tools.org/repositories
--- End diff --

I know it's not directly related to this PR, but we should switch to 
recommending the official AWS CLI now that it's mature and stable:

```
# For AWS CLI installation see https://aws.amazon.com/cli
aws s3 cp $BACKUP_FILENAME s3://mybackupbucket
rm $BACKUP_FILENAME
```


---


[GitHub] brooklyn issue #15: edit Brooklyn license info so that GitHub recognizes it

2018-06-21 Thread geomacy
Github user geomacy commented on the issue:

https://github.com/apache/brooklyn/pull/15
  
hi @eirinikos this looks good, but I do have one question. The linked CNCF 
site above refers to Brooklyn's repository as `Repository 
https://github.com/apache/brooklyn-server`.   I'm guessing this change in 
`./.../brooklyn` will not fix the linked page above,  is that right?  I expect 
we should also update `brooklyn-server` and our other repositories (`dist`, 
`docs` etc.)?



---


Build failed in Jenkins: brooklyn-master-build-docker #483

2018-06-21 Thread Apache Jenkins Server
See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H33 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/brooklyn.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/brooklyn.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/brooklyn.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae
Commit message: "Merge and close #14"
 > git rev-list --no-walk d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae # timeout=10
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule init # timeout=10
 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10
 > git config --get submodule.brooklyn-ui.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-ui.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-ui
 > git config --get submodule.brooklyn-server.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-server.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-server
 > git config --get submodule.brooklyn-library.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-library.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-library
 > git config --get submodule.brooklyn-dist.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-dist.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-dist
 > git config --get submodule.brooklyn-docs.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-docs.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-docs
 > git config --get submodule.brooklyn-client.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-client.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-client
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins5930471582854507186.sh
+ mkdir -p .m2
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins5885088133442624184.sh
+ git submodule update --remote --merge --recursive
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins3655134902597034731.sh
+ docker build -t brooklyn:latest .
Error checking context: 'can't stat 
'
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: Test reports were found 
but none of them are new. Did leafNodes run? 
For example, 

 is 1 mo 3 days old

TestNG Reports Processing: START
Looking for TestNG results report in workspace using pattern: 
**/testng-results.xml
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.

[GitHub] brooklyn-server issue #972: BROOKLYN-594: fix REST api /v1/server/ha/persist...

2018-06-21 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/972
  
Tested; LGTM


---


[GitHub] brooklyn-server issue #971: DSL for $brooklyn:location()

2018-06-21 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/971
  
Looks good, nothing to add to @geomacy's comments


---


[GitHub] brooklyn-server issue #970: MultiLocation yaml tests

2018-06-21 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/970
  
Tested, LGTM


---


Build failed in Jenkins: brooklyn-master-build-docker #482

2018-06-21 Thread Apache Jenkins Server
See 


--
Started by upstream project "brooklyn-dist-master-docker" build number 22
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H33 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/brooklyn.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/brooklyn.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/brooklyn.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae
Commit message: "Merge and close #14"
 > git rev-list --no-walk d136ae3a3cc022a4da7d62f10e3e886c4e3e26ae # timeout=10
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule init # timeout=10
 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10
 > git config --get submodule.brooklyn-ui.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-ui.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-ui
 > git config --get submodule.brooklyn-server.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-server.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-server
 > git config --get submodule.brooklyn-library.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-library.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-library
 > git config --get submodule.brooklyn-dist.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-dist.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-dist
 > git config --get submodule.brooklyn-docs.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-docs.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-docs
 > git config --get submodule.brooklyn-client.url # timeout=10
 > git config -f .gitmodules --get submodule.brooklyn-client.path # timeout=10
 > git submodule update --init --recursive --remote brooklyn-client
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins7310282287165899822.sh
+ mkdir -p .m2
[brooklyn-master-build-docker] $ /bin/bash -xe 
/tmp/jenkins5608508923344192984.sh
+ git submodule update --remote --merge --recursive
[brooklyn-master-build-docker] $ /bin/bash -xe /tmp/jenkins693859538302930816.sh
+ docker build -t brooklyn:latest .
Error checking context: 'can't stat 
'
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: Test reports were found 
but none of them are new. Did leafNodes run? 
For example, 

 is 1 mo 3 days old

TestNG Reports Processing: START
Looking for TestNG results report in workspace using pattern: 
**/testng-results.xml
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. Ignoring it.
testng-results.xml was last modified before this build started. 

[GitHub] brooklyn-docs pull request #259: Use generate-password.sh script

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/259


---


[GitHub] brooklyn-dist pull request #122: Add generate-password.sh

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-dist/pull/122


---


[GitHub] brooklyn-dist issue #122: Add generate-password.sh

2018-06-21 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-dist/pull/122
  
Thanks @duncangrant - I have squashed the three commits into one, and will 
merge.


---