[GitHub] brooklyn-server pull request #971: DSL for $brooklyn:location()

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/971


---

[GitHub] brooklyn-server issue #971: DSL for $brooklyn:location()

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/971
  
Thanks @geomacy @nakomis - merging now. Brooklyn issues are probably the 
best way to record and track further improvements, I think.


---

[GitHub] brooklyn-server issue #971: DSL for $brooklyn:location()

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/971
  
Happy for this to be merged and the more general improvements done 
separately.  How to capture/document the desire to do this? - a `//TODO`?  a 
BROOKLYN- issue?




---

[GitHub] brooklyn-server issue #971: DSL for $brooklyn:location()

[nakomis]

Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/971
  
LGTM apart from a minor comment on the test. I agree it would be nice to be 
able to tell whether DSL simply hasn't resolved yet or whether it's permanently 
failed to resolve, but I'm happy for this PR to be merged in the meantime


---

[GitHub] brooklyn-server pull request #971: DSL for $brooklyn:location()

[nakomis]

Github user nakomis commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/971#discussion_r214940310
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java
 ---
@@ -467,6 +467,30 @@ public void testDslLocation() throws Exception {
 assertEquals(getConfigInTask(testEntity, 
ConfigKeys.newConfigKey(Object.class, "config2")), appLoc);
 }
 
+@Test
+public void testDslLocationIndexOutOfBounds() throws Exception {
+String yaml = Joiner.on("\n").join(
+"location: localhost",
+"services:",
+"- type: " + BasicApplication.class.getName(),
+"  brooklyn.config:",
+"config1: $brooklyn:location(\"1\")");
+
+Application app = (Application) 
createStartWaitAndLogApplication(yaml);
+
+Location appLoc = Iterables.getOnlyElement(app.getLocations());
+try {
+assertEquals(getConfigInTask(app, 
ConfigKeys.newConfigKey(Object.class, "config1")), appLoc);
--- End diff --

If an exception is not thrown here the test will pass when it should fail. 
This case should be checked, e.g. by throwing `IllegalStateException` after 
this line


---

Re: Time to make a release?

[Richard Downer]

Looks like we have a consensus.

**KLAXON**

Last call for PRs before the release. Please let me know TODAY if there's
anything that needs to go in. Tomorrow morning I'll assess the requested
PRs and get a release started.

Richard.


On Tue, 4 Sep 2018 at 09:41, Thomas Bouron 
wrote:

> +1
>
> On Tue, 4 Sep 2018 at 09:34 Geoff Macartney 
> wrote:
>
>> +1 to an interim release
>>
>> On Mon, 3 Sep 2018 at 13:31 Alex Heneveld <
>> alex.henev...@cloudsoftcorp.com>
>> wrote:
>>
>> >
>> > +1
>> >
>> > We might want to make an effort to get these merged (but I don't think
>> > it's critical):
>> >
>> > * https://github.com/apache/brooklyn-server/pulls
>> >  #982 - better type coercion
>> >  #971 - location DSL
>> >
>> > There are a few others in library, docs, and dist, which we should take
>> > care of as general housekeeping but not ahead of an M1 IMO.
>> >
>> > Best
>> > Alex
>> >
>> >
>> > On 03/09/2018 13:24, Aled Sage wrote:
>> > > +1
>> > >
>> > > Assuming there's consensus, shall we give 24 hours for folk to get any
>> > > outstanding PRs submitted/merged, before we kick an RC1 etc?
>> > >
>> > > Aled
>> > >
>> > >
>> > > On 03/09/2018 13:17, Richard Downer wrote:
>> > >> All,
>> > >>
>> > >> It's probably about time we made a release - shockingly, it's been
>> > >> nearly a
>> > >> year since the last one.
>> > >>
>> > >> We want to start the release train towards a 1.0 release, but I
>> think we
>> > >> could benefit from an interim release first, given that the paint is
>> > >> still
>> > >> drying on the new UI. Therefore I propose a "milestone 1" release,
>> > >> 1.0.0-M1. I'm happy to volunteer to be release manager on this one.
>> > >>
>> > >> Thoughts, comments, +1 or -1?
>> > >>
>> > >> Cheers
>> > >> Richard
>> > >>
>> > >
>> >
>> >
>>
> --
>
> Thomas Bouron
> Senior Software Engineer
>
> *Cloudsoft  *| Bringing Business to the Cloud
>
> GitHub: https://github.com/tbouron
> Twitter: https://twitter.com/eltibouron
>
> Need a hand with AWS? Get a Free Consultation.
>

Re: Time to make a release?

[Geoff Macartney]

+1 to an interim release

On Mon, 3 Sep 2018 at 13:31 Alex Heneveld 
wrote:

>
> +1
>
> We might want to make an effort to get these merged (but I don't think
> it's critical):
>
> * https://github.com/apache/brooklyn-server/pulls
>  #982 - better type coercion
>  #971 - location DSL
>
> There are a few others in library, docs, and dist, which we should take
> care of as general housekeeping but not ahead of an M1 IMO.
>
> Best
> Alex
>
>
> On 03/09/2018 13:24, Aled Sage wrote:
> > +1
> >
> > Assuming there's consensus, shall we give 24 hours for folk to get any
> > outstanding PRs submitted/merged, before we kick an RC1 etc?
> >
> > Aled
> >
> >
> > On 03/09/2018 13:17, Richard Downer wrote:
> >> All,
> >>
> >> It's probably about time we made a release - shockingly, it's been
> >> nearly a
> >> year since the last one.
> >>
> >> We want to start the release train towards a 1.0 release, but I think we
> >> could benefit from an interim release first, given that the paint is
> >> still
> >> drying on the new UI. Therefore I propose a "milestone 1" release,
> >> 1.0.0-M1. I'm happy to volunteer to be release manager on this one.
> >>
> >> Thoughts, comments, +1 or -1?
> >>
> >> Cheers
> >> Richard
> >>
> >
>
>

[GitHub] brooklyn-server pull request #982: Improve coercions esp with generics

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/982


---