Build failed in Jenkins: Brooklyn » Brooklyn » master #788

2023-05-17 Thread Apache Jenkins Server 
See 


Changes:


--
[...truncated 30983 lines...]
  ComputeServiceState{uniqueTag=service.state.actual, running=true, 
entity=WorkflowStartableImpl{id=lib6l5ps40}, id=e7ofcobq8u}
  
ComputeServiceIndicatorsFromChildrenAndMembers{uniqueTag=service-not-up-indicators-from-children-and-members,
 running=true, entity=WorkflowStartableImpl{id=lib6l5ps40}, id=vxkbbi7scy}
  enricher.aggregating.fromChildren[ConfigKey:java.lang.Boolean] = true
  enricher.aggregating.fromMembers[ConfigKey:java.lang.Boolean] = false
  
enricher.service_state.children_and_members.quorum.up[ConfigKey:org.apache.brooklyn.util.collections.QuorumCheck]
 = QuorumCheck[all;require=0,100.0%]
  
enricher.service_state.children_and_members.service_problems.publish[ConfigKey:java.lang.Boolean]
 = false
  enricher.suppressDuplicates[ConfigKey:java.lang.Boolean] = true
2023-05-17 11:44:57,065 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.entity.stock.WorkflowStartableTest.testSettingSensors() 
finished in 2219 ms
2023-05-17 11:44:57,066 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2023-05-17 11:44:57,096 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 30 ms
2023-05-17 11:44:57,517 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG 
===
Surefire test
Tests run: 2680, Failures: 2, Skips: 0
===
[GC (Allocation Failure)  380014K->175102K(758272K), 0.0249170 secs]
[GC (Allocation Failure)  380926K->176160K(758272K), 0.0250720 secs]
2023-05-17 11:44:59,696 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG RUNNING: Suite: "Surefire test" containing "0" Tests (config: null)
2023-05-17 11:44:59,863 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithDateTimeTo()
2023-05-17 11:44:59,870 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithDateTimeTo()
 finished in 21 ms
2023-05-17 11:44:59,871 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithEntityId()
2023-05-17 11:44:59,871 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithEntityId()
 finished in 21 ms
2023-05-17 11:44:59,871 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithSearchSinglePhrase()
2023-05-17 11:44:59,872 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithSearchSinglePhrase()
 finished in 22 ms
2023-05-17 11:44:59,872 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithEntityIdAndPhrase()
2023-05-17 11:44:59,872 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithEntityIdAndPhrase()
 finished in 22 ms
2023-05-17 11:44:59,873 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithTaskId()
2023-05-17 11:44:59,873 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithTaskId()
 finished in 23 ms
2023-05-17 11:44:59,873 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithTimeRange()
2023-05-17 11:44:59,874 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.util.core.logbook.opensearch.OpenSearchLogStoreTest.queryWithTimeRange()
 finished in 23 ms
2023-05-17 11:44:59,874 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" -

Build failed in Jenkins: Brooklyn » Brooklyn - Server module » master #462

2023-05-17 Thread Apache Jenkins Server 
See 


Changes:


--
[...truncated 29760 lines...]
2023-05-17 10:59:24,655 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 9 ms
2023-05-17 10:59:24,655 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.setUp()
2023-05-17 10:59:24,674 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.setUp() finished in 19 ms
2023-05-17 10:59:24,675 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.testStartWithVanillaFailingChild()
2023-05-17 10:59:24,710 WARN  o.a.b.c.e.l.ServiceStateLogic$ComputeServiceState 
 Setting FailingEntityImpl{id=aiu1robw4u} on-fire due to problems when expected 
running, up=false, not-up-indicators: null
2023-05-17 10:59:24,710 WARN  o.a.b.c.m.i.EffectorUtils 
Error invoking start at FailingEntityImpl{id=aiu1robw4u}: Simulating entity 
start failure for test
2023-05-17 10:59:24,713 WARN  o.a.b.c.m.i.EffectorUtils 
Error invoking start at AsyncApplicationImpl{id=sztvgf6fut}: 
ProblemStartingChildrenException: 
org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: Error invoking 
start at FailingEntityImpl{id=aiu1robw4u}: Simulating entity start failure for 
test
2023-05-17 10:59:24,717 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.testStartWithVanillaFailingChild()
 finished in 43 ms
2023-05-17 10:59:24,717 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2023-05-17 10:59:24,719 INFO  o.a.b.c.e.AbstractApplication 
Stopping application AsyncApplicationImpl{id=sztvgf6fut}
2023-05-17 10:59:24,722 INFO  o.a.b.c.e.AbstractApplication 
Stopped application AsyncApplicationImpl{id=sztvgf6fut}
2023-05-17 10:59:24,725 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 8 ms
2023-05-17 10:59:24,726 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.setUp()
2023-05-17 10:59:24,745 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.setUp() finished in 19 ms
2023-05-17 10:59:24,745 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.testStopWillUnmanage()
2023-05-17 10:59:24,768 INFO  o.a.b.c.e.AbstractApplication 
Stopping application AsyncApplicationImpl{id=oqr1o37qpf}
2023-05-17 10:59:24,770 INFO  o.a.b.c.e.AbstractApplication 
Stopped application AsyncApplicationImpl{id=oqr1o37qpf}
2023-05-17 10:59:24,772 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.entity.stock.AsyncApplicationTest.testStopWillUnmanage() 
finished in 27 ms
2023-05-17 10:59:24,772 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2023-05-17 10:59:24,773 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 1 ms
2023-05-17 10:59:24,774 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.entity.stock.WorkflowStartableTest.setUp()
[GC (Allocation Failure)  381178K->176566K(757248K), 0.0400966 secs]
2023-05-17 10:59:24,901 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.entity.stock.WorkflowStartableTest.setUp() finished in 127 
ms
2023-05-17 10:59:24,901 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.entity.stock.WorkflowStartableTest.testSettingSensors()
2023-05-17 10:59:24,944 INFO

[GitHub] [brooklyn-server] asfgit merged pull request #1393: Fix/sum operator coercion

2023-05-17 Thread via GitHub 


asfgit merged PR #1393:
URL: https://github.com/apache/brooklyn-server/pull/1393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Build failed in Jenkins: Brooklyn » Brooklyn - Server module » master #461

2023-05-17 Thread Apache Jenkins Server 
See 


Changes:


--
[...truncated 66657 lines...]
2023-05-17 09:29:39,395 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
[GC (Allocation Failure)  358933K->150261K(760832K), 0.0375983 secs]
2023-05-17 09:29:39,446 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 51 ms
2023-05-17 09:29:39,446 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport.setUp()
2023-05-17 09:29:39,461 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport.setUp() finished in 15 
ms
2023-05-17 09:29:39,461 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.InvokeEffectorOnSensorChangeIntegrationTest.testCallEffectorOnSensorChange_WatchSensorAtOtherEntity()
2023-05-17 09:29:40,486 WARN  o.a.b.u.c.t.DynamicTasks  
Error queueing null (rethrowing): java.lang.NullPointerException: Task to queue 
cannot be null
2023-05-17 09:29:40,487 WARN  o.a.b.c.m.i.EffectorUtils 
Error invoking my-effector at BasicEntityImpl{id=s3am9xivii}: 
NullPointerException: Task to queue cannot be null
2023-05-17 09:29:40,488 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.policy.InvokeEffectorOnSensorChangeIntegrationTest.testCallEffectorOnSensorChange_WatchSensorAtOtherEntity()
 finished in 1027 ms
2023-05-17 09:29:40,489 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2023-05-17 09:29:40,495 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 7 ms
2023-05-17 09:29:40,496 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport.setUp()
2023-05-17 09:29:40,512 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport.setUp() finished in 16 
ms
2023-05-17 09:29:40,512 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.InvokeEffectorOnSensorChangeIntegrationTest.testCallEffectorOnSensorChange_WatchSensorAtThisEntity()
2023-05-17 09:29:41,532 WARN  o.a.b.u.c.t.DynamicTasks  
Error queueing null (rethrowing): java.lang.NullPointerException: Task to queue 
cannot be null
2023-05-17 09:29:41,532 WARN  o.a.b.c.m.i.EffectorUtils 
Error invoking my-effector at BasicEntityImpl{id=wsslahenbn}: 
NullPointerException: Task to queue cannot be null
2023-05-17 09:29:41,533 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.policy.InvokeEffectorOnSensorChangeIntegrationTest.testCallEffectorOnSensorChange_WatchSensorAtThisEntity()
 finished in 1020 ms
2023-05-17 09:29:41,533 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
2023-05-17 09:29:41,539 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod 
org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished 
in 6 ms
2023-05-17 09:29:41,540 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport.setUp()
2023-05-17 09:29:41,569 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod 
org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport.setUp() finished in 29 
ms
2023-05-17 09:29:41,569 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.policy.AbstractInvokeEffectorPolicyTest.testCountReflectsNumberOfExecutingEffectors()
2023-05-17 09:29:42,598 INFO  o.a.b.t.s.LoggingVerboseReporter  
TESTNG PASSED: "Surefire test" -

[GitHub] [brooklyn-server] iuliana merged pull request #1399: Adding support for configuring ...

2023-05-17 Thread via GitHub 


iuliana merged PR #1399:
URL: https://github.com/apache/brooklyn-server/pull/1399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] ahgittin commented on pull request #1396: Workflow ternary operator

2023-05-17 Thread via GitHub 


ahgittin commented on PR #1396:
URL: https://github.com/apache/brooklyn-server/pull/1396#issuecomment-1551017018

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] ahgittin merged pull request #1396: Workflow ternary operator

2023-05-17 Thread via GitHub 


ahgittin merged PR #1396:
URL: https://github.com/apache/brooklyn-server/pull/1396


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] ahgittin commented on pull request #1398: Implements list index specifiers for workflows

2023-05-17 Thread via GitHub 


ahgittin commented on PR #1398:
URL: https://github.com/apache/brooklyn-server/pull/1398#issuecomment-1551016477

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] ahgittin merged pull request #1398: Implements list index specifiers for workflows

2023-05-17 Thread via GitHub 


ahgittin merged PR #1398:
URL: https://github.com/apache/brooklyn-server/pull/1398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] iuliana commented on a diff in pull request #1399: Adding support for configuring ...

2023-05-17 Thread via GitHub 


iuliana commented on code in PR #1399:
URL: https://github.com/apache/brooklyn-server/pull/1399#discussion_r1196148723


##
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java:
##
@@ -1315,4 +1314,79 @@ public void 
testAddPolicyWithDslFromDeployableBlueprint() throws Exception {
 EntityAsserts.assertAttributeEquals(entity, 
Sensors.newSensor(Object.class, "result"), "yes");
 }
 
+@Test
+public void testSshStepOnLocalhostLocation() throws Exception {
+String yaml =
+"location: localhost\n" +
+"services:\n" +
+"  - type: " + WorkflowSoftwareProcess.class.getName() +"\n" +
+"name: sample-server\n" ;
+Entity app = createStartWaitAndLogApplication(yaml);
+
+WorkflowExecutionContext x1 = 
WorkflowBasicTest.runWorkflow(app.getChildren().iterator().next(), 
Strings.lines(
+"lock: x",
+"steps:",
+"- type: ssh\n" +
+"  command: |\n" +
+"echo \"init-done\" >> wf.log"), "test");
+Object result  = x1.getTask(false).get().get();
+Asserts.assertEquals(((Map)result).get("exit_code"), 0);
+}
+
+@Test
+public void testSshStepOnLocalhostDefinition() throws Exception {
+String yaml =
+"brooklyn.config:\n" +
+"   login: \"iuliana\"\n" +
+"services:\n" +
+"  - type: 
org.apache.brooklyn.core.test.entity.TestEntity\n" +
+"brooklyn.tags:\n" +
+"- connection: \n" +
+"name: \"ssh-at-local\" \n" +
+"type: \"ssh\" \n" +
+"user: $brooklyn:config(\"login\") \n" +
+"host: \"localhost\" \n" +
+"name: sample-server\n" ;
+Entity app = createStartWaitAndLogApplication(yaml);
+
+WorkflowExecutionContext x1 = 
WorkflowBasicTest.runWorkflow(app.getChildren().iterator().next(), 
Strings.lines(
+"lock: x",
+"steps:",
+"- type: ssh\n" +
+"  command: |\n" +
+"echo \"init-done\" >> wf.log"), "test");
+Object result  = x1.getTask(false).get().get();
+Asserts.assertEquals(((Map)result).get("exit_code"), 0);
+}
+
+@Test
+public void testSshStepOnLocalhostDefinitionWithExternalConfig() throws 
Exception {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] iuliana commented on a diff in pull request #1399: Adding support for configuring ...

2023-05-17 Thread via GitHub 


iuliana commented on code in PR #1399:
URL: https://github.com/apache/brooklyn-server/pull/1399#discussion_r1196148302


##
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java:
##
@@ -1315,4 +1314,79 @@ public void 
testAddPolicyWithDslFromDeployableBlueprint() throws Exception {
 EntityAsserts.assertAttributeEquals(entity, 
Sensors.newSensor(Object.class, "result"), "yes");
 }
 
+@Test
+public void testSshStepOnLocalhostLocation() throws Exception {
+String yaml =
+"location: localhost\n" +
+"services:\n" +
+"  - type: " + WorkflowSoftwareProcess.class.getName() +"\n" +
+"name: sample-server\n" ;
+Entity app = createStartWaitAndLogApplication(yaml);
+
+WorkflowExecutionContext x1 = 
WorkflowBasicTest.runWorkflow(app.getChildren().iterator().next(), 
Strings.lines(
+"lock: x",

Review Comment:
   Done.



##
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java:
##
@@ -1315,4 +1314,79 @@ public void 
testAddPolicyWithDslFromDeployableBlueprint() throws Exception {
 EntityAsserts.assertAttributeEquals(entity, 
Sensors.newSensor(Object.class, "result"), "yes");
 }
 
+@Test
+public void testSshStepOnLocalhostLocation() throws Exception {
+String yaml =
+"location: localhost\n" +
+"services:\n" +
+"  - type: " + WorkflowSoftwareProcess.class.getName() +"\n" +
+"name: sample-server\n" ;
+Entity app = createStartWaitAndLogApplication(yaml);
+
+WorkflowExecutionContext x1 = 
WorkflowBasicTest.runWorkflow(app.getChildren().iterator().next(), 
Strings.lines(
+"lock: x",
+"steps:",
+"- type: ssh\n" +
+"  command: |\n" +
+"echo \"init-done\" >> wf.log"), "test");
+Object result  = x1.getTask(false).get().get();
+Asserts.assertEquals(((Map)result).get("exit_code"), 0);
+}
+
+@Test
+public void testSshStepOnLocalhostDefinition() throws Exception {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] iuliana commented on a diff in pull request #1399: Adding support for configuring ...

2023-05-17 Thread via GitHub 


iuliana commented on code in PR #1399:
URL: https://github.com/apache/brooklyn-server/pull/1399#discussion_r1196147134


##
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java:
##
@@ -1315,4 +1314,79 @@ public void 
testAddPolicyWithDslFromDeployableBlueprint() throws Exception {
 EntityAsserts.assertAttributeEquals(entity, 
Sensors.newSensor(Object.class, "result"), "yes");
 }
 
+@Test

Review Comment:
   @ahgittin I had this in the back of my mind to do before submitting the PR 
and I forgot. I annotated the test methods. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org