[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #295: Updates localhost doc to add a deployable example

2019-12-03 Thread GitBox 
tbouron commented on a change in pull request #295: Updates localhost doc to 
add a deployable example
URL: https://github.com/apache/brooklyn-docs/pull/295#discussion_r353218245
 
 

 ##
 File path: README.md
 ##
 @@ -36,7 +36,7 @@ Once the `node` and `npm` are installed, run this command to 
install all the req
 at the correct versions:
 
 ```bash
-npm install
+npm install; npm install natives
 
 Review comment:
   There is a huge warning about this package: 
https://www.npmjs.com/package/natives
   
   Better to go with the recommandation and install `graceful-fs` instead


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [brooklyn-docs] tbouron commented on a change in pull request #295: Updates localhost doc to add a deployable example

2019-12-03 Thread GitBox 
tbouron commented on a change in pull request #295: Updates localhost doc to 
add a deployable example
URL: https://github.com/apache/brooklyn-docs/pull/295#discussion_r353218570
 
 

 ##
 File path: package.json
 ##
 @@ -3,7 +3,9 @@
   "version": "1.0.0",
   "description": "Apache Brooklyn Documentation",
   "main": "index.js",
-  "dependencies": {},
+  "dependencies": {
+"natives": "^1.1.6"
 
 Review comment:
   Should go into the `devDependencies`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services