[GitHub] [brooklyn-server] jcabrerizo commented on a change in pull request #1204: Introduce lineId for log entries

2021-07-20 Thread GitBox 


jcabrerizo commented on a change in pull request #1204:
URL: https://github.com/apache/brooklyn-server/pull/1204#discussion_r672129002



##
File path: 
core/src/main/java/org/apache/brooklyn/util/core/logbook/file/FileLogStore.java
##
@@ -69,23 +70,28 @@
 public final static ConfigKey LOGBOOK_LOG_STORE_DATEFORMAT = 
ConfigKeys.newStringConfigKey(
 BASE_NAME_FILE_LOG_STORE + ".dateFormat", "Date format", 
"-MM-dd'T'HH:mm:ss,SSS");
 
+public final static TimeZone UTC_TIMEZONE = TimeZone.getTimeZone("UTC");
+
 private final String filePath;
 private final Path path;
 private final String logLinePattern;
-private final String logDateFormat;
+private final DateFormat dateFormat;
+
 
 @VisibleForTesting
 public FileLogStore() {
 this.path = null;
 this.filePath = "";
 this.logLinePattern = LOGBOOK_LOG_STORE_REGEX.getDefaultValue();
-this.logDateFormat = LOGBOOK_LOG_STORE_DATEFORMAT.getDefaultValue();
+dateFormat = new 
SimpleDateFormat(LOGBOOK_LOG_STORE_DATEFORMAT.getDefaultValue());

Review comment:
   I'd add `this.` to dateFormat to keep it consistent 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] jcabrerizo commented on a change in pull request #1204: Introduce lineId for log entries

2021-07-19 Thread GitBox 


jcabrerizo commented on a change in pull request #1204:
URL: https://github.com/apache/brooklyn-server/pull/1204#discussion_r672129002



##
File path: 
core/src/main/java/org/apache/brooklyn/util/core/logbook/file/FileLogStore.java
##
@@ -69,23 +70,28 @@
 public final static ConfigKey LOGBOOK_LOG_STORE_DATEFORMAT = 
ConfigKeys.newStringConfigKey(
 BASE_NAME_FILE_LOG_STORE + ".dateFormat", "Date format", 
"-MM-dd'T'HH:mm:ss,SSS");
 
+public final static TimeZone UTC_TIMEZONE = TimeZone.getTimeZone("UTC");
+
 private final String filePath;
 private final Path path;
 private final String logLinePattern;
-private final String logDateFormat;
+private final DateFormat dateFormat;
+
 
 @VisibleForTesting
 public FileLogStore() {
 this.path = null;
 this.filePath = "";
 this.logLinePattern = LOGBOOK_LOG_STORE_REGEX.getDefaultValue();
-this.logDateFormat = LOGBOOK_LOG_STORE_DATEFORMAT.getDefaultValue();
+dateFormat = new 
SimpleDateFormat(LOGBOOK_LOG_STORE_DATEFORMAT.getDefaultValue());

Review comment:
   I'd add `this.` to dateFormat to keep it consistent 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org