[GitHub] brooklyn-dist issue #118: add docker image generation

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-dist/pull/118
  
Hi @geomacy. Indeed, the plugin updated to the latest version when I 
retested it which worked. Should we bump the version?


---

[GitHub] brooklyn-dist issue #118: add docker image generation

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-dist/pull/118
  
Aaaah just saw your PR @geomacy, never mind then :)


---

[GitHub] brooklyn-dist issue #118: add docker image generation

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-dist/pull/118
  
Upgrading the dockerfile-maven-plugin to 1.4.3 fixed the above for me - 
have raised https://github.com/apache/brooklyn-dist/pull/130


---

[GitHub] brooklyn-dist issue #118: add docker image generation

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-dist/pull/118
  
hi @tbouron what did you do exactly to get round the build error above?

I'm getting
```
[ERROR] Failed to execute goal 
com.spotify:dockerfile-maven-plugin:1.4.0:build (default) on project 
brooklyn-dist: Could not build image: 
com.spotify.docker.client.shaded.com.fasterxml.jackson.databind.exc.MismatchedInputException:
 Cannot construct instance of `com.spotify.docker.client.messages.RegistryAuth` 
(although at least one Creator exists): no String-argument constructor/factory 
method to deserialize from String value ('osxkeychain')
[ERROR]  at [Source: UNKNOWN; line: -1, column: -1] (through reference 
chain: java.util.LinkedHashMap["credSstore"])
```


---

[GitHub] brooklyn-dist issue #118: add docker image generation

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-dist/pull/118
  
Tested this again and it works like a charm. The plugin 
(https://github.com/spotify/docker-maven-plugin) come with all the flag 
necessary to disable the build and push directly the image we just build if if 
needed.

This looks very promising, thanks @andreaturli 👍 


---

[GitHub] brooklyn-dist issue #118: add docker image generation

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-dist/pull/118
  
Thanks @andreaturli for this, it's great!
However, I get an error when I try to build it:
```
[ERROR] Failed to execute goal 
com.spotify:dockerfile-maven-plugin:1.4.0:build (default) on project 
brooklyn-dist: Could not build image: 
com.spotify.docker.client.shaded.com.fasterxml.jackson.databind.exc.MismatchedInputException:
 Cannot construct instance of `com.spotify.docker.client.messages.RegistryAuth` 
(although at least one Creator exists): no String-argument constructor/factory 
method to deserialize from String value ('swarm')
[ERROR]  at [Source: UNKNOWN; line: -1, column: -1] (through reference 
chain: java.util.LinkedHashMap["stackOrchestrator"])
[ERROR] -> [Help 1]
```
Does this require some setup to do first? If yes, I would suggest to add a 
flag to disable the docker build, same as `-D no-deb` or `-D no-rpm`


---