[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
retest this please


---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
retest this please


---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
retest this please


---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
> jenkins failed with the error:

See my previous comment


---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
jenkins failed with the error:
```
java.io.IOException: remote file operation failed: 
/home/jenkins/jenkins-slave/workspace/brooklyn-library-pull-requests at 
hudson.remoting.Channel@31056a0f:H25: hudson.remoting.ProxyException: 
hudson.maven.MavenModuleSetBuild$MavenExecutionException: 
org.apache.maven.project.ProjectBuildingException: Some problems were 
encountered while processing the POMs:
[FATAL] Non-resolvable parent POM: Could not find artifact 
org.apache.brooklyn:brooklyn-library:pom:0.13.0-SNAPSHOT and 
'parent.relativePath' points at wrong local POM @ line 30, column 13
```
I presume this is temporary, until jenkins has built brooklyn-library 
master etc, so that 0.13.0-SNAPSHOT of everything is in apache's maven snapshot 
repository.

Will kick off a "retest this please" again later.


---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
@aledsage Just tested this with 
https://github.com/apache/brooklyn-server/pull/826, works great but requires to 
be rebased on the latest master + change the version in pom.xml to 
`0.13.0-SNAPSHOT`

After that, good to merge 👍 


---

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-library/pull/129
  
@tbouron changes made; ready for review + (hopefully!) merge.

@tbouron For why we have ansible, chef and salt in different modules 
(versus databases in one module), we don't have a hard-and-fast rule. However, 
with hindsight having entities like databases in the same brooklyn module was a 
mistake. Their release cadence and versioning are tied to that of 
brooklyn-core. They should have been in a community-contributed place like 
"brooklyncentral" in my opinion. And should have been in separate modules there.

For ansible, chef etc - though they are solving a similar problem, they are 
very different integrations so I think it's good to separate them into 
different modules.

The most compelling immediate answer though is that ansible and salt area 
already in different modules, so we're not going to combine them! And we should 
follow the same pattern for chef.


---