[GitHub] brooklyn-server issue #227: Fixes BrooklynFeatureEnablement setting defaults

2016-07-04 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/227
  
@nakomis regarding docs, good question. There's not, except for the 
javadoc. Most end users won't touch this stuff, but agree it's still worth 
including in the docs.

Note that `clearCache` is only used by tests. Because of the limitation you 
pointed out, I marked it as `@VisibleForTesting` to discourage its use 
elsewhere.

Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #227: Fixes BrooklynFeatureEnablement setting defaults

2016-07-01 Thread nakomis
Github user nakomis commented on the issue:

https://github.com/apache/brooklyn-server/pull/227
  
One comment unrelated to this PR. Other than that, code looks good. Is 
there an documentation that explains the explicit precedence?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---