[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/288 Thank you @neykov . Closing PR since all changes are now made in brooklyn-ui https://github.com/apache/brooklyn-ui/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/288 Couple of questions / suggestions to answers then should be good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/288 Test failure unrelated: SpecParameterUnwrappingTest.testParameterDefaultsUsedInConfig. Will check locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/288 @bostko Can you describe why we should change `/logout` from `POST` to `GET`? For one it means that if I can find a way to inject HTML into the page I can log every user that loads it out. It also risks browsers pre-fetching the page and users being unexpectedly logged out (as described in http://stackoverflow.com/questions/3521290/logout-get-or-post). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/288 Tested alongside https://github.com/apache/brooklyn-ui/pull/30 and this resolves the issue on Windows 10 on both IE and Edge. Behaviour on Chrome on OS X remains unchanged LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #288: BROOKLYN-323: Simplify Logout api
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/288 Details about this change in https://issues.apache.org/jira/browse/BROOKLYN-323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
