[GitHub] brooklyn-server issue #356: BROOKLYN-325 Rebind entity starting

2016-09-30 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/356
  
Thanks @iyovcheva - LGTM; merging. We can look at the other TODOs in 
SoftwareProcessRebindNotRunningEntityTest.java (which were removed in the final 
commit?!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #356: BROOKLYN-325 Rebind entity starting

2016-09-29 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/356
  
@neykov any comments you have are much appreciated as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #356: BROOKLYN-325 Rebind entity starting

2016-09-29 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/356
  
@iyovcheva I've added a couple more minor comments. Can you please address 
those, and then I think this is good to merge!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---