[GitHub] brooklyn-server issue #625: Updates BasicExternalConfigSupplierRegistry to u...
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/625 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #625: Updates BasicExternalConfigSupplierRegistry to u...
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/625 Tests added at https://github.com/apache/brooklyn-dist/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #625: Updates BasicExternalConfigSupplierRegistry to u...
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/625 Looks good. Can you add test coverage in `ExternalConfigBrooklynPropertiesTest` by implementing a dummy `ExternalConfigSupplier` in * `brooklyn-server/utils/common/dependencies/osgi/com-example-entities/src/main/java/com/example/brooklyn/test/osgi` and trying to load it with a bundle prefix * `brooklyn-server/utils/common/dependencies/osgi/entities/src/main/java/org/apache/brooklyn/test/osgi` and trying to load it without prefix. To add the bundle to the osgi cache follow the example in `ClassLoaderUtilsTest.installBundle(ManagementContext, String)` to load the bundle from the classpath. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
