[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/750 @grkvlt Could you look at @aledsage comments please? Would be great to merge this PR ð ---
[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/750 @grkvlt Did you had the time to looks at @aledsage's comments for this PR? ---
[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/750 Thanks for the review @aledsage, I will update appropriately. The use case is for blueprints like Kubernetes, which would be able to add a new `KubernetesLocation` or similar. ---
[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/750 @grkvlt any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/750 I agree with @drigodwin about the tests :) FYI I've tested the `CreateLocationPolicy` and it works fine in some scenarios, only a minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/750 Yes, that's probably useful - I'll put something together --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/750 This looks really useful but it could probably do with some tests if that's possible @grkvlt? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
