[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[tbouron]

Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
Tested, works as advertised. All comments from @ahgittin have been 
addressed and I have to say, it's really cool to have this extra information 
@geomacy 🎉 👍 

Merging


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
retest this please


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
Catch up to master, in particular get past 
https://github.com/apache/brooklyn-server/pull/946 which fixes the failing unit 
test 


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
retest this please


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
Rebased against master


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
BTW @aledsage you may be interested in the changes to `LogWatcher` in here, 
https://github.com/apache/brooklyn-server/pull/940/files#diff-5c4439a5d92984cb96dfaf613a5af72c


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
I have done some investigations of these build failures and I'm pretty sure 
they're not related to my change, e.g. this failure is the same as 
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-server-master-docker/48/,
 whereas the previous failure on `SensorResourceTest` I have seen on a clean 
build of `master`.  These are things to look at but not related to this PR. 
Retest this please.



---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
retest this please, I'm pretty sure it's unrelated to this change


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
retest this please


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
Rebased against master


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
retest this please


---

[GitHub] brooklyn-server issue #940: Add mapped diagnostic context with entity ids to...

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/940
  
hi @ahgittin I have taken the "do not merge" off this; check out the last 
two commits which add the task id to output and remove spaces.  I haven't yet 
included the logging of messages to track relationships  at the time of child 
(entity and task) creation, but I think there's enough in this at the moment to 
make it worth merging (keeping 'em small!), and I would aim to look at that 
additional stuff in another commit.


---